osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
wireshark/ui
History
Gerald Combs 1d999dea5c Qt: Update recent status via a non-blocking connection. 
Connect our recent file status signal using a Qt::QueuedConnection
instead of a Qt::BlockingQueuedConnection. As described at
https://woboq.com/blog/how-qt-signals-slots-work-part3-queuedconnection.html,
QueuedConnection makes a copy of the argument list while
BlockingQueuedConnection passess the list directly.

This fixes what appears to be a false positive reported by
ThreadSanitizer. Cross-thread signals are protected by a QMutex, but
qmutex_mac.cpp in the Qt5 sources uses a Mach semaphore. The
ThreadSanitizer manual says it supports pthread mutexes and compiler
atomic operations but doesn't mention Mach semaphores.

Change-Id: Icb8a63d7d0bdfe985ab8274757043ef45ae4bcde
Reviewed-on: https://code.wireshark.org/review/25576
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 		2018-02-05 05:10:10 +00:00
..
cli cli: use SPDX identifiers. 2018-02-02 13:40:28 +00:00
gtk gtk: fix memory leak in profile dialog. 2018-01-22 20:53:54 +00:00
qt Qt: Update recent status via a non-blocking connection. 2018-02-05 05:10:10 +00:00
win32 Use pcapng as the name of the file format. 2018-01-09 00:38:51 +00:00
CMakeLists.txt Fix build and thread runtime compat with older GLib 2017-12-24 20:22:58 +00:00
Makefile.am Fix make distcheck 2017-12-11 20:21:09 +00:00
alert_box.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
alert_box.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
all_files_wildcard.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
capture.c Check for gzipped files even if we don't have libz. 2018-01-14 21:08:18 +00:00
capture.h [capture_info] Fold the code of capture_info_open() into ui/capture.c 2017-12-11 13:00:25 +00:00
capture_globals.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
capture_ui_utils.c Use g_list_prepend() it's faster. 2017-12-04 13:23:10 +00:00
capture_ui_utils.h Reformat some top-level ui files. 2017-11-30 00:14:16 +00:00
commandline.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
commandline.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
console.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
console.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
decode_as_utils.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
decode_as_utils.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
dissect_opts.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
dissect_opts.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
doxygen.cfg.in
…
export_object_ui.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
export_object_ui.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
export_pdu_ui_utils.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
export_pdu_ui_utils.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
failure_message.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
failure_message.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
file_dialog.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
filter_files.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
filter_files.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
firewall_rules.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
firewall_rules.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
help_url.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
help_url.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
iface_lists.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
iface_lists.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
iface_toolbar.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
iface_toolbar.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
io_graph_item.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
io_graph_item.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
language.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
language.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
last_open_dir.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
main_statusbar.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
make-taps.c Rewrite make-tap-reg.py in C 2017-12-11 02:52:28 +00:00
mcast_stream.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
mcast_stream.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
packet_list_utils.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
packet_list_utils.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
packet_range.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
packet_range.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
persfilepath_opt.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
persfilepath_opt.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
preference_utils.c Fix comment, get rid of extra blank line. 2018-01-08 22:02:48 +00:00
preference_utils.h Add ability for preferences to determine what they can change. 2018-01-06 17:49:23 +00:00
profile.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
profile.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
progress_dlg.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
proto_hier_stats.c Have the frame_tvbuff.c routines not use the global cfile. 2017-12-08 08:31:41 +00:00
proto_hier_stats.h Use cfile.h to define the capture_file type. 2017-12-03 18:54:37 +00:00
recent.c Qt: Byte view recent updates. 2018-01-05 06:52:13 +00:00
recent.h Qt: Byte view recent updates. 2018-01-05 06:52:13 +00:00
recent_utils.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
rtp_media.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
rtp_media.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
rtp_stream.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
rtp_stream.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
service_response_time.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
service_response_time.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
simple_dialog.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
software_update.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
software_update.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
ssl_key_export.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
ssl_key_export.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
tap-iax2-analysis.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
tap-iax2-analysis.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
tap-rlc-graph.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
tap-rlc-graph.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
tap-rtp-analysis.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
tap-rtp-common.c Have the frame_tvbuff.c routines not use the global cfile. 2017-12-08 08:31:41 +00:00
tap-rtp-common.h Reformat some top-level ui files. 2017-11-30 00:14:16 +00:00
tap-sctp-analysis.c tap-sctp: change if to switch for a default case (found by clang). 2018-01-19 12:24:27 +00:00
tap-sctp-analysis.h Reformat some top-level ui files. 2017-11-30 00:14:16 +00:00
tap-tcp-stream.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
tap-tcp-stream.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
tap_export_pdu.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
tap_export_pdu.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
taps.h Rewrite make-tap-reg.py in C 2017-12-11 02:52:28 +00:00
text_import.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
text_import.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
text_import_scanner.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
text_import_scanner.l Disable flex-generated [-Wsign-compare] warnings 2017-09-19 10:06:07 +00:00
time_shift.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
time_shift.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
traffic_table_ui.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
traffic_table_ui.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
util.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
util.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
voip_calls.c ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
voip_calls.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00
ws_ui_util.h ui: use SPDX identifiers. 2018-02-02 13:39:04 +00:00