603354203b
The proto.h APIs expect valid UTF-8 so replace uses of format_text() with a label copy function that just does formatting and does not check for encoding errors. Avoid multiple levels of temporary string allocations. Make sure the copy does not truncate a multibyte character and produce invalid strings. Add debug checks for UTF-8 encoding errors instead. We escape C0 and C1 control codes (because control codes) and ASCII whitespace (and bell). Overall the goal is to be more efficient and optimized and help detect misuse of APIs by passing invalid UTF-8. Add a unit test for ws_label_strcat.
130 lines
4.3 KiB
Python
130 lines
4.3 KiB
Python
#
|
|
# Wireshark tests
|
|
# By
|
|
# Gerald Combs <gerald@wireshark.org>
|
|
# Gilbert Ramirez <gram [AT] alumni.rice.edu>
|
|
#
|
|
# Ported from a set of Bash scripts which were copyright 2005 Ulf Lamping
|
|
#
|
|
# SPDX-License-Identifier: GPL-2.0-or-later
|
|
#
|
|
'''EPAN unit tests'''
|
|
|
|
import difflib
|
|
import os.path
|
|
import re
|
|
import subprocesstest
|
|
import fixtures
|
|
|
|
|
|
@fixtures.uses_fixtures
|
|
class case_unittests(subprocesstest.SubprocessTestCase):
|
|
def test_unit_exntest(self, program, base_env):
|
|
'''exntest'''
|
|
self.assertRun(program('exntest'), env=base_env)
|
|
|
|
def test_unit_oids_test(self, program, base_env):
|
|
'''oids_test'''
|
|
self.assertRun(program('oids_test'), env=base_env)
|
|
|
|
def test_unit_reassemble_test(self, program, base_env):
|
|
'''reassemble_test'''
|
|
self.assertRun(program('reassemble_test'), env=base_env)
|
|
|
|
def test_unit_tvbtest(self, program, base_env):
|
|
'''tvbtest'''
|
|
self.assertRun(program('tvbtest'), env=base_env)
|
|
|
|
def test_unit_wmem_test(self, program, base_env):
|
|
'''wmem_test'''
|
|
self.assertRun((program('wmem_test'),
|
|
'--verbose'
|
|
), env=base_env)
|
|
|
|
def test_unit_wscbor_test(self, program, base_env):
|
|
'''wscbor_test'''
|
|
self.assertRun(program('wscbor_test'), env=base_env)
|
|
|
|
def test_unit_epan(self, program, base_env):
|
|
'''epan unit tests'''
|
|
self.assertRun((program('test_epan'),
|
|
'--verbose'
|
|
), env=base_env)
|
|
|
|
def test_unit_wsutil(self, program, base_env):
|
|
'''wsutil unit tests'''
|
|
self.assertRun((program('test_wsutil'),
|
|
'--verbose'
|
|
), env=base_env)
|
|
|
|
def test_unit_fieldcount(self, cmd_tshark, test_env):
|
|
'''fieldcount'''
|
|
self.assertRun((cmd_tshark, '-G', 'fieldcount'), env=test_env)
|
|
|
|
def test_unit_ctest_coverage(self, all_test_groups):
|
|
'''Make sure CTest runs all of our tests.'''
|
|
with open(os.path.join(os.path.dirname(__file__), '..', 'CMakeLists.txt')) as cml_fd:
|
|
group_re = re.compile(r'set *\( *_test_group_list')
|
|
in_list = False
|
|
cml_groups = []
|
|
for cml_line in cml_fd:
|
|
if group_re.search(cml_line):
|
|
in_list = True
|
|
continue
|
|
if in_list:
|
|
if ')' in cml_line:
|
|
break
|
|
cml_groups.append(cml_line.strip())
|
|
cml_groups.sort()
|
|
if not all_test_groups == cml_groups:
|
|
diff = '\n'.join(list(difflib.unified_diff(all_test_groups, cml_groups, 'all test groups', 'CMakeLists.txt test groups')))
|
|
self.fail("CMakeLists.txt doesn't test all available groups:\n" + diff)
|
|
|
|
|
|
class Proto:
|
|
"""Data for a protocol."""
|
|
def __init__(self, line):
|
|
data = line.split("\t")
|
|
assert len(data) == 3, "expected 3 columns in %s" % data
|
|
assert data[0] == "P"
|
|
self.name = data[1]
|
|
self.abbrev = data[2]
|
|
|
|
class Field:
|
|
"""Data for a field."""
|
|
def __init__(self, line):
|
|
data = line.split("\t")
|
|
assert len(data) == 8, "expected 8 columns in %s" % data
|
|
assert data[0] == "F"
|
|
self.name = data[1]
|
|
self.abbrev = data[2]
|
|
self.ftype = data[3]
|
|
self.parent = data[4]
|
|
self.base = data[5]
|
|
self.bitmask = int(data[6],0)
|
|
self.blurb = data[7]
|
|
|
|
|
|
@fixtures.uses_fixtures
|
|
class case_unit_ftsanity(subprocesstest.SubprocessTestCase):
|
|
def test_unit_ftsanity(self, cmd_tshark, base_env):
|
|
"""Looks for problems in field type definitions."""
|
|
tshark_proc = self.assertRun((cmd_tshark, "-G", "fields"), env=base_env)
|
|
|
|
lines = tshark_proc.stdout_str.splitlines()
|
|
# XXX We don't currently check protos.
|
|
protos = [Proto(x) for x in lines if x[0] == "P"]
|
|
fields = [Field(x) for x in lines if x[0] == "F"]
|
|
|
|
err_list = []
|
|
for field in fields:
|
|
if field.bitmask != 0:
|
|
if field.ftype.find("FT_UINT") != 0 and \
|
|
field.ftype.find("FT_INT") != 0 and \
|
|
field.ftype != "FT_BOOLEAN" and \
|
|
field.ftype != "FT_CHAR":
|
|
err_list.append("%s has a bitmask 0x%x but is type %s" % \
|
|
(field.abbrev, field.bitmask, field.ftype))
|
|
|
|
self.assertEqual(len(err_list), 0, 'Found field type errors: \n' + '\n'.join(err_list))
|