osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
wireshark/gtk
History
Guy Harris 3e55e6702f Get rid of the stuff to use bitfields to dissect IP and TCP headers - 
bitfields are a pain to use when dealing with structures with a fixed
layout in memory (you have to worry about bit order, for example).

Don't assume that the Ethernet header is aligned on a 2-byte boundary -
use "pntohs()" to extract stuff from it.  (Perhaps C will force it onto
a 2-byte boundary, but why take chances, and why leave the code
vulnerable to changes outside this module?)

Don't assume that the pointers to the IP and TCP headers are nicely
aligned - use "memcpy()", not structure assignment, to copy the headers.
(They're probably *not* nicely aligned on platforms that require 4-byte
alignment of 4-byte integral quantities; the code was dumping core on
SPARC with an alignment error.)

Don't even make those pointers be pointers to structures, as that may
cause the C compiler to generate in-line 4-byte loads and stores for
"memcpy()" (in fact, it *did* do so with GCC 2.95.1 on SPARC), which has
the same problem as structure assignment.

Don't test the IP protocol number twice when handling PPP.

svn path=/trunk/; revision=4378
2001-12-10 21:19:13 +00:00
..
.cvsignore Add a few more items to ".cvsignore". 2001-03-03 00:47:31 +00:00
capture_dlg.c Check for invalid maximum packet count values. 2001-12-09 03:20:19 +00:00
capture_dlg.h Santeri Paavolainen's patch to add a "Capture->Stop" menu item to let 2000-10-11 06:01:16 +00:00
color_dlg.c Get rid of an unused variable, and fix a comment. 2001-12-03 02:37:25 +00:00
color_dlg.h Split the color manipulation stuff into "color_dlg.[ch]", containing the 2000-02-12 08:31:49 +00:00
color_utils.c Add a "color.h" file that declares a nominally-toolkit-independent 2000-11-21 23:54:10 +00:00
color_utils.h Add a "color.h" file that declares a nominally-toolkit-independent 2000-11-21 23:54:10 +00:00
colors.c From John McDermott: 2001-12-02 00:16:02 +00:00
colors.h Create a more modular type system for the FT_* types. Put them 2001-02-01 20:21:25 +00:00
column_prefs.c Check for valid column titles (non-zero-length) and valid column formats 2001-07-22 21:50:47 +00:00
column_prefs.h Instead of each set of built-in preferences having "ok", "save", 2000-08-21 08:09:17 +00:00
decode_as_dlg.c Attach a descriptive name field type and base to dissector tables; that 2001-12-08 06:41:48 +00:00
decode_as_dlg.h Inactivate the "Decode As" menu item if the "Decode As" dialog box 2001-02-11 23:02:05 +00:00
dfilter_expr_dlg.c On Windows, use the directory in which the binary resides as the 2001-08-21 06:39:18 +00:00
dfilter_expr_dlg.h Add a dialog box for constructing expressions that test a field in the 2001-01-02 01:32:21 +00:00
display_opts.c Get rid of an unnecessary declaration of "packet_list". 2001-06-18 06:18:03 +00:00
display_opts.h
dlg_utils.c Bleah. What was I thinking? "dlg_window_new()" should take the title 2000-08-23 06:56:31 +00:00
dlg_utils.h Bleah. What was I thinking? "dlg_window_new()" should take the title 2000-08-23 06:56:31 +00:00
file_dlg.c Don't update the "Save As..." dialog box if it doesn't exist. 2001-12-06 03:09:28 +00:00
file_dlg.h Make the "Save only marked frames" button in the "Save As..." dialog box 2001-12-06 02:21:26 +00:00
filter_prefs.c On Windows, put Ethereal configuration files under the "Application 2001-10-24 06:13:07 +00:00
filter_prefs.h The text entry box that a filter construction dialog manipulates is 2001-02-23 05:54:27 +00:00
find_dlg.c Create a more modular type system for the FT_* types. Put them 2001-02-01 20:21:25 +00:00
find_dlg.h
follow_dlg.c Remove the global packet_info called "pi". Dissectors now only 2001-11-21 23:16:26 +00:00
follow_dlg.h Redraw: 2000-09-08 10:59:21 +00:00
goto_dlg.c Doesn't need #include "dfilter.h" 2001-01-04 04:56:20 +00:00
goto_dlg.h
gtkclist.c Use system's version of AM_PATH_GLIB macro. 2001-08-20 15:23:34 +00:00
gtkclist.h Incorporate the GTK+ 1.2.8 version of "gtkclist.c" (which includes all 2000-05-26 07:47:47 +00:00
gtkglobals.h Enable "Match Selected" only if there's a field selected *and* we can do 2001-06-05 07:39:31 +00:00
gui_prefs.c Fix to a preferences dialog bug, from <inoue@ainet.or.jp>. 2001-04-17 18:49:55 +00:00
gui_prefs.h Instead of each set of built-in preferences having "ok", "save", 2000-08-21 08:09:17 +00:00
help_dlg.c On Windows, use the directory in which the binary resides as the 2001-08-21 06:39:18 +00:00
help_dlg.h Redraw: 2000-09-08 10:59:21 +00:00
keys.h Add a popup menu for the hexdump window. For now, it has only the 2000-08-20 21:55:58 +00:00
main.c Remove proto_tree from capture_file and PacketWinData, since they 2001-12-06 04:25:09 +00:00
main.h Remove the global packet_info called "pi". Dissectors now only 2001-11-21 23:16:26 +00:00
Makefile.am TCP time-sequence, round-trip time, and throughput graphs, from Pavel 2001-12-08 09:27:51 +00:00
Makefile.nmake TCP time-sequence, round-trip time, and throughput graphs, from Pavel 2001-12-08 09:27:51 +00:00
menu.c TCP time-sequence, round-trip time, and throughput graphs, from Pavel 2001-12-08 09:27:51 +00:00
menu.h Make work better the (hexdump) popup menus. 2000-08-21 12:33:22 +00:00
packet_win.c Move the pointer to the "column_info" structure in the "frame_data" 2001-12-10 00:26:21 +00:00
packet_win.h The declaration of "destroy_packet_wins()" belongs in 2001-03-24 02:14:56 +00:00
plugins_dlg.c Get rid of support for old-style plugins (support for old-style plugins 2001-01-28 21:17:29 +00:00
prefs_dlg.c From Thomas Wittwer: remove unnecessary calls to 2001-12-04 07:23:47 +00:00
prefs_dlg.h Implements the "Properties" menu item which displays the preferences window 2000-08-15 20:46:17 +00:00
print_dlg.c On Win32, a GUI application apparently can't use "popen()" (it 2001-12-09 01:12:07 +00:00
print_prefs.c Remove #include "gtk/colors.h" from file.h, which keep the GTK+ header 2000-10-20 04:26:40 +00:00
print_prefs.h Instead of each set of built-in preferences having "ok", "save", 2000-08-21 08:09:17 +00:00
progress_dlg.c Give the code that computes protocol statistics a progress dialog box, 2001-03-24 02:07:22 +00:00
proto_dlg.c Add "Toggle All", "Enable All", and "Disable All" buttons to the 2001-03-01 21:34:09 +00:00
proto_dlg.h Add the "Edit:Protocols..." feature which currently only implements 2000-08-13 14:09:15 +00:00
proto_draw.c Have a routine to add all the hex dump tabs to the hex dump notebook, 2001-11-20 10:37:16 +00:00
proto_draw.h Have a routine to add all the hex dump tabs to the hex dump notebook, 2001-11-20 10:37:16 +00:00
proto_hier_stats_dlg.c Change name of "Last-Protocol" columns to "End" so that there's 2001-03-29 04:21:35 +00:00
proto_hier_stats_dlg.h Add a new tool which summarizes packet counts by protocols, but 2001-03-22 23:54:47 +00:00
simple_dialog.c Add support for modal message boxes ("simple dialog"). 2000-10-09 06:38:36 +00:00
stream_prefs.c On Windows, use the directory in which the binary resides as the 2001-08-21 06:39:18 +00:00
stream_prefs.h Instead of each set of built-in preferences having "ok", "save", 2000-08-21 08:09:17 +00:00
summary_dlg.c In Ethereal, attempt to get the packet statistics from libpcap when 2001-02-11 09:28:17 +00:00
summary_dlg.h No work need be done when a summary dialog box is destroyed, or when the 2000-04-01 09:16:49 +00:00
tcp_graph.c Get rid of the stuff to use bitfields to dissect IP and TCP headers - 2001-12-10 21:19:13 +00:00
tcp_graph.h TCP time-sequence, round-trip time, and throughput graphs, from Pavel 2001-12-08 09:27:51 +00:00
ui_util.c "reactivate_window()" is used only by stuff in the "gtk" directory, and 2001-03-24 02:23:08 +00:00
ui_util.h "reactivate_window()" is used only by stuff in the "gtk" directory, and 2001-03-24 02:23:08 +00:00