osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
wireshark/ui/cli
History
Gerald Combs 698ad5bd95 From Martin Kaiser via bug 7312: 
there's three coverity defects about division by zero in ui/cli/tap-iostat.c,
function iostat_packet()

This can be triggered from the command line

martin@greta# ./tshark -z io,stat,0.2,AVG\(frame.number\)
Capturing on eth0
Floating point exception

it->num is 0, wireshark crashes in

parent->max_vals[it->colnum] =                       
MAX(parent->max_vals[it->colnum], it->counter/it->num);

(and similar for other data types)

My proposal for a fix is to not update parent->max_vals[it->colnum] when
it->num==0, see the attached patch.

svn path=/trunk/; revision=42952
 		2012-05-31 21:40:55 +00:00
..
Makefile.am Add a "-build" argument to checkAPIs.pl. Use that argument when building 2012-04-04 20:46:49 +00:00
Makefile.common We already have GENERATED_HEADER_FILES; use that instead of 2012-02-19 22:41:53 +00:00
Makefile.nmake Add a "-build" argument to checkAPIs.pl. Use that argument when building 2012-04-04 20:46:49 +00:00
tap-afpstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-ansi_astat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-bootpstat.c
…
tap-camelcounter.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-camelsrt.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-comparestat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-dcerpcstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-diameter-avp.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-expert.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-follow.c Avoid needlessly shadowing a variable. 2012-05-10 16:05:02 +00:00
tap-funnel.c Remove doubled semicolons and semicolons outside function. 2012-04-13 20:22:31 +00:00
tap-gsm_astat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-h225counter.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-h225rassrt.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-hosts.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-httpstat.c
…
tap-icmpstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-icmpv6stat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-iostat.c From Martin Kaiser via bug 7312: 2012-05-31 21:40:55 +00:00
tap-iousers.c From Robert Bullen: 2012-05-23 06:36:47 +00:00
tap-macltestat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-megacostat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-mgcpstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-protocolinfo.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-protohierstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-radiusstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-rlcltestat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-rpcprogs.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-rpcstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-rtp.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-rtspstat.c
…
tap-scsistat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-sctpchunkstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-sipstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-smbsids.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-smbstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 21:29:13 +00:00
tap-stats_tree.c
…
tap-sv.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00
tap-wspstat.c AFAICT '#include sys/types.h' is not needed for these files. 2012-05-05 20:51:14 +00:00