5ab8490088
Remove the setUniformRowHeights(true) call in the PacketList constructor. This means that the packet list now calculates its height by querying the Qt::SizeHintRole for every item instead of simply multiplying item_height * number_of_rows. Implement SizeHintRole in PacketListModel::data so that size calculations aren't unbearably slow. We don't have any row text until an item is drawn (via DisplayRole), so items with multiple lines end up being rendered twice. Note where we make assumptions on line heights. Although we call gtk_tree_view_set_fixed_height_mode() in the GTK+ UI we don't have this problem there. GTK+ is apparently less strict about enforcing row heights. Bug: 10924 Change-Id: I98e9f4f5f321c2e03f18498e0a7e7556f88792a1 Reviewed-on: https://code.wireshark.org/review/7430 Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
94 lines
2.6 KiB
C++
94 lines
2.6 KiB
C++
/* packet_list_record.h
|
|
*
|
|
* Wireshark - Network traffic analyzer
|
|
* By Gerald Combs <gerald@wireshark.org>
|
|
* Copyright 1998 Gerald Combs
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#ifndef PACKET_LIST_RECORD_H
|
|
#define PACKET_LIST_RECORD_H
|
|
|
|
#include <config.h>
|
|
|
|
#include <glib.h>
|
|
|
|
#include "cfile.h"
|
|
|
|
#include <epan/column-info.h>
|
|
#include <epan/packet.h>
|
|
|
|
#include <QByteArray>
|
|
#include <QList>
|
|
#include <QVariant>
|
|
|
|
struct conversation;
|
|
|
|
class PacketListRecord
|
|
{
|
|
public:
|
|
PacketListRecord(frame_data *frameData);
|
|
// Return the string value for a column. Data is cached if possible.
|
|
const QVariant columnString(capture_file *cap_file, int column);
|
|
frame_data *frameData() const { return fdata_; }
|
|
// packet_list->col_to_text in gtk/packet_list_store.c
|
|
static int textColumn(int column) { return cinfo_column_.value(column, -1); }
|
|
struct conversation *conversation() { return conv_; }
|
|
|
|
int columnTextSize(const char *str);
|
|
static void resetColumns(column_info *cinfo);
|
|
void resetColorized();
|
|
inline int lineCount() { return lines_; }
|
|
inline int lineCountChanged() { return line_count_changed_; }
|
|
|
|
private:
|
|
/** The column text for some columns */
|
|
QList<QByteArray> col_text_;
|
|
|
|
frame_data *fdata_;
|
|
int lines_;
|
|
bool line_count_changed_;
|
|
static QMap<int, int> cinfo_column_;
|
|
|
|
/** Data versions. Used to invalidate col_text_ */
|
|
static unsigned col_data_ver_;
|
|
unsigned data_ver_;
|
|
/** Has this record been colorized? */
|
|
bool colorized_;
|
|
|
|
/** Conversation. Used by RelatedPacketDelegate */
|
|
struct conversation *conv_;
|
|
|
|
void dissect(capture_file *cap_file, bool dissect_color = false);
|
|
void cacheColumnStrings(column_info *cinfo);
|
|
|
|
};
|
|
|
|
#endif // PACKET_LIST_RECORD_H
|
|
|
|
/*
|
|
* Editor modelines
|
|
*
|
|
* Local Variables:
|
|
* c-basic-offset: 4
|
|
* tab-width: 8
|
|
* indent-tabs-mode: nil
|
|
* End:
|
|
*
|
|
* ex: set shiftwidth=4 tabstop=8 expandtab:
|
|
* :indentSize=4:tabSize=8:noTabs=true:
|
|
*/
|