osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
wireshark/ui
History
Gerald Combs 212ff30603 RTP: Fixup stream ID hashing. 
Update our hash value when calling add_address_to_hash. Fixes:

________________________________________________________________________________________________________
*** CID 1476121:  Incorrect expression  (USELESS_CALL)
/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/build/ui/rtp_stream_id.c: 141 in pinfo_rtp_info_to_hash()
135     	/* SRC PORT | DST_PORT */
136     	/* SSRC */
137     	/* SRC ADDR */
138     	/* DST ADDR */
139     	hash ^= pinfo->srcport | pinfo->destport << 16;
140     	hash ^= rtp_info->info_sync_src;
>>>     CID 1476121:  Incorrect expression  (USELESS_CALL)
>>>     Calling "add_address_to_hash(hash, &pinfo->src)" is only useful for its return value, which is ignored.
141     	add_address_to_hash(hash, &pinfo->src);
142     	add_address_to_hash(hash, &pinfo->dst);
143
144     	return hash;
145     }
146
 		2021-04-15 21:01:28 +00:00
..
cli Fix conversation table when using epoch based time 2021-04-15 03:42:47 +00:00
macosx macOS: Expand a comment. 2020-02-28 16:40:02 +00:00
qt Fix adaptive sampling performance on scatterplots 2021-04-15 07:34:19 +00:00
win32 wiretap: more work on file type/subtypes. 2021-02-17 21:54:28 +00:00
CMakeLists.txt CMake: Add ENABLE_VLD option for MSVC 2021-04-10 21:53:59 +00:00
alert_box.c wiretap: file types have a name and a description. 2021-02-13 01:25:39 -08:00
alert_box.h Have WTAP_ERR_INTERNAL include an err_info string giving details. 2020-10-14 04:51:45 +00:00
all_files_wildcard.h
…
capture.c Merge the caputils/ and capchild/ directories 2021-03-29 06:08:02 +01:00
capture.h Merge the caputils/ and capchild/ directories 2021-03-29 06:08:02 +01:00
capture_globals.h
…
capture_info.h Merge the caputils/ and capchild/ directories 2021-03-29 06:08:02 +01:00
capture_ui_utils.c Merge the caputils/ and capchild/ directories 2021-03-29 06:08:02 +01:00
capture_ui_utils.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
clopts_common.c Make ui/*.[ch] indentation consistent. 2021-03-01 22:41:23 +00:00
clopts_common.h Reorganize long option values 2019-12-15 20:02:09 +00:00
cmdarg_err.c Add more error-reporting routines that call through a function pointer. 2021-03-15 12:17:59 -07:00
cmdarg_err.h Add more error-reporting routines that call through a function pointer. 2021-03-15 12:17:59 -07:00
commandline.c Command line: Add a HAVE_LIBPCAP check for -k. 2021-04-13 14:36:12 -07:00
commandline.h
…
console.c Teach our console log handler to use log domains (Unix) 2021-03-06 12:40:20 +00:00
console.h
…
decode_as_utils.c Add FT_STRINGZTRUNC. 2020-09-12 14:16:12 -07:00
decode_as_utils.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
dissect_opts.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
dissect_opts.h Reorganize long option values 2019-12-15 20:02:09 +00:00
exit_codes.h Clean up printing of interface information. 2021-04-13 23:14:09 -07:00
export_object_ui.c
…
export_object_ui.h Move still *more* headers outside of extern "C". 2021-03-16 13:50:13 -07:00
export_pdu_ui_utils.c Remove unnecessary includes of wiretap/pcap-encap.h. 2021-03-15 16:04:02 -07:00
export_pdu_ui_utils.h Clean up "Export PDUs to File" code. 2021-03-14 06:51:36 -07:00
failure_message.c Add more error-reporting routines that call through a function pointer. 2021-03-15 12:17:59 -07:00
failure_message.h Add more error-reporting routines that call through a function pointer. 2021-03-15 12:17:59 -07:00
file_dialog.c Add a new record type REC_TYPE_SYSTEMD_JOURNAL. 2020-10-27 20:06:26 -07:00
file_dialog.h
…
filter_files.c Make ui/*.[ch] indentation consistent. 2021-03-01 22:41:23 +00:00
filter_files.h Make ui/*.[ch] indentation consistent. 2021-03-01 22:41:23 +00:00
firewall_rules.c UI: Fix Firewall ACL rules 2020-12-18 07:30:37 +00:00
firewall_rules.h
…
help_url.c WSUG: Added description of new features of telephony dialogs 2021-04-11 15:46:48 +00:00
help_url.h WSUG: Added description of new features of telephony dialogs 2021-04-11 15:46:48 +00:00
iface_lists.c if_capabilities: Use a structured error msg from dumpcap 2021-03-06 12:56:11 +00:00
iface_lists.h
…
iface_toolbar.c
…
iface_toolbar.h
…
io_graph_item.c IO Graph shows unsigned values correctly 2020-01-18 12:17:24 +00:00
io_graph_item.h Move still *more* headers outside of extern "C". 2021-03-16 13:50:13 -07:00
language.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
language.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
last_open_dir.h
…
main_statusbar.h
…
mcast_stream.c Detect and replace bad allocation patterns 2020-12-22 14:56:38 +00:00
mcast_stream.h Move still *more* headers outside of extern "C". 2021-03-16 13:50:13 -07:00
packet_list_utils.c
…
packet_list_utils.h
…
packet_range.c Qt: Multiselection in PacketList 2019-11-17 12:20:29 +00:00
packet_range.h Move still *more* headers outside of extern "C". 2021-03-16 13:50:13 -07:00
persfilepath_opt.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
persfilepath_opt.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
preference_utils.c Detect and replace bad allocation patterns 2020-12-22 14:56:38 +00:00
preference_utils.h Qt: Check if "Apply as Column" column already exists 2020-07-15 03:57:01 +00:00
profile.c Detect and replace bad allocation patterns 2020-12-22 14:56:38 +00:00
profile.h Qt: Prevent loop in renames of profiles 2019-08-13 08:16:12 +00:00
progress_dlg.h
…
proto_hier_stats.c
…
proto_hier_stats.h Move still *more* headers outside of extern "C". 2021-03-16 13:50:13 -07:00
recent.c Detect and replace bad allocation patterns 2020-12-22 14:56:38 +00:00
recent.h Move still *more* headers outside of extern "C". 2021-03-16 13:50:13 -07:00
recent_utils.h
…
rtp_media.c codecs API: Added description of API usage 2019-12-30 15:41:00 +00:00
rtp_media.h Moving glib.h out of extern C 2021-02-10 17:49:09 +00:00
rtp_stream.c VoIP dialogs: Performance improvements 2021-04-14 14:02:58 +00:00
rtp_stream.h VoIP dialogs: Performance improvements 2021-04-14 14:02:58 +00:00
rtp_stream_id.c RTP: Fixup stream ID hashing. 2021-04-15 21:01:28 +00:00
rtp_stream_id.h VoIP dialogs: Performance improvements 2021-04-14 14:02:58 +00:00
service_response_time.c
…
service_response_time.h
…
simple_dialog.h
…
software_update.c macOS: Software update fixes. 2020-02-28 04:50:38 +00:00
software_update.h Test+Qt: Add an automatic update check. 2020-02-15 11:13:25 +00:00
ssl_key_export.c
…
ssl_key_export.h
…
summary.c Remove unnecessary inclues of wiretap/pcapng.h. 2021-03-15 15:29:40 -07:00
summary.h Make ui/*.[ch] indentation consistent. 2021-03-01 22:41:23 +00:00
tap-credentials.h
…
tap-iax2-analysis.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
tap-iax2-analysis.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
tap-rlc-graph.c Detect and replace bad allocation patterns 2020-12-22 14:56:38 +00:00
tap-rlc-graph.h Move still *more* headers outside of extern "C". 2021-03-16 13:50:13 -07:00
tap-rtp-analysis.c VoIP dialogs: Cleanups and clarifications based on work on WSUG 2021-04-11 06:41:17 +00:00
tap-rtp-analysis.h RTP processing: Modified RTP sequence verification 2021-01-03 16:53:21 +00:00
tap-rtp-common.c VoIP dialogs: Performance improvements 2021-04-14 14:02:58 +00:00
tap-rtp-common.h VoIP dialogs: Performance improvements 2021-04-14 14:02:58 +00:00
tap-sctp-analysis.c
…
tap-sctp-analysis.h Move still *more* headers outside of extern "C". 2021-03-16 13:50:13 -07:00
tap-tcp-stream.c Qt: Fix memory leak in TCP Stream Dialog 2020-04-14 15:35:55 +00:00
tap-tcp-stream.h Qt: Fix memory leak in TCP Stream Dialog 2020-04-14 15:35:55 +00:00
tap_export_pdu.c tap_export_pdu: finish the job of reporting errors. 2021-03-15 14:52:12 -07:00
tap_export_pdu.h tap_export_pdu: finish the job of reporting errors. 2021-03-15 14:52:12 -07:00
taps.h Move still *more* headers outside of extern "C". 2021-03-16 13:50:13 -07:00
text_import.c text_import: just suppress the two-initializers warning. 2021-03-27 14:00:44 -07:00
text_import.h Regex based textfile import 2021-03-26 06:44:25 +00:00
text_import_regex.c Regex text imoprt: MSVC compiling and updated timestamps 2021-03-26 06:44:25 +00:00
text_import_regex.h Regex based textfile import 2021-03-26 06:44:25 +00:00
text_import_scanner.h
…
text_import_scanner.l
…
time_shift.c
…
time_shift.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
traffic_table_ui.c
…
traffic_table_ui.h
…
urls.h Revert "Apparently, WS_WIKI_URL() is unworkable not only in C++ but in C." 2020-10-25 14:42:47 -07:00
util.c HTTPS In More Places, update some URLs. 2019-07-27 07:55:36 +00:00
util.h
…
voip_calls.c RTP Player: Dialog is nonmodal now and can be called multiple ways 2021-03-30 07:57:22 +00:00
voip_calls.h Move still *more* headers outside of extern "C". 2021-03-16 13:50:13 -07:00
ws_ui_util.h Allow Multiselection of packets to work during live captures 2020-01-12 22:33:42 +00:00