e0eefe186a
- Some redundant assignments or tests. - Some declarations were changed to match definitions in terms of including _U_ for the same parameters - Some parenthesis added/changed to made precedence more obvious epan/color_filters.c:533: style: Variable 'name' is reassigned a value before the old one has been used. epan/color_filters.c:534: style: Variable 'filter_exp' is reassigned a value before the old one has been used. asn1/tcap/packet-tcap-template.c:2199: warning: Function 'dissect_tcap_ITU_ComponentPDU' argument order different: declaration '_U_, tvb, offset, _U_, tree, _U_' definition '_U_, tvb, offset, actx, tree, _U_' epan/dissectors/packet-aim.c:2546: warning: Function 'dissect_aim_tlv_value_icq' argument order different: declaration 'ti, subtype, tvb, _U_' definition 'ti, _U_, tvb, pinfo' epan/dissectors/packet-arp.c:1133: style: Clarify calculation precedence for '&' and '?'. epan/dissectors/packet-arp.c:1143: style: Clarify calculation precedence for '&' and '?'. epan/dissectors/packet-arp.c:1158: style: Clarify calculation precedence for '&' and '?'. epan/dissectors/packet-arp.c:1168: style: Clarify calculation precedence for '&' and '?'. epan/dissectors/packet-gtpv2.c:5997: warning: Function 'dissect_gtpv2_mbms_service_area' argument order different: declaration 'tvb, _U_, tree, _U_, _U_, _U_, _U_, _U_' definition 'tvb, _U_, tree, item, _U_, _U_, _U_, _U_' epan/dissectors/packet-gtpv2.c:6291: warning: Function 'dissect_gtpv2_mbms_time_to_data_xfer' argument order different: declaration 'tvb, _U_, tree, _U_, _U_, _U_, _U_, _U_' definition 'tvb, _U_, tree, item, _U_, _U_, _U_, _U_' epan/dissectors/packet-gtpv2.c:6369: warning: Function 'dissect_gtpv2_epc_timer' argument order different: declaration 'tvb, _U_, tree, _U_, _U_, _U_, _U_, _U_' definition 'tvb, _U_, tree, item, _U_, message_type, _U_, _U_' epan/dissectors/packet-knxip.c:2939: style: Condition 'mac_error' is always false (just added comment) epan/dissectors/packet-mac-lte.c:4386: style: Clarify calculation precedence for '&' and '?'. epan/dissectors/packet-nas_5gs.c:1828: style: Variable 'nas5gs_data->payload_container_type' is reassigned a value before the old one has been used. (noted confusing recursion) epan/dissectors/packet-rpcrdma.c:587: warning: Identical condition 'offset>max_offset', second condition is always false epan/dissectors/packet-rsl.c:2098: style: Assignment of function parameter has no effect outside the function. Change-Id: Ib5c9a04cfb6e6233972bc041434601c8ef09c969 Reviewed-on: https://code.wireshark.org/review/37343 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> |
||
---|---|---|
.. | ||
cli | ||
macosx | ||
qt | ||
win32 | ||
alert_box.c | ||
alert_box.h | ||
all_files_wildcard.h | ||
capture.c | ||
capture.h | ||
capture_globals.h | ||
capture_info.h | ||
capture_ui_utils.c | ||
capture_ui_utils.h | ||
clopts_common.c | ||
clopts_common.h | ||
CMakeLists.txt | ||
cmdarg_err.c | ||
cmdarg_err.h | ||
commandline.c | ||
commandline.h | ||
console.c | ||
console.h | ||
decode_as_utils.c | ||
decode_as_utils.h | ||
dissect_opts.c | ||
dissect_opts.h | ||
export_object_ui.c | ||
export_object_ui.h | ||
export_pdu_ui_utils.c | ||
export_pdu_ui_utils.h | ||
failure_message.c | ||
failure_message.h | ||
file_dialog.c | ||
file_dialog.h | ||
filter_files.c | ||
filter_files.h | ||
firewall_rules.c | ||
firewall_rules.h | ||
help_url.c | ||
help_url.h | ||
iface_lists.c | ||
iface_lists.h | ||
iface_toolbar.c | ||
iface_toolbar.h | ||
io_graph_item.c | ||
io_graph_item.h | ||
language.c | ||
language.h | ||
last_open_dir.h | ||
main_statusbar.h | ||
mcast_stream.c | ||
mcast_stream.h | ||
packet_list_utils.c | ||
packet_list_utils.h | ||
packet_range.c | ||
packet_range.h | ||
persfilepath_opt.c | ||
persfilepath_opt.h | ||
preference_utils.c | ||
preference_utils.h | ||
profile.c | ||
profile.h | ||
progress_dlg.h | ||
proto_hier_stats.c | ||
proto_hier_stats.h | ||
recent.c | ||
recent.h | ||
recent_utils.h | ||
rtp_media.c | ||
rtp_media.h | ||
rtp_stream.c | ||
rtp_stream.h | ||
rtp_stream_id.c | ||
rtp_stream_id.h | ||
service_response_time.c | ||
service_response_time.h | ||
simple_dialog.h | ||
software_update.c | ||
software_update.h | ||
ssl_key_export.c | ||
ssl_key_export.h | ||
summary.c | ||
summary.h | ||
tap-credentials.h | ||
tap-iax2-analysis.c | ||
tap-iax2-analysis.h | ||
tap-rlc-graph.c | ||
tap-rlc-graph.h | ||
tap-rtp-analysis.c | ||
tap-rtp-analysis.h | ||
tap-rtp-common.c | ||
tap-rtp-common.h | ||
tap-sctp-analysis.c | ||
tap-sctp-analysis.h | ||
tap-tcp-stream.c | ||
tap-tcp-stream.h | ||
tap_export_pdu.c | ||
tap_export_pdu.h | ||
taps.h | ||
text_import.c | ||
text_import.h | ||
text_import_scanner.h | ||
text_import_scanner.l | ||
time_shift.c | ||
time_shift.h | ||
traffic_table_ui.c | ||
traffic_table_ui.h | ||
util.c | ||
util.h | ||
voip_calls.c | ||
voip_calls.h | ||
ws_ui_util.h |