Commit Graph

82376 Commits

Author SHA1 Message Date
Guy Harris 7a4fe9b1c3 Include <sys/types.h> before including <netinet/in.h> - you have to do
that on FreeBSD, at least.

svn path=/trunk/; revision=338
1999-07-04 06:47:09 +00:00
Guy Harris aca6d29e7b Note that non-GNU "make"s appear not to be able to build Ethereal, and
that you need "flex" and either "bison" or Berkeley "yacc".  (XXX -
should notes such as this go in some other file, e.g. INSTALL?  I
discovered the "flex" and "bison"/byacc requirement on a Solaris 7
system, but it's probably a problem on other commercial UNIXes, as well,
so it probably doesn't belong in, say, "README.solaris".)

svn path=/trunk/; revision=337
1999-07-04 06:45:53 +00:00
Guy Harris 057f3639a3 In GTK+ 1.0[.x], "gtk_window_set_position()" was called
"gtk_window_position()", so use "gtk_window_position()" if we're using
GTK+ 1.0[.x].

svn path=/trunk/; revision=336
1999-07-04 06:41:19 +00:00
Richard Sharpe 4cef485bd4 Fixed a small problem that would have prevented Ethereal from compiling.
svn path=/trunk/; revision=335
1999-07-01 04:04:38 +00:00
Richard Sharpe e10ddc676c Added some more, auto-generated decoding to packet-smb.c.
Hope it is all OK.

This is getting interesting.

svn path=/trunk/; revision=334
1999-06-28 10:57:57 +00:00
Guy Harris ea9053b4f7 When checking to see if a packet is of a given type by checking the
source and destination port numbers, check both port numbers against the
specified port, rather than checking the lower of the two port numbers
against the specified port, just in case you happen to either have

	1) the port number for that type being high enough that you can
	   get client sockets using it

or

	2) client sockets using it for some other reason.

svn path=/trunk/; revision=333
1999-06-25 07:15:02 +00:00
Guy Harris 8f8923a33b If WITH_WIRETAP is defined, don't define variables used only if
WITH_WIRETAP isn't defined.

svn path=/trunk/; revision=332
1999-06-25 06:49:46 +00:00
Gilbert Ramirez 8596488569 In my haste to get rid of the compilation warning, I converted the
pointer to a signed int instead of an unsigned int. In my testing the
code still worked, but it's better to do the conversion correctly.

svn path=/trunk/; revision=331
1999-06-25 02:57:42 +00:00
Gilbert Ramirez 11394d515f Added Ashok's Match Selected functionality, and changes to move ethereal
to version 0.6.3.

svn path=/trunk/; revision=330
1999-06-24 16:25:59 +00:00
Guy Harris 5a128fea68 If the "Cancel" button is clicked in the "Display Options"
window, revert the timestamp type display option to the value it
	had before that window was popped up, undoing any changes
	applied with the "Apply" button.

	If "Display/Options" is selected while there's a "Display
	Options" window active, don't pop up another "Display Options"
	window (we really should, if that's done, switch the input focus
	to the existing "Display Options" window, if possible).

svn path=/trunk/; revision=329
1999-06-24 05:37:04 +00:00
Gilbert Ramirez 3b0b8e40f4 Finally! Got rid of compilation warning about converting pointer to int
in line 198.

svn path=/trunk/; revision=328
1999-06-23 20:09:58 +00:00
Gilbert Ramirez 98f51e741e Added an "apply" button to the display option gui, so we can try new
timestamp display w/o having the display option GUI disappear.

svn path=/trunk/; revision=327
1999-06-22 22:43:56 +00:00
Gilbert Ramirez 7ea29fb80d Added Aaron Hillegass' summary dialogue. We're ignoring the problem with
NetMon statistic packets for now. We might fix that problem with wiretap,
either filtering out those packets, and/or providing the summary
information through a new wiretap API.

svn path=/trunk/; revision=326
1999-06-22 22:02:39 +00:00
Guy Harris 919fe8f24c Update the display if the "command-line-specified" time format is
changed by updating those columns showing the time in the
"command-line-specified" format, not by redoing the entire packet list
display; that way, the display continues to show the same packets and
any packet the user selected remains selected.  (It's also less work to
do that - you don't have to re-dissect the packet.)

Turn "redisplay_packets()" into "filter_packets()", and do some other
cleanups.

svn path=/trunk/; revision=325
1999-06-22 03:39:07 +00:00
Gilbert Ramirez 851d27fff1 Found some erroneous usages of gtk_signal_connect_object. I always wondered
why I had to swap fields (data = w) in some of the callback functions when
I added support for gtk+-1.1. Because of the use of gtk_signal_connect_object,
the wrong value was being sent to the callback function. We were just lucky
that with gtk+-1.0 it worked.

gtk_signal_connect_object is for use with callbacks that take one argument.
gtk_signal_connect is for use with callbacks that take two arguments.

svn path=/trunk/; revision=324
1999-06-21 19:04:35 +00:00
Gilbert Ramirez 6533d5cae6 Added "0x" to a couple of proto_tree_add_item printf-style labels that
were printing values in hex. The lack of "0x" in fron of the hex numbers
made me think the values were decimal, causing me to waste a bit of time
during debugging.

svn path=/trunk/; revision=323
1999-06-21 16:20:18 +00:00
Gilbert Ramirez d5fab31737 Added a paragraph explaining that the SNMP decode in ethereal uses
either the UCD or CMU SNMP library. Also documented the fact that SNMP
support in ethereal can be disabled with the "--disable-snmp" option to
'configure'.

svn path=/trunk/; revision=322
1999-06-21 16:02:22 +00:00
Guy Harris f8ff7a6a79 Update the man page to reflect the "Capture/Start" and "Display/Options"
menu items.

svn path=/trunk/; revision=321
1999-06-19 08:48:30 +00:00
Guy Harris 5d565b7fee Update a comment.
svn path=/trunk/; revision=320
1999-06-19 03:22:46 +00:00
Guy Harris becbefffcb Use "gtk_toggle_button_set_state()" rather than
"gtk_toggle_button_set_active()" to set the state of radio buttions;
"gtk_toggle_button_set_active()" doesn't exist in GTK+ 1.0[.x], and
"gtk_toggle_button_set_state()" is an alias for it in GTK+ 1.2[.x].

Compute the column widths in the summary display based on the longest
string in the column; recompute it whenever we update the columns.

svn path=/trunk/; revision=319
1999-06-19 03:14:32 +00:00
Guy Harris fe725bec8c Update the column widths if we change the time stamp format from the
"Display/Options" dialog box.

"get_column_width()" should check "timestamp_type" against ABSOLUTE, not
against COL_ABS_TIME.

Clean up the code to check the state of the time stamp radio buttons in
the "Display/Options" dialog box.

Check in "timestamp.h", which we failed to check in on the previous
commit.

svn path=/trunk/; revision=318
1999-06-19 01:47:43 +00:00
Guy Harris 88e94a0186 Added "Capture" and "Display" menus; "Capture" has a "Start" item, which
is the same as "Tools/Capture", and "Display" has an "Options" item,
which pops up a dialog box to let you change the "default" time-stamp
column display format on the fly (the "default" is what the "-t"
command-line option sets), and have the display change when you do that.

Made infrastructure changes to make the immediate display update work.

Removed some unused functions, declared some functions used only in the
file in which they're defined "static", and removed some unnecessary
#includes.

svn path=/trunk/; revision=317
1999-06-19 01:14:51 +00:00
Gilbert Ramirez 6a971ea03c Found a small bug in how the Token-Ring code tried to be smart and looked
for RIF bytes w/o the source-route bit being set.

svn path=/trunk/; revision=316
1999-06-16 20:14:51 +00:00
Guy Harris b39ceabd92 Put "..." after menu items that will cause a dialog box to be popped up
(standard convention in many GUIs).

Make "Save as" be "Save As", and make "A" be the menu mnemonic for it in
the "File" menu, with GTK 1.2.

svn path=/trunk/; revision=315
1999-06-15 04:48:57 +00:00
Guy Harris 5e1f2e3a46 Get rid of an extra line in the author credits (Brad Robel-Forrest
already appears in the list; the extra line is probably leftover from
cutting-and-pasting the author list from the AUTHORS file).

svn path=/trunk/; revision=314
1999-06-15 03:58:42 +00:00
Guy Harris 66fb2e7ae6 Don't load the capture file in "main_realize_cb()", load it after the
"gtk_widget_show()" of the main window; that way:

	1) any alert box popped up because a capture file specified with
	   the "-r" flag can't be read shows up after the main window
	   shows up, and is more likely to end up on top of the main
	   window, rather than behind it;

	2) as the main window is up before we start reading a capture
	   file specified with the "-r" flag, the progress bar can show
	   our progress reading that file.

If the "-k" flag was specified, make sure "-i" and "-w" were specified
as well, rather than just dropping core trying to dereference NULL
"cf.iface" or "cf.save_file" pointers.

svn path=/trunk/; revision=313
1999-06-15 03:46:46 +00:00
Guy Harris a865469064 Add our own "strerror()", which we use on platforms that don't have it
in the standard libraries (such as SunOS 4.x).

svn path=/trunk/; revision=312
1999-06-14 21:46:36 +00:00
Gilbert Ramirez af2bae7723 Changed the Access Control and Frame Control fields in the Token-Ring header
to use the decode_*_bitfield() routines. This needed to happen anyway, but
I finally made the change so that I can figure out how I'm going to handle
bitfield fields in my experiment of changing the implementation of the
protocol tree in ethereal.

svn path=/trunk/; revision=311
1999-06-14 20:30:06 +00:00
Guy Harris 18f922b46e Improve the alert boxes put up for file open/read/write errors. (Some
influence came from

http://developer.apple.com/techpubs/mac/HIGuidelines/HIGuidelines-232.html

which has a section on dialog box and alert box messages.  However,
we're largely dealing with technoids, not with The Rest Of Us, so I
didn't go as far as one perhaps should.)

Unfortunately, it looks like it's a bit more work to arrange that, if
you give a bad file name to the "-r" flag, the dialog box pop up only
*after* the main window pops up - it has the annoying habit of popping
up *before* the main window pops up, and sometimes getting *obscured* by
it, when I do that.  The removal of the dialog box stuff from
"load_cap_file()" was intended to facilitate that work.  (It might also
be nice if, when an open from the "File/Open" menu item fails, we keep
the file selection box open, and give the user a chance to correct
typos, choose another file name, etc.)

svn path=/trunk/; revision=310
1999-06-12 09:10:20 +00:00
Guy Harris 054da75e88 Include "snprintf.h" if necessary - we use "snprintf()".
svn path=/trunk/; revision=309
1999-06-12 09:02:12 +00:00
Guy Harris 018a989bbe Don't pop up the "Can't open preferences file" dialog until *after*
we've shown the top-level window, because we want it to pop up on *top*
of the top-level window, rather than being hidden behind it.

Put a "strerror()"-based reason *why* the open failed in that dialog.

svn path=/trunk/; revision=308
1999-06-12 07:04:35 +00:00
Guy Harris a4005dff5e Move the comment from the GTK 1.0 tutorial just before the GTK 1.0
GtkMenuEntry table, and add the comment from the equivalent part of the
GTK 1.2 tutorial before the GTK 1.2 GtkItemFactoryEntry table.

svn path=/trunk/; revision=307
1999-06-12 06:22:47 +00:00
Guy Harris 1c30696df9 Make the string argument to "col_add_str()" a "const gchar *" - it
doesn't modify anything pointed to by that argument, and that keeps us
from getting complaints if we pass a "const gchar *" to it.

svn path=/trunk/; revision=306
1999-06-12 04:21:09 +00:00
Guy Harris 34178557c8 Use "val_to_str()", rather than "get_XXX()" routines, to map SNMP
versions, PDU types, error statuses, and trap types to strings.

Set the protocol column to "SNMP", and set the info column to an error
message if the parse fails (rather than printing a message to the
standard error) and to the PDU type if it succeeds.

svn path=/trunk/; revision=305
1999-06-12 04:17:19 +00:00
Gilbert Ramirez aca172004f Added RSVP protocol dissector.
svn path=/trunk/; revision=304
1999-06-11 16:45:02 +00:00
Gilbert Ramirez 34450a8a35 Added PPPoE, PPTP, GRE, and ISAKMP dissectors.
svn path=/trunk/; revision=303
1999-06-11 15:30:55 +00:00
Guy Harris 6d7cf738f0 Don't "g_strdup()" what "gtk_entry_get_text()" returns as the contents
of the packet count combo box; there's no need to do so (we don't
remember the string, just its value when converted to a number), and, as
we don't free what "g_strdup()" returns, and don't remember it to save
it later, we leak memory.

svn path=/trunk/; revision=302
1999-06-05 01:44:11 +00:00
Guy Harris a8f72707e1 When checking to see if a packet is of a given type by checking the
source and destination port numbers, check both port numbers against the
specified port, rather than checking the lower of the two port numbers
against the specified port, just in case you happen to either have

	1) the port number for that type being high enough that you can
	   get client sockets using it

or

	2) client sockets using it for some other reason.

svn path=/trunk/; revision=301
1999-06-02 01:28:47 +00:00
Guy Harris 885e4ddfcd When constructing the list for the "Count" combo box in the "Capture"
dialog box, put "0 (Infinite)" first, so that we default to that rather
than to the number of packets in the last capture we read.

svn path=/trunk/; revision=300
1999-06-01 22:24:05 +00:00
Guy Harris 653de14d44 As we may return an error message, rather than a NetBIOS name, from
"get_nbns_name()", make sure the array into which you put the name is
"big enough" - MAXDNAME+4 is more than big enough for those error
messages.

svn path=/trunk/; revision=299
1999-06-01 20:40:34 +00:00
Guy Harris 9bee1b3f20 Unfortunately, as the "cap_len" field in a "frame_data" is unsigned,
"fd->cap_len - offset", i.e. END_OF_FRAME, is unsigned, so

	while (END_OF_FRAME > 0) {

doesn't keep you out of the loop if "offset" is already beyond
"fd->cap_len", so you can try processing stuff past the end of the
captured data in the packet.

svn path=/trunk/; revision=298
1999-06-01 20:39:20 +00:00
Guy Harris cf84edfcf4 Correctly handle the case of the root showing up as a name in a DNS
request or reply.  (Redid "get_dns_name()" along the lines of the code
in the BSD resolver.)

Add code to dissect SOA RRs.

svn path=/trunk/; revision=297
1999-05-27 05:35:08 +00:00
Gilbert Ramirez 5f99945363 Removed segfault if NCP completion code was decoded for an uknown NCP reply type.
svn path=/trunk/; revision=296
1999-05-26 21:46:07 +00:00
Guy Harris fac51faa8a Dissect ICMP Router Discovery packets (router advertisements and router
solicitations).

svn path=/trunk/; revision=295
1999-05-20 02:41:22 +00:00
Gilbert Ramirez 00c52b9e33 Packaging changes for version 0.6.2
svn path=/trunk/; revision=293
1999-05-19 23:16:43 +00:00
Gilbert Ramirez caf9c3e964 Made BPF disassembly in wiretap.c a bit easier to read.
svn path=/trunk/; revision=292
1999-05-19 13:49:35 +00:00
Gilbert Ramirez 2b29a6bcad Added more functionality to the completion-code parsing routine.
svn path=/trunk/; revision=291
1999-05-16 05:12:11 +00:00
Gilbert Ramirez 4302432f16 Removed ethereal.1 and copied make rule from doc/Makefile to top-level
Makefile so that manpage can be made from pod file during packaging.

svn path=/trunk/; revision=290
1999-05-16 04:27:08 +00:00
Gilbert Ramirez 7f11c8a6d7 Fixed to actually compile with CMU SNMP library (at least on Linux).
svn path=/trunk/; revision=289
1999-05-16 04:13:29 +00:00
Gilbert Ramirez 11f27f9b29 Further refined NCP fix, and added translation of NCP Completion Code.
svn path=/trunk/; revision=288
1999-05-14 21:30:13 +00:00