Commit Graph

82376 Commits

Author SHA1 Message Date
Guy Harris 50dbd34d6d Fix a "proto_tree_add_text()" call that should've been a
"proto_tree_add_item()" call (and fix the length passed to it, which, it
appears, has been wrong for ages).

svn path=/trunk/; revision=439
1999-08-05 00:02:55 +00:00
Guy Harris 41a8a32b7b Fix a couple of memory leaks.
svn path=/trunk/; revision=438
1999-08-04 23:43:42 +00:00
Guy Harris 5161130b4b Fix a typo.
svn path=/trunk/; revision=437
1999-08-04 21:20:53 +00:00
Guy Harris d24fa06d74 Add a "dissect_xdlc_control()" routine, to dissect the control field of
SDLC-derived protocols such as HDLC and derivatives of it such as LAPB,
IEEE 802.2 LLC, and so on.  Have the LLC and LAPB dissectors use it.

Make "dissect_numeric_bitfield()" put the low-order bit of the bitfield
in the low-order bit of an integer when printing it, so that the right
value is printed.

svn path=/trunk/; revision=436
1999-08-04 06:15:07 +00:00
Guy Harris 191368270e Patch from Olivier Abad to implement modulo 128 X.25 decoding, and to
improve X.25 decoding in other ways as well.

svn path=/trunk/; revision=435
1999-08-04 06:11:17 +00:00
Guy Harris 47d1269da4 Add a "dissect_xdlc_control()" routine, to dissect the control field of
SDLC-derived protocols such as HDLC and derivatives of it such as LAPB,
IEEE 802.2 LLC, and so on.  Have the LLC and LAPB dissectors use it.

Make "dissect_numeric_bitfield()" put the low-order bit of the bitfield
in the low-order bit of an integer when printing it, so that the right
value is printed.

svn path=/trunk/; revision=434
1999-08-04 04:37:46 +00:00
Gilbert Ramirez 94f3a2c640 Give some credit.
svn path=/trunk/; revision=432
1999-08-04 03:44:11 +00:00
Gilbert Ramirez 904e195de4 Fixed match_selected to work with new display filter code. It uses
"frame[x:y]" in the display filte that it creates so that it works with
any datalink type.

svn path=/trunk/; revision=431
1999-08-04 03:37:45 +00:00
Guy Harris a0f41eddb4 Fix a comment.
svn path=/trunk/; revision=430
1999-08-04 00:33:11 +00:00
Guy Harris 6e386b4451 Eliminate an extra comma from a message.
svn path=/trunk/; revision=429
1999-08-04 00:21:37 +00:00
Gilbert Ramirez d45629555b Update version numbers to 0.7.0, and update win32 Makefiles. I made some
initial #ifdef changes to capture.c to support the win32 version of libpcap.

svn path=/trunk/; revision=428
1999-08-03 20:51:41 +00:00
Gilbert Ramirez 48a5d3ee58 Update documentation, including display filter docs.
svn path=/trunk/; revision=427
1999-08-03 16:33:12 +00:00
Gilbert Ramirez aebcf2eb32 Removed the "exists" keyword from the grammar. The name of a protocol or a
field by itself assumes you are checking for the existence of that protocol
or field.

Changed the format of the list of filterable fields in the man page.
Developers: run "./configure" so that your configure script will re-create
dfilter2pod from the new dfilter2pod.in

svn path=/trunk/; revision=426
1999-08-03 15:04:33 +00:00
Gilbert Ramirez feaab633b5 Checked in Johan's Updated RADIUS dissector which uses the new proto_tree
implementation.

svn path=/trunk/; revision=425
1999-08-03 14:59:16 +00:00
Gilbert Ramirez dd7f284649 Fixed #ifdef to call proto_register_snmp properly when SNMP is compiled in.
svn path=/trunk/; revision=424
1999-08-03 14:49:34 +00:00
Guy Harris 0ee7136b4b Patch from Bill Fumerola to quiet some EGCS complaints, at least on
FreeBSD.

svn path=/trunk/; revision=423
1999-08-03 03:48:04 +00:00
Gilbert Ramirez 36ecdca372 I was able to get rid of all the reduce/reduce conflicts by removing
the rules allowing values to precede variables in a relation, like this:

	192.168.1.1 eq ip.src

More profound changes should still be made to the grammar, though.

svn path=/trunk/; revision=422
1999-08-02 06:34:23 +00:00
Gilbert Ramirez 56f95e5520 Changed the chmod() call to a pair of umask() calls that straddle the
call to pcap_dump_open. This allows us to control the readability of the
temporary trace file, and avoid a race condition in which a user could
open the trace file after the pcap_dump_open() call and the subsequent
chmod() call.

Thanks to Jeorg for pointing for pointing out the race condition.

svn path=/trunk/; revision=421
1999-08-02 06:08:58 +00:00
Guy Harris c61ac5c4b7 Update Olivier Abad's e-mail address.
svn path=/trunk/; revision=420
1999-08-02 05:52:52 +00:00
Guy Harris ecf06ddcdc Check in Olivier Abad's patch to add dissectors for LAP-B and X.25, and
wiretap support for RADCOM Ltd.'s WAN/LAN analyzers (see

	http://www.radcom-inc.com/

).  Note: as I remember, IEEE 802.2/ISO 8022 LLC has somewhat of an SDLC
flavor to it, just as I think LAP, LAPB, LAPD, and so on do, so we may
be able to combine some of the LLC dissection and the LAPB dissection
into common code that could, conceivably be used for other SDLC-flavored
protocols.

Make "S" a mnemonic for "Summary" in the "Tools" menu.

Move the routine, used for the "Tools/Summary" display, that turns a
wiretap file type into a descriptive string for it into the wiretap
library itself, expand on some of its descriptions, and add an entry for
files from a RADCOM analyzer.

Have "Tools/Summary" display the snapshot length for the capture.

svn path=/trunk/; revision=419
1999-08-02 02:45:00 +00:00
Guy Harris 582a64f482 Add to "wtap_close()" code to free up data structures allocated for
reading RADCOM WAN/LAN analyzer files and NetXRay/Windows Sniffer files.

svn path=/trunk/; revision=418
1999-08-02 02:35:57 +00:00
Guy Harris a75f7d1d24 Olivier Abad's patch to add dissectors for LAP-B and X.25, and wiretap
support for RADCOM Ltd.'s WAN/LAN analyzers (see

	http://www.radcom-inc.com/

).  Note: a

Make "S" a mnemonic for "Summary" in the "Tools" menu.

Move the routine, used for the "Tools/Summary" display, that turns a
wiretap file type into a descriptive string for it into the wiretap
library itself, expand on some of its descriptions, and add an entry for
files from a RADCOM analyzer.

Have "Tools/Summary" display the snapshot length for the capture.

svn path=/trunk/; revision=417
1999-08-02 02:26:22 +00:00
Guy Harris 79c2223425 Check in Olivier Abad's patch to add dissectors for LAP-B and X.25, and
wiretap support for RADCOM Ltd.'s WAN/LAN analyzers (see

	http://www.radcom-inc.com/

).  Note: as I remember, IEEE 802.2/ISO 8022 LLC has somewhat of an SDLC
flavor to it, just as I think LAP, LAPB, LAPD, and so on do, so we may
be able to combine some of the LLC dissection and the LAPB dissection
into common code that could, conceivably be used for other SDLC-flavored
protocols.

Make "S" a mnemonic for "Summary" in the "Tools" menu.

Move the routine, used for the "Tools/Summary" display, that turns a
wiretap file type into a descriptive string for it into the wiretap
library itself, expand on some of its descriptions, and add an entry for
files from a RADCOM analyzer.

Have "Tools/Summary" display the snapshot length for the capture.

svn path=/trunk/; revision=416
1999-08-02 02:04:38 +00:00
Guy Harris 7bcc34708d Update the "Contributors" section of the man page to include everybody
listed in the AUTHORS file.  (Arguably, that section - *and* the list of
developers in the "Help/About" box - should be generated from the
AUTHORS file by a script....)

svn path=/trunk/; revision=415
1999-08-01 05:24:19 +00:00
Gilbert Ramirez b2f932c1db Changed the display filter scanner from GLIB's GScanner to lex. The code
as it standed depends on your lex being flex, but that only matters if you're
a developer. The distribution will include the dfilter-scanner.c file, so
that if the user doesn't modify dfilter-scanner.l, he won't need flex to
re-create the *.c file.

The new lex scanner gives me better syntax checking for ether addresses. I
thought I could get by using GScanner, but it simply wasn't powerful enough.

All operands have English-like abbreviations and C-like syntax:
and, && ; or, || ; eq, == ; ne, != ; , etc.

I removed the ETHER_VENDOR type in favor of letting the user use the [x:y]
notation:	ether.src[0:3] == 0:6:29 instead of ether.srcvendor == 00:06:29

I implemented the IPXNET field type; it had been there before, but was
not implemented. I chose to make it use integer values rather than byte
ranges, since an IPX Network is 4 bytes. So a display filter looks like this:
	ipx.srcnet == 0xc0a82c00
rather than this:
	ipx.srcnet == c0:a8:2c:00

I can supposrt the byte-range type IPXNET in the future, very trivially.

I still have more work to do on the parser though. It needs to check ranges
when extracting byte ranges ([x:y]) from packets. And I need to get rid
of those reduce/reduce errors from yacc!

svn path=/trunk/; revision=414
1999-08-01 04:28:20 +00:00
Gilbert Ramirez c31abd81fa chmod() the temporary capture file to 0600 so that only the user can
read the trace. We chmod() after pcap creates the file, but before it actually
writes data there. Thanks to Frederic Peters <fpeters@multimania.com>,
the Debian maintainer of Ethereal, for pointing this out.

svn path=/trunk/; revision=413
1999-07-31 23:06:13 +00:00
Guy Harris 7d8d76e7d6 When applying filters constructed by "Follow TCP Stream" or "Match
Selected", use "filter_packets()" to filter the packets we currently
have, rather than re-reading the capture file.

svn path=/trunk/; revision=412
1999-07-31 18:26:07 +00:00
Guy Harris 7d358ac637 Make unsigned the members of a "packet_info" structure that store IP
addresses, IP protocols, and TCP/UDP port numbers (as those are
unsigned).

svn path=/trunk/; revision=411
1999-07-31 18:18:43 +00:00
Laurent Deniel fb8aa8fb7a Fix TCP follow stream feature:
- call reset_tcp_reassembly before build_follow_filter
- modify reassemble_tcp so that packet validity is
  checked before processing it.

svn path=/trunk/; revision=410
1999-07-31 13:55:16 +00:00
Laurent Deniel 68e50f3486 - remove close_cap_file in follow_stream_cb since load_cap_file
implicitly calls it
- compute the filter in follow_stream_cb since load_cap_file
  does not honor the display filter if the dfcode is non already set
- Follow TCP stream is still buggy however (incorrect saved TCP data due
  to the fact that dissect_tcp is called even if the filter applies).

svn path=/trunk/; revision=409
1999-07-31 13:10:18 +00:00
Laurent Deniel 98ebf4ee0a Remove srcip and destip from packet_info since it is not safe to affect
string pointer from the result of ip_to_str (statically allocated string).
Use the ip_src and the new field ip_dst in follow.c to build a correct
string display filter.

svn path=/trunk/; revision=408
1999-07-31 11:21:06 +00:00
Guy Harris 60d150011a Label the TCP sequence number as "Sequence number", not "Sequence
number" - other fields (including "Acknowledgment number") capitalize
only the first word.

svn path=/trunk/; revision=407
1999-07-31 02:18:35 +00:00
Guy Harris 9b253e4151 Print FT_UINT{8,16,32} values with "%u", not "%d", as they're unsigned
values (for example, a sequence number in a TCP header should be printed
as an unsigned value; I have a trace in which the uppermost bit of the
sequence number is set...).  If we need to be able to handle signed
values, add FT_INT{8,16,32} types.

svn path=/trunk/; revision=406
1999-07-31 02:15:12 +00:00
Guy Harris e75e9ea3b5 The protocol tree field created for a protocol itself is of type
FT_NONE, so the first argument in the variable-length portion of the
argument list to the "proto_tree_add_item()" or
"proto_tree_add_item_format()" call to add the top-level protocol tree
item for a protocol has to be a null pointer.

svn path=/trunk/; revision=405
1999-07-30 05:42:25 +00:00
Guy Harris f5733e9aee Fix a typo in "Hypertext".
svn path=/trunk/; revision=404
1999-07-30 00:57:15 +00:00
Guy Harris da1baa7d22 Fix it to build with CMU, as well as UCD, SNMP.
svn path=/trunk/; revision=403
1999-07-29 07:11:23 +00:00
Gilbert Ramirez 7bd6c15378 Made the protocol (but not the fields) use the new proto_tree routine,
allowing users to filter on the existence of these protocols. I also
added packet-clip.c to the Nmake makefile.

svn path=/trunk/; revision=402
1999-07-29 05:47:07 +00:00
Guy Harris 6f1d3a3be8 Patches from Thierry Andry to support Classical IP captures from systems
with the ATM on Linux software from <http://lrcwww.epfl.ch/linux-atm/>.

svn path=/trunk/; revision=401
1999-07-28 23:16:42 +00:00
Laurent Deniel c4717a95d9 Code cleaning:
- remove the tail_timeout_cb feature
- remove unneeded fseek.

svn path=/trunk/; revision=400
1999-07-28 20:53:40 +00:00
Guy Harris 5eac77ec4c Include <stdlib.h> to get "atoi()" declared, to squelch a "gcc -Wall"
complaint.

svn path=/trunk/; revision=399
1999-07-28 20:39:42 +00:00
Laurent Deniel c42634dd82 Fix the -S option :
- read only the real number of packets that have been written
  by the child process. That's avoid incomplete packet read.
- special timeout handling no more necessary and the whole
  real time capture and display behavior is much more
  satisfying with this patch.
- wiretap modified to allow the reading of 'count' packets
  with wtap_loop.

svn path=/trunk/; revision=398
1999-07-28 20:17:24 +00:00
Guy Harris e0b268397a Fix up the comment before "get_column_width()" to reflect current
reality.

svn path=/trunk/; revision=397
1999-07-28 03:47:03 +00:00
Guy Harris 075ba742f7 If a column doesn't automatically resize, we have to set its size to the
appropriate value when we thaw the packet list, so that its size isn't
set to the size of the column title.

svn path=/trunk/; revision=396
1999-07-28 03:38:42 +00:00
Guy Harris cc0f9562c9 Get rid of the "Tools/Capture" menu item, in favor of "Capture/Start".
svn path=/trunk/; revision=395
1999-07-28 03:33:34 +00:00
Guy Harris b70d733f50 Have:
COL_INFO columns resize automatically even during a live
	capture;

	columns showing network addresses never resize automatically;

	other columns resize only when a capture is done;

and make all columns resizeable by hand (once they've resized, for
auto-resizeable columns).

svn path=/trunk/; revision=394
1999-07-28 03:29:02 +00:00
Gerald Combs f04819106b Added a bug fix from Erik Daughtrey that sets cf_filter to NULL after being
freed.

svn path=/trunk/; revision=393
1999-07-28 02:40:16 +00:00
Gerald Combs 90cae40e82 Added a fix from Shoichi Sakane that corrects some missing "break"s.
svn path=/trunk/; revision=392
1999-07-28 02:32:25 +00:00
Gerald Combs a8e264ff8e Added a fix from Takashi Tanaka to correct a byte order problem when printing
the MTU.

svn path=/trunk/; revision=391
1999-07-28 02:14:14 +00:00
Gerald Combs c7e8a7e855 Added a patch from Olivier Abad to handle X.25 iptrace captures.
svn path=/trunk/; revision=390
1999-07-28 01:35:34 +00:00
Gilbert Ramirez b080b90479 Fixed some improper word choices in the echoed error messages.
svn path=/trunk/; revision=389
1999-07-27 05:19:10 +00:00