Added check on Command-Number on control message following
Accept-Session to detect the correct state. There are
various states possible after Accept-Session.
packet-signal-pdu.c:267:1: warning: no previous prototype for function 'proto_reg_handoff_signal_pdu_can' [-Wmissing-prototypes]
packet-signal-pdu.c:293:1: warning: no previous prototype for function 'proto_reg_handoff_signal_pdu_lin' [-Wmissing-prototypes]
packet-signal-pdu.c:314:1: warning: no previous prototype for function 'proto_reg_handoff_signal_pdu_someip' [-Wmissing-prototypes]
packet-signal-pdu.c:335:1: warning: no previous prototype for function 'proto_reg_handoff_signal_pdu_pdu_transport' [-Wmissing-prototypes]
packet-r09.c:152:1: warning: no previous prototype for function 'proto_register_r09' [-Wmissing-prototypes]
packet-r09.c:217:1: warning: no previous prototype for function 'proto_reg_handoff_r09' [-Wmissing-prototypes]
file-tiff.c:840:1: warning: no previous prototype for function 'proto_register_tiff' [-Wmissing-prototypes]
file-tiff.c:1143:1: warning: no previous prototype for function 'proto_reg_handoff_tiff' [-Wmissing-prototypes]
* introduced with 9b13c4352d
* HAVE_SMI_VERSION_STRING is always defined if libsmi found
Change-Id: I50480d37a3a6f31bcfe768f030af9176213b7366
Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
Fix
wsutil/ws_getopt.c:93:21: error: possible misuse of comma operator here [-Werror,-Wcomma]
return ws_optind++, -1;
^
wsutil/ws_getopt.c:93:10: note: cast expression to void to silence warning
return ws_optind++, -1;
^~~~~~~~~~~
(void)( )
wsutil/ws_getopt.c:188:11: error: possible misuse of comma operator here [-Werror,-Wcomma]
name++, opt++;
^
wsutil/ws_getopt.c:188:5: note: cast expression to void to silence warning
name++, opt++;
^~~~~~
(void)( )
wsutil/ws_getopt.c:199:15: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
int l = arg-start;
~ ~~~^~~~~~
Add a .editorconfig entry for ws_getopt.[ch].
Besides the obvious limitation of being unavailable on Windows,
the standard is vague about getopt() and getopt_long() has many
non-portable pitfalls and buggy implementations, that increase
the maintainance cost a lot. Also the GNU libc code currently
in the tree is not suited for embedding and is unmaintainable.
Own maintainership for getopt_long() and use the musl implementation
everywhere. This way we don't need to worry if optreset is available,
or if the $OPERATING_SYSTEM version behaves in subtly different ways.
The API is under the Wireshark namespace to avoid conflicts with
system headers.
Side-note, the Mingw-w64 9.0 getopt_long() implementation is buggy
with opterr and known to crash. In my experience it's a headache to
use the embedded getopt implementation if the system provides one.
As dynamic channel data can be transported on top of TCP or UDP, we need to keep track
of the link between UDP and TCP connections so that the associated data can be shared
between the two transports.
I was hoping to avoid this, since the ptvcursor should already be
implicitly scoped to the tree it is working on. But there are a bunch of
call sites where the passed tree can be NULL (?) and a few places where
the tree is explicitly set/reset after creation, so requiring an
explicit scope is safer.
Avoids global memory pools in favour of ones the compiler can verify.
Avoids the use of the global memory pool in favour of one the compiler
actually knows must be in scope.
Also delete a few-hundred lines of if-0ed code that hadn't been active
in 15+ years.
IEC 61850 is directly over Ethernet, so use set_actual_length
like other such protocols so that the Ethernet dissector has a
chance to detect and dissect trailers / FCS.
And do it in the template from which packet-sv.c is generated, rather
than in packet-sv.c, so that it doesn't get overwritten if somebody
regenerates the sv dissector.
Added decoding and display of "Number of Schedule Slots"
and "Number of Packets" parameters contained in Request-Session
message in TWAMP Control protocol, in accordance with RFC-4656.
João Valverde