Commit Graph

86292 Commits

Author SHA1 Message Date
João Valverde eda80ed336 dfilter: Improve error location for parenthesized expressions 2022-12-26 03:20:30 +00:00
John Thacker b1d93f7952 charsets: Optimize getting UTF-8 strings with an accumulator
Add all the valid bytes at once when we get to the end of the
length (or hit an invalid sequence) instead of one byte or character
at a time. This makes for a considerable speedup.
2022-12-25 20:42:28 +00:00
Gerald Combs 274a6c9d64 [Automatic update for 2022-12-25]
Update manuf, services enterprise numbers, translations, and other items.

services failed.
2022-12-25 16:46:13 +00:00
Eric Anderson d91cd30855 BACnet: Fix dissection of Notification Parameters
When the new-value element of the change-of-discrete choice contains context
tag zero, the tag content should be decoded as a BACnetDateTime. Closes #18747.
2022-12-24 19:59:24 +00:00
João Valverde 816005fc23 dfilter: Reformat grammar code
Use a consistent style for grammar rules.

Remove a comment that is too generic. The current code should
conform to how Python operates and does not need additional error
checking.
2022-12-24 18:25:11 +00:00
João Valverde b9a5009cb2 dfilter: Clean up scanner code
Clean up some issues flagged by a linter.

Remove hyphen from pattern names and remove an unused start condition.
2022-12-24 15:51:36 +00:00
Jianwei Mao d9a09aa622 IPv6: Support dissecting IETF APN6 option.
IETF APN6: Application-Aware IPv6 Networking (APN6)

APN6 option is a new option including in IPv6 Destination Options Header.

APN6 makes use of IPv6 encapsulation to convey the APN Attribute along with
data packets and make the network aware of data flow requirements at different
granularity levels. The APN attribute can be encapsulated in the APN header.

References:
1. https://datatracker.ietf.org/wg/apn/about/
2. https://datatracker.ietf.org/doc/draft-li-apn-header/
3. https://datatracker.ietf.org/doc/draft-li-apn-ipv6-encap/
2022-12-24 08:15:27 +00:00
Guy Harris 13f3ebc4e5 Add a routine to get the path of an executable given the program name.
That reduces the number of get_progfile_dir() calls, leaving only the
calls that are done either to 1) get the pathname in order to display it
or 2) get the pathname in order to reset the library path.

That makes it easier to figure out which get_progfile_dir() calls are
made to find the directory in which (non-extcap) binaries from Wireshark
are installed and which - if any - are made to figure out the directory
in which *the currently-running executable* are stored.  (Currently,
get_progfile_dir() attemps to get the former, not the latter, so
extcaps in an extcap subdirectory, for example, will get the parent
directory of that subdirectory, *not* the directory in which they weere
installed.)
2022-12-23 23:20:22 +00:00
João Valverde 44511c318d dfilter: Improve error location for expressions
Try to underline the whole expression instead of the
token.
2022-12-23 18:23:14 +00:00
João Valverde 3938b406fb dfilter: Refactor error location tracking
Remove duplicate location struct by adding a new header.

Pass around a structure instead of a pointer.
2022-12-23 18:23:06 +00:00
Martin Mathieson 51a6dfffc7 PDCP-LTE: add a filter for decypted data 2022-12-23 10:59:35 +00:00
Guy Harris 63bd8fde63 Fix display of help file path name in error dialog.
Display it as a pathname in the native format (e.g., C:\this\is\wrong),
not as the path component of the URL supplied (e.g., /C/this/is/wrong).

Fixes some confusion that appeared in a comment in #15592 (but not the
underlying bug - fixing that bug should prevent that dialog from popping
up in the first place).
2022-12-22 18:28:04 -08:00
João Valverde 4e1211de90 dfilter: Add support for negation of arithmetic expressions 2022-12-22 23:51:16 +00:00
Gerald Combs 5dcefc7777 wsutil: Make progfile_dir the main program file directory.
If our program file directory has a trailing "/extcap" or "\extcap",
trim it off. This should let extcaps determine the proper data file and
plugin directories. Fixes #15592.
2022-12-22 21:22:04 +00:00
Pascal Quantin e9176b652d ASN.1 PER: fix dissect_per_restricted_character_string_sorted()
Avoid incrementing offset if it was already changed when trying to fetch
length. Closes #18702
2022-12-22 20:51:49 +00:00
John Thacker 5ee2e7c268 QUIC: Handle QUIC connections multiplexed on the same 5-tuple
Different QUIC connections can be multiplexed on the same network
5-tuple. Handle this, including checking for Stateless Reset tokens
on all connections on the same 5-tuple.

Create a CONVERSATION_QUIC type using our internal QUIC connection
ID, and set the conversation elements so that subdissectors like
TLS that set conversation data only alter data for the one QUIC
connection instead of all multiplexed connections.

Various failures are expected, per RFC 9000, if zero-length connection
IDs are used when multiplexing connections on the same local IP addresses
and ports.

Fix #17099
2022-12-22 19:56:19 +00:00
Gerald Combs bf17e3260e CMake: Set a default output directory for log-based extcaps 2022-12-22 19:30:17 +00:00
Martin Mathieson 369993d72c E2AP: Use gnbid to share RAN Function ID mappings 2022-12-22 19:18:18 +00:00
Gerald Combs f809e62b2a Tools: Move speexdsp to the Alpine and RPM basic lists. 2022-12-22 17:44:37 +00:00
Martin Mathieson 398b05d199 DECT-NWK: Fix a couple of typos 2022-12-22 12:05:12 +00:00
João Valverde ba1a85d381 dfilter: Improve arithmetic error messages 2022-12-22 10:13:30 +00:00
easonweii 0e4bcf427f H224: Completing of H.224 dissection for Client Data Octets
Add the client protocols prasing for CME (Client Management Entity) and H.281/FECC (Far-End Camera Control).
Related #18667
2022-12-22 08:40:53 +00:00
Bernhard Dick ae0d6324c4 DECT-NWK: Fix windows build
When building using msvc implicit changes of the integer sizes in
fmt_dect_nwk_ipei are treated as error due to possible loss of
information.
This is now forecome by explicitely masking the shifted value to fit in
guint16 and by typecasting in calculation to guint16 (the maximum value
that needs to fit here is sum(x=1..x=12)(9x)=702 )
2022-12-21 21:30:20 +00:00
Bernhard Dick 8aec74c0ba DECT-NWK: Simplify data dissector call 2022-12-21 21:30:20 +00:00
Bernhard Dick cdf134b4e5 DECT-NWK: Update wmem_strbuf function usage
In 32f88ad22c the function to create new
sized wmwm strbufs has been renamed and got a parameter change. This
updates DECT-NWK parts accordingly.
2022-12-21 21:30:20 +00:00
Bernhard Dick b7d2d107d4 DECT-NWK: Update hf type
Use type int instead of gint for all hf_ variables as this is used in
the functions and structures
2022-12-21 21:30:20 +00:00
Bernhard Dick 0905bc33b5 DECT-NWK: Remove solved TODO marks 2022-12-21 21:30:20 +00:00
Bernhard Dick 9cddc16d68 DECT-NWK: Dissect more IPUI types 2022-12-21 21:30:20 +00:00
Bernhard Dick 4e0365b25b DECT-NWK: Improve display of DECT chars/strings 2022-12-21 21:30:20 +00:00
Bernhard Dick 1d8152afd7 DECT-NWK: Escape DECT chars >= 0x80 2022-12-21 21:30:20 +00:00
Bernhard Dick ad06d7cec6 DECT-NWK: Use DECT charset for strings 2022-12-21 21:30:20 +00:00
Bernhard Dick 75fb2e770c DECT-NWK: Add basic support for DECT charsets 2022-12-21 21:30:20 +00:00
Bernhard Dick cc86a34c90 DECT-NWK: Fix IPEI string formatting 2022-12-21 21:30:20 +00:00
Bernhard Dick 1272bd3c2d DECT-NWK: Fix missing initialization 2022-12-21 21:30:20 +00:00
Bernhard Dick 4fed21f5a8 DECT-NWK: Make format function static 2022-12-21 21:30:20 +00:00
Bernhard Dick e3f010683f DECT-NWK: Dissect more S-Format message types
Adds basic dissection for futher S-Format message types:
* CISS
* CRSS
* COMS
* CLMS
2022-12-21 21:30:20 +00:00
Bernhard Dick 08cdb705e9 DECT-NWK: Add dissector to relnotes 2022-12-21 21:30:20 +00:00
Bernhard Dick 98a86dc660 DECT-NWK: Add fields to PORTABLE-IDENTITY
Add dissection of TPUI and IPEI field including IPEI format string to
the PORTABLE-IDENTITY S-Format information element
2022-12-21 21:30:20 +00:00
Bernhard Dick 3b1084d0a1 DECT-NWK: Fix missing prototype 2022-12-21 21:30:20 +00:00
Bernhard Dick e95424b4cd DECT-NWK: fix proto tree item length
The Default Cipher Key algorithm field within AUTH-TYPE is only in the
last two bits of octet 5c, not 5c+5d
2022-12-21 21:30:20 +00:00
Bernhard Dick bb9785c849 DECT-NWK: Fix typos 2022-12-21 21:30:20 +00:00
Bernhard Dick d4f070ce54 DECT-NWK: Add further ie dissection
Added dissectin of the S-Format information fields
* DURATION
* IWU-TO-IWU
* MODEL-IDENTIFIER
* CODEC-LIST
2022-12-21 21:30:20 +00:00
Bernhard Dick 775ea97ddf DECT-NWK: Fix TERMINAL-CAPAPILITY
The mask for the control codes field within the TERMINAL-CAPABILITY
information element was masking the wrong bits.
2022-12-21 21:30:20 +00:00
Bernhard Dick 528391f2bd DECT-NWK: Fix hf definition
Definition of hf_dect_nwk_s_ie_terminal_capability_blind_slot_6a
reffered to the TFS for its bits by accident, this is now removed.
2022-12-21 21:30:20 +00:00
Bernhard Dick be04f23917 DECT-NWK: fix typo in field name 2022-12-21 21:30:20 +00:00
Bernhard Dick 271f7e00f9 DECT-NWK: Fix value_string terminations 2022-12-21 21:30:20 +00:00
Bernhard Dick 2e6e44d1b1 DECT-NWK: Add MULTI-DISPLAY, MULTI-KEYPAD
Add basic dissection of S-Format elements MULTI-DISPLAY and
MULTI-KEYPAD. The dissector now holds information regarding control
characters of the DECT charset.
2022-12-21 21:30:20 +00:00
Bernhard Dick 1c0da0d2e2 DECT-NWK: Add TERMINAL-CAPABILITY dissection
Dissection of the TERMINAL-CAPABILITY S-Format information element has
been implemented.
2022-12-21 21:30:20 +00:00
Bernhard Dick f4ec602228 DECT-NWK: Add LOCATION-AREA dissection 2022-12-21 21:30:20 +00:00
Bernhard Dick d1befab186 DECT-NWK: Add single binary value IEs
Add dissection of the S-Format information elements RAND, RES, RS all
holding an arbitrary data within their whole field length
2022-12-21 21:30:20 +00:00