Commit Graph

177 Commits

Author SHA1 Message Date
Anders Broman 8e97665863 Add *.sbr files to the clean target.
svn path=/trunk/; revision=40761
2012-01-29 20:03:39 +00:00
Bill Meier 48ca3d4742 Use GSlice API instead of GMemChunk API for some memory allocation.
svn path=/trunk/; revision=40547
2012-01-16 19:05:32 +00:00
Bill Meier 49eff359e1 Fix a typo in an error message.
svn path=/trunk/; revision=40546
2012-01-16 18:12:18 +00:00
Jörg Mayer 8b8025c5d0 Add a comment about the uncommented glib deprecated warnings.
svn path=/trunk/; revision=38403
2011-08-08 09:39:30 +00:00
Jörg Mayer 553c565699 mate_grammar.lemon:
- Fix a bug my previous patch introduced.

mate/:
- Unset G_DISABLE_DEPRECATED for the mate files.

CMakeLists.txt
configure.in:
- Build with -DG_DISABLE_DEPRECATED so further usage of
  deprecated glib functions will be detected.

svn path=/trunk/; revision=38393
2011-08-07 18:35:36 +00:00
Jörg Mayer c15ff441c6 Replace deprecated glib functions.
In order to compile the whole project with -DG_DISABLE_DEPRECATED
the mate plugin needs to replace its usage of GMemChunk.
All other places should be clean.

svn path=/trunk/; revision=38392
2011-08-07 18:15:45 +00:00
Stig Bjørlykke 8443bbbf75 Replace all strerror() with g_strerror().
Remove our local strerror implementation.
Mark strerror as locale unsafe API.

This fixes bug 5715.

svn path=/trunk/; revision=37812
2011-06-28 09:00:11 +00:00
Bill Meier 7062abeb00 Don't assign a value to a variable which is then never used: Coverity 1160 [UNUSED]
svn path=/trunk/; revision=37290
2011-05-19 14:11:01 +00:00
Jörg Mayer 2b3167dcf9 Fix another old style function declaration warning
svn path=/trunk/; revision=37281
2011-05-19 05:08:42 +00:00
Guy Harris d6fdc37988 More fun with GArrays: cast away some warnings that don't report real
alignment problems and that wouldn't even happen if the "data" member of
a GArray were a "void *".

svn path=/trunk/; revision=36855
2011-04-25 21:19:54 +00:00
Alexis La Goutte 2fc740d7d1 Fix (latest) Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36802
2011-04-22 13:11:52 +00:00
Alexis La Goutte 0c598a950d Fix Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36756
2011-04-21 13:33:04 +00:00
Anders Broman bc0fbb792a Added FALLTHRU comment to avoid a "missing break" warning.
CID 489

svn path=/trunk/; revision=36400
2011-03-29 21:05:29 +00:00
Chris Maynard 10928bc0cc Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.

svn path=/trunk/; revision=36383
2011-03-28 17:04:58 +00:00
Bill Meier 7c41d527fd Removed uneeded 'continue'.
Fixes Coverity 815 ("UNREACHABLE").

svn path=/trunk/; revision=36367
2011-03-27 14:34:19 +00:00
Stig Bjørlykke 1f108b02a0 Allocate correct size of range.
Coverity 718.

svn path=/trunk/; revision=36262
2011-03-22 18:58:32 +00:00
Ronnie Sahlberg ea9e664fc9 Coverity 420
Remove dead code and add a g_assert_not_reached() at a spot we can definitely never reach.

change a if(x)g_free(x) to a g_free(x)
since g_free(NULL) is just a nop.



svn path=/trunk/; revision=36238
2011-03-22 09:05:26 +00:00
Stig Bjørlykke a774994572 Added some casts to fix coverity 325.
svn path=/trunk/; revision=36228
2011-03-21 18:33:18 +00:00
Bill Meier d3efa3ed9f A bit of Windows makefiles rework and cleanup:
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile;
  a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS;
  b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake)
      (This allows disabling "Warnings as Errors" by just changing config.nmake)
  c. CVARSDLL definitions (not usage) have been removed from the various makefiles.
     XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since:
     -DWIN32 and -DNULL=0 do not appear to be needed (any more);
     -D_MT and _D_DLL  are not needed since /MP causes these definitions.
  d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled.
     E.G., 4295: array is too small to include a terminating null character
- config.nmake: reformat some long lines for readability;
- plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile);
- dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ...

svn path=/trunk/; revision=35747
2011-02-02 01:19:53 +00:00
Bill Meier 6e079af172 Whitespace cleanup (remove trailing blanks from lines).
svn path=/trunk/; revision=35711
2011-01-30 22:57:00 +00:00
Bill Meier 17281958a2 Add a comment about some "unreachable code" indicating possible incorrect code someplace.
Fix some spelling..

svn path=/trunk/; revision=35710
2011-01-30 22:42:06 +00:00
Guy Harris ac3ac6c476 Plugins are not shared libraries, so:
1) don't set thei SOVERSION - run-time-loaded modules don't have
	   an SOVERSION;

	2) build them with link mode MODULE, not SHARED, on all
	   platforms.

(Fixing 1) also fixes the problem with building them as MODULE on OS X.)

svn path=/trunk/; revision=34243
2010-09-24 20:41:34 +00:00
Jörg Mayer de68ad3066 H. Sivank <hsivank@gmail.com>
I try to configure Wireshark with cmake on macosx 10.6.
It fails with : set_target_properties called with incorrect number of arguments.
Attached a patch to fix this issue.


svn path=/trunk/; revision=34201
2010-09-23 07:02:33 +00:00
Jeff Morriss 54082c6ed0 Add Cmake stuff to the source distribution so more people can try it out.
svn path=/trunk/; revision=32807
2010-05-14 16:27:03 +00:00
Jeff Morriss b09f79f414 Be sure we initialize the p_id in hf's. This fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3010 .

Also finish the implementation of ShowTimes for GOGs so that the variable gets
initialized (preventing another uninitialized variable warning from Valgrind).

svn path=/trunk/; revision=32465
2010-04-14 18:39:00 +00:00
Jeff Morriss ef2548d093 Fix up MATE's hf display values so MATE will actually run.
svn path=/trunk/; revision=32464
2010-04-14 14:20:16 +00:00
Jörg Mayer 96779de920 cmake changes:
- Add checking for linker flags
- Install plugins with the name including the Wireshark version.
  This will make it easier to find matching plugin versions if
  files get just copied over.


svn path=/trunk/; revision=32231
2010-03-18 10:27:17 +00:00
Jörg Mayer 67072286bf - Remove the lib prefix for plugin names.
- Remove a (resolved) comment.
- Add a commented out line how to add version infos to the
  plugin's file name.

svn path=/trunk/; revision=31995
2010-02-24 22:32:10 +00:00
Bill Meier 1341fcd87e Fix some gcc -Wshadow warnings.
svn path=/trunk/; revision=31722
2010-01-28 21:49:30 +00:00
Jörg Mayer d2cc318f4f Beginnings of enabling static builds. Still to do:
* Add -static
* Registration may need different handling
* Add plugins
* Build error in wslua

svn path=/trunk/; revision=30987
2009-11-17 11:58:36 +00:00
Jörg Mayer 9ee31d1d0e cmake will now honor -Werror if configured (default: on)
svn path=/trunk/; revision=30852
2009-11-07 10:07:00 +00:00
Stig Bjørlykke a52bf035b7 Removed redundant redeclaration of delete_avpl().
svn path=/trunk/; revision=30618
2009-10-19 14:42:10 +00:00
Kovarththanan Rajaratnam 8b8399b711 Use register_dissector_files in the plugins dissectors
svn path=/trunk/; revision=30435
2009-10-09 16:39:34 +00:00
Stig Bjørlykke cf85342eec Build plugins with cmake on OSX.
svn path=/trunk/; revision=30373
2009-10-06 18:58:09 +00:00
Jörg Mayer 6a2f689235 Fix build of make and asn1 plugins.
svn path=/trunk/; revision=30144
2009-09-25 15:17:45 +00:00
Jörg Mayer 95182116aa CMake:
- Add opcua to the list of plugins to build
- Link the gtk stuff statically into wireshark
- Beginnings of "make install"
- Change a few things about install paths

svn path=/trunk/; revision=30029
2009-09-21 00:19:07 +00:00
Jörg Mayer 5a2247f5a3 Build a few more plugins
svn path=/trunk/; revision=29942
2009-09-16 06:30:03 +00:00
Jeff Morriss 4661aad9a4 Run checkapi on the dissector header files
svn path=/trunk/; revision=29883
2009-09-13 19:48:22 +00:00
Kovarththanan Rajaratnam 2547ce21bf We no longer support the old plugin API so remove it completely from the build system
svn path=/trunk/; revision=29821
2009-09-09 14:01:57 +00:00
Bill Meier cc3a2c97a8 Use find_dissector() instead of create_dissector_handle();
Fix some indentation.

svn path=/trunk/; revision=29273
2009-08-03 16:18:06 +00:00
Stig Bjørlykke 221225e0f3 From Kovarththanan Rajaratnam via bug 3719:
This patch optimizes proto_tree_prime_hfid() + friends and
plugs a memleak in the process.

From me:
Removed unused hfindex in proto_tree_new_item()
Fixed ref_count entry in struct header_field_info.

svn path=/trunk/; revision=29137
2009-07-18 20:10:14 +00:00
Guy Harris cf91fdf16b Have tap listeners specify whether the "packet" routine requires
a protocol tree;

	the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

svn path=/trunk/; revision=28645
2009-06-05 22:42:47 +00:00
Gerald Combs 17f0d877fa Fix Win64 compilation problems in the plugins directory.
svn path=/trunk/; revision=28064
2009-04-16 03:38:23 +00:00
Bill Meier a0eee8c299 Replace some unnecessary use of g_snprintf and g_strdup_printf
svn path=/trunk/; revision=27864
2009-03-27 14:46:54 +00:00
Bill Meier 4f34bb9b15 From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
- As suggested actually use sizeof(...) rather than a numeric constant.
  - g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1.

svn path=/trunk/; revision=27772
2009-03-18 15:03:46 +00:00
Gerald Combs be943c8419 Go a little deeper into the Win64 rabbit-hole. Add tools/native-nmake.cmd
and use it as a wrapper to compile a native version of lemon.
Untested on Win32.

svn path=/trunk/; revision=27734
2009-03-15 22:40:29 +00:00
Gerald Combs 07e5df616e Disable manifest building for our DLLs. This attempts to fix bug 3272.
svn path=/trunk/; revision=27579
2009-03-02 18:57:35 +00:00
Ulf Lamping 043532d63e add missing mt.exe calls, to include manifest files into exe / dll files
svn path=/trunk/; revision=27357
2009-02-02 23:09:36 +00:00
Bill Meier 9a3563e807 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27085
2008-12-22 15:24:18 +00:00
Stig Bjørlykke 94e9e2b1ec Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26652
2008-10-31 17:27:51 +00:00