Commit graph

5097 commits

Author SHA1 Message Date
Guy Harris
165a8253b2 Allow "proto_item_append_text()" to an item that doesn't have a
representation string - set the representation string to the default
representation.  This lets you append to an item that's been added with
"proto_tree_add_XXX" calls that don't explicitly format the
representation string.

svn path=/trunk/; revision=4973
2002-03-19 08:42:16 +00:00
Guy Harris
3a3f044570 Put in desegmentation support.
Use "proto_tree_add_item()" to add items to the protocol tree; don't
fetch to a variable if the variable isn't later used (except for the
"unknown" fields).  Put fields into the protocol tree as soon as they're
fetched, so that if an exception is thrown when dissecting a packet, the
fields that didn't cause an exception get put into the protocol tree.

Fix some typos.

svn path=/trunk/; revision=4972
2002-03-19 06:31:16 +00:00
Guy Harris
da785cee2e LDP support for draft-martini-l2circuit-encap-mpls for
Ethernet-over-MPLS, from Aamer Akhter.

svn path=/trunk/; revision=4971
2002-03-18 18:56:53 +00:00
Ronnie Sahlberg
0c7d8b3b30 Quota updates. GetUserQuota implemented and support for list of userquota structures
svn path=/trunk/; revision=4970
2002-03-18 09:45:27 +00:00
Ronnie Sahlberg
fd54563f5b Add dissection of one more bit in Quota FS Flags bitmask
svn path=/trunk/; revision=4969
2002-03-18 08:34:18 +00:00
Guy Harris
0ab2b8b50f Don't show a secondary address if the secondary address length is 0.
svn path=/trunk/; revision=4968
2002-03-18 07:56:06 +00:00
Guy Harris
428f280a40 Skinny Client Control Protocol enhancements, from Paul E. Erkkila.
svn path=/trunk/; revision=4967
2002-03-18 00:45:11 +00:00
Guy Harris
d29d38d864 Cisco LEAP support, from Adam Sulmicki.
svn path=/trunk/; revision=4966
2002-03-18 00:26:27 +00:00
Guy Harris
0b4145f7d7 Add information about 64-bit integral field support.
Fix some items on the tvbuff accessors for integers.

svn path=/trunk/; revision=4965
2002-03-18 00:20:18 +00:00
Ronnie Sahlberg
7f50e21a7e quota update partial NTGetUserQuota support
svn path=/trunk/; revision=4964
2002-03-17 12:16:11 +00:00
Ronnie Sahlberg
7fa1fcaaba Partial dissection of NT Set User Quota data block
svn path=/trunk/; revision=4963
2002-03-17 11:59:36 +00:00
Ronnie Sahlberg
e9bd31fdbd SMB Quota updates
svn path=/trunk/; revision=4962
2002-03-17 11:24:16 +00:00
Ronnie Sahlberg
6ac7d7f7ac Updates for NT QUOTA in packet-smb.c
svn path=/trunk/; revision=4961
2002-03-17 10:59:35 +00:00
Ronnie Sahlberg
6836cadee8 Some minor bugfixes for netlogon
svn path=/trunk/; revision=4960
2002-03-17 07:43:11 +00:00
Guy Harris
13e6565ff4 From Aamer Akhter: LDP support for draft-martini-l2circuit-trans-mpls,
LDP status code updates, and small LDP cleanups.

svn path=/trunk/; revision=4959
2002-03-16 23:15:45 +00:00
Guy Harris
f911953894 Put an item into the protocol tree for the secondary address in a bind
ack PDU.

svn path=/trunk/; revision=4958
2002-03-16 22:54:20 +00:00
Guy Harris
fcf8cd8807 The service is just called "IPC"; the pipe is what's called "IPC$".
svn path=/trunk/; revision=4957
2002-03-16 22:39:45 +00:00
Guy Harris
949b2d4131 Whether the data returned from a read or sent in a write is DCERPC
traffic or not, that data doesn't include the padding; handle padding
if you're dissecting it as DCERPC traffic.

Don't treat the traffic as DCERPC traffic unless it's to the IPC$ share.

svn path=/trunk/; revision=4956
2002-03-16 22:35:51 +00:00
Guy Harris
d5cd7aca15 A double-click in a filter name in the list-of-filters dialog box should
activate the text widget into which the filter text is put only if
clicking "OK" in the list-of-filters dialog box does so.  Make it so.

svn path=/trunk/; revision=4955
2002-03-16 22:02:55 +00:00
Guy Harris
0b60f086ef There is no guarantee that, when processing an SMB response, "si->sip"
is non-null, as there's no guarantee that the corresponding SMB request
is in the capture.  Check whether it's null before using it.

svn path=/trunk/; revision=4954
2002-03-16 22:01:27 +00:00
Guy Harris
481b4bca97 Update the developer documentation to reflect current reality (or a
subset thereof).

svn path=/trunk/; revision=4953
2002-03-16 20:22:14 +00:00
Ronnie Sahlberg
17392c995b A new type of DCERPC over SMB transport.
I have captures with w2k speaking DCERPC without using the normal
Transaction named pipes SMBs.
Instead DCERPC is just implemented ontop of ordinary read/write calls.

The smb dissector now examines TreeConnectAndX and stores the conversation/tid/type-of-share in a table for later access.
All SMB requests examine that hash table to find out if TID in the header refers
to a normal share or an IPC$ share.

Initial support in read/write SMB calls to detect if the operations are for an
 IPC share and thus it assumes it must be DCERPC commands in the payload.
Desegmentation/Reassembly of these types of calls are not implemented yet.

svn path=/trunk/; revision=4952
2002-03-16 04:39:29 +00:00
Guy Harris
54fa1d944a XDMCP support, from Pasi Eronen.
svn path=/trunk/; revision=4951
2002-03-16 02:25:48 +00:00
Guy Harris
54034c6ecc Fix a couple of incorrect calls to "proto_tree_add_boolean()" to call
"proto_tree_add_item()" instead.

svn path=/trunk/; revision=4950
2002-03-16 02:09:28 +00:00
Richard Sharpe
dc6bb2dc67 Pretty up Policy Handles.
svn path=/trunk/; revision=4949
2002-03-15 20:46:04 +00:00
Richard Sharpe
9693b93085 Pretty up the SID dissector ...
svn path=/trunk/; revision=4948
2002-03-15 19:47:03 +00:00
Ronnie Sahlberg
ad861e7827 Moved the value_string for MS country codes from packet-dcerpc-nt.c to
packet-smb.c so that packet-smb-pipe.c can reference this struct as well.

svn path=/trunk/; revision=4947
2002-03-15 08:59:53 +00:00
Tim Potter
d3c236be5e Added error messages for invalid name and invalid form size.
svn path=/trunk/; revision=4946
2002-03-15 04:46:43 +00:00
Guy Harris
dc9448b2b4 From Andrew Feren: put all of Cisco's OUIs into manuf.tmpl.
svn path=/trunk/; revision=4945
2002-03-14 21:24:40 +00:00
Guy Harris
178a866877 From Andrew Feren: minor patch to correct what looks like a cut and
paste error in an error message.  The wrong filename is being displayed
if manuf can't be opened for writing.

svn path=/trunk/; revision=4944
2002-03-14 21:22:11 +00:00
Ronnie Sahlberg
7791aabe52 Added a value_string for the countreis which have their MS contry code listed
at www.unicode.org and made samr and netlogon use it.

svn path=/trunk/; revision=4943
2002-03-14 10:04:02 +00:00
Ronnie Sahlberg
5906cde27a hf_netlogon_code did not have an hf_[] entry.
some cruft removed from LSA_SECURITY_DESCRIPTOR that is not used anymore since
we call the dissector in packet-smb.c

svn path=/trunk/; revision=4942
2002-03-14 09:19:17 +00:00
Guy Harris
e4832c8ca8 Fix a typo.
svn path=/trunk/; revision=4941
2002-03-14 05:46:59 +00:00
Guy Harris
ecda579229 Clean up the display of the top-level item for the NT ACE Flags, so that
there's a space after the colon, and so that there's no extra comma at the
end and only one space between the items.

Fix a typo.

svn path=/trunk/; revision=4940
2002-03-14 05:45:16 +00:00
Guy Harris
435545629a Boost the maximum amount of indentation put into text output.
svn path=/trunk/; revision=4939
2002-03-14 05:41:59 +00:00
Gilbert Ramirez
aacedfa1f2 When defining the struct select_item, don't create an instance of that
struct, alsoc alled select_item, as it's not used.

svn path=/trunk/; revision=4938
2002-03-14 04:32:35 +00:00
Ronnie Sahlberg
5012aa7acd Make LSA_SECURITY_DESCRIPTOR dissector call dissect_nt_sec_desc()
instead of just displaying it as some hex string.

svn path=/trunk/; revision=4937
2002-03-13 11:19:16 +00:00
Ronnie Sahlberg
40edb36c07 Added mockups for LSA_SECRET and LSA_SECURITY_DESCRIPTOR inside
packet-dcerpc-netlocon.c so that SamDelta_reply packets will be dissected properly.

svn path=/trunk/; revision=4936
2002-03-13 10:52:22 +00:00
Ronnie Sahlberg
7224c4f42a Fixed bug in SAMDELTAS_request.
There is still a bug in the dissection of SAMDELTA_reply but this is due to
LSA_SECRET not being implemented yet which is embedded in one of the
netlogon structures.

svn path=/trunk/; revision=4935
2002-03-13 09:03:28 +00:00
Ronnie Sahlberg
5a801aacfa Update dissect_ndr_nt_STRING so it can also accept FT_BYTES and for that type
display the data as a hexadecimal string.

Update netlogon so that nt and lm challenge response bytes are displayed
in hexadecimal form and not pseudo-ascii

svn path=/trunk/; revision=4934
2002-03-13 07:38:34 +00:00
Guy Harris
7e6d288db3 Give the "prevent/allow medium removal" command the right name (it's
"prevent/allow", not "prevent allow").

svn path=/trunk/; revision=4933
2002-03-13 02:52:21 +00:00
Guy Harris
a5e2062503 From Dinesh Dutt: initial dissection of a variable-length CDB.
svn path=/trunk/; revision=4932
2002-03-12 11:30:45 +00:00
Guy Harris
b882e373f0 Get rid of unnecessary includes.
svn path=/trunk/; revision=4931
2002-03-12 10:40:01 +00:00
Guy Harris
6327b456db Get rid of the "--enable-snmp" option; instead, use "--with-ucdsnmp".
Make the directory option to "--with-ucdsnmp" optional.  Handle
"--with-ucdsnmp" similar to the way "--with-pcap" is handled.

Get rid of unnecessary #defines in "packet-cops.c".

Get rid of no-longer-necessary include of "dlfcn.h" in "packet-snmp.c".

svn path=/trunk/; revision=4930
2002-03-12 10:37:04 +00:00
Ronnie Sahlberg
385c80e202 Small fix for dissect_ndr_nt_UNICODE_STRING_str() in packet-dcerpc-nt.c
so that NETLOGON will not dump core (since netlogon has these structs as top
level reference pointers)

Addition of full netlogon dissection. Full in the sense as it assumes the idl
is correct and complete.
Many calls and fields are unknown so they get dissected with "unknown long,
 contact ethereal-dev@... if you know what it is".

svn path=/trunk/; revision=4929
2002-03-12 08:16:41 +00:00
Guy Harris
c41a4fe415 From Adam Sulmicki: use "proto_tree_add_uint()" rather than
"proto_tree_add_boolean()" for the "hf_eapol_keydes_key_index_indexnum"
field, as it's an FT_UINT8, not an FT_BOOLEAN.

svn path=/trunk/; revision=4928
2002-03-11 08:47:46 +00:00
Guy Harris
dec4861d32 In the message at the end that indicates how Ethereal was configured,
refer to "UCD SNMP" rather than just "SNMP".

svn path=/trunk/; revision=4927
2002-03-11 07:02:47 +00:00
Guy Harris
709080b358 Update various README and INSTALL files to reflect the requirement for
UCD SNMP 4.2.2 or later if you want MIB-reading support.

svn path=/trunk/; revision=4926
2002-03-11 02:12:41 +00:00
Guy Harris
bb172432d1 "format_var()" returns a "malloc()"ed string, not a "g_malloc()"ed
string; free it with "free()", not "g_free()".

svn path=/trunk/; revision=4925
2002-03-11 01:51:37 +00:00
Guy Harris
7e8c5a1741 If we're linking with the UCD SNMP library, make "format_oid()" append a
display of the symbolic form of the OID.  Remove code that used to do
that outside of "format_oid()".

Export "format_oid()" from "packet-snmp.c" and use it in
"packet-cops.c".

Remove support for CMU SNMP and older versions of UCD SNMP from
"packet-cops.c", as it has been removed from the rest of Ethereal.

svn path=/trunk/; revision=4924
2002-03-11 01:48:08 +00:00