Commit graph

5097 commits

Author SHA1 Message Date
Guy Harris
807bf4ead2 The Unicode Consortium's table has some errors in it; fix those errors
in our table.

svn path=/trunk/; revision=5023
2002-03-26 08:23:58 +00:00
Guy Harris
4d842c13de Make the UCD SNMP library read its configuration files, so that, for
example, you can configure it to read in MIB files other than the
default ones.

svn path=/trunk/; revision=5022
2002-03-26 06:35:03 +00:00
Guy Harris
2abe1ac0a6 From Andrew Feren:
Man pages don't have any notion of external links and there
	isn't enough information for pod2html to resolve the links for
	manpages in the "See Also" section of the man pages.  As a
	result running pod2html generates a bunch of warning messages
	and just emphasizes/italicizes the text.

	Therefore, we change the link (L<name>) command to an emphasizes
	(I<name>) command.  The net result is the same, but you don't get
	the warnings when generating HTML docs.

	At some point in the future someone might want to do the work to
	get the links to generate correctly, but until then this will
	shut up pod2html.

svn path=/trunk/; revision=5021
2002-03-26 06:15:08 +00:00
Tim Potter
b958e865ca Use dcerpc_call_value structure to fetch request/response frame numbers
and storage of private data.

Fix memory leaks in form dissectors.

svn path=/trunk/; revision=5020
2002-03-26 05:20:51 +00:00
Tim Potter
78fd37d27c Added dissectors for get/set/delete form.
Fixed enumforms dissector.

svn path=/trunk/; revision=5019
2002-03-26 04:29:17 +00:00
Guy Harris
952a4960f1 From Marc Milgram: properly handle fragmented packets.
svn path=/trunk/; revision=5018
2002-03-25 21:15:54 +00:00
Guy Harris
6dcb948ca2 From Andreas Sikkema: put the H.225 stuff at the top level of the
protocol tree.

svn path=/trunk/; revision=5017
2002-03-25 20:23:17 +00:00
Guy Harris
5a046966d8 From Andreas Sikkema: keep TPKT information out of the Info column in
cases where the subdissector would append information to that column.

svn path=/trunk/; revision=5016
2002-03-25 20:17:09 +00:00
Guy Harris
f4bbdc9bc3 The Cygwin "winnls.h" header, and the Microsoft "winnls.h" headers, says
that a country code of 0 is for the "default", presumably meaning "don't
override the setting on the desktop machine" or something such as that.

svn path=/trunk/; revision=5015
2002-03-25 20:01:13 +00:00
Tim Potter
c9360c715f Some refactoring of the spoolss dissector:
- rewrote request/response hashing code and moved it into
   packet-dcerpc-nt.c for use by other dcerpc/smb dissectors

 - rewrote policy handle hashing code as above, with nifty improvements

 - moved check for unparsed data and end of frame into a function

 - fixed matching of printername to handle in addprinterex

svn path=/trunk/; revision=5014
2002-03-25 05:42:02 +00:00
Tim Potter
a2364e52b8 #include <string.h> to quieten compiler warning.
svn path=/trunk/; revision=5013
2002-03-25 04:02:37 +00:00
Tim Potter
eaa3bc3095 Added a generic reply handler for unimplemented spoolss dissectors. This
just parses the error code at the end of the packet and updates COL_INFO
if necessary.

svn path=/trunk/; revision=5012
2002-03-25 01:09:01 +00:00
Guy Harris
02115cdb39 Fix "dissect_ndr_nt_UNICODE_STRING_str()" so that the "di->levels" value
is decremented after every level is appended to, so that it correctly
specifies the number of levels up the tree to which to append stuff.

Fix some arguments to various printing routines to specify the correct
level.  This includes making "dissect_ndr_nt_UNICODE_STRING()" add 1 to
the level argument it's passed before passing it on to
"dissect_ndr_pointer()".

Add a "netlogon_dissect_UNICODE_STRING()" routine to put the fields of a
bunch of NDR_POINTER_REF UNICODE_STRING values into subtrees.

Fix the labels passed as arguments in a bunch of "dissect_ndr_pointer()"
calls.

svn path=/trunk/; revision=5011
2002-03-24 12:25:40 +00:00
Guy Harris
c9396446fb From Heikki Vatiainen: fix the test for IS-IS virtual links.
svn path=/trunk/; revision=5010
2002-03-23 22:03:41 +00:00
Guy Harris
2128583c24 CGMP-over-Ethernet II support, from Heikki Vatiainen.
svn path=/trunk/; revision=5009
2002-03-23 22:02:20 +00:00
Guy Harris
3c36b98cca From Adam Sulmicki: state machine changes to update the state better,
and changes to the display items for LEAP challenges and responses.

Make the LEAP state per-conversation.

Get rid of some unneeded includes.

svn path=/trunk/; revision=5008
2002-03-23 21:24:38 +00:00
Guy Harris
4e576dc1f2 Default to *not* using the UCD SNMP library, as the current versions
have buffer-overflow vulnerabilities that we can't avoid.  You have to
ask for it explicitly if you want it.

svn path=/trunk/; revision=5007
2002-03-23 01:01:26 +00:00
Guy Harris
2ee730c79e Update from Diana Eichert to remove the comments with her login name.
svn path=/trunk/; revision=5006
2002-03-23 00:20:17 +00:00
Guy Harris
5a01067dff From Diana Eichert: add a "-q" flag to Tethereal to suppress packet
count display.

Update the Tethereal man page to reflect the new option.

Update both the Ethereal and Tethereal man pages to use the same style
to describe options, e.g.

	-Z	Cause Ethereal to draw the mark of Zorro on the display.

rather than

	-Z	Causes Ethereal to draw the mark of Zorro on the display.

(some were using the first and some were using the second).

Update the Ethereal man page to do the same for menu items.

Update both the Ethereal and Tethereal man pages to better describe the
"-N" flag (by noting that any form of name resolution *not* specified in
the flag is turned *off*).

svn path=/trunk/; revision=5005
2002-03-22 23:42:27 +00:00
Guy Harris
fb18dbe6f5 Attach to all frames containing LEAP messages an indication of the state
of the LEAP negotiation, so we can properly dissect the LEAP message
after the first pass through the packets.

For that to be computed correctly, EAP frames have to be dissected on
the first pass through the capture file, even if the protocol tree isn't
being generated; that means that RADIUS AVPs need to be dissected even
if the protocol tree isn't being generated.

svn path=/trunk/; revision=5004
2002-03-22 11:41:59 +00:00
Guy Harris
f970451d95 Add a cleanup function to close a potential memory leak.
Get rid of an assigned-to-but-not-used variable.

From Steven French: add names for some additional calls.

svn path=/trunk/; revision=5003
2002-03-22 10:03:36 +00:00
Guy Harris
29607a5107 For DCE RPC requests and replies, put an item into the protocol tree for
the sub-protocol containing the actual operation number (which isn't
necessarily the operation number in a connectionless reply's PDU;
sometimes the operation number in a connectionless reply appears to be
garbage, and it's not what we use to dissect the reply in any case), and
also giving the name of the operation, if we know it.

Show the authentication data in connectionless PDUs, if present, as an
item in the protocol tree.

svn path=/trunk/; revision=5002
2002-03-22 09:44:58 +00:00
Guy Harris
61130a5f65 Additional vendor (Issani) for Radius, and Issani VSA support for
Radius, from Jim Sienicki.

Put Jakob Schlyter into the contributors list in the Ethereal man page.

svn path=/trunk/; revision=5001
2002-03-22 02:38:54 +00:00
Guy Harris
db1428be21 Improve the media payload type names some more, and add some new ones I
found in a Cisco document.

svn path=/trunk/; revision=5000
2002-03-21 11:18:44 +00:00
Guy Harris
3f4fdd2af4 Use somewhat nicer names for the media payload types.
svn path=/trunk/; revision=4999
2002-03-21 11:08:39 +00:00
Guy Harris
030cea2057 From Todd Sabin: set the tvbuff length of the stub data for
connectionless calls to the fragment length.

Add value_string tables for authentication protocol and level values.

Show the authentication protocol in decimal in connectionless PDUs, just
as we do in connection-oriented PDUs.

Get the authentication level from connection-oriented request and reply
PDUs and, if it's DCE_C_AUTHN_LEVEL_PKT_PRIVACY, don't hand the stub
data to subdissectors, just show it as encrypted stub data.

svn path=/trunk/; revision=4998
2002-03-21 09:35:52 +00:00
Gerald Combs
c3881d8a9d From Jakob Schlyter, add the "MESSAGE" method.
Add the "QAUTH" and "DO" methods as well.

svn path=/trunk/; revision=4997
2002-03-21 03:08:46 +00:00
Guy Harris
0410cab974 Updates from Paul Erkkila.
svn path=/trunk/; revision=4996
2002-03-20 23:32:54 +00:00
Guy Harris
8cf3c7bd6b Update to draft 11, from Mark Burton.
svn path=/trunk/; revision=4995
2002-03-20 21:28:14 +00:00
Guy Harris
5c7464c673 Updates from Paul E. Erkkila.
svn path=/trunk/; revision=4994
2002-03-20 21:01:21 +00:00
Gilbert Ramirez
fbc43449fb Produce ethereal-setup-$VERSION.exe instead of ethereal-setup.exe.
From Andrew C. Feren <aferen@cetacean.com>

svn path=/trunk/; revision=4993
2002-03-20 19:45:51 +00:00
Guy Harris
b38e3f4e99 The length argument to "fake_unicode()" is in characters, not bytes.
svn path=/trunk/; revision=4992
2002-03-20 09:09:07 +00:00
Guy Harris
b25cfdba75 When dissecting an SID with more than 4 authorities, increment the
offset to go past the last authority (the RID).

svn path=/trunk/; revision=4991
2002-03-20 07:55:51 +00:00
Guy Harris
3c012e8e6e In "fake_unicode()", check to make sure we have all the data in the
string available in the tvbuff before we allocate the buffer; this means
that

	1) we don't have to register a cleanup function to free the
	   buffer if we throw an exception trying to fetch some of the
	   data, because we won't even try to allocate the buffer if we
	   don't have all the data

and

	2) we won't try to allocate a buffer with a bogus too-large
	   length, as if the length is too large, we'll throw an
	   exception in the check.

svn path=/trunk/; revision=4990
2002-03-20 07:39:18 +00:00
Guy Harris
4d52bb3267 Handle Read operations on IPC trees as DCE RPC.
svn path=/trunk/; revision=4989
2002-03-20 06:51:14 +00:00
Richard Sharpe
e2f5d92cb8 Express the RID separately of more than 4 sub-authorities. It is always the
last sub-authority.

svn path=/trunk/; revision=4988
2002-03-19 23:14:39 +00:00
Guy Harris
031c4ec27f Treat WriteAndX operations on IPC trees as containing DCERPC call
information, just as is done for Write.

Squelch a compiler warning.

svn path=/trunk/; revision=4987
2002-03-19 22:12:03 +00:00
Guy Harris
ad8b000445 There is no guarantee that a buffer obtained using "tvb_get_ptr()" is
neatly aligned on a 2-byte or a 4-byte boundary, and there is no
guarantee that a misaligned pointer can be dereferenced without getting
a fault.

Furthermore, there is no guarantee that, even if you *can* dereference a
pointer to a 2-byte or 4-byte quantity in a packet, the resulting number
you get back is in the right byte order; the data in the packet might
have a different byte order from the machine on which you're running.

Therefore, we change "prs_uint8s()", "prs_uint16s()", and
"prs_uint32s()" to return the starting offset, in the tvbuff, of the
collection of 8-bit, 16-bit, or 32-bit integral values, rather than a
pointer to the raw packet data, and change their callers to fetch the
data using "tvb_get_guint8()", "tvb_get_letohs()", and
"tvb_get_letohl()" (the stuff in all the NT protocols is presumed to be
little-endian here).  We also change "fake_unicode()" to take a tvbuff
and an offset, rather than a data pointer, as arguments, and to use
"tvb_get_letohs()" to fetch the Unicode characters (again, we assume
little-endian Unicode).

This requires "fake_unicode()" to establish a cleanup handler, so we
don't leak memory if it throws an exception.

We also make "fake_unicode()" use "g_malloc()" to allocate its buffer
(we weren't checking for allocation failures in any case; with
"g_malloc()", we'll abort on an allocation failure - if we can come up
with a cleverer way of handling them, fine), and the matching frees to
use "g_free()".  (We also insert some missing frees....)

Fix some formats to print unsigned quantities with "%u", not "%d".

Don't append text to items in the tree for non-string values in
"dissect_ndr_nt_STRING_string()".

svn path=/trunk/; revision=4986
2002-03-19 22:09:23 +00:00
Guy Harris
3795d7d240 From Adam Sulmicki: add support for NOTIFY and NAK EAP types, fix the
entry for the ID EAP type, and do some miscellaneous cleanups.

svn path=/trunk/; revision=4985
2002-03-19 20:55:40 +00:00
Guy Harris
44e195e9b7 The data for EAP_TYPE_ID is just a string; display it with
"tvb_format_text()", as per Adam Sulmicki's suggestion.

svn path=/trunk/; revision=4984
2002-03-19 12:02:03 +00:00
Guy Harris
adfba076ee From Adam Sulmicki: add all known EAP types.
Use "tvb_bytes_to_str()", not "tvb_format_text()", for binary data such
as challenges and responses.

svn path=/trunk/; revision=4983
2002-03-19 11:33:08 +00:00
Guy Harris
58387eb63b Updates from Paul E. Erkkila.
svn path=/trunk/; revision=4982
2002-03-19 11:26:23 +00:00
Guy Harris
09acc1c074 Secondary addresses are NUL-terminated strings; treat them as such.
svn path=/trunk/; revision=4981
2002-03-19 11:10:40 +00:00
Ronnie Sahlberg
84806766db Tiny quota updates
svn path=/trunk/; revision=4980
2002-03-19 10:16:40 +00:00
Guy Harris
43ad415d55 Fix some comments.
svn path=/trunk/; revision=4979
2002-03-19 09:18:42 +00:00
Guy Harris
dec54cc52a Set the length for topology change BPDUs to 4, and leave the length of
unknown BPDU types alone.

Use the tvbuff's length in as the length of the top-level protocol tree
item.

svn path=/trunk/; revision=4978
2002-03-19 09:17:54 +00:00
Guy Harris
5c42850e62 Use "set_actual_length()" to set the reported length of the packet's
tvbuff, so we don't increase it past what was in the packet.

For packets with unknown BPDU types, put the value of the type into the
Info column.

svn path=/trunk/; revision=4977
2002-03-19 09:02:01 +00:00
Guy Harris
b793e3c67d Give all the items in the packet filterable fields, including the
bitfields in the flags field.

Put a summary of the flags in the protocol tree item for the flags
field.

Give the Protocol Identifier and BPDU Type fields value_string tables.
Don't bother with "proto_tree_add_uint_format()" for fields with
value_string tables - use the default format.

Put the "Version 1 Length" field into Rapid Spanning Tree packets.

Don't fetch items until you put them into the protocol tree.

Make the length of the top-level item be the correct length of the
packet, including the "Version 1 Length" field in RST packets.  (XXX -
should it be really short for Topology Change Notification packets?)

For packets with unknown BPDU types, put the value of the type into the
Info column.

svn path=/trunk/; revision=4976
2002-03-19 09:00:44 +00:00
Guy Harris
99c86dd9b1 The protocol ID is an 8-bit field in the DEC spanning tree protocol.
svn path=/trunk/; revision=4975
2002-03-19 08:47:11 +00:00
Guy Harris
af914f5a74 Give all the items in the packet filterable fields, including the
bitfields in the flags field.

Put a summary of the flags in the protocol tree item for the flags
field.

svn path=/trunk/; revision=4974
2002-03-19 08:44:41 +00:00