osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
40547 commits 26 branches 0 tags 795 MiB
Commit graph

165 commits

Author SHA1 Message Date
Bill Meier
c055ca8c7e General minor cleanup including: 
- remove unneeded #includes;
- use val_to_str_const() as appropriate;
- reformat hf[] entries;
- reformat long lines;
- use #if 0/#endif to coment out code instead of /* ... */;
- remove boilerplate comments;
- whitespace & indentation


svn path=/trunk/; revision=42487
 2012-05-07 22:11:34 +00:00
Ronnie Sahlberg
76c79af01b SCSI SBC: Add decode of BlockLimits VPD page 
svn path=/trunk/; revision=42153
 2012-04-20 07:34:53 +00:00
Jakub Zawadzki
23494db817 Add missing const attribute to some char * 
Fix some "assignment discards qualifiers from pointer target type", etc

svn path=/trunk/; revision=41996
 2012-04-09 18:44:10 +00:00
Ronnie Sahlberg
ce6237d4a0 SCSI SBC: Start decoding LogicalBlockProvisioning VPD page 
svn path=/trunk/; revision=41867
 2012-03-31 04:45:33 +00:00
Bill Meier
2103e7f38a tvb_[reported_]length_remaining can return -1 
svn path=/trunk/; revision=39870
 2011-11-15 21:22:01 +00:00
Bill Meier
54b72021bb Fix encoding arg for various fcn calls: 
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
 2011-10-24 19:57:53 +00:00
Bill Meier
6d96a16932 Fix a few proto_tree_add_item() encoding args manually. 
Some whitespace cleanup.

svn path=/trunk/; revision=39507
 2011-10-21 14:33:43 +00:00
Bill Meier
293049dfba Do some conversions of proto_tree_add_item() 'encoding' arg. 
(previously missed).

    57   FT_BOOLEAN:       FALSE-->ENC_BIG_ENDIAN
    31   FT_BOOLEAN:       TRUE-->ENC_LITTLE_ENDIAN

    10   FT_BYTES:         ENC_BIG_ENDIAN-->ENC_NA
     1   FT_BYTES:         ENC_LITTLE_ENDIAN-->ENC_NA
    21   FT_BYTES:         FALSE-->ENC_NA
     2   FT_BYTES:         TRUE-->ENC_NA

     2   FT_IPXNET:        ENC_BIG_ENDIAN-->ENC_NA

     6   FT_IPv6:          ENC_BIG_ENDIAN-->ENC_NA
     1   FT_IPv6:          FALSE-->ENC_NA

     6   FT_NONE:          ENC_BIG_ENDIAN-->ENC_NA
    19   FT_NONE:          FALSE-->ENC_NA
     3   FT_NONE:          TRUE-->ENC_NA

     1   FT_STRING:        ENC_BIG_ENDIAN-->ENC_ASCII|ENC_NA
     1   FT_STRING:        ENC_LITTLE_ENDIAN-->ENC_ASCII|ENC_NA
     5   FT_STRING:        FALSE-->ENC_ASCII|ENC_NA
     1   FT_STRING:        TRUE-->ENC_ASCII|ENC_NA

     4   FT_STRINGZ:       ENC_NA-->ENC_ASCII|ENC_NA
     8   FT_STRINGZ:       FALSE-->ENC_ASCII|ENC_NA

     1   FT_INT32:         FALSE-->ENC_BIG_ENDIAN
     1   FT_INT32:         TRUE-->ENC_LITTLE_ENDIAN

    11   FT_UINT8:         0-->ENC_BIG_ENDIAN
   111   FT_UINT8:         FALSE-->ENC_BIG_ENDIAN
    17   FT_UINT8:         TRUE-->ENC_LITTLE_ENDIAN
     1   FT_UINT16:        0-->ENC_BIG_ENDIAN
    68   FT_UINT16:        FALSE-->ENC_BIG_ENDIAN
    18   FT_UINT16:        TRUE-->ENC_LITTLE_ENDIAN
     4   FT_UINT24:        FALSE-->ENC_BIG_ENDIAN
    70   FT_UINT32:        FALSE-->ENC_BIG_ENDIAN
     1   FT_UINT32:        TRUE-->ENC_LITTLE_ENDIAN
     4   FT_UINT64:        FALSE-->ENC_BIG_ENDIAN
     1   FT_UINT64:        TRUE-->ENC_LITTLE_ENDIAN

     1   FT_UINT_STRING:   FALSE-->ENC_ASCII|ENC_BIG_ENDIAN


svn path=/trunk/; revision=39442
 2011-10-16 23:38:49 +00:00
Bill Meier
126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
 2011-10-15 18:46:26 +00:00
Bill Meier
67ee5049d4 Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39328
 2011-10-10 00:39:31 +00:00
Bill Meier
4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
 2011-10-06 03:35:44 +00:00
Bill Meier
799578fb29 Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item with types in hf[] of: 
FT_NONE
    FT_BYTES
    FT_IPV6
    FT_IPXNET
    FT_OID

svn path=/trunk/; revision=39261
 2011-10-05 00:25:09 +00:00
Bill Meier
5db6069274 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings. 
svn path=/trunk/; revision=38085
 2011-07-18 15:52:16 +00:00
Stig Bjørlykke
1c45c1a243 From Michael Mann via bug 2794: 
Fixed display filters with obvious typos.

svn path=/trunk/; revision=36713
 2011-04-19 08:22:58 +00:00
Stig Bjørlykke
27344a90fe Removed some unneeded assignments. 
Found by clang.

svn path=/trunk/; revision=36698
 2011-04-18 15:29:25 +00:00
Ronnie Sahlberg
89d3156883 Shift the correct number of steps when masking the UAAERP bit to 0/1 
coverity 348

svn path=/trunk/; revision=36274
 2011-03-23 04:55:22 +00:00
Stig Bjørlykke
84bc28bd6a Introduce "Fragment count" filter element for all protocols doing reassembly. 
svn path=/trunk/; revision=35705
 2011-01-30 21:01:07 +00:00
Jeff Morriss
8d32d2066a There's no need to pass the result of tvb_get_ptr() as the 'value' in 
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or
tvb_get_const_stringz().

Use tvb_memeql() & tvb_memcmp().

svn path=/trunk/; revision=35558
 2011-01-16 20:51:21 +00:00
Chris Maynard
44955378b5 From Richard Sharpe via bug 5466: "Changes to dissect persistentreserveout 
parameters", with some whitespace changes by me.

svn path=/trunk/; revision=35173
 2010-12-10 15:49:33 +00:00
Chris Maynard
c0565d8936 Improve dissection of bit-oriented fields. Patch from Richard Sharpe via 
bug #5466 with some minor whitespace modifications from me and a fix of an
invalid offset introduced with the patch.  Fuzz testing still needs to be done.
I can't seem to get the fuzz tester to work with the capture files attached to
the bug report. 

svn path=/trunk/; revision=35137
 2010-12-06 22:00:08 +00:00
Jeff Morriss
a098de3e0a From Zachary Mark via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5457 : 
The scsi_persresv_type_val field in packet-scsi.c contains a mapping of
persistent reservation opcodes to their descriptive types.  The opcode for the
Exclusive Access - Registrants Only field is incorrectly set to 7, when the
correct opcode is 6 (as per SPC-2 onward).  The attached patch corrects this
discrepancy.

The attached patch also adds support for dissecting opcodes 7 and 8, the two
all registrants reservation types present in SPC-3 onward.

svn path=/trunk/; revision=35099
 2010-12-01 23:30:06 +00:00
Bill Meier
9675740701 Use value_string_ext fcns to access certain value_string arrays; 
Sort several value_string arrays to be in ascending order.
Also: Minor whitespace cleanup.

svn path=/trunk/; revision=34766
 2010-11-03 22:08:49 +00:00
Bill Meier
4a43e13976 Use value_string_ext to access several "relatively large" value-strings. 
svn path=/trunk/; revision=34689
 2010-10-29 17:48:39 +00:00
Anders Broman
f1bdb63766 From Yaniv Kaul: 
[PATCH] Add specific names to 'Flags' in packet-scsi.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5259

svn path=/trunk/; revision=34258
 2010-09-27 06:05:24 +00:00
Bill Meier
055dd62063 #include <string.h> not needed. 
svn path=/trunk/; revision=32410
 2010-04-06 21:14:01 +00:00
Stig Bjørlykke
47e732e29e Changed "reassembled_length" -> "reassembled.length". 
svn path=/trunk/; revision=31776
 2010-02-03 08:47:15 +00:00
Stig Bjørlykke
88b72356ad Introduce "Reassembled length" filter element for all protocols doing 
reassembly.

svn path=/trunk/; revision=31767
 2010-02-02 16:01:52 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548: 
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
 2009-06-18 21:30:42 +00:00
Bill Meier
10bb70f09d FT_BOOLEAN fields with bitmask: Display is 'parent bitfield width' not BASE... 
svn path=/trunk/; revision=28316
 2009-05-08 20:15:35 +00:00
Jaap Keuter
a5e56107f2 From Reinhard Speyerer: 
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28224
 2009-05-01 07:19:31 +00:00
Bill Meier
c0e92cbc04 Fix various typos and spelling errors (mostly in text strings) 
svn path=/trunk/; revision=27065
 2008-12-20 00:09:02 +00:00
Bill Meier
33c99f44fd Fix typos and spelling (mostly in text strings) 
svn path=/trunk/; revision=27028
 2008-12-17 00:08:38 +00:00
Bill Meier
c3ea1560bd Minor cleanup related to proto_register and proto_reg_handoff 
svn path=/trunk/; revision=26281
 2008-09-26 22:07:45 +00:00
Bill Meier
b3aa52f573 Fix some of the Errors/warnings detected by checkapi. 
svn path=/trunk/; revision=25307
 2008-05-15 12:54:27 +00:00
Jeff Morriss
bb323055b2 match_strval() may return NULL so don't blindly pass its return value into col_add_*() or proto_add_*(); use val_to_str() (returning "Unknown (%d)" if no match is found) instead. 
svn path=/trunk/; revision=24557
 2008-03-04 21:05:21 +00:00
Stig Bjørlykke
f95de28c72 Updated scsi_verdesc_val from appendix D in spc-3. 
Dump Inquiry Vendor Specific and Reserved fields as bytes.
(still missing dumping of Clocking/QAS/IUS bits)

svn path=/trunk/; revision=23060
 2007-10-03 16:22:50 +00:00
Stig Bjørlykke
05043ca65d Use correct offset for sccs, bque and reladdr flags. 
svn path=/trunk/; revision=23059
 2007-10-03 15:00:58 +00:00
Guy Harris
5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib 
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
 2007-05-29 18:52:42 +00:00
Sebastien Tandel
a7615a1afb another attempt to let windows buildbot becoming green 
fix rev21398 (gcc warning fix)

svn path=/trunk/; revision=21412
 2007-04-13 17:16:24 +00:00
Sebastien Tandel
42791e157b use of volatile for every functions and not only the ones using the Exception 
mechanisms. (fix rev21398)

Windows buildbot sould be green again as formal parameters are the same as the
ones in the declaration now.

svn path=/trunk/; revision=21409
 2007-04-13 15:23:47 +00:00
Stephen Fisher
f002ac6db5 Fix various warnings 
Move packet-cops.c out of clean dissectors due to a #define conflict
in the headers of net-snmp with our config.h


svn path=/trunk/; revision=21398
 2007-04-13 00:50:23 +00:00
Jeff Morriss
4d21c49929 Get rid of some more g_assert*()'s in the dissectors. There are a few 
remaining that I'm not sure exactly what to do with at the moment:
the one in packet-frame probably should be there, the others probably
shouldn't but they also should never fail unless there's a compile or build
problem (AFAICS).


svn path=/trunk/; revision=21367
 2007-04-10 14:48:06 +00:00
Ulf Lamping
f1a58d41d4 from Peter Johansson: 
compilation warnings fixed

svn path=/trunk/; revision=21230
 2007-03-27 21:20:19 +00:00
Stephen Fisher
d565967b58 From Peter Johansson: 
Fix warnings


svn path=/trunk/; revision=21214
 2007-03-26 21:16:21 +00:00
Ulf Lamping
411249419d fix some more warnings (type casts) 
svn path=/trunk/; revision=21141
 2007-03-23 00:51:21 +00:00
Ronnie Sahlberg
f6f95ea6a0 remove the revision number from the spc symbols 
change all spc2 and spc3 to spc



svn path=/trunk/; revision=20779
 2007-02-11 00:45:15 +00:00
Ronnie Sahlberg
9535fb5e42 dont encode a specific revision of the standard in the symbol names 
change all symbols from smc2 to smc

svn path=/trunk/; revision=20778
 2007-02-11 00:20:37 +00:00
Ronnie Sahlberg
a99fb4ebb7 add the remaining TAPE ALERT log flags from ssc3r01c 
svn path=/trunk/; revision=20719
 2007-02-05 11:31:21 +00:00
Ronnie Sahlberg
059f550b16 add some infrastructure to enable us to dissect the content of LOG SENSE pages and parameters 
dissect the READ WARNING flag in the TAPE-ALERT log page as an example


svn path=/trunk/; revision=20718
 2007-02-05 09:39:36 +00:00
Ronnie Sahlberg
c1ccab43aa update the LOG SELECT dissector slightly and harmonize the hf fields so both LOG SELECT and LOG SENSE use the same variables 
svn path=/trunk/; revision=20703
 2007-02-03 22:03:39 +00:00