Commit graph

153 commits

Author SHA1 Message Date
Anders Broman
0e68cac192 From Jacob Nordgren and Rishie Sharma:
RLC: changed so reassembly fail flag is set per channel instead of globally.
RLC: added reset channel function
Added support for reconfigurin HSDSCH flows, and E-DCH flows (just needs to figure out when it should become active for 'overloaded' ports), also changed slightly how ehs headers are configured in nbap.
Removed extra (debugging)  port in nbap

This is the last patch set for a while.

svn path=/trunk/; revision=44423
2012-08-10 15:22:50 +00:00
Martin Mathieson
5f1b2bd6ed If not configured to call MAC for MAC-is PDUs, don't (avoiding
assertion).  Do show extent of MAC-is PDU.

Didn't it used to show the MAC-is SDUs inside too?

svn path=/trunk/; revision=44411
2012-08-10 00:34:39 +00:00
Anders Broman
efa02ebb7a From Jacob Nordgren and Rishie Sharma:
FP: fixed so hsdsch type 1 also uses communication context id 

Added experimental conditional decryption support.

svn path=/trunk/; revision=44384
2012-08-09 16:42:31 +00:00
Anders Broman
508e1c3027 From Jacob Nordgren and Rishie Sharma:
FP: fixed exotic bug where fakes counter was sometimes not reset, RRC: fixed bug where num_chans_per_flow was not properly cleared

svn path=/trunk/; revision=44375
2012-08-09 10:06:01 +00:00
Jeff Morriss
adcb1775f6 Remove set-but-not-used variable.
svn path=/trunk/; revision=44365
2012-08-08 23:02:49 +00:00
Anders Broman
a1218c94c9 From Jacob Nordgren and Rishie Sharma:
- FP: added header CRC validation, added crc11.c and crc11.h in wsutil/ for EDCH 11 bit CRC, fixed bug in RRC,
And also smaller bugfixes in umts_fp and rrc.

svn path=/trunk/; revision=44349
2012-08-08 17:24:14 +00:00
Jeff Morriss
fe7e9760fa Remove a set-but-not-used variable.
svn path=/trunk/; revision=44297
2012-08-07 13:18:01 +00:00
Anders Broman
7623b9bae7 From Rishie Sharma:
compile error fix

svn path=/trunk/; revision=44296
2012-08-07 11:49:06 +00:00
Anders Broman
1c20e4da84 error: variable ‘hsdsch_physical_layer_category’ set but not used
svn path=/trunk/; revision=44295
2012-08-07 10:54:24 +00:00
Anders Broman
b2caee1d75 From Jacob Nordgren and Rishie Sharma:
- umts_fp: fixed so CS content is not malformed content
- RLC: added channel tree so you can filter on rbid etc
- umts_fp,rlc,mac: added some hdsch-common code

svn path=/trunk/; revision=44292
2012-08-07 09:44:16 +00:00
Anders Broman
704e2f524e From Jacob Nordgren and Rishie Sharma:
NBAP: fixed segfault, FP: aesthetic fix, RLC: added channel info to GUI, MAC-is: fixed case with reassembly when a middle segment arrives 

 MAC, RLC, added preferences for LI-size and TSN-size

svn path=/trunk/; revision=44205
2012-08-02 14:03:17 +00:00
Anders Broman
ee071c887a From Jacob Nordgren and Rishie Sharma:
-MAC-is update

svn path=/trunk/; revision=44129
2012-07-30 08:37:00 +00:00
Pascal Quantin
1f6b7eb9c4 Fix dead assignment Clang warning and use consistent indentation
The two remaining Clang warnings (function call argument is an uninitialized value, result of operation is garbage or undefined) seem to be false positives

svn path=/trunk/; revision=44079
2012-07-27 21:09:11 +00:00
Anders Broman
ad7c4a4bba From Jacob Nordgren and Rishie Sharma:
- Added basic support for tracking flows over reconfigured transport channels + mindor bugfixes 

- small fix in rrc, and some small cleanups

svn path=/trunk/; revision=44062
2012-07-27 08:10:31 +00:00
Anders Broman
180f7aa1e0 From Jacob Nordgren and Rishie Sharma:
-  FP and RLC fixed spelling 
- Fixed variable declaration in RRC 
- removed extra ppi in nbap

svn path=/trunk/; revision=44035
2012-07-26 09:42:07 +00:00
Anders Broman
aed65b0c7b From Jacob Nordgren and Rishie Sharma:
- RRC now configures logical channels in HS-DSCH hs, and some HSDSCH common support added 
- RLC: modifed memory management, MAC: dch would set the incorrect logical channel for RLC

svn path=/trunk/; revision=44027
2012-07-26 08:15:20 +00:00
Anders Broman
e5d974ec6a From Jacob Nordgren and Rishie Sharma:
- FP: added payload CRC validation, RLC: some more error reporting 
- RLC: fixed an exotic LI bug, some cosmetic fixes.

svn path=/trunk/; revision=43983
2012-07-25 09:09:32 +00:00
Anders Broman
3743a01714 From Jacob Nordgren and Rishie Sharma:
- Added support for EDCH type 2 MAC-is reassembly and slightly improved RLC error reporting 

- RLC: fixed bug where complete sequences in the end of a trace where not reassembled

svn path=/trunk/; revision=43954
2012-07-24 07:31:46 +00:00
Anders Broman
fccbea6702 Merge the rest of Jacob Nordgren and Rishie Sharmas work on
Updateing conversation handling to dissect FP/MAC/RLC
(Work in progress).

svn path=/trunk/; revision=43781
2012-07-18 07:45:19 +00:00
Anders Broman
37fdb21ec2 From Jacob Nordgren and Rishie Sharma:
Updated conversation handling to dissect FP/MAC/RLC

svn path=/trunk/; revision=43750
2012-07-16 13:54:20 +00:00
Anders Broman
fe630ec1df From Jacob Nordgren and Rishie Sharma:
Updated conversation handling to dissect FP/MAC/RLC

svn path=/trunk/; revision=43749
2012-07-16 13:11:20 +00:00
Jakub Zawadzki
bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Jeff Morriss
e83180023e Clean up some indentation (get rid of 4-space tabs) and white space.
svn path=/trunk/; revision=42988
2012-06-01 19:46:53 +00:00
Jeff Morriss
a2fe7eabbb Remember the 'lower' UDP port information even if we got the UDP packet
non-heuristically.  This prevents us from trying to decode the user's UDP
payload as FP.

(This is a followup/revision to r31113/bug 4218.)

svn path=/trunk/; revision=42987
2012-06-01 19:22:01 +00:00
Anders Broman
6e3d56f039 For RLC re-assembly to work we need to fake urnti.
svn path=/trunk/; revision=42970
2012-06-01 13:01:32 +00:00
Anders Broman
a2f13cad70 Don't call subdissectors if the CRCI bit is set.
svn path=/trunk/; revision=42969
2012-06-01 12:28:05 +00:00
Anders Broman
6a505b4cce Fix a couple of warnings
svn path=/trunk/; revision=42956
2012-06-01 05:36:52 +00:00
Anders Broman
b9e5955f46 Set dir if we don't have it.
svn path=/trunk/; revision=42945
2012-05-31 13:23:42 +00:00
Anders Broman
79e91685b7 Stab at DCH 31 dissection.
svn path=/trunk/; revision=42915
2012-05-30 14:04:45 +00:00
Anders Broman
2a7bef2cb0 Handle E-DCH
svn path=/trunk/; revision=42898
2012-05-29 14:34:34 +00:00
Pascal Quantin
a891f54067 Keep backward compatibility with UDP framing format for UMTS RLC dissector
Fix a few typo errors while we are at it

svn path=/trunk/; revision=42889
2012-05-28 20:34:27 +00:00
Anders Broman
2a412f000b Try to pacify the Ubuntu buildbot.
svn path=/trunk/; revision=42877
2012-05-28 13:53:33 +00:00
Anders Broman
d8ddd39c3d Enhance CHANNEL_HSDSCH dissection.
svn path=/trunk/; revision=42876
2012-05-28 13:38:40 +00:00
Anders Broman
551dcff815 Dissect MAC and RLC for CHANNEL_FACH_FDD
svn path=/trunk/; revision=42811
2012-05-23 10:47:52 +00:00
Anders Broman
4e7d87caa2 Fix PCH dissection
svn path=/trunk/; revision=42791
2012-05-22 21:12:59 +00:00
Anders Broman
e460267b82 Set paging indication and start fixing TFI list.
svn path=/trunk/; revision=42783
2012-05-22 15:39:12 +00:00
Jeff Morriss
913455d3b3 Get rid of non-ASCII chars. Remove a few trailing commas.
svn path=/trunk/; revision=42782
2012-05-22 14:00:19 +00:00
Anders Broman
ec5ec34f1f Collect and use E-DCH data.
svn path=/trunk/; revision=42779
2012-05-22 11:53:12 +00:00
Bill Meier
e3ea682270 General cleanup:
- 4-space tabs, trailing whitespace, etc
- use a consistent formatting style
- ...

svn path=/trunk/; revision=42733
2012-05-21 02:13:49 +00:00
Bill Meier
ca4a51873e Prevent (what seems to me to be) a possible null pointer dereference.
svn path=/trunk/; revision=42732
2012-05-21 01:00:12 +00:00
Bill Meier
0b6c88942b Fix 'unused parameter' warning.
svn path=/trunk/; revision=42730
2012-05-21 00:20:09 +00:00
Anders Broman
c5d3f8c2ba Set up conversations for more channel types
svn path=/trunk/; revision=42729
2012-05-20 21:24:18 +00:00
Anders Broman
8499bf8b8e Fix the DCH data collection for conversation setup
svn path=/trunk/; revision=42710
2012-05-19 06:20:05 +00:00
Anders Broman
46e202503a se_allocate and store per packet data.
svn path=/trunk/; revision=42657
2012-05-16 14:56:34 +00:00
Anders Broman
3e2ea7b812 Handle DCH information in RadioLinkReconfigurationPrepareFDD
svn path=/trunk/; revision=42655
2012-05-16 13:05:27 +00:00
Anders Broman
dc8224653e Only do HS-DSCH Control frames for now as something is broken.
svn path=/trunk/; revision=42653
2012-05-16 08:35:53 +00:00
Anders Broman
ce6e224b5b Bug fixes and add HSDSCH
svn path=/trunk/; revision=42649
2012-05-16 05:57:41 +00:00
Anders Broman
e134cca032 Use converstaion info to dissect FP DCH flows. Revert unfinished code.
svn path=/trunk/; revision=42628
2012-05-15 15:00:52 +00:00
Martin Mathieson
eaf2e8a0bc Formatting of { } wasn't consistent, so settle on having { at the end of
the line rather than on a  line on its own.

svn path=/trunk/; revision=42548
2012-05-10 14:34:21 +00:00
Martin Mathieson
9cd2bdf381 Remove an accidental ; following a test.
svn path=/trunk/; revision=42519
2012-05-09 12:07:14 +00:00