Commit Graph

2053 Commits

Author SHA1 Message Date
Gerald Combs cf6df46095 Fix a buffer overflow in the engineId preferences. Fixes bug 5530.
svn path=/trunk/; revision=35298
2010-12-29 20:09:27 +00:00
Anders Broman 735709bee6 Add tvb_bcd_dig_to_ep_str()
/*
 * Given a tvbuff, an offset into the tvbuff, and a length that starts
 * at that offset (which may be -1 for "all the way to the end of the
 * tvbuff"), fetch BCD encoded digits from a tvbuff starting from either 
 * the low or high half byte, formating the digits according to an input digit set, 
 * if NUll a default digit set of 0-9 returning "?" for overdecadic digits will be used.
 * A pointer to the EP allocated string will be returned.
 * Note a tvbuff content of 0xf is considered a 'filler' and will end the conversion.
 */

svn path=/trunk/; revision=35286
2010-12-28 12:36:26 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Anders Broman 86113c5a8c From Pascal Quantin:
When I coded the decoding of the feature group indicator, I decided to do not display the feature group content when it is not supported. After further thinking I find it more useful to always display the features of a given indicator whether it is supported or not.

svn path=/trunk/; revision=35200
2010-12-16 12:33:36 +00:00
Jeff Morriss f2fc5d42fd Make some prefs callback functions static. (These modules don't use proto_reg_handoff_*() as their prefs callback.)
svn path=/trunk/; revision=35138
2010-12-06 22:08:48 +00:00
Jeff Morriss 99bc06ceff Make some (preference) variables static.
svn path=/trunk/; revision=35134
2010-12-06 19:48:05 +00:00
Bill Meier 03b57df5a0 Fix various typos and spelling errors.
svn path=/trunk/; revision=35126
2010-12-06 01:34:58 +00:00
Anders Broman b4098dfae9 - Update to 3GPP TS 25.413 V9.4.0 (2010-09).
- Fill the value_strings.

svn path=/trunk/; revision=34929
2010-11-17 16:23:10 +00:00
Anders Broman 3ffa66319e - Update to 3GPP TS 25.413 V9.4.0 (2010-09).
- Fill the value_strings.

svn path=/trunk/; revision=34928
2010-11-17 15:36:53 +00:00
Anders Broman 263db68ab6 - Update to 3GPP TS 25.413 V9.4.0 (2010-09).
- Fill the value_strings.

svn path=/trunk/; revision=34925
2010-11-17 11:48:17 +00:00
Anders Broman 1913b3dd3e - Use SABP:s SCTP ppid.
- Use value_string_ext.

svn path=/trunk/; revision=34924
2010-11-17 08:18:30 +00:00
Anders Broman 838a24aaa0 value_string_ext fixes.
svn path=/trunk/; revision=34908
2010-11-16 17:31:29 +00:00
Bill Meier 0db7ad2404 Modify 'compare_files' target: ignore #line changes; compare from epan\dissectors to asn1\...
svn path=/trunk/; revision=34901
2010-11-16 15:24:51 +00:00
Bill Meier 491f05b16e Use value_string_ext fcns to access several value_string arrays;
Minor whitespace cleanup.

svn path=/trunk/; revision=34900
2010-11-16 15:20:33 +00:00
Bill Meier c52500588e Use value_string_ext fcns to access several value_string arrays.
svn path=/trunk/; revision=34894
2010-11-15 23:53:25 +00:00
Bill Meier 3c98cf2ebc Use value_string_ext fcns to access several value_string arrays.
svn path=/trunk/; revision=34891
2010-11-15 22:37:35 +00:00
Bill Meier 37742d97d8 Use value_string_ext fcns to access several value_string arrays.
svn path=/trunk/; revision=34890
2010-11-15 22:00:33 +00:00
Bill Meier 8548e16613 Use value_string_ext fcns to access a value_string array.
svn path=/trunk/; revision=34884
2010-11-15 19:46:07 +00:00
Bill Meier 0f286bbb89 Use value_string_ext fcns to access a value_string array.
svn path=/trunk/; revision=34883
2010-11-15 19:15:34 +00:00
Bill Meier b1554fc198 Use value_string_ext fcns to access certain value_string arrays;
Whitespace cleanup.

svn path=/trunk/; revision=34882
2010-11-15 19:08:12 +00:00
Bill Meier ed7105e21b Update package_name_vals[] value_string array:
- Add new entries based on: http://www.iana.org/assignments/megaco-h248 last updated 2010-10-01;
- Fix a typo (incorrect value for an entry);
- Switch values between two entries to match the IANA list;
- Switch two entries so list is in ascending order by value.

svn path=/trunk/; revision=34881
2010-11-15 19:00:16 +00:00
Bill Meier 71a74c2f3a Regenerate packet-nbap.c now that asn2wrs sorts value_string arrays used with value_string_ext fcns;
Change nbap.cnf to use val_to_str_ext to access protocolIE_ID value_string array.
Also: Minor whitespace cleanup in nbap.cnf.

svn path=/trunk/; revision=34876
2010-11-15 16:46:14 +00:00
Anders Broman 760d2a5cdc Update Camel to TS 29.078 9.2.0 (2010-06)
svn path=/trunk/; revision=34849
2010-11-12 14:50:58 +00:00
Anders Broman 92d5c09ac6 Use value_string_ext.
svn path=/trunk/; revision=34844
2010-11-11 17:24:11 +00:00
Anders Broman 2fb8971136 Update to 3GPP TS 29.002 V9.3.0 (2010-09)
svn path=/trunk/; revision=34814
2010-11-08 23:15:16 +00:00
Anders Broman ae7d471ebe Make the changes from:
Use value_string_ext fcns to access certain value_string arrays;
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.
In the source files of the as2wrs generated dissectors.

svn path=/trunk/; revision=34803
2010-11-07 20:51:16 +00:00
Stig Bjørlykke b9f01a15db Initialize dummy_me to avoid garbage or undefined values.
svn path=/trunk/; revision=34788
2010-11-05 08:28:34 +00:00
Stig Bjørlykke 8c1b03ef8e Don't generate packet-ns_cert_exts.h, it's not used.
svn path=/trunk/; revision=34736
2010-10-31 12:37:46 +00:00
Stig Bjørlykke f3f13f36b5 Added a "all" target to rebuild all asn1 dissectors.
Currently this fails for kerberos and x721, because they shall not be build.
Maybe we should add some sort of disable build for them.

svn path=/trunk/; revision=34734
2010-10-31 12:26:15 +00:00
Stig Bjørlykke c5bebaa771 One more:
Make the third argument to a UAT copy callback a size_t.

svn path=/trunk/; revision=34696
2010-10-29 21:55:04 +00:00
Stig Bjørlykke 340d64e780 Make the third argument to a UAT copy callback a size_t.
svn path=/trunk/; revision=34695
2010-10-29 21:51:59 +00:00
Guy Harris 17d4d51b7d Make the third argument to a UAT copy callback a size_t (not that any of
the callbacks we have use that argument - is it really needed?).

svn path=/trunk/; revision=34694
2010-10-29 21:11:33 +00:00
Stig Bjørlykke 8b9c15d68f Added info column descriptions for AARQ and AARE.
svn path=/trunk/; revision=34519
2010-10-15 08:39:48 +00:00
Jeff Morriss ebc190645f From Fulko Hew via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4615 :
The attached patch adds the missing decoded fields
by moving the proto_tree_add_item() call so that it
is no longer within an error handler and will be
called under normal circumstances (as well as error conditions.


From me: Apply the change to the ASN.1 source.  Also some white space
indentation cleanup.

svn path=/trunk/; revision=34505
2010-10-14 01:44:27 +00:00
Anders Broman 6dc9a19a91 Update to V9.4.0 (2010-09), no change in the asn1 def's.
svn path=/trunk/; revision=34362
2010-10-04 10:48:42 +00:00
Stig Bjørlykke e7a8e117fc Cleanup reassembly hf entries.
svn path=/trunk/; revision=34292
2010-09-30 19:40:02 +00:00
Stig Bjørlykke f5a210b2e8 Cleanup reassembly hf entries.
svn path=/trunk/; revision=34291
2010-09-30 19:35:51 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Stig Bjørlykke 907cfc535a Corrected check for attribute flag bits.
svn path=/trunk/; revision=34203
2010-09-23 07:42:20 +00:00
Stig Bjørlykke c403378c36 Show Abort source in info column.
svn path=/trunk/; revision=34202
2010-09-23 07:39:38 +00:00
Anders Broman 6dc449e99c The CLDAP attribute value on a CLDAP reply is no longer being decoded
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5239

It got broken in Revision 33390 I think, if attr_type is unset at this point it should be set in the calling function.
http://anonsvn.wireshark.org/viewvc/trunk/asn1/ldap/ldap.cnf?r1=33388&r2=33390

svn path=/trunk/; revision=34176
2010-09-21 14:56:55 +00:00
Jeff Morriss 381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 :
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
2010-09-21 03:14:49 +00:00
Stig Bjørlykke e6dac92931 Put Abort reason in info column.
svn path=/trunk/; revision=34159
2010-09-20 12:49:52 +00:00
Jeff Morriss 9ac49c557d Copy the rev 34143 changes to packet-snmp.c over to the asn1 source.
hf_snmp_engineid_enterprise is now a BASE_EXT_STRING, not BASE_RANGE_STRING.  This fixes
the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5233 

svn path=/trunk/; revision=34151
2010-09-17 14:03:05 +00:00
Stig Bjørlykke 633e4e324b From Martin Peylo via bug 5198:
Added missing OIDs in CRMF (RFC 4211) dissector.

svn path=/trunk/; revision=34099
2010-09-10 21:22:29 +00:00
Tomas Kukosa eb503df011 Do not report undecoded message to expert info for ReturnResult without result filed
svn path=/trunk/; revision=34076
2010-09-08 09:02:16 +00:00
Anders Broman 136dec3980 From Pascal Quantin:
Patch that allows the dissection of the Feature Group Indicators bit string. I tested it with our UE and it works fine.

svn path=/trunk/; revision=34035
2010-08-31 20:03:46 +00:00
Anders Broman fc87f4a4c1 Add stub code for future dissection of featureGroupIndicators.
svn path=/trunk/; revision=34032
2010-08-31 10:50:54 +00:00
Anders Broman 687eb5a2a6 Fix for Bug Packet details have errors when decode MAP V2 PRN_ACK msg
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5076

Use:
/*
 * Dissect Multiple Choice Message
 * This function is used to decode a message, when several encoding may be used.
 * For exemple, in the last MAP version, the Cancel Location is defined like this:
 * CancelLocationArg ::= [3] IMPLICIT SEQUENCE
 * But in the previous MAP version, it was a CHOICE between a SEQUENCE and an IMSI
 * As ASN1 encoders (or software) still uses the old encoding, this function allows
 * the decoding of both versions.
 * Moreover, some optimizations (or bad practice ?) in ASN1 encoder, removes the
 * SEQUENCE tag, when only one parameter is present in the SEQUENCE.
 * This explain why the function expects 3 parameters:
 * - a [3] SEQUENCE corresponding the recent ASN1 MAP encoding
 * - a SEQUENCE for old style
 * - and a single parameter, for old version or optimizations
 *
 * The analyze of the first ASN1 tag, indicate what kind of decoding should be used,
 * if the decoding function is provided (so not a NULL function)
 */

svn path=/trunk/; revision=34001
2010-08-29 17:34:44 +00:00
Jeff Morriss 9d96012b57 From Dirk via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5150 : remove Makefile.in from the asn1 directories when doing a maintainer-clean
svn path=/trunk/; revision=33955
2010-08-27 18:36:01 +00:00