Commit Graph

79911 Commits

Author SHA1 Message Date
Guy Harris f0ebc50762 wslua: expose some libwiretap APIs in Lua.
Provide Lua version of wtap_file_type_subtype_string(),
wtap_file_type_subtype_short_string(), and
wtap_short_string_to_file_type_subtype().

This will be backported to the 3.2 and 3.4 branches, to allow scripts
not run on the bleeding-edge version to use them.
2021-02-12 21:25:29 -08:00
Guy Harris b67494e32a WSDG: give more details on setting up a UNIX build environment.
List the minimum set of tools required.

We have scripts to do the setup work on a number of platforms.  Let the
user know about them.

Give instructions on using CMake; we're not using the traditional
autoconf stuff any more.

Give instructions on building the Developer's and User's Guides in the
UNIX section, and, in both that section *and* the equivalent Windows
section, give the name of the build target for building all guides.
2021-02-12 15:00:07 -08:00
Jaap Keuter b9bdc803bb ASTERIX: fix dissection of I010_041 and I010_042 fields
Fixes #17226
2021-02-12 14:20:53 +01:00
Pascal Quantin af119730e6 ISKAMP: fix a REPORT_DISSECTOR_BUG printf 2021-02-12 12:06:35 +01:00
Constantine Gavrilov 4c328749ac NVME RDMA dissector: add decoding of RDMA payload for connect command. 2021-02-12 10:57:27 +02:00
Constantine Gavrilov 7246677d42 NVME RDMA dissector: store RDMA transfers and link them to commands.
Details:
* At this point works for single RDMA transfer per command
* Commands are linked to RDMA requests
* RDMA requests are linked to commands (read and only first write)
* RDMA read requests are linked to read responses (only first response)
* RDMA read responses are linked to requests (only first response)
* RDMA read responses are linked to commands (only first response)
2021-02-12 10:57:27 +02:00
Constantine Gavrilov aea7f6fad2 NVME RDMA dissector: decode Property Get/Set structures. 2021-02-12 10:56:03 +02:00
Constantine Gavrilov bfa2ae5964 Revert "NVME RDMA dissector: store RDMA transfers and link them to commands."
This reverts commit 05d5506324.
Due to a wrong order of merge requests, and squashing the history,
I would like to split the commit into two independent changes.
2021-02-12 10:52:12 +02:00
Alex Nik c361d31843 added the description about the 29West stat menu 2021-02-12 07:48:51 +00:00
Constantine Gavrilov 5160fc895e NVME dissector: fix parsing of NVME Identify command. 2021-02-12 05:06:20 +00:00
Alex Nik 54abb56b1d added description for F5
added SME suggestions

minor fix
2021-02-12 04:49:24 +00:00
Alexis La Goutte aa0081327c wccp: fix unused variable ‘length_remaining’ [-Werror=unused-variable] 2021-02-11 21:56:37 +00:00
Alexis La Goutte 7d8d209c9f wccp: fix Dead Store found by Clang Analyzer
packet-wccp.c:2423:11: warning: Although the value stored to 'length_remaining' is used in the enclosing expression, the value is never actually read from 'length_remaining'
2021-02-11 21:56:37 +00:00
Alexis La Goutte 9d91ebd616 VNC: Fix dead store found by Clang
acket-vnc.c:1550:3: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
2021-02-11 21:56:37 +00:00
Alexis La Goutte a4bcc8bd13 snort: fix dead Store found by Clang Analyzer
packet-snort.c:515:15: warning: Although the value stored to 'line' is used in the enclosing expression, the value is never actually read from 'line'
2021-02-11 21:56:37 +00:00
Alexis La Goutte 3cf55c314e ieee80211: Fix Dead Store found by Clang Analyzer
packet-ieee80211.c:23771:5: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ieee80211.c:23905:9: warning: Value stored to 'offset' is never read [deadcode.DeadStores
packet-ieee80211.c:23994:9: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ieee80211.c:24083:9: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ieee80211.c:24146:9: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ieee80211.c:26495:7: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
2021-02-11 21:56:37 +00:00
Alexis La Goutte 2aab84350d someip-sd: Fix Dead Store found by Clang Analyzer
packet-someip-sd.c:531:9: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
2021-02-11 21:56:37 +00:00
Alexis La Goutte 6fc94ac462 extcap: Fix Dead Store found by Clang Analyzer
extcap.c:876:26: warning: Although the value stored to 'pref' is used in the enclosing expression, the value is never actually read from 'pref'
2021-02-11 21:56:37 +00:00
Alexis La Goutte f2888ecf38 btle: Fix Dead Store found by Clang Analyzer
packet-btle.c:1417:13: warning: Value stored to 'item' is never read [deadcode.DeadStores]
2021-02-11 21:56:37 +00:00
Alexis La Goutte a22ef5cca5 btatt: Fix Dead Store found by Clang Analyzer
packet-btatt.c:4754:17: warning: Value stored to 'tvb' is never read [deadcode.DeadStores]
2021-02-11 21:56:37 +00:00
Alex Nik a3bb5f2da3 Added the description for the SMPP operations 2021-02-11 21:40:57 +00:00
Constantine Gavrilov 05d5506324 NVME RDMA dissector: store RDMA transfers and link them to commands.
Details:
* At this point works for single RDMA transfer per command
* Commands are linked to RDMA requests
* RDMA requests are linked to commands (read and only first write)
* RDMA read requests are linked to read responses (only first response)
* RDMA read responses are linked to requests (only first response)
* RDMA read responses are linked to commands (only first response)
2021-02-11 21:38:15 +00:00
Dr. Lars Völker 7b9e8f3080 SOME/IP: Fix crash after loading a faulty uat config (BUGFIX)
When you load a correct wireshark config for SOME/IP responding
hashtable entries are created. If you load afterwards a new config
(empty or not) the old entries are updated.

However, Wireshark does not call the uat's post update callback,
when there was a bug in the config. This leads to an inconsistent
state, which may result in a crash on dissecting SOME/IP messages.

This patch adds code to the SOME/IP dissector to avoid inconsistent
state.

Fixes: #17227
2021-02-11 14:50:17 +00:00
Martin Mathieson f5b8c1b686 ESP: validate keys in UAT. 2021-02-11 14:29:20 +00:00
Gerald Combs c7f66cf934 TShark: Load extcap preferences only when needed.
In our first pass through our options, look for ones that might require
extcap. Call extcap_register_preferences() only when that's the case.

Warn about missing extcap preferences only when we've loaded them.
2021-02-11 13:36:22 +00:00
Constantine Gavrilov 28937e9022 Fix dissection of transport connect payload for NVMEoF with RDMA. 2021-02-11 08:03:06 +00:00
Uli Heilmeier 156bc6ca91 DNS: Support for ZONEMD RR (RFC8976)
Adding support for RFC 8976 Message Digest for DNS Zones (ZONEMD RR)
2021-02-11 06:21:38 +00:00
Guy Harris 2c6b9e83f1 RTP player: squelch a narrowing warning. 2021-02-10 18:22:46 -08:00
Guy Harris f355bfadcc SCSI: use BASE_DEC_HEX for counts/lengths/etc..
Show values that are sequence numbers, counts, lengths, and the like in
decimal, with the hex value after it in parentheses for the benefit of
those who count to 16 rather than 10.
2021-02-10 16:57:16 -08:00
Constantine Gavrilov 976f3da9aa Infiniband dissector: print RDMA addresses, sizes and keys in HEX. 2021-02-11 01:14:45 +02:00
Guy Harris 9e2e260fa8 Infiniband, iSCSI, NVMA: use BASE_DEC_HEX for counts/lengths/etc..
Show values that are sequence numbers, counts, lengths, and the like in
decimal, with the hex value after it in parentheses for the benefit of
those who count to 16 rather than 10.
2021-02-10 14:20:13 -08:00
Joey Salazar a8e2197d99 git: Parse delim-pkt and response_end-pkt
Git Protocol version 2[1] defines 0x0001 as a delimiter packet that
separates the sections of a message, as well as 0x0002 as a response_end
packet that indicates the end of a response for stateless connections.

Add parsing and checking of the delim-pkt and response_end-pkt lines,
adding them as items to the tree for ease of reading and filtering while
handling pre-existing "malformed" errors. For additional consistency,
the terminator 0x0000 is now referred to as Flush packet.

[1] https://www.kernel.org/pub/software/scm/git/docs/technical/protocol-v2.html

Part of #17093
2021-02-10 20:50:15 +00:00
Michal Ruprich c8246c9973 Moving glib.h out of extern C 2021-02-10 17:49:09 +00:00
Dr. Lars Völker 1eeb2c1a10 SOME/IP: Bugfix copy and paste in method name check
When the method name was not found it needs to be set to null. By
accident the service name was set to null instead.
This is wrong and fixed by this patch.

Fixes #17204
2021-02-10 16:43:06 +00:00
Pascal Quantin 46c44e0785 NR RRC: add preference to put NAS in the root tree 2021-02-10 14:46:27 +00:00
Pascal Quantin 12ab24019f RRC: add preference to put NAS in the root tree 2021-02-10 13:29:33 +00:00
Nicolás Alvarez ebfbf958f6 Add ENC_TIME_NSECS timestamp encoding
Add a new timestamp encoding format ENC_TIME_NSECS, like ENC_TIME_SEC but
for nanosecond values. Needed for my work-in-progress dissector for Apple
push notifications.
2021-02-10 12:45:54 +00:00
Stig Bjørlykke 9dd74b2788 p1: Rewrite do_address for extension attributes
Rewrite do_address handling to use proto_data instead of
pinfo->private_table.

Related to #17156
2021-02-10 12:29:42 +00:00
Martin Mathieson 52163d05ba IPSec: add comments to ESP key-setting function. 2021-02-10 12:03:12 +00:00
Martin Mathieson 259134b406 Make some more variables/functions static. 2021-02-10 11:14:52 +00:00
Stig Bjørlykke cb3d463a38 lte-rrc: Add preference to put NAS in the root tree
Add a preference to put DedicatedInfoNAS in the root packet
details tree.
2021-02-10 10:08:21 +00:00
Guy Harris a1e03ea89e Remove the existing "custom block" mechanism:
For most file types, blocks for which we don't have a wtap_block_type_t
aren't "custom", they're just "file-type specific".  Add
WTAP_BLOCK_FT_SPECIFIC_REPORT and WTAP_BLOCK_FT_SPECIFIC_EVENT block
types; the "mandatory" part of those blocks includes a
file-type-specific block type value, with specific values assigned to
specific block types (either as part of the file type's definition, or
by us if necessary).

For pcapng files, blocks for which we don't have a wtap_block_type_t are
either "local" (block type has the high-order bit set), are defined in
the current spec but aren't supported yet (which we should fix), or are
*not* defined in the current spec and are *not* "local" (in which case
whoever's using the block number should submit a pull request to the
spec to register the block type *and* give it a specification, so we can
add support).  For "local" block types and for not-yet-supported
non-"local" block types, they should be handled as file-type-specific
blocks with the file-type-specific block value being the pcapng block
type code, with plugin support in the pcapng code to read *and* write
those blocks.

Move the structures for the "mandatory" parts of blocks to
wiretap/wtap_opttypes.h, right after the definition of
wtap_block_type_t.
2021-02-10 09:05:41 +00:00
Anders Broman e92620454e Diameter 3GPP: Dissect more flags in Access-Restriction-Data 2021-02-10 08:33:03 +00:00
Gerald Combs 5e735f6581 TCP: Remove a no-longer-used field.
mptcp.analysis.subflows.streamid is unused as of e38e412239. Remove it.
2021-02-10 08:01:28 +00:00
Gerald Combs ce19a2512e TCP: Add a SACK range check.
Make sure we don't write past the ends of our sack_left_edge and
sack_right_edge arrays. Fixes #17187.
2021-02-10 07:29:21 +00:00
Alexis La Goutte ccd8529440 ieee80211: Add bit 34 and 35 on RM Capability
FTM Range Capability (Bit 34)
Civic Location Measurement Capability (Bit 35)
2021-02-10 07:13:28 +00:00
Martin Kaiser 70a85e1fa5 gsm_a_common: free stat table items
The init functions of the gsm statistics tables call gsm_a_stat_init, which
allocates some strings. We have to register gsm_a_stat_free_table_item to
free these table items again.

This is already done correctly for gsm_a_bssmap_stat_table. Fix it for the
other tables.
2021-02-10 06:49:11 +00:00
Martin Kaiser cd4e55fa03 gsm_a_common: create and populate the stats table only once
Use the new stat_tap_find_table function during init to check if our
statistics table already exists.

If so, we can safely assume that its rows have already beend initialized.
All we have to do is clear the data that was collected by the tap.
2021-02-10 06:33:08 +00:00
Chuck Craft 02cb167cce uftp: Fix typo in #define for default port
The change in 2eb7b05b had a typo for the UDP port #define.
2021-02-10 06:17:30 +00:00
Guy Harris f0c54cc480 wiretap: add an API to get the type of a block.
When registering a custom block type, set the block type field of the
wtap_blocktype_t structure.  (We may do custom blocks differently, so
this is just for now.)

When registering a standard block type, don't pass in the block type, as
we can just use the type in the wtap_blocktype_t structure.
2021-02-09 21:23:44 -08:00