Commit Graph

8403 Commits

Author SHA1 Message Date
Tim Potter f051c17afb Put the presentation context list and transfer syntax list of a dcerpc
bind request into some subtrees to make things look a bit nicer.

svn path=/trunk/; revision=8497
2003-09-19 05:30:01 +00:00
Guy Harris 6aed321bb5 From Lars Roland: initialize the flags.ref_time field of a frame_data
structure.

svn path=/trunk/; revision=8496
2003-09-19 04:52:16 +00:00
Guy Harris 952f81ed8d Use bitfields for the end-of-event, reserved, and volume fields.
Don't fetch fields until you need them, so you don't throw an early
exception.

Give the fields names starting with the name of the protocol.

svn path=/trunk/; revision=8495
2003-09-19 04:27:48 +00:00
Guy Harris 0c211a05e7 From Kevin A. Noll: RFC 2833 RTP Events support.
svn path=/trunk/; revision=8494
2003-09-19 04:16:23 +00:00
Guy Harris 4bd548e034 From Jesper Peterson: add support for AAL5 records in ERF files,
treating them as PDUs with an AAL5 trailer.

svn path=/trunk/; revision=8493
2003-09-19 04:08:11 +00:00
Gerald Combs 1e05de2162 Make the string variables in the *_to_str() functions non-static.
svn path=/trunk/; revision=8492
2003-09-18 21:42:45 +00:00
Gerald Combs c5156be836 From Michal Melerowicz: Properly terminate the return string in
msisdn_to_str().

Do the same for imsi_to_str().

svn path=/trunk/; revision=8491
2003-09-18 21:38:44 +00:00
Guy Harris 3177fb0722 Don't store the setting of the window scale option unless the "Relative
sequence numbers and window scaling" option is set, as that option says
it controls whether we attempt to display the real post-scaling window
size.

Also, don't store it unless the "Analyze TCP sequence numbers" option is
set, as "Relative sequence numbers and window scaling" requires it,
because, unless "Analyze TCP sequence numbers" is set, we don't set up
conversations for TCP connections and don't have a pool of data
structures for per-connection information into which to store the window
scale option value.

svn path=/trunk/; revision=8490
2003-09-18 19:19:51 +00:00
Guy Harris e28b621f8f From Olivier Biot: put a summary into the top-level SMPP item in the
protocol tree.

svn path=/trunk/; revision=8489
2003-09-17 20:24:45 +00:00
Guy Harris 1513888c99 Have "register_tap_menu_item()" put the item under Tools, not
Tools/Statistics; change the taps to put things under Statistics
themselves.  That allows taps to go elsewhere if appropriate.

svn path=/trunk/; revision=8488
2003-09-17 19:39:34 +00:00
Jeff Foster 082ee54f8b Fix recursive heap overflow problem.
When a socks connection was used to create a second socks connection
the socks dissector would be called recursively until a heap overflow
occurred.

svn path=/trunk/; revision=8487
2003-09-17 15:58:11 +00:00
Guy Harris 0cf18ffba8 Handle PPP with a pseudo-header.
svn path=/trunk/; revision=8486
2003-09-16 20:41:17 +00:00
Guy Harris 44b6284df9 There's no preference setting for the SMTP TCP port (and SMTP has a
well-known port), so we remove the extra code to handle changing it - if
it ever becomes useful to have the port number settable, we can put it
back.

svn path=/trunk/; revision=8485
2003-09-16 17:42:01 +00:00
Guy Harris aaca523a47 Re-register the dissector if a preference changes - otherwise, changing
the TCP port number won't have any effect.

svn path=/trunk/; revision=8484
2003-09-16 17:36:09 +00:00
Guy Harris b4746f3546 Make sure we return FALSE in all the failure paths in "do_capture()".
svn path=/trunk/; revision=8483
2003-09-15 23:48:42 +00:00
Guy Harris 2b5a2b8926 We no longer pop up tap windows until we have a capture file open, so we
don't have to worry about the file name being null when
"cf_get_display_name()" is called.  (It should never be called before we
have a capture file open; if it is, that's a bug.)

svn path=/trunk/; revision=8482
2003-09-15 23:28:07 +00:00
Guy Harris f3dd4b5eec Clean up an error message.
svn path=/trunk/; revision=8481
2003-09-15 23:20:34 +00:00
Guy Harris 2e98c97118 Don't pop up tap windows specified with "-z" options until we have a
capture file open.

svn path=/trunk/; revision=8480
2003-09-15 23:15:32 +00:00
Guy Harris 14509164fc Rename various capture file routines to have names starting with "cf_".
svn path=/trunk/; revision=8479
2003-09-15 22:48:42 +00:00
Guy Harris 1332b99a2a Get rid of a bunch of unnecessary #includes.
svn path=/trunk/; revision=8478
2003-09-15 22:32:21 +00:00
Guy Harris ca9ff2abdd Get rid of a no-longer-relevant comment.
svn path=/trunk/; revision=8477
2003-09-15 22:17:25 +00:00
Guy Harris f56d16abab Add a routine to return the display name for a "capture_file" structure,
rather than constructing that name when a capture file is opened and
putting a pointer to it in that structure.

svn path=/trunk/; revision=8476
2003-09-15 22:16:08 +00:00
Guy Harris 0d87da9c92 Don't allow -k and a capture file to both be specified on the command
line - either we're doing a live capture or we're reading a saved
capture file, we can't do both at the same time.

svn path=/trunk/; revision=8475
2003-09-15 20:45:19 +00:00
Guy Harris 673e47d4a9 Keep a "display name" as part of a capture_file structure; for live
capture temporary files, it's "<capture", and for saved capture files,
it's the last component of the pathname of the file.  Use that in
various places when displaying the file name.

svn path=/trunk/; revision=8474
2003-09-15 20:37:37 +00:00
Guy Harris 4339a40c03 From Yaniv Kaul: add AES-XCBC-MAC to the list of authentication methods,
per RFC 3566.

svn path=/trunk/; revision=8473
2003-09-15 19:08:27 +00:00
Guy Harris 7bfaf8caf3 From Graeme Hewson:
Don't crash if "-z" is used on the command line when a live
	capture is being done (e.g., with "-k -S" - in that case,
	"cfile.filename" is null when the window is created), just don't
	display the file name in the title.

	Don't set the title of a non-existent window - create the window
	first.

svn path=/trunk/; revision=8472
2003-09-15 19:05:01 +00:00
Guy Harris 00eb774c39 From Josef Korelus: call the data dissector on the contents of the LLC
PDU information element.

svn path=/trunk/; revision=8471
2003-09-15 18:49:06 +00:00
Guy Harris 8093f3ecff From Ritchie: dissect country information tag.
svn path=/trunk/; revision=8470
2003-09-15 18:40:53 +00:00
Guy Harris 19a1589e9c Use "int"s as array indices - it squelches a
signed-vs-unsigned-comparison complaint in one case, and it's a
generally good habit.

svn path=/trunk/; revision=8469
2003-09-15 18:31:17 +00:00
Gerald Combs a8f9d8211d Fix a buffer overflow in msisdn_to_str(). Clean up string pointer handling
in it, imsi_to_str(), and id_to_str() a bit.

svn path=/trunk/; revision=8468
2003-09-14 21:28:13 +00:00
Jörg Mayer 0c4c9462c8 Fix warning: guint8 is always <= 255
svn path=/trunk/; revision=8467
2003-09-14 20:59:31 +00:00
Guy Harris 44b236a123 According to draft-ietf-manet-aodv-13, the only differences between V4
and V6 AODV messages is the addresses in the message.

According to the now-expired draft-perkins-aodv6-01, some of the
messages differ in the order of the fields as well.

Dissect the draft-ietf-manet-aodv-13 messages correctly.

svn path=/trunk/; revision=8466
2003-09-13 00:57:10 +00:00
Guy Harris 375204a3e2 According to draft-ietf-manet-aodv-13, "the only changes to the protocol
are that the address fields are enlarged", so presumably that supercedes
the now-expired draft-perkins-aodv6-01 which gives different type
numbers for V6.  We support both - the draft-ietf-manet-aodv-13 messages
are dissected based on the address type of the source address, while the
draft-perkins-aodv6-01 messages are dissected as V6.

Handle the Route Reply Acknowledgment message.

svn path=/trunk/; revision=8465
2003-09-12 22:52:22 +00:00
Guy Harris 3cbb7da413 From Kari Tiirikainen:
Updated the COPS dissector to print the names of the Prefix
	PRIDs correctly.  The last fix to PRID OID printout caused this
	minor problem for PPRIDs.

	Rename a few variables to make the code more logical to read.

svn path=/trunk/; revision=8464
2003-09-12 19:40:33 +00:00
Ronnie Sahlberg bec5704f64 Update to netlogon
make it decode DsrGetDCSiteCoverage replies properly

svn path=/trunk/; revision=8463
2003-09-12 11:13:17 +00:00
Ronnie Sahlberg 3afd5dfa7c upadtes to NETLOGON
svn path=/trunk/; revision=8462
2003-09-12 10:32:21 +00:00
Ronnie Sahlberg b48de22d5b Enhancement to the TCP dissector:
Track window scaling and display the window field after it has been scaled to its real value

If we have seen a SYN packet with a WindowScalingOption
then if the option to use RelativeSequence numbers has been enabled,
then ethereal will change the presented window field to be the window after it has been scaled to the real value.

This obviously only works if we have seen the SYN packet and if the SYN packet contained a window scaling option

svn path=/trunk/; revision=8461
2003-09-12 05:52:38 +00:00
Ronnie Sahlberg 1ce1722006 Attempt to prettify frame.time_relative
and some other fields

svn path=/trunk/; revision=8460
2003-09-12 04:52:55 +00:00
Ronnie Sahlberg 007d873671 Added TimeReference frames.
One can now select a packet and mark it as a TimeReference packet using the menu.
A TimeReference packet will be indicated by having all timestamp related column entries replaced by the string *REF*
A TimeReference packet will always be displayed in the packet pane, and overrides any display filters.

When a frame is a TimeReference frame, all later frames will calculate the TimeRelativeToFirstPacket  relative to the timestamp of the TimeReference frame instead of the first frame of the capture.

You can have any number of TimeReference frames you like.

svn path=/trunk/; revision=8459
2003-09-12 02:48:23 +00:00
Ronnie Sahlberg 9f5cabe151 From hans Viens:
T38 dissector

svn path=/trunk/; revision=8458
2003-09-11 13:37:35 +00:00
Ronnie Sahlberg e2311645e4 From Hans Viens :
T38 dissector

svn path=/trunk/; revision=8457
2003-09-11 13:36:04 +00:00
Ronnie Sahlberg a776f2d3d9 From Jean-Baptiste Marchand
update of the type of pointer used for DsrGetSiteName reply packets

svn path=/trunk/; revision=8456
2003-09-11 13:24:19 +00:00
Ronnie Sahlberg 9428cb362e Do not take the pointer to a stack object and pass it to the tap system.
The tap listener will try to parse this pointer at a much later stage where the stack frame where this object lived will have dissapeared and possible got overwritten.

best that can happen is that service response times for dcerpc interfaces is screwed up
more probable is that we get a coredump

svn path=/trunk/; revision=8455
2003-09-11 10:31:01 +00:00
Guy Harris 930e137aff From Anders Broman: add support for BICC dissection.
Change his e-mail address.

svn path=/trunk/; revision=8454
2003-09-11 00:08:14 +00:00
Guy Harris d09530d0cf Don't export MAX_VAR_LEN - nobody uses it.
svn path=/trunk/; revision=8453
2003-09-10 23:55:52 +00:00
Guy Harris 341e84d9ec Document the "Print only marked packets" option in the "Print" dialog,
and document that you can now search for packets with particular text in
the Info column or protocol tree.

svn path=/trunk/; revision=8452
2003-09-10 22:33:31 +00:00
Guy Harris 3e1a532413 When saving packets, we have a "Save only marked packets" option; label
the option to print only marked packets similarly, rather than as
"Suppress unmarked packets" (for consistency, and because the latter
isn't unlike a double negative).

svn path=/trunk/; revision=8451
2003-09-10 22:23:58 +00:00
Gerald Combs 7704cdd149 Make tvb_find_tvb() return -1 if either tvb length is 0. Otherwise, an
assertion happens 'xxxx contains ""'.

svn path=/trunk/; revision=8450
2003-09-10 21:19:47 +00:00
Guy Harris 4e21a36656 Don't use "alloca()", and don't use "match_strval()", just use
"val_to_str()".

svn path=/trunk/; revision=8449
2003-09-10 20:07:10 +00:00
Guy Harris d4954b6700 Use the *correct* value_string for the IE Type field.
svn path=/trunk/; revision=8448
2003-09-10 19:27:14 +00:00