Commit Graph

11504 Commits

Author SHA1 Message Date
Guy Harris a6b4a098ff "-T ps" should not imply "-V"; one should be able to get a list of
packet summaries in PostScript.

svn path=/trunk/; revision=11512
2004-07-25 08:32:32 +00:00
Guy Harris b5c1e171b4 Fix the declarations for "simple_dialog()" and "vsimple_dialog()" used
for non-GCC 2.x compilers to match their definitions.

svn path=/trunk/; revision=11511
2004-07-25 08:02:06 +00:00
Ronnie Sahlberg 88d357fe04 get rid of the remaining compiler warnings.
x509af is now virtually complete (the attribute userPassword still needs 
an attribute dissector but after that, x509af is complete)



svn path=/trunk/; revision=11510
2004-07-24 22:59:02 +00:00
Ronnie Sahlberg 4d09fc5e43 Add a lot of missing attribute dissectors
svn path=/trunk/; revision=11509
2004-07-24 22:53:27 +00:00
Ronnie Sahlberg 9d69ba5911 added the userCertificate and cAcertificate attributes
svn path=/trunk/; revision=11508
2004-07-24 22:30:49 +00:00
Ronnie Sahlberg 829a19a29b add dissection of the structure : Extension
svn path=/trunk/; revision=11507
2004-07-24 22:16:41 +00:00
Guy Harris d890f4934e In "dissect_smb_server_type_flags()":
explicitly pass NULL as the tree argument to
	"dissect_ndr_uint32()" - "tree", which was passed before, was
	definitely null at that point, and the intent is that it not put
	anything into the protocol tree;

	use the correct offset when putting items into the protocol tree
	(the offset has been advanced just past the end of the field at
	the time the items are being put into the protocol tree).

svn path=/trunk/; revision=11506
2004-07-24 09:59:00 +00:00
Guy Harris fcfde0b0c0 Include "colors.h" to define BLACK and WHITE.
svn path=/trunk/; revision=11505
2004-07-24 06:38:33 +00:00
Guy Harris edf3a634d6 "color_filters.h" doesn't need to include "epan/dfilter/dfilter.h";
anything that includes "color_filters.h" also includes
"epan/dfilter/dfilter.h" either directly or indirectly.

svn path=/trunk/; revision=11504
2004-07-24 02:39:15 +00:00
Guy Harris c3cba6617b Move the color-filter related stuff out of "color.h" into
"color_filters.h", as that's the appropriate place for it - "color.h"
should just deal with "color_t".

svn path=/trunk/; revision=11503
2004-07-24 02:29:14 +00:00
Guy Harris 13e4c5b1f2 Rename "create_color()" to "initialize_color()", as that reflects a bit
better what it actually does.

svn path=/trunk/; revision=11502
2004-07-24 02:08:42 +00:00
Guy Harris e046206fad Add some comments from Gerald's Windows version of color_filters.c.
svn path=/trunk/; revision=11501
2004-07-24 01:32:29 +00:00
Guy Harris b67a0f92d2 Move color_filters.c and color_filters.h up to the top-level directory,
as they're now (theoretically) toolkit-independent (modulo changes that
might be required to the code to update filter lists when a new filter
is read in).

svn path=/trunk/; revision=11500
2004-07-24 01:29:12 +00:00
Guy Harris e62e05a80a Move the declaration of "color_add_filter_cb()" to "color.h", as,
although it currently takes a pointer to a GtkWidget as its second
argument, that argument is actually a "void *", so it's sort-of
toolkit-independent.

That lets us get rid of all GTK+ references in "gtk/color_filters.c", so
we can move it up to the top-level directory; get rid of the <gtk/gtk.h>
include, in favor of a <glib.h> include.

svn path=/trunk/; revision=11499
2004-07-24 01:16:45 +00:00
Guy Harris d5425a709a Move the declaration of "create_color()" up to "color.h", so it's
declared in a toolkit-independent header file.  Get rid of
"gtk/color_utils.h", as there's nothing left in it.

svn path=/trunk/; revision=11498
2004-07-24 00:49:19 +00:00
Guy Harris 34de3c15d9 Have "gtk/color_utils.c" contain routines with toolkit-independent APIs,
but toolkit-dependent implementations, for manipulating colors, and have
"gtk/color_utils.h" declare them (the header file should eventually be
moved to the top-level directory).  Move the routines to convert between
GdkColor and color_t out of there into "colors.c", and move their
declarations into "colors.h", as their APIs are toolkit-dependent.

Have the first such routine be a "create_color()" routine, which takes
RGB values and initializes a "color_t", including doing any
toolkit-dependent work necessary for that; use that in the
"gtk/color_filters.c" code (the goal is to remove as many of the toolkit
dependencies as possible from that code, and move it to the top-level
directory).

svn path=/trunk/; revision=11497
2004-07-24 00:35:13 +00:00
Guy Harris 8f79902cb3 Get rid of unneeded include of "colors.h".
svn path=/trunk/; revision=11496
2004-07-24 00:34:04 +00:00
Guy Harris 60da1c89f0 Make "new_color_filter()" GUI-independent - have it take two "color_t"
pointers, for the background and foreground color, as arguments, and
have its callers generate them from GdkColor values.

svn path=/trunk/; revision=11495
2004-07-24 00:08:19 +00:00
Guy Harris f16fff888c "capture_combo_utils.{c,h}" don't use any GTK+ stuff, so move them to
the top-level directory.

svn path=/trunk/; revision=11494
2004-07-23 23:36:50 +00:00
Jörg Mayer 2d21f054ef Remove set -/+x - they were added for debugging and not intended for commit
svn path=/trunk/; revision=11493
2004-07-23 23:34:15 +00:00
Jörg Mayer e869dbb17d Trivial warning fixes:
- comma at end of enum
- function declarations with empty args instead of void
- c++ style comments

svn path=/trunk/; revision=11492
2004-07-23 23:28:08 +00:00
Ronnie Sahlberg e7172b423b add nice text item for the case when we could not find the dissector for a specific OID/attribute to make it easier to see where we have missed implementing something.
svn path=/trunk/; revision=11491
2004-07-23 23:12:31 +00:00
Ronnie Sahlberg 52d5646696 inside dissect_ber_sequence() we know the expected length of the field that follows.
use this and create a new tvbsubset so that
1, reading too much data is flagged as MALFORMED PACKET indicating a bug in the dissector (or a packet that IS malformed)
2, this also implicitely passes the length of the data through the ber.oid dissector handle in case we want to pick it up later.



svn path=/trunk/; revision=11490
2004-07-23 23:06:38 +00:00
Guy Harris bbbe995ddb Use "format_text()" on strings to be put into the Info column and the
display representation of items in the protocol tree, so we don't get
hosed by non-printable characters.

svn path=/trunk/; revision=11489
2004-07-23 22:39:08 +00:00
Gerald Combs c6c01ab4b1 Have distclean remove built sources.
svn path=/trunk/; revision=11488
2004-07-23 21:24:25 +00:00
Guy Harris 3d0e67cd4e Nothing here uses any GTK+ stuff, so get rid of the include of
<gtk/gtk.h>.  (It should ultimately be moved out of the gtk directory.)

svn path=/trunk/; revision=11487
2004-07-23 20:41:23 +00:00
Ronnie Sahlberg 19f12428b6 remove some more compiler warnings
svn path=/trunk/; revision=11486
2004-07-23 14:00:34 +00:00
Ronnie Sahlberg 0d59053844 make the implicit_tag parameter _U_ to get rid of some compiler warnings in those cases it is not used.
svn path=/trunk/; revision=11485
2004-07-23 13:21:48 +00:00
Ronnie Sahlberg 543c91b203 telex and telephone number attributes
svn path=/trunk/; revision=11484
2004-07-23 13:11:29 +00:00
Ronnie Sahlberg e4fdba9e02 Remove a compiler warning for a parameter that is not used
in the DirectoryString dissector


svn path=/trunk/; revision=11483
2004-07-23 12:22:13 +00:00
Guy Harris 46e1e52757 If there's no data in the authentication option, don't unescape and
tvbuffify it.

svn path=/trunk/; revision=11482
2004-07-23 08:36:07 +00:00
Ronnie Sahlberg b662cf7641 add all the other (quite a lot of them) attributes that were of the type DirectoryString
(see how good it is to put markers for emacs macros in the files, it was pretty quick, wasnt it? i even tested the resulting code.)


svn path=/trunk/; revision=11481
2004-07-23 08:21:51 +00:00
Guy Harris 89f9e1ee88 Use "col_append_str()" and "col_append_fstr()" to build the Info column,
rather than building a string, and use "tvb_format_text()" on the data,
so that non-printable characters are escaped.

svn path=/trunk/; revision=11480
2004-07-23 07:59:15 +00:00
Ronnie Sahlberg 1b0f6edbd9 add dissection of DirectoryString, this unfortunately had to be done manually inside the template.
Also implement the attribute  organizationName which is of this type.

(Add magic comments so emacs-macros will be happy.)


svn path=/trunk/; revision=11479
2004-07-23 07:46:12 +00:00
Ronnie Sahlberg 73f560c866 register ber oid functions through a special function in packet-ber.c which also takes (still unused) the name of the oid
so that sometime later it will be easy to add code to add the name of the oid to the dissection.



svn path=/trunk/; revision=11478
2004-07-23 07:08:14 +00:00
Guy Harris 267b501cae "iax_lookup_circuit_details()" can return null; check whether it's null
before using it.

svn path=/trunk/; revision=11477
2004-07-23 06:37:58 +00:00
Guy Harris f28323ba39 From Graham Bloice: add resources to wiretap.dll.
svn path=/trunk/; revision=11476
2004-07-23 06:11:50 +00:00
Guy Harris 43b2da02ae Note that you *MUST* make sure "match_strval()" doesn't return null
before using its value, or must check for a null return value and handle
it specially, otherwise you put Ethereal at risk of crashing with bad
packet data.

svn path=/trunk/; revision=11475
2004-07-23 01:37:35 +00:00
Guy Harris 90bbb2c32c We are not guaranteed that "fchdr.r_ctl & 0x0F" is a valid frame type,
so don't use "match_strval()", use "val_to_str()".

svn path=/trunk/; revision=11474
2004-07-23 01:32:42 +00:00
Guy Harris cbc46d3e98 "dissect_x509if_AttributeTypeAndDistinguishedValue()" is static - don't
declare it as non-static in the header file.

svn path=/trunk/; revision=11473
2004-07-22 20:08:08 +00:00
Ulf Lamping f6c9daa5ec use gtk_clipboard_get(), so the "copy to clipboard" is available in all GTK2 versions
svn path=/trunk/; revision=11472
2004-07-22 18:42:50 +00:00
Ulf Lamping cf51c277bb from Thomas Palmer: add "Copy to clipboard" button to the conversation table dialogs
svn path=/trunk/; revision=11471
2004-07-22 16:36:50 +00:00
Ronnie Sahlberg 744387f3ca add the countryname attribute
svn path=/trunk/; revision=11470
2004-07-22 13:11:13 +00:00
Ronnie Sahlberg f42a958398 start dissecting AttributeTypeAnddistinguishedValue
(which must be implemented by hand inside themplate)


svn path=/trunk/; revision=11469
2004-07-22 10:29:17 +00:00
Ronnie Sahlberg 283807bf4b dissect the x509if/Name all the way down to the AttributeTypeAndDistinguishedValue structure but not the structure itself.
we are getting there, slow but steady


svn path=/trunk/; revision=11468
2004-07-22 10:05:59 +00:00
Ronnie Sahlberg 7a3139b764 minor update
GeneralNames is defined in x509ce and not x509if


svn path=/trunk/; revision=11467
2004-07-22 08:00:33 +00:00
Ronnie Sahlberg ea5916772e minor update
UniqueIdentifier is imported from x509sat and not x509if


svn path=/trunk/; revision=11466
2004-07-22 07:51:47 +00:00
Jörg Mayer 769507d234 Fix the fix to krb5
svn path=/trunk/; revision=11465
2004-07-21 22:37:04 +00:00
Gerald Combs 83b366536a Add doxygen.cfg to the "clean" target.
svn path=/trunk/; revision=11464
2004-07-21 22:12:49 +00:00
Guy Harris 67f0f40bfa Include "packet-x509sat.h" to declare a function we use.
svn path=/trunk/; revision=11463
2004-07-21 19:23:18 +00:00