Commit Graph

81692 Commits

Author SHA1 Message Date
Guy Harris c263b0a13e macos-setup: if Xcode provides Python 3, use it.
Only install an external Python 3 if /usr/bin/python3 doesn't work; on
at least some versions of macOS, /usr/bin/python3 is a wrapper to run
Python 3 from Xcode, and at least some versions of Xcode provide Python
3.
2021-07-29 19:44:20 +00:00
João Valverde 0693674494 wslog: Add function to log directly without filtering
Used to write custom logging functions.
2021-07-29 20:17:44 +01:00
João Valverde 7b845e7194 wsutil: rename bytestring_to_str() -> bytes_to_str_punct() 2021-07-29 17:23:05 +00:00
João Valverde 177e5cda1f wsutil: Clean up unit test namespaces
Remove implicit root and separate tests for proper coverage.
2021-07-29 17:23:05 +00:00
João Valverde f0b02dd0ff wsutil: Add max length argument to bytes_to_str() 2021-07-29 17:23:04 +00:00
João Valverde 1ff6cc7b27 wsutil: Add some tests for bytes_to_str() 2021-07-29 17:23:04 +00:00
João Valverde c3bd5c9d91 Move bytes_to_str() to wsutil
This utility function is useful outside of epan. Move it to wsutil
and export the interface.

The move isn't completely clean as it requires duplicating two small
inline functions but that was necessary to avoiding moving too much at
once.
2021-07-29 17:23:04 +00:00
Martin Mathieson d34d1a1e13 More fussing with masks.
Mostly longer masks with odd numbers of digits.
2021-07-29 10:15:58 +00:00
Oscar Gonzalez de Dios 0b8acdaf68 Fixed trailing whitespaces 2021-07-29 07:32:34 +00:00
Oscar Gonzalez de Dios 0f3731449a Updated support to RFC 8664. SR-PCE CAPABILITY Sub-TLV has been added. SR-ERO subobject updated to RFC version: change ST to NT and, NAI of type NT=6 decoding added, updated flag values to official IANA values. Updated errors of Type 10 according to IANA assigned values and numbers. 2021-07-29 07:32:34 +00:00
David Perry 34ee3cbc48 Change some `wmem_packet_scope()` to `pinfo->pool`
As requested [here][1], help with replacing calls to
`wmem_packet_scope()` with references to `pinfo->pool`.

My principles were:

* Plugins chosen semi-randomly.
* When a calling function already has a `pinfo` argument, just use that.
    * Remove `_U_` from its signature if it was there.
* Don't go more than 2 or 3 levels deep of changing signatures.
* If a function is clearly allocing memory to return, change the
  function signature to take a `wmem_allocator_t *`. Otherwise, either
  that or take a `packet_info *` as seems to make sense.
* No mention of `wmem_packet_scope()` should remain in the files I've
  touched.
    * I didn't always succeed at this, but I made a dent.

[1]: https://www.wireshark.org/lists/wireshark-dev/202107/msg00052.html
2021-07-29 01:36:01 +00:00
João Valverde 0983eb2456 wslog: Avoid macro duplication 2021-07-29 01:52:39 +01:00
Gerald Combs 62c7734e64 Debian: Fixup our symbols.
wmem_epan_scope wmem_file_scope, and wmem_packet_scope are still in
epan.
2021-07-28 10:17:17 -07:00
Martin Mathieson 1c210185c3 ORAN FS CUS: Add section ext 11 2021-07-28 15:23:11 +00:00
Tomas Kukosa ab1b496194 ITS: use custom value format for DSRC elements Angle and Heading 2021-07-28 07:08:26 +00:00
Orgad Shaneh fa1f76a83f rtpdump: Fix usec value in header
usec is nsec / 1000.
2021-07-28 06:51:36 +00:00
ismaelrti 9b69d05c2f RTPS: UDPv4 Wan locator bitfied not dissected properly
UDPv4 WAN locator bitfield was using the wrong offset thus the data
shown was not correct.
2021-07-28 06:35:17 +00:00
Dylan Ulis a1e05d09c6 CIP: Updates to match current specification
1. Connection Manager parameter is called 'Redundant Owner' instead of 'Exclusive'
2. Add new CIP Class Names
3. Support new time types: UTIME, STIME, NTIME
4. Add units to data type
2021-07-28 06:18:56 +00:00
David Perry 6e8c7283d6 Change some `wmem_packet_scope()` to `pinfo->pool` 2021-07-27 21:36:43 +00:00
Gtker 6d8bfc146d WOWW: Refactor SMSG_CHAR_ENUM to use ptvcursor 2021-07-27 19:08:52 +00:00
Gtker 7e9e2dac0f WOWW: Convert body fields to use `ptvcursor`
This significantly reduces boilerplate required for adding fields.

The changes to SMSG_CHAR_CREATE from ENC_LITTLE_ENDIAN to ENC_NA are
intentional, as are the changes to CMSG_CHAR_RENAME from realm_name to
character_name.
2021-07-27 19:08:52 +00:00
Gtker f864dd7e9d WOWW: Use dots in abbreviations instead of underscores
As directed in PR.
2021-07-27 19:08:52 +00:00
Gtker 8fbf781a7f WOWW: Make abbreviations fit variable names 2021-07-27 19:08:52 +00:00
Gtker 1a2169acf5 WOWW: Add CMSG_CHAR_CREATE fields
Wiki reference:
https://wowdev.wiki/CMSG_CHAR_CREATE
2021-07-27 19:08:52 +00:00
Gtker 22694dffeb WOWW: Add CMSG_CHAR_RENAME field
Wiki reference:
https://wowdev.wiki/CMSG_CHAR_RENAME
2021-07-27 19:08:52 +00:00
Gtker eafb670ee1 WOWW: Add fields for SMSG_NAME_QUERY_RESPONSE
https://wowdev.wiki/SMSG_NAME_QUERY_RESPONSE
2021-07-27 19:08:52 +00:00
Gtker 1fe0f6d2e0 WOWW: Add fields that only require result
The `login_result` field is reused for all results, since there's
nothing about the field that makes it specific to logging in and the
same values can appear in all 3 fields.

Wiki reference:
https://wowdev.wiki/SMSG_CHAR_DELETE

https://wowdev.wiki/SMSG_CHAR_CREATE

https://wowdev.wiki/SMSG_CHARACTER_LOGIN_FAILED
2021-07-27 19:08:52 +00:00
Gtker d2af1dee46 WOWW: Add CMSG_PING and SMSG_PONG fields
Wiki reference:
https://wowdev.wiki/CMSG_PING

https://wowdev.wiki/SMSG_PONG
2021-07-27 19:08:52 +00:00
Gtker 159eaaa37a WOWW: Add SMSG_TUTORIAL_FLAGS fields
Wiki reference:
https://wowdev.wiki/SMSG_TUTORIAL_FLAGS
2021-07-27 19:08:52 +00:00
Gtker 706f940ca8 WOWW: Add fields that only require GUID
Wiki reference:
https://wowdev.wiki/CMSG_NAME_QUERY

https://wowdev.wiki/CMSG_SET_ACTIVE_MOVER

https://wowdev.wiki/CMSG_CHAR_DELETE

https://wowdev.wiki/CMSG_SET_SELECTION
2021-07-27 19:08:52 +00:00
Gtker e31baaf99b WOWW: Add SMSG_LOGIN_VERIFY_WORLD fields 2021-07-27 19:08:51 +00:00
Gtker 08ceeec81e WOWW: Fix multi message PDUs using incorrect data
Previously the offset into the decrypted header tvb was used, which was
always 4 or 6, instead of the offset into the entire PDU tvb.
2021-07-27 19:08:51 +00:00
Gtker 44ce2d5173 WOWW: Add CMSG_PLAYER_LOGIN fields 2021-07-27 19:08:51 +00:00
Gtker aa650610b4 WOWW: Add equipment values to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker a5bdac52a1 WOWW: Add pet family and first login to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker 9ea1b8f9ea WOWW: Add guild id and flags to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker 4c232104aa WOWW: Add character positions to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker d9f6c1e59e WOWW: Add map and zone to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker 49c5045728 WOWW: Add level to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker fccca6ee7b WOWW: Add character looks to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker b1e1d0b755 WOWW: Add class and gender to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker 6294bf5600 WOWW: Add character race to SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker 3fd67e6a0f WOWW: Add initial fields of SMSG_CHAR_ENUM 2021-07-27 19:08:51 +00:00
Gtker db8db29e0c WOWW: Add SMSG_AUTH_RESPONSE fields
The enum is used for other opcodes as well, including SMSG_CHAR_CREATE.

Wiki reference:
https://wowdev.wiki/SMSG_AUTH_RESPONSE

Wiki reference for enum:
https://wowdev.wiki/Account_Result_Values
2021-07-27 19:08:51 +00:00
Gtker 9663f6fcf3 WOWW: Add CMSG_AUTH_SESSION fields
Wiki reference:
https://wowdev.wiki/CMSG_AUTH_SESSION
2021-07-27 19:08:51 +00:00
Gtker 2252f76075 WOWW: Add SMSG_AUTH_CHALLENGE field body
Wiki reference:
https://wowdev.wiki/SMSG_AUTH_CHALLENGE
2021-07-27 19:08:51 +00:00
Jaap Keuter afb1aff845 RakNet: Fix address bytes highlighting
Closes #17509
2021-07-27 10:41:33 +00:00
Martin Mathieson a9c6e34958 NFAPI: Fix some spellings 2021-07-27 10:34:14 +01:00
Guy Harris c4d3716ce8 macos-setup: install the current version of Ninja.
1.10.2 is the latest version, and is the first version to ship as a fat
x86-64/ARM64 binary, so that we have native binaries for both platforms
supported by macOS.
2021-07-27 00:26:28 -07:00
Evan Huus d09fb571fe asn1: convert most dissectors to pinfo->pool
Part 2/2 as the commits were too big for CI.

Largely find/replace, with a few manual tweaks. Then regenerate the asn1
dissector sources and make sure everything still builds. There are a
handful of cases I skipped as too complex, but this covers most of the
asn1 dissectors.
2021-07-26 14:00:09 -04:00