Commit Graph

5133 Commits

Author SHA1 Message Date
Stephen Fisher a29a04f112 Traditional GtkTooltips deprecated at GTK+ 2.14 (and removed in 3.0), so
use the new functions when available. 


svn path=/trunk/; revision=35926
2011-02-12 00:27:47 +00:00
Stephen Fisher 1b2f2426e0 Remove #ifndef GSEAL_ENABLE hack to work-around the lack of an accessor
for a GSEALed variable since GTK 3.0 is out, which has the accessor.


svn path=/trunk/; revision=35917
2011-02-11 18:28:55 +00:00
Guy Harris e2bdef175d Add the rest of the changes from the patch in bug 5924. Squelches some
compiler warnings.

svn path=/trunk/; revision=35901
2011-02-10 20:27:35 +00:00
Gerald Combs ceb650ecee #ifdef → #ifndef.
svn path=/trunk/; revision=35900
2011-02-10 20:15:31 +00:00
Gerald Combs 66281f8744 Mark a parameter unused if needed.
svn path=/trunk/; revision=35899
2011-02-10 19:50:05 +00:00
Gerald Combs fb3055d41a Remove a bunch of prototypes in airpcap_dlg.h for functions which are
now static. Make another function static.

svn path=/trunk/; revision=35897
2011-02-10 17:09:36 +00:00
Stephen Fisher cf5aeb0c4c Fix compilation problem for GTK+ < 2.18
graph_analysis.c(1450): error C2039: 'allocation' : is not a member of
'_GtkStyle'


svn path=/trunk/; revision=35877
2011-02-08 04:12:09 +00:00
Guy Harris 7e6b4ad3a3 Build with pre-2.18 GTK+es.
svn path=/trunk/; revision=35874
2011-02-08 01:48:07 +00:00
Stephen Fisher e53853bea0 More -DGSEAL_ENABLE cleanup in preparation for GTK+ 3.0...
svn path=/trunk/; revision=35872
2011-02-08 01:01:50 +00:00
Stephen Fisher 09c49ac78c More -DGSEAL_ENABLE cleanup (hopefully without breaking anything)...
svn path=/trunk/; revision=35870
2011-02-08 00:56:22 +00:00
Jaap Keuter 104d4d80a2 Fix parameters to gtk_widget_get_allocation() call.
svn path=/trunk/; revision=35865
2011-02-07 22:11:14 +00:00
Gerald Combs c257693621 Switch from GtkCList (which is deprecated) to GtkTreeView+GtkListStore.
Make a bunch of functions static. Get rid of a no-longer-necessary
struct. Clean up other parts of the code.

svn path=/trunk/; revision=35862
2011-02-07 20:24:42 +00:00
Guy Harris 4efa18be22 Similar corrections here.
svn path=/trunk/; revision=35861
2011-02-07 19:43:18 +00:00
Guy Harris c66802f606 Fix typo.
svn path=/trunk/; revision=35856
2011-02-07 19:39:05 +00:00
Guy Harris e895aa9ddf "XXX takes a foo * as an argument" != "pass a variable of type foo * to
XXX"; in the case of gtk_widget_get_allocation(), you have to pass it a
pointer to a variable of type foo, where foo = GtkAllocation.

The same applies to the pre-GTK-2.18 code.

svn path=/trunk/; revision=35854
2011-02-07 19:37:51 +00:00
Stephen Fisher 3ef2acd516 More -DGSEAL_ENABLE cleanup in preparation for GTK+ 3
svn path=/trunk/; revision=35853
2011-02-07 19:24:26 +00:00
Stephen Fisher 95f99b60e4 More -DGSEAL_ENABLE cleanup in preparation for GTK+ 3
svn path=/trunk/; revision=35852
2011-02-07 19:21:45 +00:00
Stephen Fisher 75333216ee Fix crash introduced in r35849
svn path=/trunk/; revision=35851
2011-02-07 19:18:19 +00:00
Stephen Fisher 9d3586b4f5 And even more -DGSEAL_ENABLE cleanup for GTK+ 3.0 preparation...
svn path=/trunk/; revision=35849
2011-02-07 18:41:38 +00:00
Stephen Fisher 88ea7649d5 More -DGSEAL_ENABLE cleanup in preparation for GTK+ 3.0
svn path=/trunk/; revision=35848
2011-02-07 18:38:33 +00:00
Stephen Fisher 2b049e573d Some -DGSEAL_ENABLE cleanup in preparation for GTK+ 3.0
svn path=/trunk/; revision=35847
2011-02-07 18:37:11 +00:00
Martin Mathieson 7d6e4633e3 Disable error substring controls when show errors checkbox is disabled.
svn path=/trunk/; revision=35784
2011-02-03 17:41:45 +00:00
Bill Meier d3efa3ed9f A bit of Windows makefiles rework and cleanup:
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile;
  a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS;
  b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake)
      (This allows disabling "Warnings as Errors" by just changing config.nmake)
  c. CVARSDLL definitions (not usage) have been removed from the various makefiles.
     XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since:
     -DWIN32 and -DNULL=0 do not appear to be needed (any more);
     -D_MT and _D_DLL  are not needed since /MP causes these definitions.
  d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled.
     E.G., 4295: array is too small to include a terminating null character
- config.nmake: reformat some long lines for readability;
- plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile);
- dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ...

svn path=/trunk/; revision=35747
2011-02-02 01:19:53 +00:00
Anders Broman 6adf502aa7 Replace a couple of deprecated functions # ifdef:ed with the GTK version they are deprecated in.
svn path=/trunk/; revision=35740
2011-02-01 07:15:14 +00:00
Bill Meier 51bae2f9f8 Use {'0', ...} type initializer for fixed length character arrays.
svn path=/trunk/; revision=35735
2011-01-31 21:45:16 +00:00
Bill Meier ed78f0a33e Fix two cases of 'if (x = y)' which should be 'if (x == y)'.
Found by reviewing msvc level 4 warnings "assignment within conditional expression".

(Unfortunately most of the warnings are false positives so this warning can't be enabled)



svn path=/trunk/; revision=35726
2011-01-31 18:58:38 +00:00
Anders Broman 1d9fe2c424 Only define view_menu_auto_scroll_live_cb if HAVE_LIBPCAP
svn path=/trunk/; revision=35720
2011-01-31 13:58:36 +00:00
Anders Broman c9b96a9bfb Try to fix previous commit.
- menu.h commited by mistake
- new_packet_list.c missing

svn path=/trunk/; revision=35719
2011-01-31 13:52:32 +00:00
Anders Broman b7527dd063 From Cal Turney:
Bug 5621 - With String in Packet details searches, highlight row in tree 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5621

svn path=/trunk/; revision=35718
2011-01-31 12:19:15 +00:00
Stig Bjørlykke 502ddd6cdb Added filter autocomplete to "Edit Column Details".
svn path=/trunk/; revision=35717
2011-01-31 07:42:13 +00:00
Bill Meier 7f0107220d Fix various instances of "unreachable code".
svn path=/trunk/; revision=35713
2011-01-30 23:27:57 +00:00
Bill Meier 043e0e0bbf Don't compile non-used (unreachable) code on Windows.
svn path=/trunk/; revision=35712
2011-01-30 23:24:23 +00:00
Bill Meier b0d7bf821c Don't compile unused non-Windows code when on Windows.
(Found by msvc level 4 warning "unreachable code").

Also:
- suppress an invalid msvc level 4 warning by initializing a variable.
- Use #ifdef _WIN32 iso #if _WIN32


svn path=/trunk/; revision=35708
2011-01-30 22:23:45 +00:00
Stephen Fisher d6e70aa723 Improve r35695/35696 by repeating the whole function call in each
block of the #if / #else / #endif for clarity.


svn path=/trunk/; revision=35697
2011-01-29 07:47:03 +00:00
Bill Meier b96434a014 Fix Windows compile error(s);
{Compiles OK on Windows but not tested). 

svn path=/trunk/; revision=35696
2011-01-29 04:41:03 +00:00
Stephen Fisher bf8ce5c383 If we're compiling with GTK+ 2.14 or higher, use accessor function
gtk_color_selection_dialog_get_color_selection() instead of accessing
the struct member directly. 


svn path=/trunk/; revision=35695
2011-01-29 00:30:42 +00:00
Michael Tüxen cf46488ec4 From Irene Ruengeler: Double check that the interface specified in the
preferences still exists. If not, don't use it.

svn path=/trunk/; revision=35659
2011-01-26 15:15:20 +00:00
Bill Meier df985b7140 Fix crash when doing File ! Export ! Objects ! SMB.
[Essentially: simplify the code used to test for duplicate packets].
Fixes Bug #5337: http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5337

Also:
- Fix "divide by 0" which caused garbage for display of a percent value;
- Remove some unneeded #includes;

svn path=/trunk/; revision=35638
2011-01-24 18:59:26 +00:00
Bill Meier becab16f36 Fix a crash which can occur if a user hits "Capture:Options" immediately followed by "Capture:Start"
Fixes Bug #4645: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4645

Essentially: The "Capture Start" code "interrupted" the "Capture Options" code and attempted
 to use not yet initialized "Capture Options" state.

svn path=/trunk/; revision=35633
2011-01-23 20:59:12 +00:00
Bill Meier ce1313cc15 Reword some text about the accuracy of the dislayed values.
svn path=/trunk/; revision=35629
2011-01-23 17:29:06 +00:00
Stephen Fisher 73100c482b Resolve bug #2520 by moving the follow stream direction combo box above the
buttons to make more room for hostnames.


svn path=/trunk/; revision=35625
2011-01-22 17:42:40 +00:00
Stig Bjørlykke 09d5dd80c7 Set active combo_box entry before connecting the changed signal
to avoid a crash when opening the Import window.

svn path=/trunk/; revision=35620
2011-01-22 14:02:38 +00:00
Stig Bjørlykke fb4d2c059c Close dir opened by ws_dir_open().
svn path=/trunk/; revision=35618
2011-01-22 13:43:54 +00:00
Martin Mathieson 58fc79bb04 Add buttons to allow filtering only UL or DL on selected UE.
svn path=/trunk/; revision=35616
2011-01-22 03:49:23 +00:00
Jaap Keuter 2c4bf4d8fa Re-arrange help menu a bit to group website and wiki links.
svn path=/trunk/; revision=35613
2011-01-21 23:24:08 +00:00
Stephen Fisher fb645f7e28 Cast the returned value from strlen() to an int to make the Windows 64-bit
buildbot happy.


svn path=/trunk/; revision=35585
2011-01-19 19:42:00 +00:00
Stephen Fisher 347d0a77bf From Cal Turney via enhancement bug #5587: In hex or string searches of the
packet data highlight the target rather than the entire field.


svn path=/trunk/; revision=35584
2011-01-19 18:21:21 +00:00
Stephen Fisher 30b047223a From Cal Turney via bug #5585: When searching in packet bytes, the field and
bytes are not immediately shown.


svn path=/trunk/; revision=35583
2011-01-19 17:58:53 +00:00
Anders Broman bc80cd8155 Fix the broken Edit Menu when UImanager is used.
(UnmarkAllDisplayedPackets)

svn path=/trunk/; revision=35582
2011-01-19 14:55:15 +00:00
Bill Meier 180bb0c13f Remove redundant test for a non-null pointer;
svn path=/trunk/; revision=35570
2011-01-17 16:36:52 +00:00