Commit Graph

373 Commits

Author SHA1 Message Date
Chris Maynard 2eeb504807 From Klaus Heckelmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7221: Avoid wireshark crash on platforms where an 8 byte alignment is required by changing the resp_time field in the icmp_transaction_t from a double to an nstime_t.
svn path=/trunk/; revision=42393
2012-05-03 01:48:59 +00:00
Jakub Zawadzki 8a1dc57c03 Remove doubled semicolons and semicolons outside function.
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
Graham Bloice aa8c8f6dfd Added Rel. Start and Duration to tshark -z conv,xxx output. Tidied up duplicated code
svn path=/trunk/; revision=42037
2012-04-12 20:18:49 +00:00
Martin Mathieson 7054049bef Fix test to avoid dividing by 0.0 (was displaying as "-nan" rather than
crashing).

svn path=/trunk/; revision=41948
2012-04-05 00:53:01 +00:00
Jeff Morriss 75c3c92f19 Add a "-build" argument to checkAPIs.pl. Use that argument when building
from makefiles (and thus from the buildbot).

The intention is to be able to tell when a human is running the tool so we
can provide more code-review guidance.

As a starter, enable the "too many proto_tree_add_text() calls" check when
a human is running the tool.

svn path=/trunk/; revision=41943
2012-04-04 20:46:49 +00:00
Alexis La Goutte ba19f72aab Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41461
2012-03-10 17:45:17 +00:00
Anders Broman 1b7e7ea109 Try to make the buildbot happy
svn path=/trunk/; revision=41370
2012-03-06 09:24:49 +00:00
Anders Broman 3b06ee6ca0 From Cal Turney: Try to fix the remaining warnings. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6883
svn path=/trunk/; revision=41367
2012-03-06 08:45:54 +00:00
Anders Broman de47b36104 From Cal Turney:
Bugs in the tshark '-z io,stat' output:
1: The LOAD stat in the last row of the output is inaccurate because rpc.time
is divided by the full interval rather than limiting it to the capture
duration.
2: An The empty comma field (for outputting total frames and bytes) is ignored
when it is the first field in the command.
3: Intervals at the end of capture that contain no data are not displayed. Such
intervals are as important to see as those (zero data intervals) that occur
earlier in the capture. 
4: Floating point numbers are not properly aligned under their column headers.

Enhancements to '-z io,stat' output:
1. Column widths are determined by the maximum magnitude of their values rather
than set to a fixed width of 15 chars which allows for more stats to be
displayed per row without wrapping. 
2. To improve readability, filters wrap at 102 chars or the table width,
whichever is greater, and wrap on the nearest space. An option can be added to
alter the 102-char limit. 
3. Column numbers begin at 1 instead of 0.     
4. The columns and entire output are enclosed in a border for improved
presentability in reports. The table can be imported into a spreadsheet by
specifying the vertical bar as the data delimiter.

"Fixed" compiling on Ubuntu

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6883

svn path=/trunk/; revision=41355
2012-03-05 12:06:26 +00:00
Jeff Morriss 094e8f8947 Revert 41240, 41239, 41234, 41233, and (finally) 41231. Every time I fix a warning, 3 more pop up. Some of the uninitialized-variable ones look genuine and figuring them out would take a while.
svn path=/trunk/; revision=41241
2012-02-29 15:28:20 +00:00
Anders Broman ee38355eed Remove the offending %s for now.
svn path=/trunk/; revision=41240
2012-02-29 15:22:33 +00:00
Jeff Morriss 4a6e191973 Don't use itoa(). It still doesn't compile due to a format warning on line 760; like Martin, I'm not sure what is supposed to be there.
svn path=/trunk/; revision=41239
2012-02-29 15:04:06 +00:00
Martin Mathieson e7bd26af04 Fix another couple of warnings, but not sure what to do about the rest:
tap-iostat.c: In function ‘iostat_draw’:
tap-iostat.c:542:5: error: implicit declaration of function ‘itoa’
tap-iostat.c:756:9: error: too few arguments for format
tap-iostat.c:756:9: error: too few arguments for format

itoa() could be converted into a g_snprintf(), but the buffer used is only
one character long.  Is that right?

For the printf() format one, I'm not sure what was intended.


svn path=/trunk/; revision=41234
2012-02-29 10:25:44 +00:00
Martin Mathieson 86f0a7b80c Fix several compiler warnings (a few more remain though).
svn path=/trunk/; revision=41233
2012-02-29 10:19:32 +00:00
Anders Broman 9bdde5216f From Cal Turney:io,stat LOAD error, comma field ignored, zero data intervals not displayed, enhanced output https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6883
svn path=/trunk/; revision=41231
2012-02-29 05:49:18 +00:00
Bill Meier 605dea0486 CVARSDLL hasn't been used (is undefined) for a while....
svn path=/trunk/; revision=41180
2012-02-24 16:23:38 +00:00
Bill Meier d7ed0237c4 (Minor): use GLIB_CFLAGS instead of GTK_CFLAGS; also put libcliui: as first target
svn path=/trunk/; revision=41078
2012-02-19 23:30:03 +00:00
Guy Harris 7100e7a8a0 We already have GENERATED_HEADER_FILES; use that instead of
GENERATED_H_FILES.

If we have DIRTY_GENERATED_C_FILES, use it the same way we use
GENERATED_C_FILES.

GENERATED_FILES is "everything to nuke on a "make maintainer-clean"",
not "everything to put into the distribution".

svn path=/trunk/; revision=41075
2012-02-19 22:41:53 +00:00
Bill Meier ec953f91f2 A few more changes to fix the Windows build: Fix building tshark-tap-register.c
svn path=/trunk/; revision=41073
2012-02-19 21:38:48 +00:00
Guy Harris 30d168baa6 This is 2 levels down, unlike the 1-level-down ui/Makefile.nmake I
copied as an initial contents of this.

svn path=/trunk/; revision=41071
2012-02-19 19:28:31 +00:00
Guy Harris 2ae289a62e Build the TShark taps into a static libcliui library in the ui/cli
directory, and link TShark with that; let's see if this fixes the
Windows buildbots.

svn path=/trunk/; revision=41070
2012-02-19 19:01:01 +00:00
Guy Harris 9dc2cbdecc Move dftest.c back to the top-level directory; that way, all of the
stuff in ui/cli can be stuffed into a libcliui library to link with
TShark, and all of the source files containing main() (except for
Wireshark) are in the top-level directory (dftest isn't any more special
than TShark or capinfos or mergecap or editcap or...).

svn path=/trunk/; revision=41064
2012-02-19 05:57:14 +00:00
Jörg Mayer 35508464b2 Start moving files to ui/ and ui/cli/
svn path=/trunk/; revision=41047
2012-02-17 12:30:27 +00:00