Commit Graph

1851 Commits

Author SHA1 Message Date
Ronnie Sahlberg eb994de4cb change a g_malloc() that was never released into ep_alloc()
this function would always leak memory when called.

this fixes a memleak in dcm



svn path=/trunk/; revision=15352
2005-08-14 05:50:14 +00:00
Ronnie Sahlberg 675e61a8a4 ememify packet-x11
plug a memleak for ...].strptr   that is alloced by g_malloc() but never released.



svn path=/trunk/; revision=15351
2005-08-14 05:37:12 +00:00
Ronnie Sahlberg 185d5c2f04 giop allocates only and never releases the memory from the gmemchunk so replace it with equivalen g_malloc() calls and get rid of the gmemchunks
svn path=/trunk/; revision=15350
2005-08-14 01:48:43 +00:00
Ronnie Sahlberg 6411d20b50 the tds dissector were only using a GMemChunk as a simple way to prevent memleaks in case of an exception. (reset the gmemchunk at the start of each packet)
replace this gmemchunk with ep_alloc()


svn path=/trunk/; revision=15349
2005-08-14 01:41:55 +00:00
Ronnie Sahlberg f8d286b7e3 add dissection of two more SSC commands
add 4 commands from SMC to the SSC tables.
the fallback for missing commands/i.e. commands defined outside the SSC
only handles SPC   I.e.  If a command for SSC is missing in the SSC tables, assume it might be imported from SPC instead.

This fallback only works with opcodes imported from SPC.


svn path=/trunk/; revision=15345
2005-08-14 00:10:41 +00:00
Guy Harris fc9d3d4165 Use gboolean for Booleans.
Use "proto_tree_add_item()" whenever possible.

svn path=/trunk/; revision=15344
2005-08-13 22:35:50 +00:00
Guy Harris ebb23fbc68 Construct the tvbuff for the payload of an 802.3 packet to have the
appropriate length (min(reported length, captured data present)).

svn path=/trunk/; revision=15343
2005-08-13 22:34:44 +00:00
Guy Harris 79dcb408d3 Properly terminate the string generated for string items.
Use "format_text()" to handle non-printable characters in the display
string for those items.

svn path=/trunk/; revision=15342
2005-08-13 22:08:22 +00:00
Guy Harris 0fb64bd9cb Get rid of unused variables.
Use "tvb_format_text()" and friends to format strings for display.

Don't throw an exception on errors if we can keep dissecting.

Use "PROTO_ITEM_SET_GENERATED()" to mark items as generated.

If an item covers real data, it's not generated.

Dissect WRITE FILEMARKS (6) (we already had a dissector, but it wasn't
being used).

svn path=/trunk/; revision=15341
2005-08-13 22:05:01 +00:00
Gerald Combs 078df6ca6c Fix another infinite loop found by randpkt.
svn path=/trunk/; revision=15339
2005-08-13 18:49:57 +00:00
Anders Broman 5030bf580c Get rid of an unused variable, don't include tcap.h and remove some redundant code.
svn path=/trunk/; revision=15338
2005-08-13 10:17:20 +00:00
Anders Broman 1f31e083d2 From Peter Johansson:
mnc>>4; Should  be replaced with mnc = mnc>>4;

svn path=/trunk/; revision=15337
2005-08-13 10:11:23 +00:00
Guy Harris ccbb97ed45 Do the sequence number analysis *before* dissecting the payload, so we
don't have to worry about catching exceptions in the payload dissection
and doing the sequence number analysis - we weren't doing so in one
place.  That also puts the sequence number analysis *before* the "TCP
payload" entry for payload being reassembled into a later packet.

XXX - should we do the tapping before dissecting the payload, too, so
that it gets done even if we throw an exception?

svn path=/trunk/; revision=15335
2005-08-13 07:30:57 +00:00
Ronnie Sahlberg c30eeef7d8 some more gmemchunk -> se_alloc() updates
there are only 5 gmemchunks left   but they have different litetime for their allocations   than the 100+   ones that have been removed.

The remaining 5 should be converted some other way.




svn path=/trunk/; revision=15328
2005-08-13 01:29:31 +00:00
Ronnie Sahlberg 00f05d8892 gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15327
2005-08-13 00:03:12 +00:00
Ronnie Sahlberg 05dbe84db8 gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15326
2005-08-12 23:57:01 +00:00
Ronnie Sahlberg 5eda7935dd some gmemchunk -> se_alloc() improvements for tcp
svn path=/trunk/; revision=15325
2005-08-12 23:46:46 +00:00
Ronnie Sahlberg 9d17101f94 gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15324
2005-08-12 23:34:59 +00:00
Ronnie Sahlberg a6af4ea93e gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15323
2005-08-12 23:29:19 +00:00
Ronnie Sahlberg a1c541945e gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15322
2005-08-12 23:17:30 +00:00
Ronnie Sahlberg 4a3a614fd9 more gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15321
2005-08-12 23:00:01 +00:00
Jörg Mayer 8692baec8c Fix dissector bug on last element of ESRP
svn path=/trunk/; revision=15320
2005-08-12 22:55:58 +00:00
Ronnie Sahlberg 918b1eb805 more gmemchunk->se_alloc() improvements
svn path=/trunk/; revision=15319
2005-08-12 22:12:32 +00:00
Ronnie Sahlberg 3f0f7e1d3f gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15318
2005-08-12 21:29:06 +00:00
Ronnie Sahlberg 8bba9aa02b gmemchunk -> se_alloc() updates
svn path=/trunk/; revision=15317
2005-08-12 21:21:49 +00:00
Anders Broman 8b0ed89155 From Hannes Gredler
- add support for Multi-Link Frame-Relay (FRF.15) captures
  taken on Juniper ML-, LS-, AS- PICs.

- rework of the common juniper header dissector:
    test the extension flag (0x80) which indicates that there are
    meta-information like interface-index, interface-name etc.
    present

- minor bugfix (LSQ L3-proto masks, direction masks were broken)

svn path=/trunk/; revision=15316
2005-08-12 21:08:02 +00:00
Gerald Combs f7af2880e0 Don't try to allocate more than ITEM_LABEL_LENGTH bytes for something we're
adding to the tree.  Fixes bugs 349 and 352.

svn path=/trunk/; revision=15315
2005-08-12 16:32:28 +00:00
Gerald Combs 86d66bc85c Fix the length that we pass to proto_tree_add_uint_format() so that we don't
throw a dissector error.  Fixes bug 348.

svn path=/trunk/; revision=15314
2005-08-12 15:27:11 +00:00
Jörg Mayer c2c1614951 - Bug fix: Show ip-addresses with correct endianess.
- Show version properly
- VLAN ID was at a different place than expected.
- Add some documentation infos

svn path=/trunk/; revision=15313
2005-08-12 14:05:38 +00:00
Ronnie Sahlberg 234f09c663 more gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15312
2005-08-12 10:50:55 +00:00
Ronnie Sahlberg e9e87bb4a6 more gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15311
2005-08-12 10:41:22 +00:00
Ronnie Sahlberg 002f74031e more gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15310
2005-08-12 10:29:09 +00:00
Ronnie Sahlberg e00bf25af9 some more gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15309
2005-08-12 10:21:14 +00:00
Ronnie Sahlberg f6e45c9d5f remove some unused variables from scsi
change two gmemchunks in smtp to se_alloc() and remove one now redundant init routine.


svn path=/trunk/; revision=15308
2005-08-12 10:03:17 +00:00
Ronnie Sahlberg d3b675c2d6 add missing include to scsi
change two gmemchunks to se_alloc() for msproxy

svn path=/trunk/; revision=15307
2005-08-12 09:56:28 +00:00
Jörg Mayer 8a75a550de EDS/EAPS/EPRS mostly finished - several fixmes remain
svn path=/trunk/; revision=15306
2005-08-12 09:56:13 +00:00
Ronnie Sahlberg 0a06795b00 oops forgot to delete a variable
svn path=/trunk/; revision=15304
2005-08-12 09:31:07 +00:00
Ronnie Sahlberg ec7942851e get rid of some unnessecary GMemChunks.
These GMemChunks are used here because :
1, GMemChunks are cheap to allocate and cheap to free
2, We always unconditionally free the entire chunk When and only when we load a new capture.

==>
se_alloc() does exactly the same thing but with significantly less code

==>
se_alloc() is a much better fit to out allocation requirements and useage than GMemChunks



svn path=/trunk/; revision=15303
2005-08-12 09:30:24 +00:00
Michael Tüxen d1db771cec Fix handling of ASAP_ENDPOINT_KEEP_ALIVE message.
svn path=/trunk/; revision=15302
2005-08-12 09:16:51 +00:00
Guy Harris 960f9cb5e7 In an "address" structure, "data" is a pointer; dereferencing "&data"
doesn't give you the address value, it gives a pointer to the address
value.

Don't assume that pointer is aligned on a 32-bit boundary.

svn path=/trunk/; revision=15300
2005-08-12 07:47:27 +00:00
Jörg Mayer 86b6922604 Beginnings of a EDP, ESRP and EAPS dissector
svn path=/trunk/; revision=15299
2005-08-12 04:06:04 +00:00
Luis Ontanon 03c8023311 avoid throwing a malformed packet
svn path=/trunk/; revision=15298
2005-08-11 23:51:35 +00:00
Jörg Mayer 39e5ff4ed1 Add Extreme OUI, reorder alphabetically
svn path=/trunk/; revision=15297
2005-08-11 23:18:46 +00:00
Anders Broman 0c69d44dba From Rene Pilz:
The MCC/MNC in de_gmm_rai is not correct decoded

svn path=/trunk/; revision=15296
2005-08-11 20:47:09 +00:00
Anders Broman c61a9fddad From W. Borgert:
three trivial corrections for the GIOP dissector:

- allow filtering GIOP exceptions, e.g. "giop.replystatus = 2"
  or "giop.exceptionid matches MyError", older patch at
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314835

- show IDLs sequence<octet> more compact, not one line per
  octet, older patch at
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314836

- decode _is_a requests and replies, older patch at
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314871

With a change to not create a malformed packet in the "stub data".

svn path=/trunk/; revision=15295
2005-08-11 20:14:41 +00:00
Luis Ontanon 1480f629dc Change a switch into an "if else if else if else" that fixes the "too large for switch" in HP-UX 10.20 .
The generated file has a lot of indentation changes due probably to a change in asn2eth.

The underlying reason for which I added this code (dissect_ber_integer() would not add as a "filterable" field if it is larger than 4 bytes, should be handled in dissect_ber_integer() ) remains there.

Should we change dissect_ber_integer() itself to make sure that a 5 byte unsigned integer which fits in 4 bytes gets added to the tree as "filterable"?


svn path=/trunk/; revision=15294
2005-08-11 18:21:23 +00:00
Gerald Combs 699bd0fa60 Add checks for infinite loops. Fixes recent Buildbot failures.
svn path=/trunk/; revision=15292
2005-08-11 15:35:17 +00:00
Ronnie Sahlberg 1f0993e47e Fix for bug 342
If we encounter a frame we have already seen (i.e. visited==1)  but we can not fing the ISCSI command inside the _matched table, this just means there were no response pdu nor any data pdu with the S bit set.
So, then just pick the cdata structure up from the _unmatched table instead.

The SCSI CDB  dissector really really want a real CDATA structure passed to it.




svn path=/trunk/; revision=15291
2005-08-11 10:08:45 +00:00
Ronnie Sahlberg 030981ff55 We use heuristics to detect what MIGHT be onc-rpc packets.
as heuristics they are not 100% perfect, else they would not be heuristics.


IF the preference option "Dissect unknown RPC program numbers" are enabled,
add a sanity check to see that program_version is <=10
  (no one uses versions >10 ?)
to avoid trying to add 2 bilion different versions to the program->version linked list
in case we mistook the packet for ONC-RPC and the "version" field contains a huge random number.


This bug would only trigger a hang/crash IFF the option above is enabled.


svn path=/trunk/; revision=15290
2005-08-11 09:20:23 +00:00
Ronnie Sahlberg 216cc15b46 fix several bugs where we might dereference a null pointer
svn path=/trunk/; revision=15289
2005-08-11 08:15:52 +00:00