Commit graph

28077 commits

Author SHA1 Message Date
Bill Meier
174ce5633c From Kovarththanan Rajaratnam: Fixes for bug #3536
(plus some additional changes by me).

Handle BASE_RANGE_STRING display types properly

We always treat header field info strings as value_string's undiscriminated.
However, if the header field info display is marked as BASE_RANGE_STRING, we
need to treat them as range_string's. This wasn't properly handled in the
filter expression dialog and in the filter toolbar which would cause a crash
upon referencing any fields marked as BASE_RANGE_STRING.


svn path=/trunk/; revision=28931
2009-07-03 01:11:23 +00:00
Gerald Combs
5631122d1d Try to allocate enough memory on all platforms.
svn path=/trunk/; revision=28930
2009-07-03 00:17:06 +00:00
Michael Tüxen
3e74e4043d Get it compiling with -DNEW_PACKET_LIST on Mac OS X.
svn path=/trunk/; revision=28929
2009-07-02 22:04:22 +00:00
Stephen Fisher
5a241cb6ad Allow the new packet list's columns to be moved back
and forth while the packet list is open without having
to go into the preferences.  The new column ordering is
not saved for next time though.  Perhaps it should be.

svn path=/trunk/; revision=28928
2009-07-02 21:06:24 +00:00
Gerald Combs
88ba030310 From Kovarththanan Rajaratnam via bug 3567:
The template cache contains pointers that are session-scope (only freed in
netflow_reinit()) but still we use g_malloc(). This patch changes that so we
now use se_alloc(). With this patch I'm able to reproduce the crash
("Per-session memory corrupted").

svn path=/trunk/; revision=28927
2009-07-02 20:35:58 +00:00
Gerald Combs
2391d808af Update documentation links.
svn path=/trunk/; revision=28926
2009-07-02 20:35:46 +00:00
Guy Harris
9de2d18463 Don't dump out the raw link-layer type when noting that
KHciLoggerDatalinkTypeBCSP and KHciLoggerDatalinkTypeH5 aren't supported
- just explicitly say "BSCP" or "H5".

For unknown link-layer types, say "unknown or unsupported", as other
Wiretap modules do.

svn path=/trunk/; revision=28925
2009-07-02 20:10:05 +00:00
Michael Tüxen
be7b89aa49 Patch from Alex Badea for Bug 3645.
This fix will be included in Wireshark 1.2.1.

svn path=/trunk/; revision=28924
2009-07-02 19:52:47 +00:00
Gerald Combs
bfa7074d82 mkstemp cleanups.
svn path=/trunk/; revision=28923
2009-07-02 19:50:35 +00:00
Anders Broman
f0219f88ef This time with the comment...
svn path=/trunk/; revision=28922
2009-07-02 18:24:26 +00:00
Anders Broman
7629c688db Don't resort the list for every row, the list will be in packet order any way. And "clicking" on the column titles will resort the list.
svn path=/trunk/; revision=28921
2009-07-02 18:22:41 +00:00
Gerald Combs
72a20c1695 Pull mkstemp() into tempfile.c. That's the only place we use it now, and
it's arguably the only place we _should_ use it. Add create_tempdir() to
tempfile.c and use it to create a temp directory for IP maps. This
should fix bug 3530.

(This still doesn't work on IE 8 / Vista here. IE gives an access denied
error in OpenLayers.js, but this is a separate issue).

svn path=/trunk/; revision=28920
2009-07-02 17:20:27 +00:00
Anders Broman
9952ce524f From Radek Vokál:
Support for new NFSv4 features.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3258

svn path=/trunk/; revision=28919
2009-07-02 16:54:20 +00:00
Stig Bjørlykke
110a1e9753 Move updating menus with new recent values to a point after we have created
the new packet list, because we relay on the columns for time values.

This fixes bug 3640.

svn path=/trunk/; revision=28918
2009-07-02 09:08:11 +00:00
Stig Bjørlykke
75a8a15e2b From Albert Chin:
Small patch to make it compile on AIX.

svn path=/trunk/; revision=28917
2009-07-02 06:51:27 +00:00
Gerald Combs
1f6ad93f9f Fix the build.
svn path=/trunk/; revision=28916
2009-07-02 02:50:24 +00:00
Gerald Combs
e0ebc32195 Updates to create_tempfile:
- Use g_get_tmp_dir, just like get_tempfile_path.
  - Don't make the caller worry about the path buffer length.

svn path=/trunk/; revision=28915
2009-07-01 23:36:51 +00:00
Gerald Combs
e2890d4053 Fix a couple of labels.
svn path=/trunk/; revision=28914
2009-07-01 23:36:35 +00:00
Stig Bjørlykke
581d804ce5 Added error value tables.
svn path=/trunk/; revision=28913
2009-07-01 21:20:18 +00:00
Gerald Combs
a66905c3d2 Add a couple of IPFIX labels where they differ from Netflow.
svn path=/trunk/; revision=28912
2009-07-01 20:56:03 +00:00
Gerald Combs
0aaad68faf Try to fix fuzzing errors in bug 3636. When dissecting an options
template, differentiate between Netflow v9 and IPFIX, which require
different interpretations. Add other minor fixes and comments.

svn path=/trunk/; revision=28911
2009-07-01 19:36:24 +00:00
Guy Harris
3de850b274 Thou shalt not call assert() in dissectors.
svn path=/trunk/; revision=28910
2009-07-01 17:40:08 +00:00
Anders Broman
f0fbf120f2 Realy make the new packet list compile under Windows...
svn path=/trunk/; revision=28909
2009-07-01 17:39:19 +00:00
Gerald Combs
bdd6f6345d Fix a key entry bug in the decryption key dialog. Remove some unused /
unnecessary functions. Clean up code in a couple of places.

svn path=/trunk/; revision=28908
2009-07-01 15:56:12 +00:00
Anders Broman
3fe0c34110 Make the new packet list compile on Windows.
svn path=/trunk/; revision=28907
2009-07-01 14:37:02 +00:00
Anders Broman
39139dc75c Sligtly modify Stig's fix, I forgot the makefile change :-(
svn path=/trunk/; revision=28906
2009-07-01 11:40:24 +00:00
Stig Bjørlykke
8324323784 Try to fix HAVE_NEW_PACKET_LIST handling.
svn path=/trunk/; revision=28905
2009-07-01 11:12:58 +00:00
Stig Bjørlykke
58eba2d80c Added NEW_PACKET_LIST guard for new_packet_list.h
svn path=/trunk/; revision=28904
2009-07-01 09:05:13 +00:00
Anders Broman
ddad90c3e3 Make it possible to configure use of NEW_PACKET_LIST and fix
one compile error. It still fails in file.c trying to include gtk/gtk.h in new_packet_list.h

svn path=/trunk/; revision=28903
2009-07-01 08:23:32 +00:00
Stig Bjørlykke
c18998e9c0 Added support for Simulcrypt EMMG <-> MUX,
and generic support for other interfaces.

svn path=/trunk/; revision=28902
2009-07-01 07:21:13 +00:00
Jörg Mayer
6425275b89 - Put ISMP.EDP into the protocol column to make it clearer
that filtering on edp is not going to help
- Make it possible to filter on ismp.edp
- In case of edp fill info column

svn path=/trunk/; revision=28901
2009-07-01 05:27:34 +00:00
Guy Harris
fe767063a7 Replace one assert() with DISSECTOR_ASSET(), so we don't crash, and get
rid of another, as the pointer in question is non-null in all calls (if
somebody adds another call with a null pointer, it'll crash when
dereferencing the pointer in any case).

svn path=/trunk/; revision=28900
2009-06-30 23:56:26 +00:00
Guy Harris
bc57dc2d75 Don't crash if a null pointer is passed, just skip the appending of the
items.

svn path=/trunk/; revision=28899
2009-06-30 23:52:20 +00:00
Guy Harris
db08b1f783 Get rid of assert() call; either the pointer will never be null, in
which case it won't crash, or it will be null, in which case that just
trades one crash for another, and we should fix the crash.

svn path=/trunk/; revision=28898
2009-06-30 23:49:34 +00:00
Gerald Combs
4f19e431b7 Add some length checks. Fixes bug 3567.
svn path=/trunk/; revision=28897
2009-06-30 20:59:51 +00:00
Gerald Combs
c66d0e4a6f Add assert and assert_perror to the 'abort' list.
svn path=/trunk/; revision=28896
2009-06-30 20:28:26 +00:00
Bill Meier
6e2bd7cc03 From: Benjamin Roch: Enhancements and small fixes for packet-tte.c dissector;
Also: a few minor mostly formatting changes by me.

svn path=/trunk/; revision=28895
2009-06-30 19:52:43 +00:00
Guy Harris
3706f913f0 Fix typo.
svn path=/trunk/; revision=28894
2009-06-30 19:10:11 +00:00
Guy Harris
104b74d068 Fix typo.
svn path=/trunk/; revision=28893
2009-06-30 19:09:18 +00:00
Stephen Fisher
e6d0686f7b Introduce experimental new feature: GTK2 tree view based packet list
To use the GTK2 based packet list, define NEW_PACKET_LIST when compiling.
To do this with gcc, set the environment variable CPPFLAGS to
"-DNEW_PACKET_LIST" and re-run configure.

Many features do not yet work.  This work began with prototypes by Ulf
quite a while back.  I've put quite a bit of work into this so far and
as discussed with a few of the core team members at Sharkfest09 and it was
decided that it would be best to commit what I have so far to allow others to
help work on this.


svn path=/trunk/; revision=28892
2009-06-30 18:05:04 +00:00
Bill Meier
92446c8005 packet-radius: Fix exception CLEANUP handling when malformed attribute list/pair seen;
Fixes crash reported in Bug #3578. [https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3578]
Essentially: CLEANUP_CALL_AND_POP wasn't being executed for certain error exits from
 dissect_attribute_pairs() thus leaving a CLEANUP entry on the exception stack.
Also: vsa_buffer_table wasn't being destroyed if an exception occurred in dissect_attribute_pairs.

svn path=/trunk/; revision=28891
2009-06-30 13:57:26 +00:00
Stig Bjørlykke
a01a94d02b Always register to tcp.port to be able to decode as.
svn path=/trunk/; revision=28890
2009-06-30 12:26:11 +00:00
Stig Bjørlykke
4721f29558 Changed check for having multiple ldap PDU's in one frame.
The previous check is incorrect when the first ldap frame in the capture is
selected and the filter is changed, or selecting "Follow TCP Stream".

Also removed check_col().

svn path=/trunk/; revision=28889
2009-06-30 10:38:00 +00:00
Stig Bjørlykke
942b03f06e Cleanup protocol name for ldap.
svn path=/trunk/; revision=28888
2009-06-30 08:28:21 +00:00
Guy Harris
491eed02a9 Put in missing newline at the end.
svn path=/trunk/; revision=28887
2009-06-30 00:32:20 +00:00
Gerald Combs
e8f4577ab8 Fix a couple of AirPcap channel/offset bugs. Remove an unused
routine. Fixup whitespace in a couple of places.

svn path=/trunk/; revision=28886
2009-06-29 23:08:05 +00:00
Balint Reczey
aa2c87df87 Added option to show not dissected packet data on a separate packet bytes pane.
It makes offsets in the not dissected data easier to follow.

svn path=/trunk/; revision=28885
2009-06-29 22:22:30 +00:00
Bill Meier
ec28353bb4 From Kovarththanan Rajaratnam: Fix for Bug #3572
[http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3572]

svn path=/trunk/; revision=28884
2009-06-29 20:59:26 +00:00
Jörg Mayer
dcd823565b Add value for vfstate: active
svn path=/trunk/; revision=28883
2009-06-29 20:35:47 +00:00
Stig Bjørlykke
bb810ef093 WiresharkPortable.ini -> WiresharkPortable.tmpl
svn path=/trunk/; revision=28882
2009-06-29 20:16:20 +00:00