e8fed416a2
Another change that should have been part of r50465, which removed the limits to the number of characters in the display filter(s). [Technically, there is still the inherent 65535 limit.]
...
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=50469
2013-07-09 18:01:44 +00:00
9c9864976f
Use sizeof() instead of hard-coded values. Other minor whitespace cleanup.
...
svn path=/trunk/; revision=50466
2013-07-09 16:58:07 +00:00
dacf47c217
Remove the advanced filter field arbitrary text limit of 100 and remove the filter field arbitrary text limit of 256.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8909
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=50465
2013-07-09 16:44:47 +00:00
bbf7636e61
From Cal Turney:
...
Wireshark crashes when switching from a v1.11.0 profile to a v1.4.6 prof and then to a v1.5.1 profile.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8884
#BACKPORT 1.10
svn path=/trunk/; revision=50455
2013-07-09 04:22:43 +00:00
59644b3899
New Qt feature: Show related packet list items in the frame number
...
column. Conversation spans (setup frame to last frame) are shown with a
square bracket. Linked frames are shown with a circle.
Use correct column justifications in Qt. Move common
justification-related packet list code to ui/packet_list_utils.[ch].
Add a last_frame element to conversation_t.
svn path=/trunk/; revision=50447
2013-07-08 16:54:18 +00:00
36d3734dcb
From Jim Young via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8906 :
...
This patch augments Wireshark's and tshark's augument usage reports (-? and
-t?) and the Wireshark and tshark man pages to list all available timestamp
options available for the -t option.
svn path=/trunk/; revision=50445
2013-07-08 16:25:13 +00:00
792f35a28c
Make tree_is_expanded array static, add setter/getter function.
...
svn path=/trunk/; revision=50433
2013-07-07 16:33:49 +00:00
337ad423c1
From Peter Hatina via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8888
...
We're allocating an array of pointers, not an array of objects, so make the
sizeof() reflect that to avoid over-allocating.
svn path=/trunk/; revision=50423
2013-07-06 21:55:10 +00:00
218608f1a2
Count SDUs even when dumping only the MAC header
...
svn path=/trunk/; revision=50420
2013-07-06 21:07:42 +00:00
88ae57458f
Attachment #11134 proposed as fix for bug #8899 by Peter Hatina
...
svn path=/trunk/; revision=50341
2013-07-03 14:12:44 +00:00
b2788e5687
Preserve symlinks when copying libraries into the application bundle on
...
OS X so that it doesn't become excessively large.
svn path=/trunk/; revision=50317
2013-07-02 18:26:52 +00:00
ff8842c865
Fix Coverity CID 1037114 (Dereference before null check).
...
svn path=/trunk/; revision=50298
2013-07-01 15:20:02 +00:00
43442af8e3
Define certain 'const char *...' arrays as static.
...
(That is: Don't create the array on the stack each time
the function is called).
Reduces code memory usage and execution time.
(See SVN #50271 )
svn path=/trunk/; revision=50295
2013-07-01 14:32:08 +00:00
f426c3cd45
Consistently maintain the callState member of an iax2_info_t structure
...
as a voip_call_state value; don't have it sometimes a voip_call_state
and sometimes a frame subtype.
This should squelch some complaints from newer versions of Clang about
unnecessary array-bounds checks - the array-bounds checks are done on
frame subtypes, where they *are* necessary (nothing prevents an
untrustworthy IAX2 implementation or an untrustworthy capture file
writer from putting an arbitrary value in the packets), not on
voip_call_state values (where it was only necessary because the value
wasn't, in that case, a voip_call_state value, it was a frame subtype
cast to a voip_call_state).
svn path=/trunk/; revision=50277
2013-07-01 02:51:48 +00:00
397ab1dbb7
Fix indent (Tabs => Spaces) and add modelines info for follow_* files
...
svn path=/trunk/; revision=50245
2013-06-29 22:01:01 +00:00
b5187b496b
Use newly assigned DLT for PDU export functionality
...
svn path=/trunk/; revision=50212
2013-06-28 13:05:12 +00:00
277aed869e
Make colors used by colorize_filter_te_as_* as preferences. Bug 5413 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5413 )
...
svn path=/trunk/; revision=50203
2013-06-28 03:03:36 +00:00
24a5467228
Propagate the main_window_update change of few commits ago into the qt client
...
:wq
svn path=/trunk/; revision=50198
2013-06-27 19:24:39 +00:00
16fc2c5998
Remove a no-longer-used variable.
...
svn path=/trunk/; revision=50194
2013-06-27 18:44:11 +00:00
7f5d688bda
Windows changes for main_window_update ....
...
svn path=/trunk/; revision=50192
2013-06-27 17:45:07 +00:00
1895c1c5a0
cleanup, use packet_list_iter_nth_child() in another place.
...
svn path=/trunk/; revision=50189
2013-06-27 17:12:23 +00:00
0bdc0efc46
get main_window_update out of the way... pass an update_cb to the capture_sync stuff
...
... as per the XXX comment removed from tshark.c this was a mess to keep the linker
happy... I couldn't!
I did this without even understanding whether calling main_window_update was realy
necessary in most cases. I guess nothing or more specific update cbs would be best.
svn path=/trunk/; revision=50188
2013-06-27 17:10:50 +00:00
97d59088b0
#gtk #packet-list simplify, use gtk_tree_view_column_add_attribute() for text attribute.
...
svn path=/trunk/; revision=50176
2013-06-26 22:03:57 +00:00
0426c05d49
packet-editor: Allow focus for byteview, it should fix problems with field hexeditor not getting key-press-event.
...
Generally it should be also safe for builds without packet-editor, just in case ifdef it.
svn path=/trunk/; revision=50172
2013-06-26 17:15:25 +00:00
500d399393
Move tap-*-common.{h,c} into ui/ since that's the home for common UI functions.
...
svn path=/trunk/; revision=50165
2013-06-26 02:12:12 +00:00
bbf6a3766e
Move tempfile.{h,c} into wsutil.
...
svn path=/trunk/; revision=50163
2013-06-26 01:14:35 +00:00
74dc568ef1
As pointed out by Guy: timestats uses packet_info so it belongs in epan
...
not wsutil.
svn path=/trunk/; revision=50159
2013-06-26 00:18:44 +00:00
2259c5c47d
There's no need to compile timestats.c any more--it's now in libwsutil.
...
svn path=/trunk/; revision=50157
2013-06-25 23:34:07 +00:00
a441793cba
Move a couple of time-related modules into wsutil.
...
A bunch of files didn't really need to include these header files so remove
the include line rather than changing it.
svn path=/trunk/; revision=50154
2013-06-25 22:02:20 +00:00
847fbeefdb
Fix build with packet editor enabled. (Fix a typo while we're at it.)
...
svn path=/trunk/; revision=50153
2013-06-25 21:45:56 +00:00
f0c9b34b55
Allocate memory for col_text[_len] when really needed
...
remove columnized bit, now the same can be done with col_text.
svn path=/trunk/; revision=50144
2013-06-25 18:27:31 +00:00
f56d9b49b3
packet_list_iter_children() simplify, just call packet_list_iter_nth_child(..., 0)
...
svn path=/trunk/; revision=50143
2013-06-25 18:07:33 +00:00
ca99b7a50a
Cast away another implicit conversion not allowed in C++ warning
...
svn path=/trunk/; revision=50109
2013-06-21 22:37:40 +00:00
eb0d10c9d2
Sort the man pages. Add capinfos and reordercap. Should we also any others (i.e., asn2deb, dftest, idl2deb, idl2wrs, randpkt)?
...
svn path=/trunk/; revision=50107
2013-06-21 15:30:08 +00:00
50bc11bc14
One more fix for the protocol grey highlighting.
...
svn path=/trunk/; revision=50100
2013-06-21 00:49:35 +00:00
2bd2bfb416
Yet another fix, put spaces in insensitive or normal state.
...
svn path=/trunk/; revision=50099
2013-06-21 00:42:19 +00:00
135ecc1d88
fix for r50095 don't fetch parent hfinfo, traverse tree to get top one.
...
svn path=/trunk/; revision=50098
2013-06-21 00:23:55 +00:00
1b69a2b3c8
Highlight protocol bytes in grey, idea stolen from qtshark
...
svn path=/trunk/; revision=50095
2013-06-20 23:28:35 +00:00
879d865039
Sort the encapsulation type combo box similar to the GTK change in r50077.
...
svn path=/trunk/; revision=50081
2013-06-20 18:07:54 +00:00
2dab2c8102
Fix file_import_dlg.c:132: warning: useless storage class specifier in empty
...
declaration
I guess anonymous enums can't be static?
svn path=/trunk/; revision=50079
2013-06-20 16:44:46 +00:00
9229a5eeb3
Sort the list of encapsulation types, but still have Ethernet be the default.
...
svn path=/trunk/; revision=50077
2013-06-20 16:40:46 +00:00
88a4c49bf7
update the button in the status bar when a packet comment is added
...
(this is a quick fix, the case when the last comment is removed
is still not handled correctly)
svn path=/trunk/; revision=50069
2013-06-19 23:37:38 +00:00
8411a601df
Implement bug 8675: show stream id in follow TCP stream window.
...
svn path=/trunk/; revision=50067
2013-06-19 23:27:12 +00:00
21a682ea24
Fix for bug 6090. Clear the list store when resetting the dialog.
...
svn path=/trunk/; revision=50064
2013-06-19 22:57:39 +00:00
3369a97da7
If the user turns off printing of the packet summary line, disable the column headings checkbox; otherwise, enable it.
...
svn path=/trunk/; revision=50053
2013-06-19 19:16:35 +00:00
ba951e1a4d
Try to make it more obvious that you can select unselected task list
...
items.
svn path=/trunk/; revision=50052
2013-06-19 18:48:20 +00:00
f655e90d8b
Remove col_headings_cb from print_cmd_toggle_detail() altogether. It's not needed since if summary isn't printed, neither are column headings anyway.
...
svn path=/trunk/; revision=50051
2013-06-19 18:44:42 +00:00
50da1aacf9
Try and keep r50047 and still fix
...
print_dlg.c:916: warning: value computed is not used
svn path=/trunk/; revision=50050
2013-06-19 18:38:52 +00:00
95a68da158
Fix for
...
Building C object ui/gtk/CMakeFiles/gtkui.dir/print_dlg.c.o
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/print_dlg.c: In function ‘print_cmd_toggle_detail’:
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/print_dlg.c:910:38: error: variable ‘col_headings_cb’ set but not used [-Werror=unused-but-set-variable]
GtkWidget *print_bt, *summary_cb, *col_headings_cb, *details_cb;
^
cc1: all warnings being treated as errors
No idea wether the fix is correct. Compile tested only.
svn path=/trunk/; revision=50047
2013-06-19 18:30:04 +00:00
909d2eb309
Allow for column headers not to be printed in order to make it possible to export packets as plain text in a format that could then have a chance of being imported again (assuming other factors such as packet bytes were printed, etc.) in order to recover the original pcap file.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1636
svn path=/trunk/; revision=50036
2013-06-19 15:22:56 +00:00
Chris Maynard