Commit graph

13880 commits

Author SHA1 Message Date
Gerald Combs
c92c1df4a4 Try not to call proto_tree_add_text() with negative lengths in error messages.
svn path=/trunk/; revision=14018
2005-04-05 14:40:59 +00:00
Ronnie Sahlberg
573ba4ee40 From Francisco Alcoba
patch for viop analysis to fix the breakage from the tap reordering patch



svn path=/trunk/; revision=14017
2005-04-05 08:14:58 +00:00
Gerald Combs
b170e98255 Add length checks so that we don't overflow buffers.
svn path=/trunk/; revision=14016
2005-04-04 21:44:53 +00:00
Ronnie Sahlberg
79b30e6df5 From Lars Ruoff
Make it possible to tap 4 PDUs from one frame


svn path=/trunk/; revision=14015
2005-04-04 20:12:18 +00:00
Gerald Combs
8b95cd38d5 Don't generate a "dissector bug" warning in cases where a dissector calls
proto_tree_add_*(tree, tvb, offset, 0, ...);

and "offset" is greater than the length remaining in the tvbuff.

svn path=/trunk/; revision=14014
2005-04-04 18:10:42 +00:00
Ronnie Sahlberg
f16afe28a9 From Cvetan Ivanov
Updates to Q931, SM and ISUP


svn path=/trunk/; revision=14013
2005-04-04 07:40:07 +00:00
Ronnie Sahlberg
38fd4be564 the definition of tcp address structure changed between version 3 and version 4
make version 4 dissect tcp addr structure properly



svn path=/trunk/; revision=14012
2005-04-04 05:56:57 +00:00
Ronnie Sahlberg
882f734f34 From Kenny Shumard
Update for IAX2


svn path=/trunk/; revision=14011
2005-04-04 05:10:45 +00:00
Ronnie Sahlberg
088f70bb53 From Martin Mathieson
small update for SIP request/response matching.



svn path=/trunk/; revision=14010
2005-04-04 04:51:47 +00:00
Ronnie Sahlberg
d430320b6a the netware dissector is the only dissector that accesses fvalue_ functions directly.
this made it crash for some packets when the filter speedup patch was enabled, since some of these finfo nodes did no longer exist.

as far as i can tell the only other instances of fvalue_ usage is from some tap based functions but all those do take care to make sure that the fields being accessed are all part of a filter, and will thus never be optimized away.

The patch does two things

1, refactor the code but do not change the logic to reduce the number of places where the external fvalue_ functions are called from.

2, add code to force the tree to be visible (and thus change the code) so that the speedup patch will not optimize these fiuelds away.




svn path=/trunk/; revision=14009
2005-04-04 04:14:41 +00:00
Gerald Combs
f52c3c3a14 Add a couple of length checks.
svn path=/trunk/; revision=14008
2005-04-04 03:01:40 +00:00
Guy Harris
9f0d946003 Fix up the table of encapsulation type strings to match the new set of
encapsulation types.

svn path=/trunk/; revision=14007
2005-04-03 12:05:05 +00:00
Guy Harris
466c3e9c8d Make editcap use wtap_read(); that eliminates the last user of
wtap_loop(), so eliminate wtap_loop().

svn path=/trunk/; revision=14006
2005-04-03 11:00:49 +00:00
Anders Broman
951b7c9aaa From Tim Endean:
1) Return errors.
 2) Return rejects.
 
 Numerous other bugs fixed.
 

svn path=/trunk/; revision=14005
2005-04-02 18:51:38 +00:00
Anders Broman
72f015771b From Tim Endean:
1) Return errors.
 2) Return rejects.
 
 Numerous other bugs fixed.
 

svn path=/trunk/; revision=14004
2005-04-02 18:50:57 +00:00
Ronnie Sahlberg
fb1ac828aa from Jeremy Jouglet
some GTP updates  and some tips for those using cygwin


svn path=/trunk/; revision=14003
2005-04-01 21:23:40 +00:00
Ronnie Sahlberg
61e984ffaf update for padbyte on old juniper boxens
svn path=/trunk/; revision=14002
2005-04-01 21:04:55 +00:00
Ronnie Sahlberg
448191721c from Lars R
TAP order of caller update


svn path=/trunk/; revision=14001
2005-04-01 20:55:33 +00:00
Ronnie Sahlberg
305d4cc151 tiny bugfix for gsmmap
svn path=/trunk/; revision=14000
2005-04-01 11:12:32 +00:00
Ronnie Sahlberg
3b435e70a3 From Mark C Brown NETTL updates
svn path=/trunk/; revision=13999
2005-04-01 10:17:05 +00:00
Guy Harris
d549b4456e Give it an RCS ID.
Set the svn:keywords and svn:eol-style properties to the standard values.

svn path=/trunk/; revision=13998
2005-04-01 10:04:32 +00:00
Ronnie Sahlberg
08d7106984 From Giles Scott
New protocol  ARUBA ADP


svn path=/trunk/; revision=13997
2005-04-01 09:48:34 +00:00
Guy Harris
df8cbd0dfc From Charlie Lenahan: support for some HP switch protocol.
Fix some damage to the AUTHORS file.

svn path=/trunk/; revision=13996
2005-04-01 09:43:19 +00:00
Guy Harris
e611516763 Get rid of an unused variable.
Include "packet-gsm_map.h", not "packet-gsm_map.c".

Check in the regenerated CAMEL dissector.

svn path=/trunk/; revision=13995
2005-04-01 09:20:39 +00:00
Guy Harris
bed220604d "get_conv_info()" doesn't use the tvbuff passed to it, so don't pass it
one.

svn path=/trunk/; revision=13994
2005-04-01 09:19:29 +00:00
Guy Harris
80c1907a36 Rename "register_ethereal_tap()" to "register_tap_listener_cmd_arg()" as
it's used to register a callback for a tap listener invoked if the
specified command line argument is specified to the "-z" flag.

Move it, along with routines to:

	look up a "-z" argument in the table constructed by
	"register_tap_listener_cmd_arg()" and either save the full
	argument to "-z" and the corresponding listener if it's found or
	return a failure indication if it isn't;

	list the available tap listeners;

	call the "init" routines for the tap listeners saved in the
	table above;

and have Ethereal and Tethereal use those routines.

svn path=/trunk/; revision=13993
2005-04-01 09:08:27 +00:00
Guy Harris
0f8018692f Edits, update to current "all GTK+ stuff is common" state.
svn path=/trunk/; revision=13992
2005-04-01 08:47:42 +00:00
Guy Harris
910ad32b3b Don't assume only one "-z" argument will be given on the command line;
add information for each tap to a list, and set up all the taps in the
list.

svn path=/trunk/; revision=13991
2005-04-01 05:45:08 +00:00
Guy Harris
31954877ca Give the RFC number for IGMPv3.
svn path=/trunk/; revision=13990
2005-04-01 04:19:28 +00:00
Guy Harris
93692fa5aa Fix a couple of "proto_tree_add_text()" calls to pass the right arguments.
svn path=/trunk/; revision=13989
2005-03-31 23:48:08 +00:00
Guy Harris
9432aeb823 Add a link to a more recent Apple page describing DSI.
svn path=/trunk/; revision=13988
2005-03-31 22:04:59 +00:00
Anders Broman
03840a53ec Included packet-gsm_map.h and removed unpack_digits as it now is exported from gsm_map, as it isn't used
yet no need to regenerate the dissector now.

svn path=/trunk/; revision=13987
2005-03-31 18:51:14 +00:00
Anders Broman
caa56dfc55 From Jacques, Olivier: Length of digit_str wrongly calculated.
Free the string, fix dissection of some elements.

svn path=/trunk/; revision=13986
2005-03-31 18:41:44 +00:00
Anders Broman
c4e25e0599 From Jacques, Olivier: Length of digit_str wrongly calculated.
Free the string, fix dissection of some elements.

svn path=/trunk/; revision=13985
2005-03-31 18:39:45 +00:00
Anders Broman
68af7e99c2 From Jacques, Olivier: Length of digit_str wrongly calculated.
Free the string, fix dissection of some elements.

svn path=/trunk/; revision=13984
2005-03-31 18:34:25 +00:00
Guy Harris
05cebb5aaa http://www.shaftnet.org/~pizza/software/capturefrm.txt is currently not
available; add an archive.org URL for it.

svn path=/trunk/; revision=13983
2005-03-31 07:59:43 +00:00
Anders Broman
86d6adf84f Further IE dissection updates.
svn path=/trunk/; revision=13982
2005-03-31 04:50:48 +00:00
Anders Broman
2c8cf2ab42 Small bug fix
svn path=/trunk/; revision=13981
2005-03-30 19:10:26 +00:00
Anders Broman
dfdff5a70c Improve some debug messages.
svn path=/trunk/; revision=13980
2005-03-30 19:09:48 +00:00
Anders Broman
d238f2c65f Update and small bugfix
svn path=/trunk/; revision=13979
2005-03-30 19:08:39 +00:00
Michael Tüxen
1de67556ea Fix the handling of the length parameter in the DATA chunk.
This is a quick fix. A systematic follows...

svn path=/trunk/; revision=13978
2005-03-30 16:16:07 +00:00
Anders Broman
b183d4d1e3 From Ulf Lamping:
Fix a "off by one" error.

svn path=/trunk/; revision=13977
2005-03-30 13:37:27 +00:00
Ronnie Sahlberg
95d12a0bc6 From Tim
small bugfix for packet-ber.c if packet is malformed, prevent dereferenceing a null pointer


svn path=/trunk/; revision=13976
2005-03-30 09:18:25 +00:00
Guy Harris
8b334b9148 Make it a bit clearer that what "-w" writes is raw binary packet data,
not the result of dissecting that data.

Note that "-F" applies to the output of "-w", that "-S" says "dissect
and print even if you're doing '-w'", and that "-T" applies to the
dissected output, not the "-w" output.

svn path=/trunk/; revision=13975
2005-03-30 01:06:12 +00:00
Gerald Combs
137d5a0fcd Add a tvb_ensure_bytes_exist() and fix a few other offset-related bugs.
svn path=/trunk/; revision=13974
2005-03-29 22:23:09 +00:00
Anders Broman
dfdd9ce19d From Martin Mathieson:
- bump up SDP_MAX_PAYLOAD_TYPES to 20 (I have an mgcp capture where a media
gateway responded with 12 media types, resulting in a crash).  Probably more
care needs to be taken while parsing the list of media types though...

svn path=/trunk/; revision=13973
2005-03-29 20:58:03 +00:00
Anders Broman
80e9643f2f From Martin Mathieson :
- allow dissector to show "MGCP/SDP" in the Protocol column, at least when
the 'Display the number of MGCP messages' preference is switched off
- when displaying the command verb, show in the tree the full verb name as
well as the 4-letter code
- show the links to response and request messages as being [generated]
- fixed some indentation problems


svn path=/trunk/; revision=13972
2005-03-29 20:56:42 +00:00
Gerald Combs
b2c4af01c2 Remove a g_assert() left over from debugging.
svn path=/trunk/; revision=13971
2005-03-29 19:52:04 +00:00
Gerald Combs
8e79a1852f Use an offset of 0 in PER_NOT_DECODED_YET() so that we don't generate a
dissector bug error.

svn path=/trunk/; revision=13970
2005-03-29 16:11:11 +00:00
Gerald Combs
4198c72a69 Fix a compiler warning.
svn path=/trunk/; revision=13969
2005-03-29 16:02:02 +00:00