Lars Roland
e52a52322d
Remove redundant definition of _need_var_import_
...
svn path=/trunk/; revision=14068
2005-04-13 23:05:41 +00:00
Gerald Combs
cea394348c
Fix a bug introduced by my previous checkin.
...
svn path=/trunk/; revision=14067
2005-04-13 22:04:50 +00:00
Gerald Combs
37c30f6c63
Check for COL_INFO before trying to modify it.
...
svn path=/trunk/; revision=14066
2005-04-13 21:56:00 +00:00
Gerald Combs
d357c745a6
In dissect_ber_octet_string_wcb(), make sure out_tvb is non-NULL before
...
trying to use it so that we don't throw an assertion. Fixes bug 22.
Do the same thing in dissect_ber_GeneralString().
svn path=/trunk/; revision=14065
2005-04-13 21:20:23 +00:00
Gerald Combs
e3bd36c2d5
Add a couple of tvb_ensure_bytes_exist() calls to fix bug 12.
...
svn path=/trunk/; revision=14064
2005-04-13 20:59:39 +00:00
Ulf Lamping
dc223932b8
another try to fix the unix build
...
svn path=/trunk/; revision=14063
2005-04-12 23:48:47 +00:00
Ulf Lamping
6cacb84377
bugfix for unix builds, remove leftover things from function move
...
svn path=/trunk/; revision=14062
2005-04-12 23:12:37 +00:00
Ulf Lamping
854c387c0b
add clear toolbar icon (from GTK stock icons)
...
svn path=/trunk/; revision=14061
2005-04-12 22:55:40 +00:00
Ulf Lamping
24801e8e5f
don't display "No packets captured" dialog, when using the new clear feature
...
svn path=/trunk/; revision=14060
2005-04-12 21:56:27 +00:00
Ulf Lamping
7e9cedfed8
capture engine:
...
add a new feature to clear the currently captured packets and restart the capture with the previous parameters
various code cleanup and minor bugfixes
Win32: use millisecond resolution in capture_loop, to smooth screen update a bit (500ms instead of 1000ms)
svn path=/trunk/; revision=14059
2005-04-12 21:44:55 +00:00
Ulf Lamping
fcb74124f8
Save As: ask user if he wants to overwrite an already existing file
...
svn path=/trunk/; revision=14058
2005-04-12 21:24:30 +00:00
Ulf Lamping
6e38159c25
add functions file_exists and file_identical to filesystem.c (coming from file.c)
...
svn path=/trunk/; revision=14057
2005-04-12 21:12:19 +00:00
Ulf Lamping
4929e662b8
[CHECKSUM INCORRECT] -> [TCP CHECKSUM INCORRECT]
...
svn path=/trunk/; revision=14056
2005-04-12 21:07:48 +00:00
Ronnie Sahlberg
83f14e4614
change time_secs_to_str() and time_msecs_to_str() to take a signed integer as parameter so we can handle negtive times
...
svn path=/trunk/; revision=14055
2005-04-12 19:59:08 +00:00
Ulf Lamping
06ef0a3b52
it should now be possible to use "Update packets in real time" even if used with one of the "Multiple files" option.
...
If this is used together with an option where input files changes too fast (e.g. new file every second), capturing will be (hopefully) stopped.
I've replaced the former capture pipe message format into a somewhat more general format to remove a lot of confusion.
svn path=/trunk/; revision=14054
2005-04-12 00:54:52 +00:00
Ulf Lamping
61ccc8baf1
various capture code cleanup and fixes:
...
display filename in statusbar while capturing
print_usage banner fixed
cf_cb_live_capture_prepare no longer needed
rename sync_pipe_do_capture -> sync_pipe_start
bugfix: sync_pipe_input_wait_for_start replaced by former implementation
fix cleanup of old file in capture_input_new_file
fix a tempfile detection bug (named file showed up as tempfile after capture)
svn path=/trunk/; revision=14053
2005-04-11 18:57:19 +00:00
Ulf Lamping
fbace0592c
fix some error handling
...
fflush new output file (to have at least the pcap header on disk) before sending the corresponding message to the capture parent
svn path=/trunk/; revision=14052
2005-04-11 18:39:31 +00:00
Ronnie Sahlberg
2bc81b2a48
Major speed improvement for filtering and dissection.
...
It should not dump core as far as all my tests are concerned and Menu_Statistics/ProtocolHierStats work
It needs more testing and there might still be cases where it will crash that will need to be fixed but I feel it will be worth it since it will decrease the time to filter very large capture files dramatically.
Real significant performance boost for very large captures.
(If we cant fix all the problems we can just revert this patch)
svn path=/trunk/; revision=14051
2005-04-11 08:43:51 +00:00
Gerald Combs
c9be421b16
Add a note about testing to the "Robustness" section.
...
svn path=/trunk/; revision=14050
2005-04-11 01:57:00 +00:00
Ulf Lamping
018cde2a41
add some missing menu items, describe changes in the -b ring buffer command line parameter.
...
svn path=/trunk/; revision=14049
2005-04-11 00:10:50 +00:00
Gerald Combs
cd67d1fcf8
Remove debugging printf()s.
...
svn path=/trunk/; revision=14048
2005-04-10 23:17:05 +00:00
Ulf Lamping
af118c9e12
disable /View/Resize Columns menu item, if no packets available
...
svn path=/trunk/; revision=14047
2005-04-10 23:13:35 +00:00
Gerald Combs
c8ff864b00
Add an option to Editcap that adds various types of errors to the capture
...
file.
svn path=/trunk/; revision=14046
2005-04-10 23:12:48 +00:00
Ulf Lamping
5625c461d0
bugfix: call to cf_cb_live_capture_..._started with correct parameter
...
svn path=/trunk/; revision=14045
2005-04-10 21:03:31 +00:00
Ulf Lamping
163f2b61a8
fix statusbar messages by splitting into update and fixed messages between capture and main
...
svn path=/trunk/; revision=14044
2005-04-10 19:36:56 +00:00
Ulf Lamping
adc2bf61a8
bugfix: hide panes if a non "Update" capture had no packets captured (hopefully it's working correct now...)
...
svn path=/trunk/; revision=14043
2005-04-10 17:36:36 +00:00
Ulf Lamping
63047dfdd5
bugfix: call cf_cb_live_capture_finished *if* some packets were captured
...
svn path=/trunk/; revision=14042
2005-04-10 17:18:45 +00:00
Ulf Lamping
70f1945084
fix a typo
...
svn path=/trunk/; revision=14041
2005-04-10 17:08:32 +00:00
Ulf Lamping
7b7f7e7f9a
Win32 only bugfix: as using TerminateProcess is the brute force way and sometimes clipped packets in the middle, now using a pipe called signal_pipe from the parent to the child for this.
...
On unix we're using kill() for this, which simply signals the child, but this isn't available on win32.
svn path=/trunk/; revision=14040
2005-04-10 16:43:22 +00:00
Ulf Lamping
78a7b0bcc0
bugfix: when no packets were captured, don't call cf_cb_live_capture_finished after closing the capture file
...
svn path=/trunk/; revision=14039
2005-04-10 15:35:41 +00:00
Ulf Lamping
3ee155a90a
refactoring of the capture startup (while the capture parent waits for the child to start)
...
svn path=/trunk/; revision=14038
2005-04-10 14:29:12 +00:00
Ulf Lamping
96a1fab95e
fix descriptive texts, so they fit into the window
...
svn path=/trunk/; revision=14037
2005-04-10 13:43:07 +00:00
Guy Harris
5341ad2bba
Clean up indentation.
...
svn path=/trunk/; revision=14036
2005-04-10 08:55:56 +00:00
Guy Harris
5e096c5c19
Clean up white space, and tweak a comment slightly ("message" in the
...
error message case referred to the error message text, not the message
on the pipe).
svn path=/trunk/; revision=14035
2005-04-10 08:51:46 +00:00
Guy Harris
39836021f7
Fix indentation.
...
svn path=/trunk/; revision=14034
2005-04-10 08:31:27 +00:00
Guy Harris
8881cec2df
Make it slightly clearer that the bitwise AND operator evaluates to a
...
Boolean value that's true if any of the bits in question are set and
false if none of them are, not to an integer or slice value with the
only the bits set in both values set.
svn path=/trunk/; revision=14033
2005-04-10 08:28:08 +00:00
Ronnie Sahlberg
b803431715
KRB_ERROR can be returned and it is not encapsulated
...
svn path=/trunk/; revision=14032
2005-04-09 01:28:23 +00:00
Gerald Combs
05ae084f5b
Fix brokenness from previous patch.
...
svn path=/trunk/; revision=14031
2005-04-08 20:28:24 +00:00
Gerald Combs
caf66bb8dd
Add a length check.
...
svn path=/trunk/; revision=14030
2005-04-08 19:14:05 +00:00
Gerald Combs
388c7e2da9
Add a length check, fix up some comments.
...
svn path=/trunk/; revision=14029
2005-04-08 19:09:46 +00:00
Ronnie Sahlberg
a574ef6b88
From Martin M
...
updates to MGCP
checked in per Anders B request hope it compiles
svn path=/trunk/; revision=14028
2005-04-08 11:25:18 +00:00
Ronnie Sahlberg
a55085054c
From Neil Kettle
...
Fix two potential buffer overflow bugs in fc els
svn path=/trunk/; revision=14027
2005-04-08 10:28:44 +00:00
Ronnie Sahlberg
df98534657
From Didier:
...
optimization for COLUMNS to make ethereal faster when filtering
optimization to make the slow find_protocol_by_id() fast.
(idea from Didier, implementation modified by me to be less intrusive)
svn path=/trunk/; revision=14026
2005-04-07 12:00:03 +00:00
Ronnie Sahlberg
412e592a12
updating Mark C Browns information
...
svn path=/trunk/; revision=14025
2005-04-07 10:04:50 +00:00
Ronnie Sahlberg
4eb8b88421
make the ip ip field we use as the reassembly key a bit more
...
"unique" by mixing in the source and destination address.
svn path=/trunk/; revision=14024
2005-04-07 09:44:58 +00:00
Ronnie Sahlberg
6ac7c99cc5
From Francisco Alcoba
...
Very cool ASCII art version of viop graphs
svn path=/trunk/; revision=14023
2005-04-07 09:14:35 +00:00
Ronnie Sahlberg
3fbcc50513
From Greg Morris
...
Fix the breakage from my previous patch
svn path=/trunk/; revision=14022
2005-04-07 08:32:49 +00:00
Ulf Lamping
396d51fce3
add Ilya Konstantinov
...
svn path=/trunk/; revision=14021
2005-04-06 21:28:02 +00:00
Ulf Lamping
37f7683cd1
from Ilya Konstantinov: fixed a bug as DND wasn't working with GNOME, I've also added a comment how GNOME handles these things
...
svn path=/trunk/; revision=14020
2005-04-06 21:24:00 +00:00
Ronnie Sahlberg
eb98d35922
use proto_item_appent_text() instead of proto_item_append_string() since the hf field is not neccessarily a FT_STRING value always.
...
svn path=/trunk/; revision=14019
2005-04-05 20:20:21 +00:00