Commit Graph

38 Commits

Author SHA1 Message Date
Michael Mann ce537f6b94 Remove static packet_info *gpinfo and just use the packet_info provided by the function.
svn path=/trunk/; revision=49145
2013-05-03 14:54:39 +00:00
Anders Broman 5f6b7f95bc Fix dissection of IMSI detach from non-EPS service type.
svn path=/trunk/; revision=48789
2013-04-08 16:44:15 +00:00
Evan Huus 37600a157b Rename value string (and similar) functions to use a consistent pattern. This
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
Pascal Quantin bda771b86b Do not initialize ett_tree and msg_fcn_p when match_strval_idx_ext does not find a match
svn path=/trunk/; revision=48538
2013-03-24 21:52:19 +00:00
Pascal Quantin 86eda54fe6 As suggested by Evan Huus, use extended value_strings
svn path=/trunk/; revision=48407
2013-03-18 22:21:53 +00:00
Pascal Quantin 94f330030d use enum values instead of hardcoded values
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487)

svn path=/trunk/; revision=48397
2013-03-18 20:26:47 +00:00
Pascal Quantin ae61fe0158 Try to fix dissection of GSM protocol family broken by r47209.
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)


svn path=/trunk/; revision=47218
2013-01-22 23:25:44 +00:00
Bill Meier a8112e6529 Fix [-Wshadow] warnings;
Also (for one or more of the files):
 - create/use one or more extended variable strings;
 - remove some uneeded variable initializers;
 - reformat some long lines;
 - reformat hf[] entries;
 - convert apparent 4-space tabs to spaces;
 - do some whitespace and formatting changes to use a consistent style.

svn path=/trunk/; revision=46265
2012-11-28 22:41:07 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
pascal 0ba1ab2909 Display Element ID in hexadecimal (like in 3GPP specs)
Display EPS bearer ID in decimal

svn path=/trunk/; revision=42755
2012-05-21 19:27:38 +00:00
Chris Maynard fb6cce75d9 Fix some duplicate display filter names.
svn path=/trunk/; revision=40669
2012-01-23 20:14:37 +00:00
Anders Broman d3e76bdeb0 Use correct string length.
svn path=/trunk/; revision=40209
2011-12-15 17:14:56 +00:00
Anders Broman 42b44648c8 Get rid of Warnings.
svn path=/trunk/; revision=39954
2011-11-20 08:59:19 +00:00
Bill Meier 30cee99009 Fix a number of proto_tree_add_item() encoding args.
svn path=/trunk/; revision=39774
2011-11-09 17:33:18 +00:00
Anders Broman 35ac513981 Use the correct length for the NAS message container.
svn path=/trunk/; revision=39759
2011-11-08 17:31:23 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Bill Meier ad1efb6b9c (Trivial) Remove trailing whitespace from lines for a few files.
svn path=/trunk/; revision=39084
2011-09-21 23:42:55 +00:00
Bill Meier 5db6069274 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=38085
2011-07-18 15:52:16 +00:00
Anders Broman d33f1c24cc From Sijin N K:
Missing hf declaration for cn_id.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5901

svn path=/trunk/; revision=37038
2011-05-10 07:58:33 +00:00
Anders Broman aaf0d277b8 Get rid of gsm_a_dtap_pinfo.
svn path=/trunk/; revision=36444
2011-04-04 14:49:14 +00:00
Anders Broman 8d6ca293dc Change the signature of elem_fcn():ns to include pinfo.
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman 72b69aeaf5 Change the msg_fcn() signature to include pinfo.
svn path=/trunk/; revision=36441
2011-04-04 07:45:34 +00:00
Anders Broman db3a34973a Beutify IMEISV IE output.
svn path=/trunk/; revision=36308
2011-03-24 10:36:39 +00:00
Anders Broman 1ab6930388 - Add 9.4.5 IMEISV IE dissection
- UE Time Zone is TLV
- Cell Global Identity  PDU type is SGSAP_PDU_TYPE

svn path=/trunk/; revision=36239
2011-03-22 09:06:42 +00:00
Guy Harris 3908493548 Use the right proto_tree * variable.
Clean up indentation.

svn path=/trunk/; revision=35786
2011-02-03 18:15:56 +00:00
Anders Broman 5d6c22fdb8 Dissect Erroneous message.
svn path=/trunk/; revision=35785
2011-02-03 17:45:17 +00:00
Anders Broman 690d412c5a - Use the right tree for IE's
- Dissect MME and VLR name
- Add strings to some IE's

svn path=/trunk/; revision=35782
2011-02-03 16:36:22 +00:00
Anders Broman 4374c0b0b7 - Wrong element type used.
- Use match_strval_idx_ext.

svn path=/trunk/; revision=35609
2011-01-21 14:03:42 +00:00
Anders Broman 83c29e1672 Move sgsap_elem_idx_t to packet-gsm_a_common.h
Dissect Global-CN-Id

svn path=/trunk/; revision=35607
2011-01-21 09:26:29 +00:00
Gerald Combs cc02a10ef8 Fix checkAPI.
svn path=/trunk/; revision=35309
2010-12-30 19:52:24 +00:00
Anders Broman 465a18eea4 Extend a comment
svn path=/trunk/; revision=35308
2010-12-30 14:10:35 +00:00
Anders Broman 23b188ca06 Add dissection of NAS message container.
svn path=/trunk/; revision=35285
2010-12-28 11:24:46 +00:00
Anders Broman 14e2d5c04a Remove de_sgsap_tmsi as it's not needed.
svn path=/trunk/; revision=35275
2010-12-27 20:19:55 +00:00
Stephen Fisher 4c0447c8cc Fix build by #if 0 out unused de_sgsap_tmsi() function.
svn path=/trunk/; revision=35274
2010-12-27 16:38:03 +00:00
Anders Broman a95df8ac8c Add more IE dissection.
svn path=/trunk/; revision=35273
2010-12-27 15:15:55 +00:00
Anders Broman 356aced5bf Start of a SGSAP (TS 29.118) dissector for LTE.
svn path=/trunk/; revision=35266
2010-12-26 21:06:08 +00:00