e69ec10794
Callers of tvb_per_bit_string expect that the returned value_tvb is non-NULL.
...
Ensure that is the case even in certain peculiar error conditions, by filling it
with a 0-length subset TVB. Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9117
Also add modelines.
svn path=/trunk/; revision=51821
2013-09-07 13:48:13 +00:00
2e299ec910
Add modelines, use consistent indentation in address.h
...
Use the "do { } while (0)" trick to make the macros behave like regular function
calls syntatically.
Fix one dissector that wasn't using semicolons after the macro calls.
svn path=/trunk/; revision=51819
2013-09-07 12:51:29 +00:00
071f89e3b3
coverity 1047692: check return value of inet_pton()
...
svn path=/trunk/; revision=51814
2013-09-07 10:02:46 +00:00
f974c74fd8
From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9105 :
...
Add additional PN532 opcodes, and update USB CCID dissector to skip status word in PN532 responses
svn path=/trunk/; revision=51812
2013-09-07 08:03:32 +00:00
52c9e57474
Deduplicate some type and field names.
...
svn path=/trunk/; revision=51800
2013-09-06 17:39:03 +00:00
1c46818354
Convert to wmem, and as per Michael's suggestion in
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9107 , use zeroed memory for
ntlmssp_info structs.
svn path=/trunk/; revision=51799
2013-09-06 15:59:45 +00:00
0e885e8089
Set length and contents to 0/NULL if the blob is empty. Fixes
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9107
svn path=/trunk/; revision=51798
2013-09-06 15:29:18 +00:00
96d29a5d50
Get rid of a duplicated filter name.
...
svn path=/trunk/; revision=51792
2013-09-05 20:55:59 +00:00
2d1b7d1e32
add casts to make my compiler (gcc 4.6.3) happy
...
svn path=/trunk/; revision=51790
2013-09-05 20:18:13 +00:00
f6eb619d87
Display "TEID/GRE Key" field consistently as hexadecimal since 3GPP TS 36.444 says this field is of type, "octet string".
...
Ref: http://ask.wireshark.org/questions/24221/decode-gtpv2-teid-as-decimal-or-hex
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=51789
2013-09-05 18:51:46 +00:00
b3f4084c4e
Make "content blob" dynamically sized so it doesn't take up 20k of memory per conversation.
...
Add filterable expert info while we're at it.
svn path=/trunk/; revision=51787
2013-09-05 16:29:08 +00:00
808d594087
Add an expert info if we see content-length header and chunked encoding
...
together.
The other part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9101
Also fix modelines.
svn path=/trunk/; revision=51786
2013-09-05 16:05:32 +00:00
8552f0df64
The length field is retrieved from the packet in bytes, not bits, so stop
...
adjusting it by 8 everywhere.
Seems to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9087 though
someone more familiar with the protocol will have to verify it's actually
correct now.
svn path=/trunk/; revision=51784
2013-09-05 13:15:04 +00:00
e67292ff14
Move where timing reference for DRX timers will be set
...
svn path=/trunk/; revision=51783
2013-09-05 13:11:54 +00:00
3b6f55c579
Convert atn-* dissectors to wmem. No emem in new code please!
...
svn path=/trunk/; revision=51780
2013-09-05 12:13:00 +00:00
854363611c
Generated file differs in whitespace output
...
svn path=/trunk/; revision=51774
2013-09-05 07:36:16 +00:00
7e2efe9e6b
From Christoph Viethen:
...
Typo in the name of a PPPoE tag name.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9102
svn path=/trunk/; revision=51769
2013-09-05 05:39:15 +00:00
dd12400161
From Chris Bontje:
...
Changes include:
- Detect previously-unknown object types. No dissection is attempted of response messages, but at least the types are documented and labelled. As Graham notes, if some examples are provided we can attempt a little more here.
- Change up info_column object label handling to add some of the new objects. Also added in a few that would be present in 'write' messages.
- Add expert info field for abnormal IIN bits. This will help me in my job of detecting unknown objects and unsupported function codes and will easily flag to the user that 'something is up' due to the color changes.
- Only detect Application Layer if we are on the Final Transport Layer frame.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9056
svn path=/trunk/; revision=51768
2013-09-05 05:34:40 +00:00
436a6d2e99
From Mathias Guettler:
...
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8903
svn path=/trunk/; revision=51767
2013-09-05 05:26:34 +00:00
80cd0dca1d
From Mathias Guettler:
...
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8903
svn path=/trunk/; revision=51766
2013-09-05 05:26:04 +00:00
edbade8458
3GPP-MS-TimeZone value is not decoded in RADIUS and DIAMETER messages.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9099
svn path=/trunk/; revision=51765
2013-09-05 05:03:42 +00:00
b422c4892d
From Dirk:
...
fix NTLMSSP Target Info Attribute dissection
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9098
svn path=/trunk/; revision=51764
2013-09-05 04:57:33 +00:00
239971eca9
Fix some expert filter field names (one of which was illegal)
...
svn path=/trunk/; revision=51763
2013-09-05 02:52:08 +00:00
dd4b03512f
Remove commented out expert_add_info_format
...
svn path=/trunk/; revision=51762
2013-09-05 01:42:11 +00:00
0c49b4d872
Add filterable expert info to dissect_802_3() and clean up the shrapnel.
...
svn path=/trunk/; revision=51761
2013-09-05 01:39:35 +00:00
e65df7f453
Batch of filterable expert info.
...
Some of the FT_NONE hf_ variables were removed in favor of proto_tree_add_expert. It may also be possible to remove some of the booleans surrounding the expert info.
New expert display filters may need to be double-checked to make sure they make sense.
svn path=/trunk/; revision=51760
2013-09-05 01:05:16 +00:00
1abd5a5965
dissect some more items of the smart card descriptor
...
svn path=/trunk/; revision=51758
2013-09-04 22:00:41 +00:00
90ac3f129f
Improve the display of AUTH related parameters.
...
Only use IANA registered values for HMAC ids.
svn path=/trunk/; revision=51755
2013-09-04 21:07:09 +00:00
48089ba4ca
Use epan-scoped memory for building more of the diameter table stuff.
...
svn path=/trunk/; revision=51754
2013-09-04 21:06:56 +00:00
f5b85d81d0
From Katrina Zhang:
...
Fix QoS dissection.
svn path=/trunk/; revision=51752
2013-09-04 18:11:21 +00:00
a53b483969
From Katrina Zhang:
...
Change to tfs_enabled_disabled.
svn path=/trunk/; revision=51750
2013-09-04 18:10:00 +00:00
10f7f95d09
From Katrina Zhang:
...
637 UAR-Flags dissection.
svn path=/trunk/; revision=51749
2013-09-04 18:08:08 +00:00
86656b31d2
Another small step towards modelling and reporting upon DRX state in
...
MAC.
svn path=/trunk/; revision=51748
2013-09-04 16:56:37 +00:00
d11c7d5480
Always initialize the hash when dissecting nfsv3 file handle. Fixes the recent
...
valgrind fuzz failure.
svn path=/trunk/; revision=51746
2013-09-04 11:46:01 +00:00
55f7519fc2
From Tyson Key:
...
Update the InListPassiveTarget Response handler to dissect the ISO 14443-A ATQA, and UID values from InnoVision/Broadcom Topaz cards/tags.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9096
svn path=/trunk/; revision=51745
2013-09-04 04:47:38 +00:00
a59b5388a9
From Andreas Urke via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9091 :
...
Add support for CFM R-APS/G.8032 version 2
From me: convert a few value_string to true_false_string
svn path=/trunk/; revision=51744
2013-09-03 22:05:22 +00:00
69dfcffbc0
Remove obsolete code
...
svn path=/trunk/; revision=51743
2013-09-03 21:25:16 +00:00
6fc009baac
Similar to the IPv4 dissector's hf_ip_dst_host, hf_ip_src_host and hf_ip_host fields, add to the Ethernet dissector:
...
hf_eth_dst_resolved
hf_eth_src_resolved
hf_eth_addr_resolved
and add to the IEEE802.11 dissector:
hf_ieee80211_addr_da_resolved
hf_ieee80211_addr_sa_resolved
hf_ieee80211_addr_ra_resolved
hf_ieee80211_addr_ta_resolved
hf_ieee80211_addr_bssid_resolved
hf_ieee80211_addr_resolved
Change motivated by:
http://ask.wireshark.org/questions/24314/possible-to-use-the-mac-info-in-the-wireshark-manuf-file-as-part-of-display-filter
svn path=/trunk/; revision=51742
2013-09-03 21:20:59 +00:00
a65045ec3f
Code cleanup:
...
- remove some useless trees
- prettify the dissection of a few IEs
- use ELEM_MAND_VV_SHORT macro where applicable
svn path=/trunk/; revision=51741
2013-09-03 21:10:05 +00:00
79352919a6
Fix "malformed packet" and tidy up a bit.
...
svn path=/trunk/; revision=51740
2013-09-03 19:04:13 +00:00
4a226911da
Protect agains infinite loop.
...
svn path=/trunk/; revision=51738
2013-09-03 18:47:44 +00:00
dc1477b79b
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=51737
2013-09-03 18:44:42 +00:00
5098965030
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=51736
2013-09-03 18:44:16 +00:00
6ac93da7f9
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=51735
2013-09-03 18:43:50 +00:00
b4a4a768dc
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=51734
2013-09-03 18:43:29 +00:00
154d793f1e
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=51733
2013-09-03 18:43:11 +00:00
6934553230
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=51732
2013-09-03 18:42:49 +00:00
7ecb6b1d7d
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=51731
2013-09-03 18:42:01 +00:00
9de7a12476
Fix "Tones off" value typo introduced in r51613
...
svn path=/trunk/; revision=51729
2013-09-03 18:29:34 +00:00
20227036fc
Add MACSEC dissector
...
From Allan W. Nielsen, bug 9094 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9094 )
svn path=/trunk/; revision=51727
2013-09-03 17:35:00 +00:00
Evan Huus