osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
51480 commits 26 branches 0 tags 795 MiB
Commit graph

2928 commits

Author SHA1 Message Date
Pascal Quantin
696194999e From Vasil Velichkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9382 : 
Fix dissection of GSM MAPv3 ReportSM_DeliveryStatusRes

svn path=/trunk/; revision=53148
 2013-11-07 21:08:15 +00:00
Evan Huus
5f2c75e940 Add missing cast. 
svn path=/trunk/; revision=53096
 2013-11-05 22:58:50 +00:00
Michael Mann
b6b78d69db In an effort to reduce the use of pinfo->private_data (and some true global variables), I converted the ASN.1 dissectors that use pinfo->private_data to exchange a SESSION_DATA_STRUCTURE to instead only exchange it in the context of ASN.1. This meant converting dissectors to the "new" style to pass the SESSION_DATA_STRUCTURE as well as providing a pointer to it in asn1_ctx_t.private_data. Yes, it's still "private data", but it's not used by all dissectors like pinfo->private data is. 
svn path=/trunk/; revision=53090
 2013-11-05 18:47:26 +00:00
Michael Mann
149de99d68 Have rose_ctx_t passed into subdissectors instead of using pinfo->private_data. 
svn path=/trunk/; revision=53061
 2013-11-03 12:57:58 +00:00
Michael Mann
60e3e52a53 Have asn1_ctx_t passed into the "h245.gef.name" and "h245.gef.content" subdissectors instead of using pinfo->private_data. 
svn path=/trunk/; revision=53055
 2013-11-03 02:45:22 +00:00
Michael Mann
02a8391535 Require dissector_try_string to pass a data parameter to its subdissectors. There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new. 
svn path=/trunk/; revision=53049
 2013-11-02 15:52:25 +00:00
Michael Mann
c0fcebb07a Add a data parameter to call_ber_oid_callback to be able to pass data to subdissectors found with dissector_try_string_new. 
The intention is to aid in the removal of pinfo->private_data use as well as static global variables in a dissector.  For now, all calls to call_ber_oid_callback have the data parameter set to NULL.

svn path=/trunk/; revision=52994
 2013-10-31 00:57:03 +00:00
Michael Mann
bd683d5ee1 Pass T.38 data to subdissectors directly instead of using pinfo->private_data. 
svn path=/trunk/; revision=52964
 2013-10-29 21:12:50 +00:00
Bill Meier
0ad98563a2 From didier gautheron: remove redundant or use faster col_xxx functions 
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for  replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
    + before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set

   https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344


svn path=/trunk/; revision=52948
 2013-10-29 14:09:20 +00:00
Martin Mathieson
66d64c686e Pass security command details (integrity and ciphering algorithms) to PDCP (which doesn't yet do much with them) 
svn path=/trunk/; revision=52946
 2013-10-29 13:49:14 +00:00
Martin Kaiser
c89b9a2cdc initialize tree variables 
svn path=/trunk/; revision=52920
 2013-10-28 16:59:57 +00:00
Michael Mann
3b91b9586f Pass tcap_private into the dissectors that need it rather than use private_data. Not sure if value_ptr is the "proper" place to pass tcap_private "internally" within the TCAP dissector, but it gets away from (potential) private_data (ab)use. 
svn path=/trunk/; revision=52916
 2013-10-28 13:36:49 +00:00
Michael Mann
09bd9ad788 Have ANSI TCAP dissector pass data through subdissector parameter instead of using struct _packet_info. 
svn path=/trunk/; revision=52885
 2013-10-27 02:00:18 +00:00
Jeff Morriss
0690c4f490 More SVN properties cleanup. 
svn path=/trunk/; revision=52884
 2013-10-27 01:11:15 +00:00
Evan Huus
3342e3bc89 Convert some emem to wmem. It took some manual flow analysis, but they are only 
used during actual packet dissection.

svn path=/trunk/; revision=52870
 2013-10-26 16:04:21 +00:00
Bill Meier
6dd42b581a Fix some [-Wunused-const-variable] warnings (using '#if 0') 
svn path=/trunk/; revision=52862
 2013-10-26 02:09:14 +00:00
Evan Huus
95f484a91e Add a very small hack to make the UAT update callback error string freeable, and 
convert all existing UAT update callbacks to use glib memory instead of
ephemeral memory for that string.

UAT code paths are entirely distinct from packet dissection, so using ephemeral
memory was the wrong choice, because there was no guarantees about when it would
be freed.

The move away from emem still needs to be propogated deeper into the UAT code
itself at some point.

Net effect: remove another bunch of emem calls from dissectors, where replacing
with wmem would have caused assertions.

svn path=/trunk/; revision=52854
 2013-10-25 22:14:25 +00:00
Pascal Quantin
b552143a5c Put PDU dissection in protocol tree 
svn path=/trunk/; revision=52724
 2013-10-20 21:05:37 +00:00
Pascal Quantin
7f3d07b9fd From e.yimjia via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9289 : 
Add dissection of OMA-ILP

svn path=/trunk/; revision=52721
 2013-10-20 18:43:00 +00:00
Pascal Quantin
d269d19f99 Fix a typo 
svn path=/trunk/; revision=52719
 2013-10-20 18:06:23 +00:00
Tomas Kukosa
744f47107e H.225.0: fix handling of compound parameters in Generic Extensible Framework (H.460.22 did not work well) 
svn path=/trunk/; revision=52659
 2013-10-17 11:24:43 +00:00
Pascal Quantin
938206442c Upgrade RRLP dissector to V11.0.0 
svn path=/trunk/; revision=52640
 2013-10-16 03:06:46 +00:00
Bill Meier
f6e09faa2d From Ed Beroset: add modelines and fix irregular indenting; 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9273

This patch adds modelines and cleans up the irregular indentation of
this dissector's code.  The only other change was in
asn1/c1222/packet-c1222-template.c to consolidate an #ifdef that had a
redundant #endif (line 812) and subsequent reopening #ifdef (line
824).  The only thing between them was comments, so the span of the
original #ifdef (line 644) was simply extended by eliminating those
two lines.

The purpose for this patch is to make the file easier to edit and
understand in advance of more substantive patches later.  This patch
is intended to be easy to review by having only non-substantive
changes.


svn path=/trunk/; revision=52636
 2013-10-16 00:57:28 +00:00
Graham Bloice
9c4ee86784 Add CMake properties to targets so that they are logically organised when using a Visual Studio solution. 
Add CMake properties to group the source files in epan into logical blocks when using a Visual Studio solution.

svn path=/trunk/; revision=52580
 2013-10-13 09:21:55 +00:00
Jeff Morriss
545455db1c Fix compilation when we don't HAVE_LIBGCRYPT 
svn path=/trunk/; revision=52527
 2013-10-11 00:42:02 +00:00
Evan Huus
f29544f9df Add a call to tvb_ensure_bytes_exist before we allocate memory based on our 
offset+size, prevents attempts to allocate outrageous memory, fixing
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9260

svn path=/trunk/; revision=52503
 2013-10-10 17:44:55 +00:00
Evan Huus
a50dee3286 From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9246 
Fix memory leaks and bad memory accesses in c1222 dissector.

From me: use realloc in a handoff function since it may get called multiple
times, and we only need the latest.

svn path=/trunk/; revision=52497
 2013-10-10 16:18:49 +00:00
Martin Kaiser
8a9e9de7bf mpeg pes private data is 16 bytes long, see iso 13818-1 
svn path=/trunk/; revision=52447
 2013-10-08 11:23:22 +00:00
Michael Mann
94f0e1fe21 Fully support relative AP-titles in C12.22. Bug 9196 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9196) 
From Ed Beroset

svn path=/trunk/; revision=52394
 2013-10-06 02:42:14 +00:00
Pascal Quantin
76e8ff1d8d Replace the 3 dissector tables (with a single entry in each) by a direct call to the GSM SMS dissector 
svn path=/trunk/; revision=52336
 2013-10-02 18:04:06 +00:00
Anders Broman
408ba7bade From beroset@mindspring.com: 
c1222 dissector has wrong tag value for BER-encoding of calling_AE_qualifier

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9193

svn path=/trunk/; revision=52225
 2013-09-26 21:15:44 +00:00
Pascal Quantin
019e64f58d Upgrade RRC dissector to v11.7.0 
svn path=/trunk/; revision=52202
 2013-09-24 17:56:17 +00:00
Pascal Quantin
d74564d6cf Ensure to release an existing DRX configuration when receiving a RRC Connection Setup message 
svn path=/trunk/; revision=52193
 2013-09-23 21:21:58 +00:00
Pascal Quantin
15ba18d1df Upgrade LPPa dissector to v11.3.0 
svn path=/trunk/; revision=52192
 2013-09-23 20:20:36 +00:00
Pascal Quantin
102c452bcb More emem -> wmem conversion: 
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz()
- tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc()
- tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz()
- tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str()
- update docs accordingly

svn path=/trunk/; revision=52180
 2013-09-22 20:04:35 +00:00
Pascal Quantin
a0c53ffaa1 emem -> wmem conversion: 
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly

svn path=/trunk/; revision=52172
 2013-09-22 15:50:55 +00:00
Evan Huus
6df83e8078 Add _g_ to the names of functions that allocate glib memory. This is a bit more 
explicit, and frees up the "generic" names (like tvb_memdup) for new signatures
that take the appropriate wmem pool.

Majority of the conversion done with sed.

svn path=/trunk/; revision=52164
 2013-09-21 17:04:41 +00:00
Anders Broman
95c5f81c83 DCH-ID can be 255 
svn path=/trunk/; revision=52154
 2013-09-20 14:19:31 +00:00
Chris Maynard
ab7d8cc87d Fix a couple of EXPORT_DEPENDS 
svn path=/trunk/; revision=52135
 2013-09-18 03:58:07 +00:00
Jörg Mayer
6883f691c7 Add the dependeny handling for windows builds as well 
svn path=/trunk/; revision=52134
 2013-09-18 03:31:03 +00:00
Chris Maynard
ae8824d555 Missed 1 character replacement as part of r52132. 
svn path=/trunk/; revision=52133
 2013-09-18 02:58:14 +00:00
Chris Maynard
b9ee9fa694 Remove all non-ASCII characters from all .asn files. I didn't see the harm in replacing them all as opposed to only those not copied verbatim from other sources. 
svn path=/trunk/; revision=52132
 2013-09-18 02:48:29 +00:00
Jörg Mayer
af15a51a6b Fix remaining dependencides for -exp.cnf files. 
svn path=/trunk/; revision=52129
 2013-09-17 20:45:00 +00:00
Jörg Mayer
de20bbf0ac More dependeny updates for asn1 -exp.cnf files. 
Only three remaining: p7, p22, x509ce - thanks to Chris Maynard for the list.

svn path=/trunk/; revision=52127
 2013-09-17 19:43:37 +00:00
Jörg Mayer
72f8ca4895 One of the wmem patches only updated the generated packet-snmp.c 
but not the source. Fix that.

svn path=/trunk/; revision=52123
 2013-09-17 18:54:18 +00:00
Jörg Mayer
fb834104e5 When building packet-dap.c on an empty build tree, packet-dap.c would 
be incorrect on the first pass and only be correct when remade.
The reason was that disp-exp.cnf was created incorrectly on first pass.
disp-exp.cnf required dop-exp.cnf to build correctly, so add a mechanism
to add dependencies for export files.

Note: Only the cmake change has been tested, the autofoo stuff requires
  testing.

svn path=/trunk/; revision=52120
 2013-09-17 18:02:25 +00:00
Chris Maynard
a2e86de160 Fix dependency problems (continuation of r52110 and r52112). 
svn path=/trunk/; revision=52118
 2013-09-17 14:45:52 +00:00
Jörg Mayer
af96c7bb45 Fix a difference to Makefile.common 
svn path=/trunk/; revision=52117
 2013-09-17 05:53:02 +00:00
Jörg Mayer
686dd9b061 Copy over rev 52110 to cmake 
svn path=/trunk/; revision=52112
 2013-09-16 21:45:46 +00:00
Chris Maynard
e14b587293 Fix dependency problem reported by Joerg Mayer on wireshark-dev. 
Ref: http://www.wireshark.org/lists/wireshark-dev/201309/msg00151.html

svn path=/trunk/; revision=52110
 2013-09-16 21:35:27 +00:00
Jörg Mayer
886332e74f Whitespace changes 
svn path=/trunk/; revision=52109
 2013-09-16 21:35:19 +00:00
Pascal Quantin
7d6899b96b Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9155 : 
Ensure that codec_str string is always initialized 

svn path=/trunk/; revision=52107
 2013-09-16 21:26:03 +00:00
Jörg Mayer
c5ffff76d8 Fix checkapi warnings (missing id) 
Replace Makefile.{am,nmake,common} that did not conform by
their asn1/c133/ version.

svn path=/trunk/; revision=52062
 2013-09-15 15:00:03 +00:00
Jörg Mayer
65ff43fada Finish asn1 emem -> wmem conversion. 
Left are snmp and those functions that don't have wmem equivalents.

svn path=/trunk/; revision=52060
 2013-09-15 14:37:46 +00:00
Jörg Mayer
c65459c729 emem -> wmem (don't forget about .cnf) 
svn path=/trunk/; revision=52058
 2013-09-15 14:33:38 +00:00
Jörg Mayer
888650324b emem -> wmem 
svn path=/trunk/; revision=52054
 2013-09-15 13:24:14 +00:00
Pascal Quantin
868b345eea Convert a few more dissectors to wmem API 
svn path=/trunk/; revision=52053
 2013-09-15 10:29:49 +00:00
Martin Kaiser
fd50ee16e8 dissect OCSP nonce extension 
some minor reformatting of the ASN.1 imports

svn path=/trunk/; revision=51987
 2013-09-12 21:29:50 +00:00
Pascal Quantin
efe18f199c Convert a few dissectors from emem to wmem API 
svn path=/trunk/; revision=51983
 2013-09-12 20:37:30 +00:00
Guy Harris
0c11b6f8da Give various files RCS IDs. 
svn path=/trunk/; revision=51963
 2013-09-12 03:41:22 +00:00
Chris Maynard
0c41507bad Change some internal dissector table UI names so it's clear which protocol they pertain to and it's easier to find in the list. 
svn path=/trunk/; revision=51904
 2013-09-09 21:55:57 +00:00
Michael Mann
9e3f9b449f expert_add_info_format_text -> expert_add_info_format 
svn path=/trunk/; revision=51852
 2013-09-09 00:44:09 +00:00
Michael Mann
00dd0adc0d expert_add_info_format_text -> expert_add_info_format 
svn path=/trunk/; revision=51851
 2013-09-09 00:28:48 +00:00
Pascal Quantin
f54441c125 Add a chunk forgotten in r51846 
svn path=/trunk/; revision=51847
 2013-09-08 21:22:11 +00:00
Pascal Quantin
a6ae13dee9 Slightly different fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9117 : 
Check that tvb returned by dissect_per_bit_string is not null before trying to use it

svn path=/trunk/; revision=51846
 2013-09-08 21:10:36 +00:00
Evan Huus
57c28aeffd Fix the FSF address in the license header for the new ASN.1 dissectors. 
svn path=/trunk/; revision=51830
 2013-09-07 22:12:24 +00:00
Gerald Combs
52c9e57474 Deduplicate some type and field names. 
svn path=/trunk/; revision=51800
 2013-09-06 17:39:03 +00:00
Anders Broman
96d29a5d50 Get rid of a duplicated filter name. 
svn path=/trunk/; revision=51792
 2013-09-05 20:55:59 +00:00
Evan Huus
8552f0df64 The length field is retrieved from the packet in bytes, not bits, so stop 
adjusting it by 8 everywhere.

Seems to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9087 though
someone more familiar with the protocol will have to verify it's actually
correct now.

svn path=/trunk/; revision=51784
 2013-09-05 13:15:04 +00:00
Evan Huus
3b6f55c579 Convert atn-* dissectors to wmem. No emem in new code please! 
svn path=/trunk/; revision=51780
 2013-09-05 12:13:00 +00:00
Jörg Mayer
39bff3218a Missed 50% of the updates in last commit 
svn path=/trunk/; revision=51773
 2013-09-05 07:33:05 +00:00
Jörg Mayer
d4f2865595 CMakeLists was no longer in sync with Makefile.common 
svn path=/trunk/; revision=51772
 2013-09-05 07:28:47 +00:00
Jörg Mayer
022706764b Add missing CMakeLists.txt files 
svn path=/trunk/; revision=51771
 2013-09-05 06:05:15 +00:00
Jörg Mayer
02a61b07e4 Fix cmake syntax - so now it "only" warns about missing 
CMakeLists.txt in the subdirectories.

svn path=/trunk/; revision=51770
 2013-09-05 05:48:22 +00:00
Anders Broman
80cd0dca1d From Mathias Guettler: 
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8903

svn path=/trunk/; revision=51766
 2013-09-05 05:26:04 +00:00
Evan Huus
7dbc052d78 More dissectors to wmem. There are no more dissectors using se_tree now, just a 
few other places.

svn path=/trunk/; revision=51622
 2013-09-01 01:00:11 +00:00
Martin Mathieson
a09ee6af03 The first step towards tracking and showing DRX info in MAC: 
- send release from RRC
- show current DRX config from each frame, including a link back to the
  RRC config frame
- show simple DRX state for each frame (currently only offset into long
  cycle and whether within long cycle 'on' period)

TODO:
- simulate timers in response to new UL/DL transmissions or DL CRC
  errors
- maintain whether in long or short cycle
- show state of all timers

svn path=/trunk/; revision=51585
 2013-08-30 04:08:57 +00:00
Anders Broman
7e3922cf43 Use dissector_delete_uint_range/dissector_add_uint_range 
svn path=/trunk/; revision=51540
 2013-08-27 19:21:20 +00:00
Evan Huus
b5900e53d9 Make sure our ldap_call_response_t struct is always completely initialized, 
fixing a "Conditional jump or move depends on uninitialised value" error found
by valgrind fuzzing.

svn path=/trunk/; revision=51516
 2013-08-25 17:31:15 +00:00
Guy Harris
0675ed7494 Clang, clang, clang went the warning.... 
Fix a memset (drb_mapping is a pointer, so its size is the size of a
pointer; we want the size of what it points to).

svn path=/trunk/; revision=51500
 2013-08-23 23:51:52 +00:00
Pascal Quantin
ae4f556630 Simplify logic a bit now that we do not use anymore GUINT_TO_POINTER macro 
svn path=/trunk/; revision=51490
 2013-08-23 12:51:07 +00:00
Pascal Quantin
483ee317f7 From Martin Mathieson: 
Follow-up of r51429 that
- uses accessors to lazily allocate a private_data struct and returns the different parts based upon their use
- includes the v1130 DRX Config

svn path=/trunk/; revision=51489
 2013-08-23 10:42:11 +00:00
Pascal Quantin
75f4fa5b4b Remove tree check when dissecting PCCH message so as to avoid filtering expert info on first pass 
svn path=/trunk/; revision=51477
 2013-08-22 19:55:25 +00:00
Chris Maynard
b3dc1eed1c Fix Coverity CID's 1063706-1063710: Out-of-bounds read (OVERRUN_STATIC) 
svn path=/trunk/; revision=51450
 2013-08-21 14:08:42 +00:00
Martin Mathieson
641032ea44 Gather together dedicated DRX configuration, and make sure that it 
is internally consistent.

TODO: include r11 sequence that can overwrite some of these values.
TODO: actx->private_data gets reused for several purposes, need to
separate these uses out and avoid possible conflicts...

svn path=/trunk/; revision=51429
 2013-08-19 17:06:42 +00:00
Pascal Quantin
b46f9bebe2 Change some dissectors to use pinfo memory pool instead of malloc if it can trigger an exception between between buffer allocation and tvb_set_free_cb call 
svn path=/trunk/; revision=51427
 2013-08-19 14:55:41 +00:00
Pascal Quantin
02cae558f9 Do not use ephemeral memory when adding a new data source 
svn path=/trunk/; revision=51424
 2013-08-19 11:11:11 +00:00
Guy Harris
64f079430b Fix $Id$. 
svn path=/trunk/; revision=51373
 2013-08-15 03:55:09 +00:00
Jörg Mayer
3b5aaefce3 - Extract variables from Makefile.common. 
- Apply this to asn1/c1222/

svn path=/trunk/; revision=51324
 2013-08-12 22:17:06 +00:00
Pascal Quantin
24e7b8aefd Fix copy paste error and reinitialize actx->private_data to NULL once used 
svn path=/trunk/; revision=51311
 2013-08-12 09:26:24 +00:00
Alexis La Goutte
467ece42b3 Fix (-W)documentation error found by Clang 
../../asn1/c1222/packet-c1222-template.c:348:15: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param pinfo
   ~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:349:14: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tree
   ~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:350:16: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param length
   ~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:351:16: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param offset
   ~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:758:11: error: parameter 'keybuf' not
      found in the function declaration [-Werror,-Wdocumentation]
 * \param keybuf is updated with a copy of the key data if successful lookup.
          ^~~~~~
../../asn1/c1222/packet-c1222-template.c:758:11: note: did you mean 'keybuff'?
 * \param keybuf is updated with a copy of the key data if successful lookup.
          ^~~~~~
          keybuff
../../asn1/c1222/packet-c1222-template.c:879:13: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tvb
   ~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:880:16: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param offset
   ~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:881:13: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param len
   ~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:882:15: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param pinfo
   ~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:883:14: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tree
   ~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1023:13: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tvb
   ~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1024:15: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param pinfo
   ~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1025:14: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tree
   ~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1047:15: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param pinfo
   ~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1048:13: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tvb
   ~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1049:16: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param offset
   ~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1068:13: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tvb
   ~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1069:15: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param pinfo
   ~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1070:14: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tree
   ~~~~~~~~~~^

svn path=/trunk/; revision=51272
 2013-08-10 21:30:38 +00:00
Martin Mathieson
237182ba42 Use proper macros to cast between uint and pointer 
svn path=/trunk/; revision=51246
 2013-08-10 17:09:12 +00:00
Martin Mathieson
11304a30ee Try again... 
svn path=/trunk/; revision=51245
 2013-08-10 16:53:05 +00:00
Martin Mathieson
8cddb7a24e Try using guint. 
svn path=/trunk/; revision=51244
 2013-08-10 16:34:19 +00:00
Martin Mathieson
0fb73abcc9 Add a malformed check to show if GroupA has more RAPIDs than A & B 
combined.

svn path=/trunk/; revision=51243
 2013-08-10 16:17:33 +00:00
Stig Bjørlykke
cf6288e21f Added default ignore targets for new asn1 dissectors. 
Removed cnf data from atn-cpdlc.asn to make it generate.

svn path=/trunk/; revision=51215
 2013-08-08 11:15:45 +00:00
Anders Broman
77f4bef154 From Mathias Guettler: 
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.

Add the files to the distribution.

svn path=/trunk/; revision=51212
 2013-08-08 05:34:22 +00:00
Anders Broman
a4d1560fd1 From Mathias Guettler: 
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.

Just adding the files to SVN for now.

svn path=/trunk/; revision=51210
 2013-08-08 05:09:13 +00:00
Anders Broman
08d223eb71 When dissecting IMSI handle the zero length tvb case, fixes "Malformed Packet: CAMEL (empty IMSI tag)" 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9015

svn path=/trunk/; revision=51208
 2013-08-08 04:36:54 +00:00
Martin Kaiser
2f072ac53c add a range check for dch_id 
this should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9005

svn path=/trunk/; revision=51195
 2013-08-07 20:18:11 +00:00
Jakub Zawadzki
9cfac1227d Replace hfinfo pointer to same_name_prev, with same_name_prev_id. 
svn path=/trunk/; revision=51175
 2013-08-06 20:53:47 +00:00
Jakub Zawadzki
518ac53e2c Make some global variables static 
svn path=/trunk/; revision=51163
 2013-08-05 20:15:06 +00:00
Michael Mann
af134c29ca Convert proto_item_set_expert_flags into filterable items. 
svn path=/trunk/; revision=51140
 2013-08-04 19:59:01 +00:00
Michael Mann
3eafc74e2b Convert proto_item_set_expert_flags to "filterable" items in alcap dissector. Unfortunately it had a few tentacles, so they needed to be brought along for the ride. 
svn path=/trunk/; revision=51136
 2013-08-04 13:46:25 +00:00
Jeff Morriss
f7843da692 md5.h is in wsutil now. 
svn path=/trunk/; revision=51102
 2013-08-01 23:53:35 +00:00
Jeff Morriss
2df54da6e2 Move a bunch of the crypt modules and pint.h into wsutil. 
This means wsutil now links against libcrypt.

Protect a bunch of the crypt header files from multiple inclusion.

svn path=/trunk/; revision=51100
 2013-08-01 23:34:47 +00:00
Anders Broman
82569132d9 Add the forgotten makefile updates. 
svn path=/trunk/; revision=51017
 2013-07-29 18:19:59 +00:00
Anders Broman
266e577aee Update to handle version 9. 
svn path=/trunk/; revision=50981
 2013-07-28 19:25:14 +00:00
Evan Huus
8441fff193 Use the pinfo pool for adding data sources in the h245 dissector. The packet 
pool is freed before the packet is displayed or otherwise processed, so adding
data sources from it leads to use-after-free errors.

Not sure why this wasn't showing up in the fuzz-bot valgrind step, there
are lots of h245 captures in the menagerie...

svn path=/trunk/; revision=50897
 2013-07-25 23:58:49 +00:00
Pascal Quantin
802e7bed77 Try to differentiate a non filled private_data (pointer set to NULL) from an enum with value = 0 
svn path=/trunk/; revision=50837
 2013-07-23 14:34:46 +00:00
Jakub Zawadzki
c702e92121 Replace relative timestamp with reference frame number. Saves 16B per frame. 
svn path=/trunk/; revision=50772
 2013-07-21 23:07:33 +00:00
Jakub Zawadzki
a18172147f Remove fragment_data, add fragment_head, fragment_item - for now alias it to the same structure. 
This is begin of work to split fragment head and fragments items.

svn path=/trunk/; revision=50708
 2013-07-17 21:12:24 +00:00
Chris Maynard
f5f20fa8e3 Fix warning: ISO C does not allow extra ';' outside of a function. 
svn path=/trunk/; revision=50638
 2013-07-15 20:42:57 +00:00
Jeff Morriss
54bb2e7a5c Move report_err.{h,c} from epan into wsutil: there's nothing epan-specific there and moving it avoids having to recompile the file for use in editcap and capinfos (which don't link against libwireshark). 
svn path=/trunk/; revision=50598
 2013-07-15 02:48:26 +00:00
Guy Harris
0e40234217 Make pointers to raw packet data pointers to guint8, not pointers to 
char; they're chunks of raw octets, not characters.

svn path=/trunk/; revision=50586
 2013-07-14 17:39:36 +00:00
Jakub Zawadzki
543ba2746b fix: ../../asn1/t38/packet-t38-template.c:346: warning: request for implicit conversion from 'gpointer' to 'char *' not permitted in C++ 
svn path=/trunk/; revision=50582
 2013-07-14 15:51:15 +00:00
Jakub Zawadzki
c766e78cfa Rewrite reassemble API to use TVBs instead of raw data. 
(it seems to be working for TCP ^^)

svn path=/trunk/; revision=50580
 2013-07-14 14:42:05 +00:00
Pascal Quantin
8c9ab802ce Upgrade LTE RRC dissector to v11.4.0 
svn path=/trunk/; revision=50473
 2013-07-09 20:39:09 +00:00
Guy Harris
b2475c1c29 Squelch some warnings that show up with, for example, the GCC 4.2.1 that 
comes with Xcode 3.2.6 (it's not a real problem, but that requires more
flow analysis than that version of the compiler does, apparently).

svn path=/trunk/; revision=50419
 2013-07-06 19:34:21 +00:00
Evan Huus
74e1b830a9 Use epan-scoped memory for h248 packages. Fixes another ~24KB of leaks. 
svn path=/trunk/; revision=50414
 2013-07-06 18:14:04 +00:00
Michael Mann
225698ef0b Fix display filter errors caught by checkfiltername.pl 
svn path=/trunk/; revision=50399
 2013-07-06 02:53:45 +00:00
Michael Mann
eec311ef39 Fix duplicate diplay filter names found by checkfiltername.pl 
svn path=/trunk/; revision=50396
 2013-07-06 01:20:38 +00:00
Michael Mann
7878e93cad expert_add_info_format_text + proto_tree_add_text = proto_tree_add_expert_format, where applicable. 
svn path=/trunk/; revision=50377
 2013-07-03 23:43:26 +00:00
Pascal Quantin
b00abd1c43 Check actx->private_data validity before using it 
svn path=/trunk/; revision=50339
 2013-07-03 12:01:12 +00:00
Pascal Quantin
b91b990a77 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8880 : 
Check actx->private_data validity before using it

svn path=/trunk/; revision=50338
 2013-07-03 08:53:47 +00:00
Michael Mann
98492c5619 expert_add_info + proto_tree_add_text = proto_tree_add_expert, where applicable 
svn path=/trunk/; revision=50337
 2013-07-03 02:59:31 +00:00
Chris Maynard
17772df943 Fix Coverity CID 1040373 (Dereference before null check). Minor whitespace changes come along for the ride on this one. 
svn path=/trunk/; revision=50297
 2013-07-01 15:09:56 +00:00
Chris Maynard
997c6c7d8e Fix Coverity CID 712348 (Unused pointer value). 
svn path=/trunk/; revision=50288
 2013-07-01 06:15:37 +00:00
Guy Harris
95daae2290 Squelch some warnings. 
svn path=/trunk/; revision=50286
 2013-07-01 06:13:21 +00:00
Chris Maynard
bfcaf93bff Fix Coverity CID 1040372 (Printf arg count mismatch) by eliminating the double %'s. 
svn path=/trunk/; revision=50283
 2013-07-01 05:47:13 +00:00
Michael Mann
c1ddd6046d replace object_identifier_id with actx->external.direct_reference 
svn path=/trunk/; revision=50209
 2013-06-28 12:52:13 +00:00
Michael Mann
9009944d51 Remove all global variables in P1 dissector. Bug 8515 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8515) 
Added a "subtree context" structure to asn1_ctx_t. This should allow other ASN.1 dissector global variables to be replaced when only used for transferring data between fields in a subtree.

svn path=/trunk/; revision=50208
 2013-06-28 12:43:29 +00:00
Jeff Morriss
a441793cba Move a couple of time-related modules into wsutil. 
A bunch of files didn't really need to include these header files so remove
the include line rather than changing it.

svn path=/trunk/; revision=50154
 2013-06-25 22:02:20 +00:00
Pascal Quantin
d23f769c0d Add an option to dissect RRC-Container IE 
svn path=/trunk/; revision=50130
 2013-06-24 21:31:25 +00:00
Michael Mann
87eb22f464 More proper fix (per advice of bug 8515 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8515)) of global variables complained about in bug 7060 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7060). Not sure if algorithm_id of x509af dissector could also be a actx->external.direct_reference, so left it alone. 
svn path=/trunk/; revision=50113
 2013-06-22 15:08:18 +00:00
Pascal Quantin
de10bc6b5e Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8799 : 
Display certificate as UINT64 and add support for a 64bits unsigned value in BER dissector

svn path=/trunk/; revision=50096
 2013-06-20 23:37:16 +00:00
Martin Mathieson
64e15853fc Fix for bug 8826. 
The global variable 'address_item' was not always being set to NULL
before the dissection of a new frame.  Do more to set it in the general
case, and in the particular case of an MTSBindResult_PDU, which was
triggering an error in the supplied capture.

There may be other entry points where this still safely isn't being
set.

svn path=/trunk/; revision=50083
 2013-06-20 18:54:58 +00:00
Evan Huus
7c8530539c Ldap still needs to include wmem.h since it uses wmem during normal dissection, 
just not for UAT purposes.

svn path=/trunk/; revision=50074
 2013-06-20 14:01:54 +00:00
Evan Huus
d63bd5330f Back out some of the wmem conversions (r50063 and r50057). 
These dissectors allocate ephemeral or seasonal memory in UAT callbacks, which
really makes no sense because UAT callbacks can occur when there is no packet or
file in scope, making this effectively a leak if the user is fiddling with their
UAT and never opens a capture.

Emem let you get away with this, wmem forces an assertion. Back out the changes
so that the UATs are usable until the code can be properly fixed to not use
out-of-scope allocators.

svn path=/trunk/; revision=50073
 2013-06-20 06:26:03 +00:00
Evan Huus
0d3718b467 Add some missing wmem includes that apparently only show up on Windows. 
svn path=/trunk/; revision=50071
 2013-06-19 23:53:25 +00:00
Evan Huus
8b0f1addd9 Apparently one of our major global headers must include emem.h, because I just 
found a bunch more asn1 dissectors using emem without ever directly including
the header. Convert those to wmem as well, which involves add a number of
#include directives since dissectors do *not* automatically pull in the wmem
headers.

svn path=/trunk/; revision=50066
 2013-06-19 23:08:58 +00:00
Evan Huus
b1e12ec925 Convert the rest of the ASN1 dissectors from emem to wmem. 
svn path=/trunk/; revision=50063
 2013-06-19 22:47:36 +00:00
Evan Huus
9fa4a8e6b6 Convert a batch of asn1 dissectors from emem to wmem. 
svn path=/trunk/; revision=50057
 2013-06-19 20:43:03 +00:00
Jörg Mayer
b77119aca7 Remove traling whitespace. 
svn path=/trunk/; revision=50048
 2013-06-19 18:33:49 +00:00
Pascal Quantin
2eec913a4d Fet rid of a global variable 
svn path=/trunk/; revision=50034
 2013-06-19 07:16:14 +00:00
Pascal Quantin
830ebed406 Get rid of global variables 
svn path=/trunk/; revision=50032
 2013-06-19 06:44:39 +00:00
Jörg Mayer
d9b5210c61 Fix CID 712341: Dereference null return value (NULL_RETURNS) 
Well, not really. Just catch that case and error out.

svn path=/trunk/; revision=50029
 2013-06-19 03:23:31 +00:00
Martin Mathieson
2cf27a92a6 Set PDCP SN length for DRBs for separate RRC element. 
svn path=/trunk/; revision=50021
 2013-06-18 22:38:54 +00:00
Martin Mathieson
868f74d628 Also signal value of PDCP SN (only used if enabled by RLC preferences). 
svn path=/trunk/; revision=50019
 2013-06-18 21:44:48 +00:00
Martin Mathieson
ece132a5ce Configure MAC LCID -> RLC channel settings from RRC. 
svn path=/trunk/; revision=50016
 2013-06-18 21:02:00 +00:00