Guy Harris
0a99ee25d5
Don't make claims of constness that can't be guaranteed in terms the C
...
compiler can verify.
svn path=/trunk/; revision=54792
2014-01-14 17:45:03 +00:00
Evan Huus
a6415ece0a
Rename a couple of to_str functions to have ep_ in the name. This makes it
...
obvious that the returned string is ephemeral, and opens up the original names
in the API for versions that take a wmem pool (and thus can work in any scope).
svn path=/trunk/; revision=54249
2013-12-19 15:49:09 +00:00
Anders Broman
e6d09c1634
Make local functions static. Include *.h when needed.
...
svn path=/trunk/; revision=54201
2013-12-17 22:07:32 +00:00
Michael Mann
4945174ae6
Pass "wild_card" directly to dissector instead of using private_data. "h248term" dissector is not in Wireshark source, so third-party will need to update accordingly.
...
svn path=/trunk/; revision=53241
2013-11-10 21:33:45 +00:00
Jakub Zawadzki
ae59b09443
Add missing includes in order to remove exceptions.h from proto.h (next commit).
...
svn path=/trunk/; revision=53230
2013-11-10 15:59:37 +00:00
Pascal Quantin
a0c53ffaa1
emem -> wmem conversion:
...
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly
svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Anders Broman
96d29a5d50
Get rid of a duplicated filter name.
...
svn path=/trunk/; revision=51792
2013-09-05 20:55:59 +00:00
Evan Huus
7dbc052d78
More dissectors to wmem. There are no more dissectors using se_tree now, just a
...
few other places.
svn path=/trunk/; revision=51622
2013-09-01 01:00:11 +00:00
Michael Mann
af134c29ca
Convert proto_item_set_expert_flags into filterable items.
...
svn path=/trunk/; revision=51140
2013-08-04 19:59:01 +00:00
Michael Mann
3eafc74e2b
Convert proto_item_set_expert_flags to "filterable" items in alcap dissector. Unfortunately it had a few tentacles, so they needed to be brought along for the ride.
...
svn path=/trunk/; revision=51136
2013-08-04 13:46:25 +00:00
Evan Huus
74e1b830a9
Use epan-scoped memory for h248 packages. Fixes another ~24KB of leaks.
...
svn path=/trunk/; revision=50414
2013-07-06 18:14:04 +00:00
Evan Huus
8b0f1addd9
Apparently one of our major global headers must include emem.h, because I just
...
found a bunch more asn1 dissectors using emem without ever directly including
the header. Convert those to wmem as well, which involves add a number of
#include directives since dissectors do *not* automatically pull in the wmem
headers.
svn path=/trunk/; revision=50066
2013-06-19 23:08:58 +00:00
Michael Mann
7fe5422c4b
Convert ASN.1 dissectors to use filterable expert info.
...
NOTE: Kerberos ASN.1 template was updated, but not generated to source.
svn path=/trunk/; revision=49707
2013-06-03 03:42:36 +00:00
Jörg Mayer
5fa9c90ffd
Some more
...
svn path=/trunk/; revision=49203
2013-05-07 16:26:35 +00:00
Jörg Mayer
243e9c0ba5
Just whitespace changes
...
svn path=/trunk/; revision=49167
2013-05-05 08:49:18 +00:00
Jörg Mayer
8faa262e90
Stub cmake support for generating the asn1 dissectors.
...
It doesn't do anything yet, it is just to make svn status
readable again.
svn path=/trunk/; revision=49007
2013-04-23 23:05:33 +00:00
Evan Huus
37600a157b
Rename value string (and similar) functions to use a consistent pattern. This
...
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).
Use a consistent coding style, and make proper use of the WS_DLL_* defines.
Group the functions appropriately in the header.
I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467
svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
Anders Broman
7c56677cf9
From beroset:
...
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48429
2013-03-19 21:22:31 +00:00
Balint Reczey
1ebdb2e521
Export libwireshark symbols using WS_DLL_PUBLIC define
...
Also remove old WS_VAR_IMPORT define and related Makefile magic
everywhere in the project.
svn path=/trunk/; revision=47992
2013-03-01 23:53:11 +00:00
Bill Meier
d449c31d1d
its ==> it's & it's ==> its as needed.
...
svn path=/trunk/; revision=47892
2013-02-26 01:22:18 +00:00
Guy Harris
021069a56b
Clean up white space - get rid of 4-space tabs.
...
Reformat the hf[] array to be consistent, and get rid of some bogus
blurbs (probably copy-and-pasteos).
svn path=/trunk/; revision=47759
2013-02-20 01:37:08 +00:00
Bill Meier
8ef31f222e
Hack: disguise '/*' in text strings to prevent checkAPIs & etc seeing 'start of comment' within a text string.
...
svn path=/trunk/; revision=47446
2013-02-02 14:20:15 +00:00
Evan Huus
518eee193b
Use epan-scoped memory to clean up another 1Kb+ of valgrind
...
sorta-false-positive leaks.
svn path=/trunk/; revision=47170
2013-01-19 20:14:42 +00:00
Pascal Quantin
53edadd49b
From John Batty via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8087 :
...
H.248 MEGACO PkgName property is poorly formatted
svn path=/trunk/; revision=46526
2012-12-13 14:24:44 +00:00
Jeff Morriss
3551a86c36
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45015
2012-09-20 01:29:52 +00:00
Anders Broman
6dfa10bc57
Revert part of revision 43107 which broke sub dissection of
...
Signal and events as a new tvb wasn't created.
|BASE_EXT_STRING also removed.
svn path=/trunk/; revision=43661
2012-07-11 14:40:35 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Anders Broman
189ea54f0b
from Alex Lindberg:
...
Update to packet-h248.c and associated h248 dissecorts.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332
svn path=/trunk/; revision=43107
2012-06-05 10:54:21 +00:00
Guy Harris
c51cadd00e
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
svn path=/trunk/; revision=42488
2012-05-07 22:46:14 +00:00
Anders Broman
fd19aa7c89
H.248 Annex E dissector does not properly dissect event parameters
...
(Update the h.248 dissector's package registration to support v1 packets.)
Applying part of the patch from Alex Lindberg in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6915 by hand.
Fixes bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4842
svn path=/trunk/; revision=41526
2012-03-13 13:26:13 +00:00
Jeff Morriss
183f0e934c
Create a list of MTP Service Indicator macros and use them.
...
svn path=/trunk/; revision=40828
2012-02-03 18:26:37 +00:00
Anders Broman
34ea886454
[-Wunused-but-set-variable]
...
svn path=/trunk/; revision=39829
2011-11-14 17:35:04 +00:00
Anders Broman
fa7ea2ea34
fix [-Wunused-but-set-variable]
...
svn path=/trunk/; revision=39803
2011-11-12 12:37:38 +00:00
Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Jeff Morriss
cf012d27b1
Build the ASN.1 dissectors directly into epan/dissectors (rather than building
...
them and then copying them over). The "all" target to builds these dissectors
now (instead of "generate_files" and/or "copy_files").
asn2wrs's "-O" option now means "the dissector goes in this directory" (rather
than "all output goes in this directory"); it also means that the "-s" (single
output file) option is now required.
Fix things up so that it's possible to build all of the ASN.1 dissectors in
one shot.
Fix building of conformance files when doing out-of-source-tree builds.
Unfortunately "make all" in the asn1 directory always builds something--I think
because of circular depedencies.
svn path=/trunk/; revision=39333
2011-10-10 02:31:11 +00:00
Jeff Morriss
f3f9f2697f
Make TVBs opaque for most users.
...
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions.
svn path=/trunk/; revision=37422
2011-05-27 03:06:50 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier
b1554fc198
Use value_string_ext fcns to access certain value_string arrays;
...
Whitespace cleanup.
svn path=/trunk/; revision=34882
2010-11-15 19:08:12 +00:00
Bill Meier
ed7105e21b
Update package_name_vals[] value_string array:
...
- Add new entries based on: http://www.iana.org/assignments/megaco-h248 last updated 2010-10-01;
- Fix a typo (incorrect value for an entry);
- Switch values between two entries to match the IANA list;
- Switch two entries so list is in ascending order by value.
svn path=/trunk/; revision=34881
2010-11-15 19:00:16 +00:00
Anders Broman
eb136e00d8
From Alex Lindberg:
...
resolves all h248V1 differences and provides dissection of V1
instances of Packets, Events, Signals, and Properties.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3999
svn path=/trunk/; revision=31597
2010-01-21 06:39:25 +00:00
Anders Broman
a255c08b66
Get rid of check_col();
...
svn path=/trunk/; revision=31546
2010-01-17 12:46:00 +00:00
Kovarththanan Rajaratnam
7ab993bee7
Remove unused NEED_PACKET_PROTO_H variable
...
svn path=/trunk/; revision=30409
2009-10-08 17:26:57 +00:00
Kovarththanan Rajaratnam
a9ed97b344
From Gerasimos Dimitriadis via. bug 4104:
...
When dissecting a h248 message, col_set_str is called with a string from the ephemeral pool and an assertion fails.
svn path=/trunk/; revision=30398
2009-10-08 13:17:51 +00:00
Stig Bjørlykke
e2d6320d75
Only include config.h in C files, to avoid multiple inclusion.
...
svn path=/trunk/; revision=30182
2009-09-28 17:58:47 +00:00
Anders Broman
8a23b29c91
From Alex Lindberg:
...
Add H248V1 suport.
(H248 dissector fails on poorly formed AuditReply packet from Media Gateway)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3953
svn path=/trunk/; revision=29835
2009-09-10 05:57:30 +00:00
Anders Broman
3d2e307ae6
From Alex Lindberg:
...
Update to h248v3.asn
Applied the change from the Amendment 1 by hand.
svn path=/trunk/; revision=29787
2009-09-08 09:11:21 +00:00
Kovarththanan Rajaratnam
c19f7978db
Sanitize epan includes
...
svn path=/trunk/; revision=29500
2009-08-21 20:32:50 +00:00
Kovarththanan Rajaratnam
e971354a54
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Anders Broman
9b9880a25a
From yin sun:
...
h248 term wildcard enhancement
svn path=/trunk/; revision=28861
2009-06-27 13:37:03 +00:00
Stig Bjørlykke
e3ef20f3ea
From Kovarththanan Rajaratnam:
...
Clean up header field info in asn1/*-template.c files.
From me:
Fixed a few typos in the patch.
svn path=/trunk/; revision=28817
2009-06-23 06:02:12 +00:00