Commit graph

2145 commits

Author SHA1 Message Date
Ronnie Sahlberg
c3467685d5 make io-stat able to do SUM(*) for FT_RELATIVE_TIME fields
Example:   SUM(tcp.analysis.rto)
so one can plot the total amount of time that TCP sessions were idle due to waiting for a retransmission to occur.



svn path=/trunk/; revision=14920
2005-07-15 08:29:26 +00:00
Michael Tüxen
1962844317 From Irene Ruengeler: Handle multiple gap reports correctly and use correct name of a button.
svn path=/trunk/; revision=14908
2005-07-12 21:04:05 +00:00
Guy Harris
18527dc22e Just pass &cfile to select_tcpip_session(); we don't need to pass
cfile.current_frame to it separately.

Note that we shouldn't ever get a "Selected packet isn't a TCP segment"
error any more; we can now handle all link layers.

Give a little more detail in the message shown if there's *more than
one* TCP header in the packet.

svn path=/trunk/; revision=14895
2005-07-10 18:29:43 +00:00
Guy Harris
47e79c4961 Fix some comment typos.
Don't regenerate the packet list when generating the TCP stream graph -
it won't be changing; just redissect and run the tap.

svn path=/trunk/; revision=14894
2005-07-10 10:10:40 +00:00
Guy Harris
b6b0ee7cf8 Get rid of an unused argument.
svn path=/trunk/; revision=14892
2005-07-10 09:21:57 +00:00
Jörg Mayer
5b442f2279 After doing "make maintainer-clean", "svn status --no-ignore | grep ^I"
returned quite a list of files. Add them to MAINTAINERCLEANFILES.

Whitespace changes (replace multiple spaces by TABs, in a few cases this
needed to be done at the beginning of Makefile lines.


svn path=/trunk/; revision=14891
2005-07-10 08:04:27 +00:00
Ronnie Sahlberg
847bb5af7f It works reasonably well with extensive testing so here goes :
tcp-graph has been modified to extract tcp data from a TAP instead of reading and parsing directly from the capture file.

This makes tcp graph work for any type of capture and for any transport.




In the future someone with access to captures with TCP over something over TCP
to add a dialog where the user can specify WHICH of the multiple TCP sessions to graph.



svn path=/trunk/; revision=14889
2005-07-10 02:59:50 +00:00
Ulf Lamping
dc6b471aad MSVC: fix some guint64 related compiler errors
strange enough, MSVC cannot convert from guint64 to float, so cast guint64 -> gint64 -> float

However, even gint64 might be big enough to prevent us from an overflow :-)

svn path=/trunk/; revision=14888
2005-07-09 11:28:13 +00:00
Ulf Lamping
832fc14ad8 MSVC: fix some guint64 related compiler warnings, could someone please review my comment(s), I don't think it's currently implemented correct
svn path=/trunk/; revision=14887
2005-07-09 11:26:46 +00:00
Michael Tüxen
3d4375731a Fix a crash reported by Jeff Morris.
svn path=/trunk/; revision=14876
2005-07-08 11:47:59 +00:00
Guy Harris
979511b3fa Make the counters in the summary 64-bit, so they don't overflow on
Really Big Captures.

svn path=/trunk/; revision=14875
2005-07-08 09:12:11 +00:00
Ronnie Sahlberg
897a12c305 make the packets/bytes counters 64bit integers to not wrap when using really large captures.
setting packet counter to 64bit is overkill but makes it consistent with the very similar bytes counter.



svn path=/trunk/; revision=14872
2005-07-07 22:24:28 +00:00
Guy Harris
a95d1209eb Squelch a compiler pointer vs. integer warning - NULL is for pointers,
'\0' is for characters.

svn path=/trunk/; revision=14868
2005-07-07 04:05:01 +00:00
Guy Harris
e2d750eab5 Add a cast to SET_ADDRESS() to squelch GCC4 "differ in signedness"
warnings.  Use SET_ADDRESS in the VOIP calls code, rather than
explicitly filling in "pstn_add".

svn path=/trunk/; revision=14867
2005-07-07 04:03:35 +00:00
Guy Harris
2465355c7b Explicitly initialize all the elements of a voip_calls_tapinfo_t, to
squelch a compiler warning.

svn path=/trunk/; revision=14866
2005-07-07 03:20:43 +00:00
Anders Broman
c8b69874cb From Alejandro Vaquero
- avoid the clist of the calls dlg to be refreshed multiple times when 
first appear.
- destroy the Graph window when the data is not valid anymore.
- fixes an H245 packet count error
- resizing the Graph windows when is displayed (up to 5 columns).
With a change to leave static voip_calls_tapinfo_t the_tapinfo_struct =
	{0, NULL, 0, NULL, 0, 0, 0, 0, NULL, 0, 0, 0, 0, 0, 0, 0, 0, 0};
alone.

svn path=/trunk/; revision=14852
2005-07-05 05:16:28 +00:00
Anders Broman
0b90c61ac8 From Ainsley Pereira:
If you have an RTP stream in which the first packet is duplicated, and has the marker bit set, then the RTP stream analysis will try to pad silence into a temporary file from 0 upto whatever the RTP timestamp is (which is enough to fill up my disk...). The  patch fixes this misbehaviour.

svn path=/trunk/; revision=14850
2005-07-05 04:30:59 +00:00
Ulf Lamping
22fff1e1f3 fix #271: don't do:
g_free(bytes); 

twice, probably a copy/paste error

svn path=/trunk/; revision=14829
2005-07-01 20:47:22 +00:00
Ulf Lamping
3d831f4bfb add a new DCE/RPC related column, which contains the call_id for connection oriented packets or the sequence number for connectionless (datagram) packets.
This is extremely useful, to keep track of the corresponding request/response packets of a DCE/RPC call (which can be quite a lot packets if fragmentation is used).

svn path=/trunk/; revision=14826
2005-06-30 22:46:19 +00:00
Guy Harris
3522c0719d More constification.
svn path=/trunk/; revision=14812
2005-06-28 22:15:12 +00:00
Guy Harris
3f01c028ba "Handle" a couple of cases in the switch statement by adding them to the
"not supported" case, to suppress compiler warnings.

svn path=/trunk/; revision=14811
2005-06-28 22:01:18 +00:00
Guy Harris
c1b4b3a760 "mtp3_sum_draw()" is never called with a null "table" argument - the
code before the call would have blown up if "table" were null.  Remove
the check for a null pointer; this squelches some unset-variable
warnings you get from GCC4 because its dataflow analysis runs across
function boundaries.

svn path=/trunk/; revision=14810
2005-06-28 21:43:24 +00:00
Anders Broman
06067ecc7c Add som more const qualifiers.
svn path=/trunk/; revision=14795
2005-06-27 08:13:41 +00:00
Anders Broman
8d5958785d From Alejandro Vaquero
new dissector for the AudioCodes trunk trace protocol. 
This protocol is used to debug the trunk protocol in AudioCodes 
gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart, 
etc...) trunk protocols. It also add these protocols in the "Voip Calls 
Graph..."

svn path=/trunk/; revision=14789
2005-06-27 06:20:23 +00:00
Ulf Lamping
630881b469 proto_hier_stats_dlg.c(99) : warning C4090: '=' : different 'const' qualifiers
svn path=/trunk/; revision=14766
2005-06-26 10:28:51 +00:00
Ulf Lamping
da12395ac6 sctp_graph_dlg.c(383) : warning C4244: '=' : conversion from 'unsigned int ' to 'float ', possible loss of data
svn path=/trunk/; revision=14765
2005-06-26 10:26:47 +00:00
Ulf Lamping
1c897f0559 remove compiler warnings:
main.c(345) : warning C4090: 'function' : different 'const' qualifiers
main.c(345) : warning C4022: 'simple_dialog_set_cb' : pointer mismatch for actual parameter 3

svn path=/trunk/; revision=14764
2005-06-26 10:23:39 +00:00
Ronnie Sahlberg
cc3b0df4ca From Alejandro, fix for GTK1 graph_analysis issue.
svn path=/trunk/; revision=14757
2005-06-26 00:12:15 +00:00
Ulf Lamping
df7520d2a1 we are not a GNU program, so we shouldn't report as such in the command line help output
svn path=/trunk/; revision=14753
2005-06-25 21:27:26 +00:00
Guy Harris
b67f63560e More constification.
svn path=/trunk/; revision=14740
2005-06-24 02:51:01 +00:00
Guy Harris
76258fe8e3 Constify a bunch of structure members and function arguments, to squelch
compiler warnings.

Clean up indentation.

svn path=/trunk/; revision=14739
2005-06-24 01:32:42 +00:00
Ulf Lamping
5ce6b0d8bc fix #135: handle the command line parameters -v, -h and -G completely in their own getopt() loop.
This is done "long before" calling gtk_init() as this function requires a running X server, causing an error if running from the console only.

svn path=/trunk/; revision=14736
2005-06-23 21:19:05 +00:00
Ulf Lamping
7d1f4d4dfa Win32: "fix" handling of create_console(), hopefully clarifying usage of the corresponding prefs flag
svn path=/trunk/; revision=14735
2005-06-23 20:18:17 +00:00
Ulf Lamping
826107f6cf beautify version and usage output
svn path=/trunk/; revision=14734
2005-06-23 20:14:05 +00:00
Anders Broman
2ab0496a72 From Mike Duigou:
In order to get filtering of conversations and
> endpoints to work from the endpoints and conversations windows I found 
> it necessary to add a new AT_URI address type and a SAT_JXTA. This also 
> necessitated a change to to_str.c to avoid a buffer overflow problem. 
> Please review these changes carefully.
> 
> Also includes some changes to the jxta dissector to fix filtering on
> generated fields and some changes to the types used for ints/unsigned ints.
> 
> Fixes a bug with the processing of messages containing namespaces.

svn path=/trunk/; revision=14714
2005-06-20 20:14:22 +00:00
Ulf Lamping
a1b6649a54 fix a typo in the usage output
svn path=/trunk/; revision=14678
2005-06-17 07:57:41 +00:00
Guy Harris
de1ed1e840 Get rid of unnecessary assignment and unnecessary "volatile" qualifier.
Mark unused parameter as such.

svn path=/trunk/; revision=14661
2005-06-16 10:05:23 +00:00
Guy Harris
ff38fe8476 Don't hand a null pointer to a "%s" format.
svn path=/trunk/; revision=14656
2005-06-16 06:41:28 +00:00
Guy Harris
72acd3728a Fix a typo, and squelch a compiler warning.
svn path=/trunk/; revision=14655
2005-06-16 06:34:27 +00:00
Guy Harris
7259a05303 Include <ctype.h> to define/declare "isspace()".
svn path=/trunk/; revision=14654
2005-06-16 06:33:49 +00:00
Ulf Lamping
6d1405fd29 don't call "Capture/Start" Capture but Start in the toolbar
svn path=/trunk/; revision=14644
2005-06-15 23:05:37 +00:00
Anders Broman
5e3a716014 From Javier Acuna
patch to include Cic info in Voip Calls

svn path=/trunk/; revision=14630
2005-06-14 21:48:42 +00:00
Ulf Lamping
4a2cdd3f42 add missing #include "webbrowser.h" from previous commit
svn path=/trunk/; revision=14614
2005-06-11 16:50:18 +00:00
Ulf Lamping
f20b5b0a32 add help button pointing to the wiki page
svn path=/trunk/; revision=14611
2005-06-11 12:12:12 +00:00
Ulf Lamping
ef20416f66 this is an attempt, please report problems:
after asking the devlist if this would break things and got no negative response, try to scan command line parameters twice, trying to "rewind" the getopt settings

this way, fixing #135

svn path=/trunk/; revision=14610
2005-06-10 19:09:49 +00:00
Ulf Lamping
e2f38f5456 fix positions of create_console()/destroy_console() calls for help and version output
svn path=/trunk/; revision=14602
2005-06-09 19:58:02 +00:00
Ulf Lamping
0489ec846e bugfix: don't crash, if cf->filename is NULL (which happens if an invalid capture filter is entered)
svn path=/trunk/; revision=14601
2005-06-09 19:55:55 +00:00
Anders Broman
abcecaaf90 From Alejandro Vaquero:
glib-object.h is is glib2 only.
 graph_analysis.c:47:25: glib-object.h: No such file or directory
 a patch for ths issue and also to correct the "first_item" 
issue reported in "RE: [Ethereal-dev] Voip graph analysis "Save as" button"

svn path=/trunk/; revision=14577
2005-06-07 15:21:22 +00:00
Anders Broman
6cdb6bf031 Add an ifdef and "dont apply patch twice".
svn path=/trunk/; revision=14563
2005-06-06 17:08:37 +00:00
Anders Broman
ca32dfb6a0 From Mike Duigou:
a patch which adds support for displaying jxta 
conversations and endpoints from the 'Statistics' menu. Also adds :

  - a generated field to Welcome messages to indicate whether this 
welcome is from the initiator or the receiver. You can filter on this 
field with 'jxta.welcome.initiator==[0|1]'

  - Marks the source and destination fields of message added in the last 
patch as generated fields. (Saw it being done for some other protocol).

  - Cleans up dissection of Message which used to assume it would 
dissected more than one set of hdr/message per tvbuff. Now it only 
attempts to dissect one.

- Uses GMemChunk for tap info and for conversation data rather than 
g_malloc() There's still a major leakage of g_malloc()ed the c-strings 
which are used in jxta addresses. Any suggestions for how these can be 
allocated such that they can be freed re-init is called would be 
appreciated. For address objects whose data ptr doesn't point into a 
tvbuff it's not clear what the lifecyle of an address object is.

  - Fixes a bug with filling in the of the transport layer conversation 
data. >= vs. >


svn path=/trunk/; revision=14559
2005-06-06 15:22:17 +00:00