From Colin McInnes:
Closes: #18964
Added VC IDs (Option 60) for:
RPD, RMD, eDOCSIS, sROUTER, DEMARC and TRIF
Used by CableLabs Vendor Info Heuristic for VSE (Option 43)
Depending on the negotiated security type, we can have RDSTLS packets at the
beginning of the conversation. This patch adds support for these packets and
adjust the heuristic accordingly.
This commit makes three changes to how
proto_tree links to the display filter reference page
located at https://www.wireshark.org/docs/dfref/ :
1) Previously, proto_tree tooltips did not match
the URL. For example, the tooltip would have:
https://www.wireshark.org/docs/dfref/t/tcp.seq_raw
but would link to:
https://www.wireshark.org/docs/dfref/t/tcp
, which would then 302 redirect to:
https://www.wireshark.org/docs/dfref/t/tcp.html
This commit fixes how the tooltip is generated
so the URL and tooltip are the same.
2) The URL now directly links to the page
ending with '.html', avoiding the 302 redirect
3) As of #19222, the display filter reference page
contains anchor tags for each field. This commit
also improves the proto_tree URLs by directly
linking to the anchor tag for the particular
field being referenced, instead of the
less-specific page as a whole.
That way, we can do as much dissection as possible before hitting either
the snapshot length or a too-short packet length.
Instead of fetching everything in advance and filling in the text of the
top-level protocol tree entry and the Info column all at once, fetch
them at the same time out add them to the protocol tree, and append to
those two items as fields become available.
Instead of having a global init.lua in datafile_dir that may
contain library code, load the init.lua script from the plugins
directories, similar to other Lua scripts, but guaranteed to
be the first one loaded.
This is consistent with our practice and avoids overwriting the
customizable share/wireshark/init.lua with each instalation or
upgrade.
It also should allow using package.path correctly (which does
not include the configuration directory).
The init.lua in the configuration directory is still loaded for
backward compatibility. It generates a warning in the console.
Add two new fields `capture_types` and `encap_types` to the output of
`sharkd`'s `info` method which replicate the info displayed by
`editcap -F` and `editcap -T`, respectively.
Adds a new menu under Tools to launch a browser with the
SSLKEYLOGFILE environment variable set.
Adds a new GUI preference to store the browser path specific
to the SSL Keylog dialog (which may be different from the user's
preferred system browser).
Enable synchronous name resolution in `sharkd` via a call to
`set_resolution_synchrony` in `sharkd_session_main`. Work for
supporting synchronous calls to `mmdb_resolve` for MaxMind GeoIP seems
to have been done and is also enabled by the
`set_resolution_synchrony` call.
Fix a bug that was using `uat_clear` in `sharkd`'s `main` function to
stop an existing `mmdb_resolve` process. Using `uat_clear` also wipes
out any custom configuration set by the `maxmind_db_paths` UAT, which
we don't want. By instead calling the UAT's `reset_cb` callback, we
can stop the old `mmdb_resolve` process without erasing the UAT in the
child `sharkd` process.
See 0542c5b7 for an explanation as to why performing synchronous name
resolution in `tshark` is important. The same reasoning applies for
`sharkd` as well.
Pass a pointer to the IPv6 address instead of a pointer to the pointer.
Fixes#19294
Fixes: v2.9.0rc0-666-g0542c5b700 ("Do IP address resolution synchronously before printing in TShark.")
Increase the request transfer length by 8 to accommodate for merged
in SETUP data. This makes the dissector correctly reassemble control
transfers where there is less than 9 bytes in the last data chunk.
Commit a4c6a2f1 added a `voip-calls` tap to `sharkd`, but a copy-paste
bug in `sharkd_session_process_tap_voip_calls_cb` caused each call's
`stop_time` field to actually be the call's start time. This commit
fixes this bug and updates the `test_sharkd_req_tap_voip_calls` unit
test accordingly.
Gerald Combs