Commit Graph

25234 Commits

Author SHA1 Message Date
Guy Harris 6995b0b392 Combine the cd and the make on one lien for the checkapi rules;
otherwise, the cd runs independently of the make, and the make runs in
the current directory and thus runs another "make checkapi" (forkbomb
los!).

svn path=/trunk/; revision=25657
2008-07-02 01:53:29 +00:00
Guy Harris a04774395f Add Makefile.common files for epan/dfilter and epan/ftypes.
Add checkapi rules to Makefile.am files.

svn path=/trunk/; revision=25656
2008-07-02 01:44:30 +00:00
Guy Harris 40773753ad Get rid of a misleading comment (it says "no need to modify anything
under here", right above a comment that tells you what you need to
modify under there...).

svn path=/trunk/; revision=25655
2008-07-02 01:43:50 +00:00
Guy Harris b5fc663751 libwireshark.def is in the EXTRA_DIST in epan/Makefile.am; we don't need
it in our EXTRA_DIST.

svn path=/trunk/; revision=25654
2008-07-02 01:40:51 +00:00
Guy Harris b6e20d89be Put printf into a separate "termoutput" API group. For most files,
check for it - but not for TShark plugins, as they are expected to
print to the standard output.

svn path=/trunk/; revision=25653
2008-07-01 21:13:32 +00:00
Anders Broman df8081391b Fix bug "iax2 dissector always reports retransmission bit to be false"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2666

svn path=/trunk/; revision=25652
2008-07-01 21:05:45 +00:00
Anders Broman 8a59a33405 Get rid of some unused code warnings. Hopefully without breaking anything.
svn path=/trunk/; revision=25651
2008-07-01 20:53:22 +00:00
Guy Harris 3d18ce8e87 The intended argument for "-g" was presumably "abort", given Gerald's
checkin comment (that Wiretap routines shouldn't abort the program).

svn path=/trunk/; revision=25650
2008-07-01 20:30:21 +00:00
Guy Harris d299a7f556 Unless I've misread the GetOptions documentation, the "-g" flag to
checkAPIs.pl takes a mandatory string argument, not an optional string
argument.

svn path=/trunk/; revision=25649
2008-07-01 20:28:26 +00:00
Anders Broman f56f92673e Update the ASN.1 files.
svn path=/trunk/; revision=25648
2008-07-01 19:58:01 +00:00
Anders Broman 4cd09cde05 Get rid of some unused code warnings.
svn path=/trunk/; revision=25647
2008-07-01 19:57:03 +00:00
Stig Bjørlykke 673a730de3 Added a new make target, osx-app, to build only the app and not the dmg.
This is usefull when using the app locally.

svn path=/trunk/; revision=25646
2008-07-01 13:39:09 +00:00
Anders Broman bd0598cc55 Get rid of some unused code warnings.
svn path=/trunk/; revision=25645
2008-07-01 12:55:08 +00:00
Anders Broman fbcb77edf8 Get rid of some unused code warnings.
svn path=/trunk/; revision=25644
2008-07-01 12:54:33 +00:00
Guy Harris 64aac645aa unicode-utils.h is in wsutil now.
svn path=/trunk/; revision=25643
2008-07-01 02:57:35 +00:00
Jeff Morriss 3a2848cf46 SET_ADDRESS should not be called with an address type of FT_IPv4 but rather AT_IPv4.
svn path=/trunk/; revision=25642
2008-06-30 18:57:13 +00:00
Jeff Morriss 8980883a4e Move privileges.c and unicode-utils.c symbols from epan to wsutil
svn path=/trunk/; revision=25641
2008-06-30 18:07:34 +00:00
Jeff Morriss 83f9ecf96f Move privileges.c and unicode-utils.c from epan to wsutil (so things like
capinfos and dumpcap don't need to depend on libwireshark nor directly pull
in those modules).  Because capinfos and editcap were only being linked with
privileges.c if we had plugins, this allows those programs to be linked when
someone is compiling --without-plugins.

svn path=/trunk/; revision=25640
2008-06-30 17:16:29 +00:00
Gerald Combs 6d4f9c1eda When we open a debug console on Windows, don't grab stdin. We never read
anything on this particular console, and if we open stdin here we can't
read a capture from an anonymous pipe.

svn path=/trunk/; revision=25638
2008-06-30 16:36:37 +00:00
Jeff Morriss e62c7c54d1 Create the MTP3 TVB (if any) with a reported length that mirrors the reported length of the frame. That way subdissector exceptions on short frames will (properly) show up as 'packet size limited during capture'.
svn path=/trunk/; revision=25637
2008-06-30 15:23:11 +00:00
Jeff Morriss b54acc9ad7 From Abhik Sarkar via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2661 : fix prototypes of tvb_fake_unicode() and tvb_get_ephemeral_faked_unicode()
svn path=/trunk/; revision=25636
2008-06-30 13:46:34 +00:00
Jaap Keuter 98899e9996 Fix for bug 2659:
Account for IPv6 addresses representation in Via header.

svn path=/trunk/; revision=25635
2008-06-30 06:35:22 +00:00
Bill Meier 56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
Sake Blok cd7405c44d From Kovarththanan Rajaratnam (bug 2657):
Resolve accelerator ambiguity in filter toolbar


svn path=/trunk/; revision=25633
2008-06-29 14:59:23 +00:00
Sake Blok 50fa079b11 From Kovarththanan Rajaratnam (bug 2658):
Leading $ will now be propageted to display filter entry (on keyboards
where AltGr needs to be used to enter a '$').


svn path=/trunk/; revision=25632
2008-06-29 12:55:14 +00:00
Michael Tüxen 5429cd6600 * Fix a bug reported by Peter Hertting: Handle more than one integer interface identifier.
* Call parameters parameter.
* List integer interface ranges in range parameters.


svn path=/trunk/; revision=25631
2008-06-29 10:15:41 +00:00
Sake Blok be8956d104 Add accelerator keys for (un)mark all packets
svn path=/trunk/; revision=25630
2008-06-29 09:01:12 +00:00
Sake Blok 9fe2206771 From Kovarththanan Rajaratnam (bug 2652):
Add accelerator keys for Find Next/Previous Reference


svn path=/trunk/; revision=25629
2008-06-29 08:36:24 +00:00
Bill Meier 33af75a599 Fix some warnings reported by gcc -Wshadow ...
svn path=/trunk/; revision=25628
2008-06-28 21:09:57 +00:00
Anders Broman d897f46ed2 Get rid of some unused code warnings.
svn path=/trunk/; revision=25627
2008-06-28 20:58:35 +00:00
Anders Broman c756e273f9 Get rid of some unused code warnings.
svn path=/trunk/; revision=25626
2008-06-28 20:53:13 +00:00
Anders Broman 36916d5ac5 Add som missing extension IE's and try to get rid of som unused code warnings.
svn path=/trunk/; revision=25625
2008-06-28 20:31:56 +00:00
Anders Broman 028c6a75bd To handle 64 bit constraints we also need to change FT_UINT32 to FT_UINT64
svn path=/trunk/; revision=25624
2008-06-28 19:25:15 +00:00
Anders Broman 09a741cb17 Add FT_INT64 to IS_FT_INT and FT_UINT_64 to IS_FT_UINT.
svn path=/trunk/; revision=25623
2008-06-28 17:23:07 +00:00
Guy Harris 8e03447dd4 Set the Info column.
svn path=/trunk/; revision=25622
2008-06-28 01:51:12 +00:00
Guy Harris 78f43162ad If we find an invalid version number, at least put something into the
Info column and protocol tree to indicate that.

If we find an invalid version number in the *second* switch statement,
don't bother spewing out a warning - that's a "cannot happen", so just
throw a dissector assertion.

svn path=/trunk/; revision=25621
2008-06-27 23:47:25 +00:00
Gerald Combs b642ef10fa Have checkAPIs.pl print to stderr, so that its output is colored red in
Buildbot. Make capitalization more consistent. Look for abort functions in
wsutil.

svn path=/trunk/; revision=25619
2008-06-27 22:48:25 +00:00
Bill Meier f8e3822738 Fix some warnings reported by gcc -Wshadow ...
Fix some spacing in packet-dcom.c

svn path=/trunk/; revision=25618
2008-06-27 16:15:30 +00:00
Gerald Combs 09868c5db5 Fix some checkAPIs warnings.
svn path=/trunk/; revision=25617
2008-06-27 16:07:21 +00:00
Bill Meier 7aaadd9bec Fix some warnings reported by gcc -Wshadow ...
svn path=/trunk/; revision=25616
2008-06-27 04:52:56 +00:00
Gerald Combs 6012eaeafb Wiretap code probably shouldn't abort the application either.
svn path=/trunk/; revision=25615
2008-06-26 23:43:15 +00:00
Gerald Combs 83aacf0a09 Add support for "API groups" in checkAPIs.pl. Make the "prohibited"
and "deprecated" groups the default. Add an "abort" group for code that
shouldn't exit the program. Update the makefiles to call "checkAPIs.pl
-g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl.

svn path=/trunk/; revision=25614
2008-06-26 22:20:05 +00:00
Jeff Morriss 708fbadf26 Fix a comment: the subdissector won't /assert/ out it will /except/ out if the MSU is truncated.
svn path=/trunk/; revision=25613
2008-06-26 20:42:58 +00:00
Jeff Morriss 9bc8f579a1 From Abhik Sarkar via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2647 :
The syslog dissector could crash if the "packlog" MSU is truncated such that
the hex string ends in with a nibble.

From me: Check if that will happen and chop off the nibble before giving it to
convert_string_to_hex() so we'll dissect as much of the MSU as possible.

svn path=/trunk/; revision=25612
2008-06-26 20:40:30 +00:00
Gerald Combs 72965329b0 Remove a lot of vestigal GTK-Wimp stuff. It's been included with
GTK+ since version 2.8, when its name was changed to the "GTK MS
Windows-Engine."

Simplify the Windows installer by removing the GTK-Wimp option (which
means the "Wireshark" item can be an entry instead of a group). Move
Rawshark to the "Tools" group.

(If anyone wants to disable the MS Windows Engine they can still do so
after installation by disabling or removing libwimp.dll.)

svn path=/trunk/; revision=25611
2008-06-26 16:42:07 +00:00
Guy Harris 3ac07269e6 Fix a missed "item" -> "item_local" in the previous checkin.
svn path=/trunk/; revision=25610
2008-06-26 02:29:13 +00:00
Guy Harris 18bc1a2fef Make the default for HDLC traffic "Raw data", just as it is for other
record types, so that people know they have to set the preference.

svn path=/trunk/; revision=25609
2008-06-26 01:47:59 +00:00
Guy Harris 1f08653d0e Make the preference settings for the dissector to use for various ERF
link-layer types static.

If the preference is set to "raw data" for any of those types, display
the raw data with an indication that the preference in question has been
set to "raw data", so people don't just wonder why ERF files aren't
working right any more.  (See bug 2641; I had the same surprise when I
tried it on some ERF captures I have.)

Pull the dissect_erf_header() code into dissect_erf() - it's dissecting
the *payload*, not the *header*.

Fill in the Info column with the record type.

When using tvb_new_subset() to chop a header off of a tvbuff, just
specify lengths of -1, so we go all the way to the end.

Clean up the Infiniband dissector call.

svn path=/trunk/; revision=25608
2008-06-26 01:38:38 +00:00
Bill Meier ceebccced4 Fix some warnings reported by gcc -Wshadow ...
svn path=/trunk/; revision=25607
2008-06-26 00:16:58 +00:00
Gerald Combs e783130961 We last supported NT 4.0 with version 0.99.4 (according to
wireshark.nsi, at least). Drop it from the "supported" list and add a
note about NT 4.0 and older Windows versions.

svn path=/trunk/; revision=25606
2008-06-25 23:07:40 +00:00