Jeff Morriss
1944665283
tvb_format_text() returns a pointer chars, not guint8s
...
svn path=/trunk/; revision=25714
2008-07-11 20:15:52 +00:00
Jeff Morriss
8b4468cacd
Fix a couple signed/unsigned char mismatches (still more here)
...
svn path=/trunk/; revision=25713
2008-07-11 20:12:22 +00:00
Jeff Morriss
2a89ea15d5
Cast away the unsignedness of a string (which has had EBCDIC_to_ASCII() run on it)
...
svn path=/trunk/; revision=25712
2008-07-11 20:05:44 +00:00
Jeff Morriss
83b913dd13
prefs_register_uint_preference() takes a pointer to a guint, not a pointer to gint.
...
svn path=/trunk/; revision=25711
2008-07-11 20:00:41 +00:00
Jeff Morriss
28426d27ff
prefs_register_uint_preference() takes as its argument a pointer to a uint, not a pointer to a gboolean. Similarly prefs_register_enum_preference takes a pointer to a gint, not a guint.
...
svn path=/trunk/; revision=25710
2008-07-11 19:56:43 +00:00
Jeff Morriss
83ae90ae83
In a call to proto_tree_add_bytes_format(): actually pass a pointer to the start of the bytes
...
svn path=/trunk/; revision=25709
2008-07-11 19:48:30 +00:00
Jeff Morriss
bb72192654
Change a string's declaration from guint8 to a gchar
...
svn path=/trunk/; revision=25708
2008-07-11 19:30:10 +00:00
Jeff Morriss
9d67d57cad
Change a guchar to gchar: it's used as a regular string
...
svn path=/trunk/; revision=25707
2008-07-11 19:18:54 +00:00
Jeff Morriss
19e29f228f
Remove some dead (statement not reached) code (while trying to avoid any false control reaches end of non-void function warnings)
...
svn path=/trunk/; revision=25706
2008-07-11 18:56:03 +00:00
Jeff Morriss
ccd5751c19
packet-k12.c expects pseudo_header->k12.extra_info to be guchar so make it a unsigned
...
svn path=/trunk/; revision=25705
2008-07-11 16:37:21 +00:00
Jeff Morriss
2cd9755e81
unicode-utils.c is only for Windows; don't build it on UN*X. Put in a check
...
to cause it to fail when built on UN*X.
svn path=/trunk/; revision=25704
2008-07-11 16:18:32 +00:00
Jaap Keuter
77c287a58c
From Frank Wang:
...
The ULMAP decoder can get a wrong bit offset when decoding CQICH_Alloc_IE.
The finishing position shoud not pad to byte but pad to the length specified,
which can be nibble aligned.
svn path=/trunk/; revision=25703
2008-07-11 16:03:06 +00:00
Jeff Morriss
0c18cbc98f
(Finally) stop guint16s to access a string: just treat it as an array of chars and swap them "the hard way".
...
svn path=/trunk/; revision=25702
2008-07-11 15:16:03 +00:00
Guy Harris
b92594e56c
ASCII (well, alphabetic, really) until proven otherwise; that fixes a
...
warning, which is a valid warning if the length is 0.
Clean up indentation a bit.
svn path=/trunk/; revision=25701
2008-07-11 03:16:54 +00:00
Guy Harris
08b4f712c8
Note bug 2699, which reports a bug in xdg-open.
...
svn path=/trunk/; revision=25700
2008-07-10 18:36:19 +00:00
Guy Harris
2577fe6e01
Include <ctype.h> to define isalpha().
...
svn path=/trunk/; revision=25699
2008-07-10 18:35:11 +00:00
Jeff Morriss
7ab9808489
Cast that guint16 into a char before trying to NULL terminate the string (so that we only set 1 byte to 0, not 2).
...
svn path=/trunk/; revision=25697
2008-07-10 13:42:51 +00:00
Gerald Combs
98f5096bbd
Replace r25638 with a better fix. On Windows, don't open a console window if
...
we've been passed "-i -", since it clobbers stdio.
svn path=/trunk/; revision=25695
2008-07-09 23:28:18 +00:00
Jeff Morriss
8580c6ab54
Don't declare a char[] then cast it into a guint16 to use it as both a guint16 and a char: the char[] alignment may not be correct for a guint16. Instead declare a guint16[] and cast it to char when needed. This is still weird but it fixes a Solaris/SPARC warning.
...
svn path=/trunk/; revision=25693
2008-07-09 21:22:00 +00:00
Jeff Morriss
9bd70e0d1d
Don't cast a char[] into a guint32/64: the array may not be aligned correctly. This fixes a warning on Solaris/SPARC.
...
svn path=/trunk/; revision=25692
2008-07-09 20:16:24 +00:00
Jeff Morriss
34e3e26d07
Reindent some to get things a bit more consistent/readable.
...
svn path=/trunk/; revision=25691
2008-07-09 20:09:23 +00:00
Jeff Morriss
74c02268d8
Add MP3 to the list of magic types
...
svn path=/trunk/; revision=25690
2008-07-09 19:15:50 +00:00
Jaap Keuter
0f199f4bff
From Sven Eckelmann:
...
Just forgot to set inited variable in reg_handoff_bat_*().
svn path=/trunk/; revision=25689
2008-07-09 19:10:54 +00:00
Jaap Keuter
e957d8ad1a
From Motonori Shindo:
...
Currently, sFlow dissector only recongnizes "Header" as the packet data type.
This patch enhances it to support "IPv4" and "IPv6" packet data type.
This patch seems to work well against sFlow packets exported from AlaxalA switch.
svn path=/trunk/; revision=25688
2008-07-09 18:37:50 +00:00
Martin Mathieson
f37686bc6f
Initialise type to avoid warning.
...
I'm pretty sure that it won't be used uninitialised, and that the code could be more clearly arranged to make this obvious to the compiler too.
svn path=/trunk/; revision=25685
2008-07-09 14:50:05 +00:00
Jaap Keuter
b29e8aed10
From Paolo Abeni:
...
- the StringInfo allocator may fail when a 0 data length is requested
- many wrong values into the cipher_suites table
- duplicated code for ssl session state checking before each
ssl_generate_keyring_material() call
- missing initialization of 'server_data_for_iv.data_len' and
'client_data_for_iv.data_len' in ssl_session_init()
From Jaap Keuter:
- Some code rationalisation
- Gammatical/factual corrections in output and comments
- Whitespace cleanup
svn path=/trunk/; revision=25684
2008-07-09 07:24:13 +00:00
Bill Meier
c63145b3d9
Fix some spacing .....
...
svn path=/trunk/; revision=25683
2008-07-09 02:30:39 +00:00
Bill Meier
d0258115a6
Fix some mis-spellings
...
svn path=/trunk/; revision=25682
2008-07-09 01:30:30 +00:00
Bill Meier
65bcd0d67f
Display "Decompression failed" when appropriate (& Fix some src spacing)
...
svn path=/trunk/; revision=25681
2008-07-08 22:36:35 +00:00
Jeff Morriss
a3e69d9ec5
Tighten heuristics a bit: if the caplen or iplen is 0 then it's not a valid CSIDS file
...
svn path=/trunk/; revision=25680
2008-07-08 22:24:32 +00:00
Jeff Morriss
be97290991
Tighten heuristics a bit: traces with packets longer than 16k are no good (is this a valid limit?)
...
svn path=/trunk/; revision=25679
2008-07-08 22:23:26 +00:00
Sake Blok
feac4247db
From Randy McEoin (bug 2654):
...
Avaya IPSI Control dissector
svn path=/trunk/; revision=25678
2008-07-08 21:44:05 +00:00
Jeff Morriss
73f7073540
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2649 by adding some length checks to two while loops in tvb_uncompress()
...
svn path=/trunk/; revision=25677
2008-07-08 20:04:11 +00:00
Martin Mathieson
6f286b94fb
Register raw_sip.line with correct protocol, as noticed while testing
...
patch for 2581.
svn path=/trunk/; revision=25676
2008-07-08 16:32:56 +00:00
Martin Mathieson
5283264092
Fix bug 2662 (ULMAP HARQ_ULMAP_IE decode error).
...
From Frank Wang.
I'd prefer to delete wrong code, but we'll see if anyone misses it.
svn path=/trunk/; revision=25675
2008-07-08 16:05:41 +00:00
Bill Meier
c18d922045
Fix compile error
...
svn path=/trunk/; revision=25674
2008-07-08 03:21:54 +00:00
Bill Meier
d3fc3b6c3e
Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
...
gtk_button_box_set_spacing() ==> gtk_box_set_spacing()
svn path=/trunk/; revision=25673
2008-07-08 02:43:40 +00:00
Bill Meier
44efa0ed2e
Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
...
gtk_timeout_add() ==> g_timeout_add
gtk_timeout_remove() ==> g_source_remove()
Also: timer callback should return gboolean (not void or gint)
svn path=/trunk/; revision=25672
2008-07-08 02:25:30 +00:00
Bill Meier
e1a5e58ac1
Fix benign usage of incorrect symbol in #ifdef
...
svn path=/trunk/; revision=25669
2008-07-04 12:52:16 +00:00
Guy Harris
e82d99d2b4
If we have pcap_free_datalinks(), use it. If not, then, on Windows,
...
just leak the list returned by pcap_list_datalinks(), as there's no
guarantee that if you have a library built with one version of the
MSVC++ run-time library, and it returns a pointer to allocated data, you
can free that data from a program linked with another version of the
MSVC++ run-time library. (This is not an issue on UN*X.)
This should fix bug 2677.
svn path=/trunk/; revision=25668
2008-07-04 03:33:00 +00:00
Guy Harris
d1275537c0
Get rid of #defines that are no longer being used (we now have a port
...
range list preference for HTTP, which we initialize to the default list).
svn path=/trunk/; revision=25667
2008-07-03 19:50:15 +00:00
Jeff Morriss
e4730dce77
packet-pkcs12-template.c uses the libgcrypt symbol GCRY_CIPHER_RFC2268_40
...
which, according to:
http://lists.gnupg.org/pipermail/gnupg-devel/2004-February/020779.html
is new to the 1.1.92 release of libgcrypt. Bump our required version of
libgcrypt from 1.1.42 to 1.1.92 .
svn path=/trunk/; revision=25666
2008-07-03 15:57:34 +00:00
Bill Meier
dbc6a778a8
From: Kovarththanan Rajaratnam; Add Windows browse file makefile target
...
svn path=/trunk/; revision=25665
2008-07-03 00:16:28 +00:00
Anders Broman
9fc3601684
Revert previous change.
...
svn path=/trunk/; revision=25664
2008-07-02 18:11:27 +00:00
Anders Broman
b17f41d62a
See if this gets rid of some unused code warnings...
...
svn path=/trunk/; revision=25663
2008-07-02 16:32:48 +00:00
Guy Harris
1f46ed6f11
COPYING is already put into the tarball; we don't need to add it here.
...
svn path=/trunk/; revision=25662
2008-07-02 08:50:11 +00:00
Guy Harris
6b1c9b4948
Push EXTRA_DIST entries into the lowest-level Makefile.am available.
...
svn path=/trunk/; revision=25661
2008-07-02 07:12:42 +00:00
Guy Harris
e937ed67bb
Put the EXTRA_DIST items for the doc directory in doc/Makefile.am (which
...
doesn't need to be one of those items).
svn path=/trunk/; revision=25660
2008-07-02 05:08:43 +00:00
Guy Harris
35ce35ebf5
Include the new Makefile.common file.
...
svn path=/trunk/; revision=25659
2008-07-02 02:18:53 +00:00
Guy Harris
3f215ba230
This directory needs some checkapi love; it's not yet ready for that to
...
be a default part of the build process, now that we're doing some more
checking.
svn path=/trunk/; revision=25658
2008-07-02 02:00:28 +00:00