Commit graph

141 commits

Author SHA1 Message Date
Jeff Morriss
3729335973 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45016
2012-09-20 01:48:30 +00:00
Guy Harris
dfe0389590 Move the AX.25 address routines to address_to_str.c, where they belong;
hopefully this will fix some of the build errors.

svn path=/trunk/; revision=44219
2012-08-02 18:51:40 +00:00
Guy Harris
835111692f From Richard Stearn: support for AX.25, including support for
LINKTYPE_AX25.

svn path=/trunk/; revision=44211
2012-08-02 16:54:43 +00:00
Jakub Zawadzki
bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Chris Maynard
557ab87a9b Trivial typo: of -> or
svn path=/trunk/; revision=42458
2012-05-07 04:15:10 +00:00
Gerald Combs
8b3024e57c Make bit_offset in _tvb_get_bits64 and related functions unsigned. This
removes a potential buffer overflow and should fix a bunch of Coverity
errors mentioned in bug 6878.

We might want to do the same for no_of_bits.

svn path=/trunk/; revision=41945
2012-04-04 21:54:22 +00:00
Guy Harris
0bd7a24d4b Put back the checks for null arguments, but report a dissector bug if
we're given null pointers.

Put in comments clarifying that some routines intentionally do *not*
null terminate the strings they produce.

svn path=/trunk/; revision=40194
2011-12-14 02:46:16 +00:00
Guy Harris
dfe020b5f9 Back the previous change out; I'll be checking in a change to throw a
dissector bug exception in cases where a null pointer was passed, as
those really *are* dissector bugs (and I have a fix for the bug in
question in the HP Teaming heartbeat dissector, which I'll be checking
in later).

svn path=/trunk/; revision=40193
2011-12-14 02:03:05 +00:00
Chris Maynard
47116e864c Protect against NULL pointers as input. Based on the stacktrace provided, this should avoid crashes reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6634
svn path=/trunk/; revision=40176
2011-12-13 16:50:34 +00:00
Bill Meier
4f420ef6cd Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings
svn path=/trunk/; revision=37600
2011-06-07 22:28:55 +00:00
Jakub Zawadzki
453d0a8568 Introduce ip6_to_str_buf_len (little cleaner version of inet_ntop6 from wsutil/inet_ntop.c)
and use it instead of inet_ntop(AF_INET6, ...)

- Add MAX_IP6_STR_LEN define.
- use MAX_IP6_STR_LEN as a buffer size when ip6_to_str_buf() is used.

svn path=/trunk/; revision=37000
2011-05-05 20:48:21 +00:00
Chris Maynard
ee36a5cfbe Use g_strlcat instead of strcat: Coverity 632.
svn path=/trunk/; revision=36598
2011-04-12 18:16:55 +00:00
Jaap Keuter
1be49d98a5 From Matthew Parris:
Display "Day of Year" for January 1 as 1, not 0.

svn path=/trunk/; revision=35949
2011-02-15 07:14:22 +00:00
Stig Bjørlykke
3d11d9c9d9 Print "0 seconds" when time_val==0 in functions converting seconds to string.
svn path=/trunk/; revision=35640
2011-01-24 19:33:36 +00:00
Bill Meier
2276b10ddf Add a comment about not needing to g_free() the value returned from g_locale_to_utf8().
svn path=/trunk/; revision=35240
2010-12-21 21:01:01 +00:00
Bill Meier
7d0c23a125 Fix a GCC error.
svn path=/trunk/; revision=35087
2010-12-01 02:18:01 +00:00
Bill Meier
bd793cd800 On Windows: convert _tzname[] strings from the system charset to UTF8 before use.
In the Windows C Runtime the strings in the global array _tzname[]
   are encoded using the "system default ansi code page".
   They must be converted to UTF8 before use by Wireshark/GTK.
   (See comment in the code for details).

   Fixes Bug #5421 (I hope).
   https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5421

Also: Fix bug: when the timezone name is not available from the system
      ?ST was used when ?DT should have been used (and vice-versa).

svn path=/trunk/; revision=35086
2010-12-01 01:31:49 +00:00
Guy Harris
927b7da346 Have abs_time_to_str() and abs_time_to_str_secs() take an additional
argument indicating whether to include the time zone in the string.  If
we're constructing a display filter, don't include the time zone,
otherwise do.  Fixes bug 4756.

svn path=/trunk/; revision=32913
2010-05-21 06:33:25 +00:00
Bill Meier
6812b68eb1 From Yaniv Kaul: constify parameters
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422

 From me: Fix a number of instances where the function prototype or
  the function definition wasn't changed so there was a mismatch 
  thus causing Windows (but not gcc) compilation errors.

svn path=/trunk/; revision=32365
2010-04-03 18:18:50 +00:00
Bill Meier
d32b4c0758 Revert SVN #32360 until Windows compilation errors corrected.
svn path=/trunk/; revision=32361
2010-04-02 15:18:03 +00:00
Bill Meier
049f9eac85 From Yaniv Kaul: constify parameters
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422

svn path=/trunk/; revision=32360
2010-04-02 14:37:49 +00:00
Guy Harris
adde80ad43 From Jakub Zawadzki: split off the address-to-string functions, except
for ip_to_str_buf(), into address_to_str.c.

Fix up the SVN attributes for time_fmt.h while we're at it.

svn path=/trunk/; revision=32038
2010-02-27 21:41:12 +00:00
Guy Harris
45bed99e2b Squelch some compiler warnings.
svn path=/trunk/; revision=32036
2010-02-27 20:12:47 +00:00
Guy Harris
500eb99cd9 Add a third date format, ABSOLUTE_TIME_DOY_UTC, to show UTC with the
date as YYYY/DDD, where DDD is a 1-origin day of year.  Move the formats
to a "time_fmt.h" file, included by the headers that use it.  Have
abs_time_to_str() and abs_time_secs_to_str() take the date format value,
rather than a Boolean "show this as UTC" flag, as an argument.  Document
the ABSOLUTE_TIME_ formats a bit better.  Use that format in the CCSDS
and VCDU dissectors, rather than having those dissectors do the
formatting themselves.

svn path=/trunk/; revision=32034
2010-02-27 19:01:27 +00:00
Anders Broman
35574147d7 From Jakub Zawadzki:
Don't sigsegv on negative bd_len in bytes_to_str*

svn path=/trunk/; revision=31986
2010-02-24 12:59:09 +00:00
Anders Broman
4e66c899d1 From Jakub Zawadzki:
Optimizations.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4303

svn path=/trunk/; revision=31967
2010-02-23 19:28:38 +00:00
Bill Meier
9d663d7081 Fix various gcc -Wshadow warnings.
svn path=/trunk/; revision=31720
2010-01-28 18:45:46 +00:00
Bill Meier
e0064797fb Use more unique names for certain enum constants.
(enum constant names are part of the global name space).
(Fixes at least one gcc -Wshadow warning).

svn path=/trunk/; revision=31572
2010-01-19 19:37:03 +00:00
Guy Harris
818b8c3878 Protect against localtime() failing.
svn path=/trunk/; revision=31238
2009-12-11 08:08:05 +00:00
Guy Harris
38316e0483 The pointer is "tmp", not "tm".
svn path=/trunk/; revision=31237
2009-12-11 07:17:09 +00:00
Guy Harris
229b262e15 Squelch warnings.
svn path=/trunk/; revision=31236
2009-12-11 07:14:52 +00:00
Guy Harris
488253bfe7 Add the time zone abbreviation to the result of abs_time_to_str() and
abs_time_secs_to_str().

svn path=/trunk/; revision=31234
2009-12-11 03:39:17 +00:00
Guy Harris
4fde145bd2 Add an argument to abs_time_to_str() and abs_time_secs_to_str()
indicating whether the time should be shown as local time or UTC.  For
now, always pass FALSE, meaning "show as local time".

Clean up some stuff in the SNMP dissector, use abs_time_secs_to_str()
for times with one-second resolution, and update a comment in various
macros in the WSP dissector, while we're at it.

svn path=/trunk/; revision=31227
2009-12-10 22:19:29 +00:00
Guy Harris
4ac5594f7b Note that there are similar functions to the "to_hexstr" functions
in strutil.c.

svn path=/trunk/; revision=31212
2009-12-09 01:31:41 +00:00
Stig Bjørlykke
d71b1088f7 From Jakub Zawadzki:
Fix win64 build.

svn path=/trunk/; revision=31204
2009-12-08 10:17:37 +00:00
Anders Broman
e59f952b98 From Jakub Zawadzki:
Replace some g_snprintf() with 'probably' faster version.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4303

svn path=/trunk/; revision=31201
2009-12-08 07:45:06 +00:00
Anders Broman
88bb44a51e From Jakub Zawadzki:
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164

svn path=/trunk/; revision=30691
2009-10-25 11:43:30 +00:00
Kovarththanan Rajaratnam
d6122ad422 Reorder file to group related functionality
svn path=/trunk/; revision=29753
2009-09-06 15:06:41 +00:00
Kovarththanan Rajaratnam
f641693bf4 Change se_address_to_str() to call address_to_str_buf() directly
svn path=/trunk/; revision=29748
2009-09-06 14:39:53 +00:00
Kovarththanan Rajaratnam
8c48c6835f Rename address_to_str() to ep_address_to_str() because:
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
Stig Bjørlykke
f900d9c3a5 From Jakub Zawadzki via bug 3701:
Fix regressions in r29130 and r29133
In r29130 formating for DSECS was changed. (old: %01d now: %02d)
In r29133 adding sign was removed (old: buf[0] = '-' now: buf[0] = '\0')

svn path=/trunk/; revision=29146
2009-07-20 12:40:55 +00:00
Gerald Combs
25e7cac69d Fix an ep buffer overrun introduced in r29130.
svn path=/trunk/; revision=29133
2009-07-17 15:59:24 +00:00
Anders Broman
3278582767 From Kovarththanan Rajaratnam:
Optimize column fill path.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3701

svn path=/trunk/; revision=29130
2009-07-17 08:24:06 +00:00
Anders Broman
23b068e307 Introduce se_address_to_str()
svn path=/trunk/; revision=28973
2009-07-07 09:42:09 +00:00
Stig Bjørlykke
1ec579f62b Unsigned does not have msign.
svn path=/trunk/; revision=28842
2009-06-25 02:13:35 +00:00
Stig Bjørlykke
7221f30ab3 From Nathan Hartwell via bug 2733:
Added time_secs_to_str_unsigned().

svn path=/trunk/; revision=28840
2009-06-25 02:07:17 +00:00
Anders Broman
1464f7ca84 Introduce decode_bits_in_field() and use it.
clean up some left owers from previous checkin.

svn path=/trunk/; revision=28373
2009-05-15 18:38:13 +00:00
Gerald Combs
d6d9e7afdc Fix the last commit.
svn path=/trunk/; revision=28001
2009-04-08 17:55:35 +00:00
Gerald Combs
c2ae798ae2 More size_t fixes.
svn path=/trunk/; revision=28000
2009-04-08 17:31:12 +00:00
Gerald Combs
ffe205dd8b Check in a modified version of Alexey Neyman's patch from bug 2777. This should
also fix bug 2899. Make sure we only print a minus sign once and fixup a
comment.

svn path=/trunk/; revision=26302
2008-09-30 02:56:11 +00:00