- Fix typo which caused Properties|Descriptions value field to be incorrectly right-justified;
- Fix several (small) memory leaks;
- Rename variables & rework comments: What was a clist was replaced by a treeview/liststore;
- Remove a left-over line of code still calling a gtk_clist function;
- Rename some constants and variables to more closely reflect usage;
- Add some defensive coding;
- Use gtk_combo_box_get_active_text if GTK+ is 2.6 or greater;
- Simplify code in several places;
- Use consistent indentation;
svn path=/trunk/; revision=28398
Attached please find a patch that enables to heuristically find VNC
traffic on non-standard ports.
(it also adds some if(tree) ... around some proto_tree_add_item()
functions)
svn path=/trunk/; revision=28394
Not much, just a little bit of fine tuning:
- Spelling
- Added expert_add_info() for status responses with warning & error level
- Added command details in info column (optionally)
Also plugging memory leak.
svn path=/trunk/; revision=28392
use.
Rename some variables to reflect the names they have in the IGRP
document.
Don't treat being called with a non-IPv4 address as a dissector bug - we
can't prevent ourselves from being called from the IPv6 dissector. This
fixes bug 3466.
Clean up indentation.
svn path=/trunk/; revision=28390
Currently the randpkt random packet generator does not have support to
generate WTAP_ENCAP_USB and WTAP_ENCAP_USB_LINUX type packets.
svn path=/trunk/; revision=28388
The hexdump of the "Follow TCP Stream" feature creates a file that is about 160
characters wide. That's far beyond the size of my screen. The appended patch
suggests a narrower layout.
From me:
Add a note about prepending each line with "C" or "S" instead.
svn path=/trunk/; revision=28386
The attached patch updates wireshark to the radiotap RX flags leaving the
non-standard option to dissect bit 14 as "FCS in header".
Merge the patch by hand in a couple of places to avoid conflicts with
r26861.
svn path=/trunk/; revision=28385
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2824
I have added the SCM header to the wlccp dissector. This header is present in
packets of base message type 0x01. You can find the specification in the
following document, when you search for "The table below shows the fields for
an SCM Advertisement Reply Message.":
http://www.freepatentsonline.com/y2005/0220054.html
It seems like the header structure in the document is wrong regarding the "SCM
Node ID" (MAC address) field. From looking at the hexdumps I found out that the
node id shows up in the header before the "Instance Age" field. There is also a
2 byte field between the node id and the instance age, which is always zero. I
have named this field wlccp.scm_unknown_short, because I don't know what it is
for.
Me:
Fix two bugs that came up during testing but were present before the patch,
both involving wrong length handling triggering dissector assert and malformed
packet messages.
svn path=/trunk/; revision=28376
support for vendor-specific IEs. Fix variable-length record handling. Add
conversation tracking to the UDP dissector and add process flow
information to TCP and UDP conversations.
This lets us run process flow collectors on one or more machines and
have the process username, PID, command name, etc. show up in the TCP
and UDP protocol trees.
svn path=/trunk/; revision=28366
Stig Bjørlykke