Commit Graph

3147 Commits

Author SHA1 Message Date
Ronnie Sahlberg d9227587f0 prettify dissection of nfsv3 fattr3 structure
put useful info like type,mode,uid,gid on the expansion lines so we dont have to open the expansion to see these values.

allow it to push this info multiple expansion lines upward
and optionally (such as for GETATTR replies) put this info in the info column as well




svn path=/trunk/; revision=17783
2006-04-02 21:04:11 +00:00
Anders Broman 30ade25ed3 From Martin Mathieson:
Removes the use of the deprecated proto_tree_add_item_hidden() function

I was adding the 'msmms.command.unknown' field in lots of places (a 
habit of mine in my own dissectors), but this probably isn't useful.

svn path=/trunk/; revision=17782
2006-04-02 19:38:36 +00:00
Anders Broman 510b805e69 From Greg Morris:
Fixes bug 830
Adds a few more expert info details.
 

svn path=/trunk/; revision=17781
2006-04-02 19:37:12 +00:00
Anders Broman 89de25406b From Ming Zhang:
fix a minor error in mode_select, packet-scsi.c

svn path=/trunk/; revision=17780
2006-03-31 05:11:57 +00:00
Anders Broman 17d995edfa From Francesco Fondelli:
you find attached a patch for dissecting MPLS OAM pdus
as defind in Y.1711 ITU-T doc.

svn path=/trunk/; revision=17779
2006-03-31 05:09:37 +00:00
Anders Broman 84fb70ef42 call OID subdissector for private extensiions, fix makefiles.
svn path=/trunk/; revision=17772
2006-03-30 16:46:36 +00:00
Gerald Combs f87b0f78ae Fix an off-by-one error.
svn path=/trunk/; revision=17771
2006-03-30 16:13:37 +00:00
Jaap Keuter d53b9d7205 Update status codes from RFC 2616 and RFC 2518
svn path=/trunk/; revision=17769
2006-03-30 10:16:35 +00:00
Anders Broman e4f01d2051 From Martin Mathieson:
> > This patch adds a hidden 'sip.auth' field, that will be present 
> > whenever one of the authenticiation/authorization headers is 
> > present.
> >
> > I believe this is one place where hidden fields are justified:
> > - it is a substring of several sip.auth.* fields, so its reassuring 
> > to see the field turn green as you're typing in one of the visible 
> > fields
> > - it lets you quickly find all of the frames with any of these fields
> > (there are 4 different SIP headers that can contain the auth fields)

svn path=/trunk/; revision=17766
2006-03-30 05:02:06 +00:00
Guy Harris 015b486dc9 Get rid of an unused variable.
svn path=/trunk/; revision=17764
2006-03-29 22:11:42 +00:00
Guy Harris 01606f6114 Get rid of some unused variables.
svn path=/trunk/; revision=17763
2006-03-29 22:05:57 +00:00
Guy Harris 3ea3ee1fa2 Get rid of an unused function argument.
Clean up indentation.

svn path=/trunk/; revision=17762
2006-03-29 22:04:37 +00:00
Guy Harris 31e5e71b90 Close a comment to squelch a compiler warning.
svn path=/trunk/; revision=17761
2006-03-29 22:03:21 +00:00
Guy Harris 25ff28766f Squelch a compiler warning (for a problem that can't happen).
Fix up indentaton.

svn path=/trunk/; revision=17760
2006-03-29 21:57:58 +00:00
Anders Broman 9c5ac889e7 sccp - fix a typo
gre - fix a length error, and change the way to display 3GPP atributes.

svn path=/trunk/; revision=17757
2006-03-29 17:00:16 +00:00
Jaap Keuter 9734da71a8 From Ming Zhang: the track # in read toc command dissector should be 1 instead of 4.
svn path=/trunk/; revision=17753
2006-03-28 21:03:01 +00:00
Jaap Keuter 6d34f7ea92 Function should return a value.
svn path=/trunk/; revision=17752
2006-03-28 20:54:59 +00:00
Luis Ontanon cb24ac2121 Some compilers do not handle very long lines...
Shouldn't this  preference description be somewhere else?


svn path=/trunk/; revision=17748
2006-03-27 22:37:11 +00:00
Jaap Keuter 6a093bd4a3 Major properties cleanup
svn path=/trunk/; revision=17747
2006-03-27 21:00:16 +00:00
Luis Ontanon c9179bea2e Forgotten in previuous commit....
svn path=/trunk/; revision=17740
2006-03-27 19:24:34 +00:00
Anders Broman 2bf7bd3a45 From Jacques, Olivier
Here is a patch for gsm_map dissector that adds USSD string decoding (mainly used in processUnstructuredSS-Request, UnstructuredSS-Request, UnstructuredSS-Notify). For now, it assumes that it will be GSM 7 bits.
It re-use packet-gsm_sms.c "gsm_sms_char_7bit_unpack" and "gsm_sms_char_ascii_decode" functions, as well as packet-smpp.c "smpp_handle_dcs" function.

svn path=/trunk/; revision=17739
2006-03-27 18:48:33 +00:00
Anders Broman 43e97ddcc8 Comment out the unused code.
svn path=/trunk/; revision=17735
2006-03-27 16:28:43 +00:00
Anders Broman 4facedb3ee From Frederic Roudaut:
With a change :

#ifdef HAVE_LIBCRYPT
#define __USE_LIBGCRYPT__ 
#endif

>> > finally, I have updated my dissector using libgcrypt.
>> > It does not use openssl anymore.
>> > If gnutls is installed, all should work.
>> > Thus, now it should decrypt and dissect (transport/tunnel/several 
>> > encapsulations ...) :
>> >
>> > - NULL Encryption Algorithm
>> > - TripleDES-CBC [RFC2451] : keylen 192 bits.
>> > - AES-CBC with 128-bit keys [RFC3602] : keylen 128 and 192/256 
>> > bits.
>> > - AES-CTR [RFC3686] : keylen 160/224/288 bits. The remaining
>> > 32 bits will be used as nonce.
>> > - DES-CBC [RFC2405] : keylen 64 bits
>> >
>> > I also have added :
>> >
>> > - BLOWFISH-CBC : keylen 128 bits.
>> > - TWOFISH-CBC : keylen 128/256 bits.
>> >
>> > You have to indicate the Authentication algorithm even if all 
>> > Algorithms since it uses 12 bytes in the Auth field should work 
>> > (have a look to the README to understand why I put it
>> > ;-) ). If you consider I have to throw it away please tell me.
>> >
>> > HMAC-SHA1-96 [RFC2404]
>> > NULL
>> > AES-XCBC-MAC-96 [RFC3566]
>> > HMAC-MD5-96 [RFC2403]

svn path=/trunk/; revision=17734
2006-03-27 16:25:35 +00:00
Anders Broman f4ef555b75 From Ravi Valmikam:
a minor fix for 3GPP2 A11 Session Updat

From me:
 a fix to packet-ppp.c to dissect the payload
and some changes in the gre dissector to display the 3GPP values.

svn path=/trunk/; revision=17733
2006-03-27 16:23:00 +00:00
Jaap Keuter ec3f23a3a2 Fix for bug 840
svn path=/trunk/; revision=17730
2006-03-26 08:08:51 +00:00
Graeme Lunt 4dd0ac18bc Support for otherName and x400address in a GeneralName
svn path=/trunk/; revision=17728
2006-03-25 17:10:07 +00:00
Graeme Lunt c51f4fa887 Support for P1 Strong Authentication
svn path=/trunk/; revision=17727
2006-03-25 16:48:28 +00:00
Graeme Lunt 011ced394c Support for Session Extended User Data and IMPLICIT APPLICATION tagged bitstrings
svn path=/trunk/; revision=17726
2006-03-25 16:32:46 +00:00
Jaap Keuter 719b8effbe From Ming Zhang: fix for several wrong use of ntohs in packet-scsi.c
svn path=/trunk/; revision=17725
2006-03-25 07:57:11 +00:00
Luis Ontanon b833808fb8 - Actually Fix Coverity CID 105 It is true...
- avoid derreferencing an uninitialized leg->dest_nsap

svn path=/trunk/; revision=17724
2006-03-24 23:26:10 +00:00
Ronnie Sahlberg fd58413224 start decoding PA_PW_SALT in the PA-DATA structure.
for the time being   since i have never seen this salt being used elsewhere,
assume everything is the MS style salt:

guint32 nt_status
guint32 unknown
guint32 unknown


if the MS KDC does nopt allow a client to grab a ticket (due to policy   client can only log in at certain hours or such)
KDC will repsond with a failuer with edata like above   and nt-status ==  STATUS_LOGON_HOURS




svn path=/trunk/; revision=17722
2006-03-24 21:41:01 +00:00
Ronnie Sahlberg 54f9da2135 the edata field is PA-DATA for error PREAUTH_FAILED just the same as for PREAUTH_REQUIRED
add decode of edata field for the error code PREAUTH_FAILED



svn path=/trunk/; revision=17721
2006-03-24 21:16:47 +00:00
Jaap Keuter b21337192c From Olivier Jacques:
- to_str.c: add support of "AT_NONE" address type in address_to_str_buf (avoid the assert failed later on
when messages have address type of AT_NONE - which can be the case for an MTP2 capture with FISU messages)
- packet-isup.c: changed source and destination addresses from (net_src and net_dst) to (src and dst) so 
that addresses taken into account in the statistics are the SS7 point codes

svn path=/trunk/; revision=17720
2006-03-24 14:26:01 +00:00
Anders Broman 8d61e9b902 Mark the value_strings static.
svn path=/trunk/; revision=17718
2006-03-24 07:10:22 +00:00
Anders Broman 9a6f6e7d37 From Ravi Valmikam
1. Decode A11 Session Update message
 
2. Decode A10 3GPP2 (GRE Payload Type 0x88D2) packets with the following attributes
    - Flow Control
    - Segmentation
    - SDI Indicator
    - Flow Discriminator

svn path=/trunk/; revision=17717
2006-03-24 07:09:35 +00:00
Ulf Lamping e43c4e50c9 add another comment what's currently missing in the PROFINET specific parts
svn path=/trunk/; revision=17713
2006-03-24 02:20:37 +00:00
Jaap Keuter a10dd1b04e Completed Channel Identification IE with Channel number/Slot map field
svn path=/trunk/; revision=17712
2006-03-23 23:04:43 +00:00
Anders Broman e4bdd466cf From Mike Duigou:
> I have improved the heuristics and the display tree building code in
> dissect_jxta_udp() and dissect_jxta_stream() to avoid this problem.

svn path=/trunk/; revision=17709
2006-03-23 18:42:25 +00:00
Gerald Combs 40be5362b6 Coverity CID 48 is still complaining about a NULL dereference. Hopefully
this will fix it.

svn path=/trunk/; revision=17708
2006-03-23 18:22:42 +00:00
Anders Broman b0d52994be Covierty bug fix.
svn path=/trunk/; revision=17705
2006-03-23 17:00:32 +00:00
Anders Broman 7186d13653 Fix bug:
825 setup message has an error in gsm-a-dtap 

svn path=/trunk/; revision=17704
2006-03-23 16:59:48 +00:00
Anders Broman 2f9f463ede Fix Bugs
820     gsm-map checkIMEI decoding error  
821     gsm-map sendIMSI decoding error  

svn path=/trunk/; revision=17703
2006-03-23 16:58:50 +00:00
Michael Tüxen fd0640e930 Update to draft-ietf-tsvwg-sctp-auth-02.txt.
svn path=/trunk/; revision=17701
2006-03-23 00:36:35 +00:00
Anders Broman 441d892b13 From Motonori Shindo:
find attached the patch that reflects this interpretation of 
> this field accordingly. It also fixes a few minor bugs associated with 
> the handling of 'UNIX Secs' field and two field types
> (LAST_SWITCHED(21) and FIRST_SWITCHED(22)) in case of NetFlow V9.

svn path=/trunk/; revision=17698
2006-03-22 17:19:56 +00:00
Anders Broman 8fa4a23147 From Jeff Morris
fix http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=332

svn path=/trunk/; revision=17697
2006-03-22 17:13:09 +00:00
Anders Broman f0c117048d Handle two octet lengths correctly and remove optional decoding of sns_config, as I read the standard there is no difference.
svn path=/trunk/; revision=17696
2006-03-22 17:11:31 +00:00
Anders Broman f935a4f8f6 Fix http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=820
svn path=/trunk/; revision=17695
2006-03-22 17:10:19 +00:00
Jaap Keuter f4248f455d From Bill Meier:
Ensure "relevant function" logic works for loopback packets containing multiple forwarding addresses.


svn path=/trunk/; revision=17689
2006-03-21 06:54:12 +00:00
Anders Broman ea024eb4ad From Martin Mathieson:
Some cosmetic changes:
- when working out the application id description to show in the info 
column, also consider vendor application identifiers
- make sure application ids and command codes are always shown as 
decimal numbers
- a little whitespace tidyup

svn path=/trunk/; revision=17684
2006-03-20 19:46:04 +00:00
Ronnie Sahlberg f331077a60 waste a couple of bytes per tcp conversation and make the tree for acked_packets (i.e. packets that have interesting tcp properties such as being retransmissions etc) hang off the per conversation tcpd struct instead of being global.
while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite   tcp analysis might actually work and work well even for tcp over tcp tunnelling. 

this also means that if you include packet-tcp.h   you also need to include emem.h .




svn path=/trunk/; revision=17681
2006-03-20 10:52:53 +00:00