osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
82,115 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

86 Commits

Author SHA1 Message Date
Evan Huus cdfab0d6e9 tvbuff: convert helper methods to pinfo->pool 
A few of them just needed scratch memory, so allocate and free it
manually after doing any exception-raising checks.

A few others were returning memory, and needed conversion to accept a
wmem scope argument.
 2021-09-01 03:54:52 +00:00
Evan Huus d09fb571fe asn1: convert most dissectors to pinfo->pool 
Part 2/2 as the commits were too big for CI.

Largely find/replace, with a few manual tweaks. Then regenerate the asn1
dissector sources and make sure everything still builds. There are a
handful of cases I skipped as too complex, but this covers most of the
asn1 dissectors.
 2021-07-26 14:00:09 -04:00
Pascal Quantin 6dcb6568ff S1AP: upgrade dissector to v16.6.0 2021-07-02 09:02:58 +00:00
John Thacker c571e0a5d5 S1AP, X2AP: Add GUMMEI MNC/MCC fields 
Add a new MNC/MCC field type to packet-e212 for the GUMMEI
(Globally Unique MME Identity), and use it where appropriate
in S1AP and X2AP. See 3GPP TS 23.003.
 2021-05-16 15:59:35 -04:00
John Thacker 1701a2db5d S1AP: Use specific MCC/MNC fields 
Use the specific MCC/MNC fields for the LAI, CGI, ECGI, NR-CGI, TAI,
and 5GS-TAI IEs, continuing to use E212_NONE for PLMNidentity in all
other cases. Add fields and an enum value for 5GS-TAI to packet-e212.
(The 5GSTAC has an additional octet compared to the original TAC.)
 2021-05-09 23:07:19 -04:00
Joakim Karlsson 6d72eb7a30 GTPv2: Add dissect of F-Container in Configuration Transfer Tunnel 2021-04-16 11:44:20 +00:00
Pascal Quantin 7ebd4dba7a S1AP: upgrade dissector to v16.5.0 2021-04-09 18:30:39 +02:00
Pascal Quantin 9df7492627 S1AP: have a single filter for ENB-UE-S1AP-ID or MME-UE-S1AP-ID fields 2021-03-21 17:28:31 +00:00
Pascal Quantin 40c1ab88da S1AP: upgrade dissector to v16.4.0 2021-01-05 13:42:31 +00:00
Anders Broman 16ea22eaa4 F-Container: Try to improve error handling. 2020-12-09 00:44:44 +00:00
Pascal Quantin 74c0b2134b S1AP: fix decoding of inter eNB transparent container from NGAP 2020-11-24 14:05:21 +01:00
Anders Broman e209253636 Create a cross protocol filter 3gpp.tmsi 
It can be useful to track a "call" trough multiple protocols to make
that easier create a cross protocol filter, more may come.
 2020-10-14 07:56:26 +00:00
Pascal Quantin 44739c33ce S1AP: upgrade dissector to v16.3.0 2020-10-05 09:54:35 +02:00
Pascal Quantin fa9f718692 S1AP: fix a field mask 2020-09-04 21:47:32 +00:00
Pascal Quantin 09c9b87c8c XnAP: upgrade dissector to v16.2.0 2020-09-03 12:22:26 +02:00
Pascal Quantin 986ead744d NGAP: upgrade dissector to v16.2.0 2020-08-26 18:37:12 +02:00
Pascal Quantin abd6f143c7 S1AP: upgrade dissector to v16.2.0 
Change-Id: Ifa71f952f5aca11f99ae751d1c1404a2af95e3a5
Reviewed-on: https://code.wireshark.org/review/38204
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Tomáš Kukosa <keksa@email.cz>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-08-20 12:14:30 +00:00
Pascal Quantin 18d29c7023 S1AP: add dissection of inter RAT to EUTRA transparent containers 
Change-Id: Ibcffda34dea8e8e4f247667222cca24b80cd32b1
Reviewed-on: https://code.wireshark.org/review/37637
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2020-07-01 10:56:17 +00:00
Guy Harris e1d9a226a2 Fix the type of arrays of pointers to hf_ values for bitfield routines. 
The static arrays are supposed to be arrays of const pointers to int,
not arrays of non-const pointers to const int.

Fixing that means some bugs (scribbling on what's *supposed* to be a
const array) will be caught (see packet-ieee80211-radiotap.c for
examples, the first of which inspired this change and the second of
which was discovered while testing compiles with this change), and
removes the need for some annoying casts.

Also make some of those arrays static while we're at it.

Update documentation and dissector-generator tools.

Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc
Reviewed-on: https://code.wireshark.org/review/37517
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2020-06-19 11:32:26 +00:00
Pascal Quantin a3cf955113 X2AP: upgrade dissector to v15.9.0 
Change-Id: I3a3c73eac9a576f4c494986b19332330523a9883
Reviewed-on: https://code.wireshark.org/review/36698
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-04-04 17:30:10 +00:00
Peter Wu 0145bd0ce5 asn1: fix -Wmisleading-indentation warnings with Clang 10 
A lot of auto-generated ASN.1 dissectors have broken identation and
Clang 10 started warning about them for the first time. Fix these by
using 2 spaces as indentation instead of 2, none, or tabs.

Change-Id: Ia91668596c2f5000954d2265c39cc5dba18e44a7
Reviewed-on: https://code.wireshark.org/review/36368
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2020-03-11 04:18:46 +00:00
Pascal Quantin f3988d0302 S1AP: fix import of ASN.1 code 
Change-Id: Id5cb9be1ab42a42bd4dc000fc9fdd11fd01b0a4f
Reviewed-on: https://code.wireshark.org/review/35757
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-01-12 17:05:57 +00:00
Pascal Quantin efa5c4cbeb S1AP: upgrade dissector to v15.8.0 
Change-Id: I53d1a30f02f8325472a7fd63cb16ca2b1917f9a1
Reviewed-on: https://code.wireshark.org/review/35748
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2020-01-11 22:12:31 +00:00
Pascal Quantin 56bb121cb9 S1AP: upgrade dissector to v15.7.0 
Change-Id: Ie56d3796bf8cc17d995f66159ef8f85d2485e34a
Reviewed-on: https://code.wireshark.org/review/34699
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-10-03 15:38:16 +00:00
Anders Broman 459b9ad293 BSS MAP: Dissect Source Cell ID IE. 
Bug: 16086
Change-Id: I9904a75dd4c8e14f848f7977d5cb17aa0cc5fd4e
Reviewed-on: https://code.wireshark.org/review/34655
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2019-09-30 13:02:24 +00:00
Pascal Quantin d2229b368e S1AP: use SRVCC HO Indication IE to decode Source to Target Transparent Cont IE 
Bug: 16073
Change-Id: I78caf82103e1a3e2027cd5f5c6f862fde4f2c898
Reviewed-on: https://code.wireshark.org/review/34603
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-09-24 14:04:25 +00:00
Guy Harris 20800366dd HTTPS (almost) everywhere. 
Change all wireshark.org URLs to use https.

Fix some broken links while we're at it.

Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c
Reviewed-on: https://code.wireshark.org/review/34089
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2019-07-26 18:44:40 +00:00
Pascal Quantin 62abddc26e S1AP: upgrade dissector to v15.6.0 
Change-Id: I87b7aba8abb69254f30429cdc1c84efac317b652
Reviewed-on: https://code.wireshark.org/review/33909
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-07-12 10:22:04 +00:00
Joakim Karlsson 84a3cc1064 s1ap: fix compile error on older GCC 
error: variable ‘handle’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]

Change-Id: Id53d02927cbb738acedc80b0f6556afb3322c787
Reviewed-on: https://code.wireshark.org/review/33846
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2019-07-04 22:07:43 +00:00
Anders Broman 41d0cf7320 S1AP: Catch out-of-bounds error when dissecting UERadioCapability. 
Change-Id: I14fbf46583a5e17bcd3e7b05d1faee43983f47a5
Reviewed-on: https://code.wireshark.org/review/33763
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2019-06-28 12:50:07 +00:00
Pascal Quantin a8317adbca S1AP: add ErrorIndication message type to info column 
Change-Id: I82206169d7a77f9798fc672a87de9789d56fda3d
Reviewed-on: https://code.wireshark.org/review/33088
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-05-05 21:36:00 +00:00
Pascal Quantin fe50824bb4 X2AP: upgrade dissector to v15.5.0 
Change-Id: I43f96e8ea5acb3cd94b8b3b4e08e0d10a5e8d951
Reviewed-on: https://code.wireshark.org/review/32800
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-04-09 11:31:21 +00:00
Pascal Quantin a9861fb4cf S1AP: upgrade dissector to v15.5.0 
Change-Id: Ibef1a516dfd0cb5b66abdc8df0663174687ca39a
Reviewed-on: https://code.wireshark.org/review/32796
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-04-09 06:56:02 +00:00
Binh Trinh 54ca64a1c4 S1AP: add hidden items for mme/enb-ue-s1ap-id 
Bug: 8165
Change-Id: I73bca63d6c5b32a1b185cd7a65cbf914f5b7823f
Reviewed-on: https://code.wireshark.org/review/32694
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
 2019-04-05 05:38:14 +00:00
Pascal Quantin d6b187e42f XnAP: upgrade dissector to v15.2.0 
Change-Id: Ie26f8918aff20ade21eda611950795a320a417f2
Reviewed-on: https://code.wireshark.org/review/31483
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2019-01-11 12:02:40 +00:00
Pascal Quantin e0d6041bcf S1AP: upgrade dissector to v15.4.0 
Change-Id: Iecf02ce3858cd2cea12bc73e402ace0c558d8abc
Reviewed-on: https://code.wireshark.org/review/31444
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2019-01-08 15:25:28 +00:00
Michael Mann 7a4e932571 Add tvb_ascii_isprint API 
This allows dissectors to check if a portion of the tvb is an ascii string while hiding the use of tvb_get_ptr.

Change-Id: Iaec7559dcfdefb8a5ae23e099ced45e90e611f8f
Reviewed-on: https://code.wireshark.org/review/30291
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-10-21 07:55:40 +00:00
Pascal Quantin 8d3243edc3 S1AP: prettify TrafficLoadReductionIndication IE decoding 
Change-Id: I87a861db1ebb931193918821a6c4656c61a91e47
Reviewed-on: https://code.wireshark.org/review/30033
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-10-05 18:29:36 +00:00
Pascal Quantin 4e519c12a4 S1AP: remove a duplicate line in .cnf file 
Change-Id: I0b4ccc2f270d7c0132ca4960a2426c66f1cf67d1
Reviewed-on: https://code.wireshark.org/review/29855
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-09-26 13:23:51 +00:00
Pascal Quantin 74957d4f07 S1AP: upgrade dissector to v15.3.0 
Change-Id: I949665dd7b26775f3f9a3e704f7e8b815a419165
Reviewed-on: https://code.wireshark.org/review/29824
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-09-25 13:25:28 +00:00
Pascal Quantin 2c6248f011 NGAP: upgrade dissector to v15.0.0 
Change-Id: I859265260fde2e986a3b95ff117512cff90bed90
Reviewed-on: https://code.wireshark.org/review/28556
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-07-01 18:10:39 +00:00
Pascal Quantin a15fc7f430 S1AP: search GCSNA dissector only at startup 
Change-Id: I1805010dc4d8f5cc920786a00a2fb175cc7eebdd
Reviewed-on: https://code.wireshark.org/review/28551
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-07-01 10:20:30 +00:00
Pascal Quantin 6cbf24b58e S1AP: display 5GS TAC as DEC_HEX 
Change-Id: Ib5950cbd587809424c1e3fc3ae8cd2dc7e504348
Reviewed-on: https://code.wireshark.org/review/28512
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-06-28 18:58:28 +00:00
Pascal Quantin ff3b7c9a93 S1AP: fix a copy/paste error in a field name 
Change-Id: I3c602deaaeffa6738f325df5e4abda7b8214f560
Reviewed-on: https://code.wireshark.org/review/28386
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-06-22 12:11:51 +00:00
Pascal Quantin 651336f3e8 S1AP: update version info in header 
Change-Id: I8bd5021786006e08391d885137e7aa5778c9118f
Reviewed-on: https://code.wireshark.org/review/28382
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-06-22 08:45:36 +00:00
Pascal Quantin 3909f8a8b9 S1AP: upgrade dissector to v15.2.0 
Change-Id: I53feb77f91ac72f4e5f18c56453f2974b8b426be
Reviewed-on: https://code.wireshark.org/review/28376
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-06-22 08:29:03 +00:00
Dario Lombardo 4a156da068 Remove autotools build system. 
It has been replaced by cmake.

Change-Id: I83a5eddb8645dbbf6bca9f026066d2e995d8e87a
Reviewed-on: https://code.wireshark.org/review/26969
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-04-18 03:46:17 +00:00
Pascal Quantin 4cc78e6fe4 S1AP: upgrade dissector to v15.1.0 
Change-Id: Ib3728a35f3635b58da2a10736799fd825c34e58b
Reviewed-on: https://code.wireshark.org/review/26782
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-04-06 21:49:02 +00:00
Pavel Strnad 18cd454da9 S1AP: fix filtering on cell-ID 
Filter does not work due to same shared short name for cell-id being used for two different asn.1 defintions
  cell-ID OCTET STRING,
  cell-ID CellIdentity,

Change-Id: I5921bc82d46f38d43f9083e41d3a0558821042eb
Reviewed-on: https://code.wireshark.org/review/26545
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Pavel Strnad <pavel_strnad@hotmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-03-19 14:37:04 +00:00
AndersBroman 5c25e1b2c1 S1AP: EmergencyAreaIDListForRestart is not an extension IE. 
Change-Id: I3dd623e1a2ec3005ee2c810492e4d0fad39ce1d0
Reviewed-on: https://code.wireshark.org/review/26364
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2018-03-08 14:44:02 +00:00