Commit Graph

35488 Commits

Author SHA1 Message Date
Evan Huus d6d7dd1e56 First pass pinfo->pool conversion
Automated find/replace of wmem_packet_scope() with pinfo->pool in all
files where it didn't cause a build failure.

I also tweaked a few of the docs which got caught up.
2021-07-21 05:38:29 +00:00
Gtker bb25eca4eb WOWW: Rename 'index' variables to 'idx'
As discussed on the PR:
https://gitlab.com/wireshark/wireshark/-/merge_requests/3707#note_631240408
2021-07-20 20:46:58 +00:00
Gtker 9161ba62eb WOWW: Remove template comments 2021-07-20 20:46:58 +00:00
Gtker 2c8d57db61 WOWW: Make saved original values use struct 2021-07-20 20:46:57 +00:00
Gtker cade03373e WOWW: Update documentation 2021-07-20 20:46:57 +00:00
Gtker b9a6268819 WOWW: Add better support out of order parsing 2021-07-20 20:46:57 +00:00
Gtker 3f4ac5539b WOWW: Move header decryption into separate function 2021-07-20 20:46:57 +00:00
Gtker e37f6599b0 WOWW: Remove and move declarations 2021-07-20 20:46:57 +00:00
Gtker 57f32d974e WOWW: Add all remaining opcodes for 1.12.x
From Mangos Zero:
e45aa74e0f/src/game/Server/Opcodes.h (L53)
2021-07-20 20:46:57 +00:00
Gtker 9e767608f7 WOWW: Make session key deduction work
Detailed description in the comment at the top of the file.
2021-07-20 20:46:57 +00:00
Gtker 92e62a74fd WOWW: Add working decryption 2021-07-20 20:46:57 +00:00
Gtker e1b3796419 WOWW: Add protocol
The protocol is a continuation of the WOW protocol occuring between the
world server and the client (as opposed to the login server and the
client).

The first two opcodes are unencrypted and perform setup for the
encryption.
The encryption was setup in the WOW protocol through SRP6.
Using the session key for encryption like this is not part of the SRP6
protocol.
All other opcodes are encrypted using the session key, which will need
to be deduced first.
2021-07-20 20:46:57 +00:00
Gtker 894b1eec6a WOW: Make username and realm names display as UTF-8
Both CHALLENGE and REALM_LIST are UTF-8 strings:

https://wowdev.wiki/CMD_AUTH_LOGON_CHALLENGE_Client

https://wowdev.wiki/CMD_REALM_LIST_Server
2021-07-20 20:46:57 +00:00
David Perry dc7089e831 Carry drop count/packet ID/queue ID as options on packet block 2021-07-19 21:25:40 +00:00
Developer Alexander 1f12e1d267 json: fix buffer overflow in string_unescape()
Fixes a potential buffer overflow issue in string_unescape() with a redesign
to be more robust against invalid input.

It makes use of wmem_strbuf API now.

Closes #17475
2021-07-18 20:02:52 +00:00
Gerald Combs 96c29704c8 [Automatic update for 2021-07-18]
Update manuf, services enterprise numbers, translations, and other items.
2021-07-18 09:29:30 +00:00
Evan Huus f54493278f Delete various unused fields
Discovered during the build failure of
https://gitlab.com/wireshark/wireshark/-/merge_requests/3695
2021-07-17 16:35:41 -04:00
Jaap Keuter 490017ea7f XML: don't try to hide the UTF-8 Byte Order Mark
Closes #17489
2021-07-17 08:52:42 +00:00
Developer Alexander 2051cadf99 can: Optimized column info for better readability
Column info is tuned for better readability. It containes CAN ID and Length.
The same applies to protocol item within protocol tree.

Entire packet data (payload) should not be printed to column info by default.
So this behaviour is removed.
2021-07-17 07:15:27 +00:00
Dr. Lars Völker 27c72d1edc LIN: Fix ID parsing (bugfix) 2021-07-16 17:56:46 +02:00
Dr. Lars Völker 73bb25bbc9 BLF: fix clang warnings 2021-07-16 14:45:21 +00:00
Dr. Lars Völker c22846d898 ISO15765: Add support for the new CAN API
This patch allows to register single IDs for CAN.
2021-07-16 10:09:44 +00:00
Arkady Gilinsky 4742371c97 oampdu: Add Network port declaration and it's parsing to GetRequest packets
* Declarations were added according to CableLab specification

Signed-off-by: Arkady Gilinsky <8351139-ark-g@users.noreply.gitlab.com>
2021-07-16 09:44:54 +00:00
Dr. Lars Völker 4cb4217dfd TECMP: Adding a filter for Channel ID names
This patch allows adding a channel name column or use a filter for it.
2021-07-16 09:28:45 +00:00
Dr. Lars Völker e0055d0698 Signal-PDU: Add support for the new CAN API
This patch directly registers configured CAN IDs.
2021-07-16 09:12:18 +00:00
Dr. Lars Völker 102a952533 CAN: Adding support for more specific tables (2)
This patch changes TECMP, 1722, and caneth to use the new
socketcan_call_subdissectors method.
2021-07-16 08:27:11 +00:00
Jaap Keuter fba16c88f4 JUNIPER: Set proper item length for protocol layer 2021-07-16 08:10:34 +00:00
Dr. Lars Völker 796819c955 BLF: Support for BLF file format
This patch adds first support for the BLF file format.
2021-07-16 07:37:43 +00:00
Evan Huus f58850d207 tcp: switch packet_scope to pinfo->pool
Per mailing list discussion:
https://www.wireshark.org/lists/wireshark-dev/202107/msg00030.html

Long-term we want to get rid of the wmem_*_scope globals in favour of
passing wmem pools around. Step one is to replace all reasonable uses of
wmem_packet_scope() with pinfo->pool which has effectively the same
lifespan. This converts the TCP dissector as a proof of concept. TCP is
a common enough protocol this should stress-test the idea fairly well.
2021-07-15 18:14:16 +00:00
Arkady Gilinsky 96c0700c62 wireshark(HEAD): oampdu: Fix: do not stop GetReq packet parsing for Object 0
* The next_byte variable is taken before the pointer moved forward, this lead
   to stop parsing get request packets when object is 0. This commit fixes it.

Signed-off-by: Arkady Gilinsky <8351139-ark-g@users.noreply.gitlab.com>
2021-07-15 13:01:38 +00:00
Martin Mathieson 458d870a66 ORAN FH CUS: Fix C-Section dissection.
Some fields are present or not depending upon the section
type - fix reserved/beamId error.
2021-07-15 11:44:21 +01:00
Developer Alexander 2a1ebd1e91 can: more specific dissector tables for CAN IDs and extended IDs
Introduces two new dissector tables can.id and can.extended_id to enable a
more precise control of subdissectors dependent on the can id which is often
used to identify the the payload.

Since standard CAN IDs and extended IDs can be used in the same network and
their ranges overlap it is necessary to have two different dissector tables.

Existing Decode as dissector table can.subdissector stays as is to prevent a
breaking change. But new dissector tables can.id and can.extended_id get
priority over can.subdissector since they are more specific. Id they get a
match can.subdissector won't be called.

New dissector tables can.id and can.extended_id are accessible in lua scripts
via DissectorTable:add() while can.subdissector unfortunately is not.

For related Discussion see MR !3405
2021-07-15 07:29:46 +00:00
J M cbed7130de DoIP: Add TLS handover for encrypted communication 2021-07-15 06:40:22 +00:00
Stefan Metzmacher 94ac641efa packet-kerberos: implement PAC Ticket checksum verification
We use some private functions from MIT kerberos:
- krb5_free_enc_tkt_part()
- decode_krb5_enc_tkt_part()
- encode_krb5_enc_tkt_part()
but we already do that for krb5int_c_mandatory_cksumtype(),
which is newer than the above functions.

We use all of them only under HAVE_KRB5_PAC_VERIFY,
so we don't seem to need additional configure tests.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2021-07-15 04:52:30 +00:00
Stefan Metzmacher 8cd877fc4d packet-kerberos: always get the true length from decrypt_krb5_data_asn1()
Otherwise the child_tvb blobs may contain to much data.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2021-07-15 04:52:30 +00:00
Alexis La Goutte 0ea7692ec4 sv: fix typo ConfRef => ConfRev
Reported by Robert Sandholzer (#17486)
2021-07-14 17:46:39 +00:00
Martin Mathieson 1f9f287fba ISO15765: Make a function static. 2021-07-14 13:29:33 +01:00
Martin Mathieson 560f271d27 ISIS-LSP: Fix spelling of "algorithm" 2021-07-14 10:56:24 +00:00
Dr. Lars Völker 95dc4f52bc LIN: Adding support for LIN dissection
This patch adds support for LIN (Local Interconnect Network) as
well as support for:
- Signal PDUs on LIN
- ISO 15765 (ISO TP) on LIN
- TECMP transported LIN is handle like LIN

LIN is a simple automotive fieldbus to connect for example simple
sensors and actuators to an electronic control unit.
2021-07-14 09:31:06 +00:00
Chuck Craft a7d927a9e9 prefs_register_protocol_obsolete protocols with only obsolete prefs
Related to #17465 and !3526
2021-07-13 23:12:04 +00:00
bookding 175d75aa03 MySQL: Add support for session track gitds & transaction info 2021-07-13 21:43:41 +00:00
Martin Mathieson eb2015a373 DCT2000: Support a format for MAC-NR PDUs inside comment lines 2021-07-13 17:22:01 +01:00
Richard Sharpe 893ec461f2 ieee80211: Correctly handle trigger frames when there is no padding. 2021-07-13 07:10:15 -07:00
Dr. Lars Völker e8ceb9964c DoIP: Adding name resolution for Diagnostic Addresses (UAT)
This patch will add name resolution to the Diagnostic Addresses of
DoIP by using an UAT based table.
2021-07-13 09:25:16 +00:00
Dr. Lars Völker b82ef729aa TECMP: Adding name resolution for Channel IDs 2021-07-13 09:08:38 +00:00
Taisuke Sasaki 20785aed78 ISIS: Add Flexible Algorithm (draft-ietf-lsr-flex-algo-16)
- Add Flexible Algorithm Definition Sub-TLV
- Add IS-IS Application-Specific Link Attributes (rfc8919)
- Add Extended Administrative Groups Sub-TLV (rfc7308)
2021-07-13 08:49:06 +00:00
Anders Broman 1d590a8c4d ppcap: Remove unused preference code
These preferences has been obsoleted for a long time so let's get rid of
the code.
2021-07-13 07:43:07 +00:00
Uli Heilmeier 3413daad58 Multipart: Add option to uncompress data
Add an option to uncompress gzip:ed data.

Fixes: wireshark/wireshark#17471
2021-07-13 07:27:15 +00:00
Alexander Aring f9037e6537 packet-dlm3: update dissector for version 3.2
This patch updates the dlm3 dissector for version 3.2 which are
currently prepared for sending Linux upstream. The dlm dissector follows
the Linux implementation. There is no other protocol specification.

For the specific protocol changes see:

https://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git/commit/?h=next&id=489d8e559c6596eb08e16447d9830bc39afbe54e
2021-07-13 07:10:48 +00:00
Alexander Aring 456c74cb1f packet-dlm3: dissect pdus for tcp case
Currently there can be multiple dlm messages in one tcp segment and in
some cases dlm message can be overlapped between two segments. The main
fix would be that we can now dissect multiple dlm messages if they
appear in one tcp segment. It's still own as one message in the "packet
flow" but in tree view it will be displayed as multiple messages which
are not visible.

For sctp the problem still exists, although there can't be overlapped messages.
2021-07-13 07:10:48 +00:00