074b9660b6
Have new_packet_list_queue_draw() redraw the packet detail as well. Call
...
new_packet_list_queue_draw() whenever we mark/unmark frames. Fixes bug
4669.
svn path=/trunk/; revision=32981
2010-05-26 19:44:40 +00:00
65ee4e797a
From Jakub Zawadzki:
...
New functions: cf_read_frame_r, cf_read_frame
It's much easier to write:
cf_read_frame (cf, fdata, &err, &err_info)
Than:
wtap_seek_read (cf->wth, fdata->file_off, &cf->pseudo_header, cf->pd,
fdata->cap_len, &err, &err_info)
svn path=/trunk/; revision=32980
2010-05-26 19:11:23 +00:00
a59da6ffd8
Update name resolving description.
...
svn path=/trunk/; revision=32979
2010-05-26 19:06:17 +00:00
b07566f60e
Reference the 'interlink' plugin dir as an example (rather than agentx
...
which is no longer a plugin).
Fix a typo.
svn path=/trunk/; revision=32978
2010-05-26 16:21:19 +00:00
763a397ae3
Add a tooltip.
...
svn path=/trunk/; revision=32977
2010-05-26 15:51:47 +00:00
13c9cf1d38
Add some tooltips.
...
svn path=/trunk/; revision=32976
2010-05-26 15:20:10 +00:00
3d909801bc
proto_registrar_dump_fields: output "" for blurb if blurb is a zero-length string.
...
svn path=/trunk/; revision=32975
2010-05-26 14:35:06 +00:00
7c4ec2e051
Expert severity was still overlapping with bits length, so separate them.
...
svn path=/trunk/; revision=32974
2010-05-26 13:53:17 +00:00
f19eee998f
Try to optimize a bit.
...
svn path=/trunk/; revision=32973
2010-05-26 11:51:41 +00:00
2ed269439d
Fix indentation.
...
svn path=/trunk/; revision=32972
2010-05-26 11:51:07 +00:00
e2082dedb6
Export value_string_ext related functions
...
svn path=/trunk/; revision=32971
2010-05-26 07:39:03 +00:00
b9bf692c3e
Untabify.
...
svn path=/trunk/; revision=32970
2010-05-26 07:19:42 +00:00
5c27494bd6
Don't report EINTR - it might be from a ^C.
...
Do report the error string for other read errors, though.
svn path=/trunk/; revision=32969
2010-05-26 05:33:57 +00:00
b0bfae2a85
Don't send ^T output to the standard error if we're a capture child.
...
Make SIGINFO a restart-the-system-call signal, so reads etc. don't
return an error.
svn path=/trunk/; revision=32968
2010-05-26 04:29:36 +00:00
12b5361a7b
Remember the default value of each protocol preference.
...
If, when we're writing the preferences file, the current value of the
preference is the same as the default, write out the preference (since the
preference file is also the documentation for the preferences) but comment it
out (so that if, for example, you go back to an older version of Wireshark
you won't get warnings about non-existant preferences that you didn't
change--and thus probably don't care too much about).
It might be interesting to, in the future, add a UI to restore the default
values.
svn path=/trunk/; revision=32967
2010-05-26 03:31:30 +00:00
d3be76c010
g_error -> expert_add_info_format. Fixup whitespace.
...
svn path=/trunk/; revision=32966
2010-05-26 02:46:50 +00:00
26bf53f0b1
Use the right system call name.
...
svn path=/trunk/; revision=32965
2010-05-26 02:34:12 +00:00
d0ac88186d
If dumpcap exits abnormally, report the error.
...
svn path=/trunk/; revision=32964
2010-05-26 02:32:19 +00:00
347e7a0052
More <stdarg.h> cleanup; some are real bugs, some are just "don't do
...
va_start and va_end unless you're actually going to use the va_list"
(those bring the va_start and va_end closer to the use point, which
makes it a little more obvious that we're using <stdarg.h> correctly and
makes it a little harder to use it incorrectly).
svn path=/trunk/; revision=32963
2010-05-26 02:25:13 +00:00
7da29cfe69
Put in a warning about the <stdarg.h> problem that I just found and
...
fixed in one place (and am now fixing in some other places).
svn path=/trunk/; revision=32962
2010-05-26 02:21:23 +00:00
ebc3739570
Once you've used a va_list, you can't use it again until you
...
reinitialize it with va_start(). (Yes, there are platforms where
reusing the va_arg fails, e.g. Mac OS X on x86-64.)
svn path=/trunk/; revision=32961
2010-05-26 02:01:49 +00:00
ea0c9d6b14
Reindent a bit
...
svn path=/trunk/; revision=32960
2010-05-26 01:51:41 +00:00
d3f8320039
Fix build without pcap.
...
svn path=/trunk/; revision=32959
2010-05-26 01:32:00 +00:00
7a630c61a1
Add a -q flag to dumpcap, to squelch its reporting of the packet count,
...
and add support for SIGINFO, so, if your OS supports SIGINFO, you can
get the packet count by typing ^T.
svn path=/trunk/; revision=32958
2010-05-26 00:19:27 +00:00
237eef2ae7
r32323 broke packet detail tree expansion using the left/right keys on
...
X11. Add back the removed code and add checks for expandable items.
svn path=/trunk/; revision=32957
2010-05-25 23:55:33 +00:00
a34ed6fcff
Handle lines ending in \r\n.
...
Fixes Bug #4780
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4780
svn path=/trunk/; revision=32956
2010-05-25 22:27:00 +00:00
a07fd7f50d
From Sam Leffler and Javier Cardona via email & bug 4793:
...
Add 802.11s mesh support.
From me:
Merge all of the "#ifdef" and "#if 0" switches into "#ifdef
MESH_OVERRIDES"
Add Fast BSS Transition to the list of overridden tags.
Fix a couple of variable initialization errors.
svn path=/trunk/; revision=32955
2010-05-25 22:15:46 +00:00
4ebe9a0e2e
Add a note about running autogen.sh.
...
svn path=/trunk/; revision=32954
2010-05-25 22:11:00 +00:00
a12990e603
RFC 4165 uses the same message/parameter formats as draft-12 did so let's
...
call it RFC 4165.
svn path=/trunk/; revision=32953
2010-05-25 21:12:43 +00:00
7436d04550
Only try header reassembly for TCP.
...
svn path=/trunk/; revision=32952
2010-05-25 21:00:55 +00:00
069fbb2ad3
Remove find_val_for_string
...
svn path=/trunk/; revision=32951
2010-05-25 20:57:51 +00:00
c420b83ee5
find_val_for_string() is only used in prefs.c so remove the prototype
...
and make it static.
When reading enum preferences, use the current value of the preference as the
default value of the preference instead of a hard-coded 1. This way if we
couldn't find the appropriate value we'll don't end up changing the preference
to something that may or may not make sense.
svn path=/trunk/; revision=32950
2010-05-25 20:57:14 +00:00
71de391514
Pull the big pile of code that handles the
...
capture-stopping/file-switching operation into a routine. Move a few
variables into the loop_data structure so that routine can get at them.
svn path=/trunk/; revision=32949
2010-05-25 20:14:22 +00:00
91e949512d
From Neil Piercy:
...
Fix misleading PER Bit string display.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4789
(I Added bits display)
svn path=/trunk/; revision=32948
2010-05-25 19:29:23 +00:00
e441284063
Fix for bug 4782:
...
Use proper bitmask to test the "MATCH"-part.
svn path=/trunk/; revision=32947
2010-05-25 17:47:00 +00:00
892d3112ed
Add a filter for DCT2000 error strings, and allow it be included in generated filters from RLC status window.
...
svn path=/trunk/; revision=32946
2010-05-25 14:02:17 +00:00
ee5c636603
Re-organise which FI bits are used to store expert severity and event info, in order to avoid clash with bit offset and length as added in 4413 (Improve bitview display).
...
The event info values were (mostly) done as though they were flags rather than values, but as it doesn't really make sense to combine events I changed them to use contiguous values. They now use the 8 m.s. bits, so there are now 9 unused bits available for new uses.
svn path=/trunk/; revision=32945
2010-05-25 11:21:51 +00:00
2f0c4dde50
Support of value_string_ext in the asn2wrs using new directive #.USE_VALS_EXT
...
Example usage in NBAP
svn path=/trunk/; revision=32944
2010-05-25 09:07:12 +00:00
3b8ccd8e63
Remove faulty vendor from SIP AVP:s, update comments.
...
svn path=/trunk/; revision=32943
2010-05-25 08:42:24 +00:00
1010acc278
From Jakub Ruzicka:
...
Trunk packet support in IAX2 dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4783
svn path=/trunk/; revision=32942
2010-05-25 05:48:36 +00:00
36623bcb71
From H.sivank: GtkOSXApplication support.
...
Call the various flavors of OS X integration just "OS X integration",
not anything with "IGE" in it - it appears that, in some places,
"ige-mac-integration" refers only to the older Carbon-based functions,
although the library still appears to be called -ligemacintegration.
Update the URLs for the information about the OS X integration
libraries.
Clean up help message for --with-pcap-remote.
Clean up white space a bit.
Speaking of white space, it's "Mac OS X", not "MacOS X".
svn path=/trunk/; revision=32941
2010-05-25 00:35:44 +00:00
9bafe20643
Minor rewording; Also: add note to not use "" for a hf[] array blurb.
...
svn path=/trunk/; revision=32940
2010-05-25 00:00:58 +00:00
fbbf502752
Jose Pedro Oliveira <jpo@di.uminho.pt>
...
(via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4786 )
Add missing +INCLUDE(CheckVariableExists) to make the previous
commit work.
svn path=/trunk/; revision=32939
2010-05-24 23:41:21 +00:00
f036ba32ab
At least according to the CMake 2.6 documentation,
...
CHECK_VARIABLE_EXISTS() can be used to check for C variables; use that
to check for pcap_version.
svn path=/trunk/; revision=32938
2010-05-24 22:50:30 +00:00
ca2a2b6298
Fix the value_string regexp so it doesn't match value_string_ext (which we don't have to check for NULL termination and the like)
...
svn path=/trunk/; revision=32937
2010-05-24 22:31:51 +00:00
47e4c55698
- Add a comment about the magic in the FindXXX.cmake filenames.
...
- Fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4786
Define HAVE_PCAP_VERSION if HAVE_PCAP_LIB_VERSION is set.
svn path=/trunk/; revision=32936
2010-05-24 21:59:29 +00:00
b8812638dc
Use the new name for the last argument to proto_tree_add_item().
...
svn path=/trunk/; revision=32935
2010-05-24 17:39:03 +00:00
98c68fc8ec
Check that the PDU isn't bigger than the reported grant size. Thought I was already doing this...
...
svn path=/trunk/; revision=32934
2010-05-24 16:28:34 +00:00
64f5d56bba
Fix reassemble_test's (copy of the) proto_tree_add_item() prototype to get it
...
compiling again.
fragment_add_seq_check(), fragment_add_seq_802_11(), and fragment_add_seq_next()
all call fragment_add_seq_check_work() so make their prototypes match each other
in const-ness. This fixes a warning when compiling reassemble_test.
svn path=/trunk/; revision=32933
2010-05-24 15:13:02 +00:00
2543a7ab91
Use value_string_ext for AVP:s
...
svn path=/trunk/; revision=32932
2010-05-24 14:20:53 +00:00
Gerald Combs