Commit Graph

7909 Commits

Author SHA1 Message Date
Gerald Combs 4403f89243 More size_t fixes.
svn path=/trunk/; revision=27976
2009-04-06 19:30:48 +00:00
Anders Broman 680cf63be8 Dissect g722.2 H.245 paramaters.
svn path=/trunk/; revision=27972
2009-04-06 16:53:41 +00:00
Jaap Keuter bdf8c5d574 Fix bug 3342:
Add decoding of newer component codes.
Add dissection of Alternate Assignment Component.

svn path=/trunk/; revision=27970
2009-04-06 05:43:24 +00:00
Stephen Fisher 5f78aafa55 Fix compiler warning/errors
svn path=/trunk/; revision=27969
2009-04-06 02:50:46 +00:00
Gerald Combs 60d3b45792 More size_t casts/fixes, and string buffers.
svn path=/trunk/; revision=27968
2009-04-06 00:08:46 +00:00
Gerald Combs 7265c99e0c Get rid of a bunch of size_t's.
svn path=/trunk/; revision=27967
2009-04-05 23:42:26 +00:00
Guy Harris 532a4ad4bd Use ep_strdup_printf() and emem_strbuf_t's.
svn path=/trunk/; revision=27966
2009-04-05 18:37:47 +00:00
Guy Harris ee8ddd5123 Use an emem_strbuf_t in bitrange().
svn path=/trunk/; revision=27965
2009-04-05 18:20:20 +00:00
Guy Harris a36f62678c Casts of pointer differences to squelch P64 warnings; the differences
aren't going to be > 2^31-1.

svn path=/trunk/; revision=27964
2009-04-05 17:28:20 +00:00
Gerald Combs 098eb5606f tvbuff.[ch]: Accept more size_t's.
packet-wcp.c: Add size_t casts.
packet-x11.c: Use string buffers.

svn path=/trunk/; revision=27959
2009-04-04 19:34:06 +00:00
Anders Broman 526cf5d50d Keep the buildbot happy.
svn path=/trunk/; revision=27958
2009-04-04 17:29:46 +00:00
Anders Broman 757a6bf29a Wrong tree used, add Codec list dissection.
svn path=/trunk/; revision=27957
2009-04-04 15:19:45 +00:00
Anders Broman e0cf1679e3 From Francesco Fondelli:
New ATM PW (with/without CW) dissector, RFC 4717
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3375

svn path=/trunk/; revision=27955
2009-04-04 11:48:19 +00:00
Guy Harris 978f771a8d Use an emem_strbuf_t where appropriate.
svn path=/trunk/; revision=27954
2009-04-03 19:10:34 +00:00
Guy Harris ed30baaa0d size_t fix (you won't get more than 2^31-1 bytes there).
svn path=/trunk/; revision=27953
2009-04-03 19:03:31 +00:00
Guy Harris 7c1cf2f696 size_t fix (you're not going to get more than 2^31-1 bytes there).
svn path=/trunk/; revision=27952
2009-04-03 19:02:38 +00:00
Guy Harris 9d6909f188 Some size_t cleanups.
svn path=/trunk/; revision=27951
2009-04-03 19:01:40 +00:00
Guy Harris 03af06a63f Turn length variables that don't need to be size_t into guint.
svn path=/trunk/; revision=27950
2009-04-03 18:59:01 +00:00
Guy Harris dd54a0cbbd tvb_memcpy() now takes a size_t as an argument, so get rid of a
no-longer-needed cast that provokes warnings on Win64.

svn path=/trunk/; revision=27949
2009-04-03 18:55:25 +00:00
Guy Harris 39630a763d Squelch a warning.
svn path=/trunk/; revision=27947
2009-04-03 17:06:20 +00:00
Guy Harris cf308a6cc0 Don't reply on an argument of -1 as the last argument of tvb_memcpy()
meaning "to the end of the tvbuff"; we'd like to get rid of the "-1
means to the end of the tvbuff" convention, as in many cases the length
comes from a 32-bit length field in the packet, and we want 0xFFFFFFFF
to be treated, even on ILP32 platforms, as meaning "2^32-1 bytes",
probably giving an exception, rather than as "to the end of the packet".

svn path=/trunk/; revision=27945
2009-04-03 16:53:40 +00:00
Anders Broman 13282b7a7c Add value strings and code clenup.
svn path=/trunk/; revision=27944
2009-04-03 16:19:12 +00:00
Gerald Combs 00043fb64e More size_t.
svn path=/trunk/; revision=27943
2009-04-03 15:46:21 +00:00
Sake Blok a3601ba7d4 Make buildbot happy again...
svn path=/trunk/; revision=27940
2009-04-02 20:51:55 +00:00
Guy Harris f41351188a Get rid of an unused variable.
Clean up indentation.

svn path=/trunk/; revision=27939
2009-04-02 20:03:36 +00:00
Anders Broman 0f17f96acf From Garey Hassler:
CableLabs vendor-specific decoding for Bootp, DHCPv6.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3218

svn path=/trunk/; revision=27938
2009-04-02 19:41:09 +00:00
Anders Broman 83d1303053 From Naoyoshi Ueda:
Radius dissector enhancement to support WiMAX vendor specific attributes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3176

svn path=/trunk/; revision=27937
2009-04-02 19:05:52 +00:00
Anders Broman a92cd3fddd From Chris Maynard:
Misc. NHRP bug fixes & additions and AFN udpates
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3379

svn path=/trunk/; revision=27933
2009-04-02 17:21:18 +00:00
Anders Broman 4086013afd Yin Sun:
tipc v1 improvement.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3381

svn path=/trunk/; revision=27932
2009-04-02 17:12:44 +00:00
Anders Broman daf059d5ed Remove #if 0
svn path=/trunk/; revision=27931
2009-04-02 17:04:04 +00:00
Gerald Combs c1e7e4b619 From Peter Hertting: Fix the maximum poll interval.
svn path=/trunk/; revision=27930
2009-04-02 03:55:37 +00:00
Gerald Combs 453cd58768 Fix a typo.
svn path=/trunk/; revision=27929
2009-04-02 03:51:42 +00:00
Gerald Combs 3a4a3643c2 The format argument of val_to_str() formats a guint32, not a char *. Fixes
bug 3383.

svn path=/trunk/; revision=27928
2009-04-02 03:44:00 +00:00
Anders Broman 87c4184e91 According to the section 2.4 of the spec.
http://www.3gpp2.org/Public_html/specs/X.S0004-540-E_v2.0_070723.pdf

mandatory parameters for the message Authentication Failure Report.

1. Electronic serial number
2. MSID(i.e MIN/IMSI)
3.Report Type
4.System Access Type
5.System Capabilities(Serving)

svn path=/trunk/; revision=27923
2009-04-01 16:21:00 +00:00
Bill Meier 2baf9bd747 From Abhik Sarkar: SMPP TLV tag value_strings.
"I have chosen _not_ to use the value_string array in the header field for the
 tag because the information appears in too many places - once in the sub-tree
 and again once in the field which displays the value. Displaying the tag name
 again in the tag field would make the same information appear three times in
 four lines."
 See Bug #3369 [https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3369]

From me: Use consistent indentation throughout packet-smpp.c

svn path=/trunk/; revision=27922
2009-04-01 13:22:07 +00:00
Bill Meier b45c3cb272 Change to prevent "off-the-end" array access if invalid payload-type/media-format;
Prevents crash as reported in bug 3373:
  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3373)

svn path=/trunk/; revision=27917
2009-03-31 21:47:58 +00:00
Anders Broman 7afd67fd94 Update value strings.
svn path=/trunk/; revision=27916
2009-03-31 18:52:36 +00:00
Anders Broman 80f5487276 Fix a typo.
svn path=/trunk/; revision=27915
2009-03-31 18:51:59 +00:00
Guy Harris 6443db2e94 Make the forward declaration of dissect_snmp() match the definition.
svn path=/trunk/; revision=27914
2009-03-31 18:09:24 +00:00
Martin Mathieson 3681cb1be3 Fix gcc 3.4.6 warning about setjmp/longjmp.
svn path=/trunk/; revision=27913
2009-03-31 17:31:07 +00:00
Bill Meier d67b7d5347 If GLib < 2.10.0 use g_mem_chunk instead of g_slice.
svn path=/trunk/; revision=27912
2009-03-31 15:33:15 +00:00
Bill Meier 7172127412 #include reassemble.h not req'd
svn path=/trunk/; revision=27911
2009-03-31 12:08:44 +00:00
Bill Meier 5a3e7edbe3 #include reassemble.h not req'd; Also: move proto_register... & etc to be last in file.
svn path=/trunk/; revision=27910
2009-03-31 12:05:48 +00:00
Bill Meier 6d740b3d00 From: yami <yamisoe [AT] gmail.com>: Update comment in .c file; copy same to .h file
svn path=/trunk/; revision=27909
2009-03-31 11:59:59 +00:00
Guy Harris 2776974a35 Get rid of val_to_strlen() - strlen() on the results of val_to_str()
suffices (and 100 is an odd choice of failure), and it shouldn't return
a guint8 in any case.

Don't use tvb_length() to determine how big a packet is - you want the
real size, not the possibly-shortened-by-a-snapshot-length size.

Don't make things guint8 if they're not guaranteed to be one byte long.

Use an ep_strbuf in another case.

svn path=/trunk/; revision=27908
2009-03-31 07:10:17 +00:00
Anders Broman 19de9df296 From Vincent Helfre:
Fix unaligned bitfields.

svn path=/trunk/; revision=27907
2009-03-31 05:44:48 +00:00
Anders Broman 7e57d89548 Dissect security protected NAS message(un ciphered).
svn path=/trunk/; revision=27906
2009-03-30 22:38:56 +00:00
Bill Meier 891aa5a6aa Fix bug: ptr to an ep str kept for use while capture file open.
svn path=/trunk/; revision=27905
2009-03-30 21:59:31 +00:00
Jörg Mayer 8b6ae788b2 Andreas Schuler:
add framenumber, extended fixed part capabilities and higher
layer capabilities

Me;

- replace div by crc to fix a shadowed global variable
- the last argument to proto_tree_add_item is the endianess
  indicator, not the value
- replace // by /* */

svn path=/trunk/; revision=27904
2009-03-30 21:55:22 +00:00
Gerald Combs 7247fa0b45 More Win64 fixes.
svn path=/trunk/; revision=27903
2009-03-30 20:52:25 +00:00
Anders Broman 6065fbd874 Extention and bug fixes.
svn path=/trunk/; revision=27901
2009-03-30 20:03:04 +00:00
Gerald Combs 772e18dc89 Fixup whitespace.
svn path=/trunk/; revision=27900
2009-03-30 19:39:01 +00:00
Anders Broman bd49b6e54b More size_t casts(Unfinished)
svn path=/trunk/; revision=27898
2009-03-30 19:00:00 +00:00
Gerald Combs ef0e74e533 More size_t casts.
svn path=/trunk/; revision=27897
2009-03-30 18:40:33 +00:00
Gerald Combs c5f52b8fa0 In packet-enttec.c and packet-fw1.c, replace string pointer tracking with a
string buffer. In packet-ftp.c and packet-gift.c, cast some size_t's.

svn path=/trunk/; revision=27896
2009-03-30 17:53:41 +00:00
Gerald Combs 92ade75cd0 Replace another string pointer dance with a string buffer.
svn path=/trunk/; revision=27895
2009-03-30 17:24:50 +00:00
Anders Broman 184a60e0d6 Handle NAL-unit start code correctly.
svn path=/trunk/; revision=27894
2009-03-30 16:35:58 +00:00
Bill Meier 61a8dfa849 From Jens Steinhauser: IEEE C37.118 Synchrophasor dissector
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2798
Committed with minor changes:
- Add the standard Wireshark copyright lines
  [Wireshark ... Copyright 1998 Gerald Combs]
- Move proto_register... and proto_reg_handoff... to
  the end of the file as per the usual Wireshark
  dissector file format.

svn path=/trunk/; revision=27893
2009-03-30 11:57:14 +00:00
Martin Mathieson 6cc0cf8456 Initialise a variable to prevent a warning (that looks invalid to me).
svn path=/trunk/; revision=27892
2009-03-30 09:34:15 +00:00
Gerald Combs 2c74073079 Add a couple of size_t casts to packet-dnp.c.
Make the length arguments of format_text() and format_text_wsp()
size_t's, since it's natural to use strlen() for that.

svn path=/trunk/; revision=27891
2009-03-30 03:40:12 +00:00
Bill Meier 808a4e2c3c Define certain fcns as static (if not used externally).
Also: whiule we're at it: 
 - fix hf[] blurbs as appropriate to use NULL;
 - fix some indentation

svn path=/trunk/; revision=27890
2009-03-29 22:16:26 +00:00
Anders Broman f77b5f8d77 Handle the case when FMTP parameters are "out-of-order".
-  - Use NULL instead of repeated text in blurb in hf[];

svn path=/trunk/; revision=27889
2009-03-29 21:59:28 +00:00
Anders Broman caf80bbb74 More size_t casts.
svn path=/trunk/; revision=27888
2009-03-29 21:20:15 +00:00
Anders Broman b666a7942e More size_t casts.
svn path=/trunk/; revision=27887
2009-03-29 18:26:06 +00:00
Anders Broman 564e51f8cc - Dissect Supplemental enhancement information (SEI).
- Use NULL instead of repeated text in blurb in hf[];

svn path=/trunk/; revision=27886
2009-03-29 16:08:17 +00:00
Bill Meier cba2558006 Fix code so changing port pref will work + other small changes:
- Use NULL instead of "" in blurb in hf[];
- Remove unnecessary #includes;
- Make various internal functions static;
- Use tabs consistently for indentation;
- Some reformatting of statements;

svn path=/trunk/; revision=27885
2009-03-29 15:34:26 +00:00
Anders Broman 8e7599022d More size_t casts.
svn path=/trunk/; revision=27882
2009-03-29 14:37:57 +00:00
Anders Broman f36c046eef Fix:
packet-ldss.c: In function 'dissect_ldss_transfer':
packet-ldss.c:469: warning: 'ldss_tree' may be used uninitialized in this function
packet-ldss.c:469: warning: 'line_tree' may be used uninitialized in this function

svn path=/trunk/; revision=27881
2009-03-29 14:16:37 +00:00
Anders Broman e0171e1a79 More size_t casts.
svn path=/trunk/; revision=27880
2009-03-29 13:47:15 +00:00
Anders Broman 8611ec5f5e More size_t casts.
svn path=/trunk/; revision=27879
2009-03-29 12:07:30 +00:00
Stephen Fisher 1ab88afea0 Squelch warning about variable may be used uninitialized in this function
svn path=/trunk/; revision=27878
2009-03-29 05:30:26 +00:00
Stephen Fisher a7d48ed8b6 Patch from enhancement bug #3265: LDSS (local download sharing service)
svn path=/trunk/; revision=27877
2009-03-29 04:58:27 +00:00
Guy Harris c023fe9066 Don't use sprintf() - use ep_strbufs and ep_strbuf_append_printf()
instead.

svn path=/trunk/; revision=27876
2009-03-28 17:30:31 +00:00
Gerald Combs a76381c40e Fix a couple items from the last checkin.
svn path=/trunk/; revision=27874
2009-03-28 00:35:02 +00:00
Gerald Combs 21e87a963f Replace a lot of pointer tracking and some GStrings with emem_strbufs. Add
ep_strbuf_printf and ep_strbuf_append_c.

svn path=/trunk/; revision=27873
2009-03-28 00:27:03 +00:00
Gerald Combs 446d43351c Add initial support for string buffers - ep_allocated, growable strings
similar to GLib's GStrings. Use them to create the list of TCP flags.

svn path=/trunk/; revision=27872
2009-03-27 23:05:37 +00:00
Stephen Fisher ab972611da Remove extra parenthesis on two lines
svn path=/trunk/; revision=27871
2009-03-27 20:16:15 +00:00
Stephen Fisher 956c2e2dc6 Add request/response like tracking to the TFTP dissector. In this case, it
is used to show the source or destination filename being trasnferred on
every packet of that transfer as a generated item.


svn path=/trunk/; revision=27870
2009-03-27 19:45:46 +00:00
Stephen Fisher d3be9b80a9 Put the new tvb_get_seasonal_string() function to good use.
svn path=/trunk/; revision=27869
2009-03-27 19:41:18 +00:00
Gerald Combs c12114d6e1 More size_t casts.
svn path=/trunk/; revision=27866
2009-03-27 16:17:31 +00:00
Bill Meier e1f255fbda (Minor); if (! initialized) not req'd; move hf[] to proto_register;
Remove unnecessary include files.

svn path=/trunk/; revision=27862
2009-03-27 12:48:11 +00:00
Bill Meier cb3db511f6 As suggested by Jakob Zawadzki: (Bug #3311): g_free() is NULL safe, so we don't need check against it.
svn path=/trunk/; revision=27861
2009-03-27 12:16:02 +00:00
Anders Broman 07a02beb98 From Artem Tamazov:
Added: FR MPLS PW support. Expanded: "default MPLS payload" menu.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3325

svn path=/trunk/; revision=27860
2009-03-27 07:17:05 +00:00
Anders Broman 4e5748c125 From Andreas Heise:
SIP dissector fix: mismatch of P-Asserted-Identity and P-Answer-State headers
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3356

svn path=/trunk/; revision=27859
2009-03-27 07:08:07 +00:00
Anders Broman 44c3d1b3ad In informationDirective use MSID instead of mobileIdentificationNumber.
svn path=/trunk/; revision=27858
2009-03-27 06:59:15 +00:00
Bill Meier 90b9182895 From Peter <pva At gentoo.org>: Fix build err: "variable 'payload_len' might be clobbered by 'longjmp' or 'vfork'"
Fixes Bug #3353

svn path=/trunk/; revision=27856
2009-03-26 22:34:53 +00:00
Bill Meier 9a8ab9dd23 (Trivial): Fix a typo
svn path=/trunk/; revision=27855
2009-03-26 21:46:07 +00:00
Jörg Mayer c025bc7263 Repleace "" by NULL in hf-array (inspired by commit 27851).
svn path=/trunk/; revision=27854
2009-03-26 18:33:50 +00:00
Anders Broman 98d0847eda From Vincent Helfre:
Fix unaligned bitfields.
From me activate the SEQUENCE OF patch.

svn path=/trunk/; revision=27853
2009-03-26 18:01:26 +00:00
Bill Meier eb88a5ea1f (Trivial): Use NULL instead of "" in hfp[] blurbs
svn path=/trunk/; revision=27851
2009-03-26 17:17:06 +00:00
Balint Reczey 974074c316 Fix ESP Initialization Vector dissection.
svn path=/trunk/; revision=27850
2009-03-26 14:40:18 +00:00
Anders Broman 99bbe55222 Make it possible to check for extension marker in SEQUENCE OF and SET OF.
Fore some reason  the trace in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3360 does not decode properly
if dissecting the exension marker so leave that code #if 0:ed out for now.

svn path=/trunk/; revision=27848
2009-03-25 22:04:23 +00:00
Balint Reczey 124533ce95 From Frederic Roudaut:
Add CAST5-CBC and HMAC-RIPEMD160-96 support.


svn path=/trunk/; revision=27847
2009-03-25 18:04:30 +00:00
Jörg Mayer 85102f7a8f Forgot Makefile.common (packet-wassp.c)
svn path=/trunk/; revision=27845
2009-03-25 00:28:54 +00:00
Jörg Mayer 46ac6b6e53 Andreas Schuler
Fix display problems with b-fields:
increase the length of the string and use sprintf.

Original German comment:

weiter hab ich festgestellt das das b-field nicht richtig dargestellt wird .
Entweder ist g_snprintf broken , oder wir sind beide zu unf\344hig die
funktion zu benutzen .
Der string wird aus 16x %.2x + leerzeichen zusammengesetzt , was nach
meinen berechnungen eine h\366chstl\344nge von 144 zeichen + nullbyte ergibt .
deshalb hab ich die stringvariable auf 145 hochgesetzt und benutze wieder
sprintf . hier der patch dazu .


svn path=/trunk/; revision=27844
2009-03-24 22:13:18 +00:00
Jörg Mayer d50755f465 Andreas Schuler
small fix:
In a  PP packet TA=7 gets dissected as Paging tail.  In case of PP it
is really an Mt .


svn path=/trunk/; revision=27843
2009-03-24 22:09:21 +00:00
Jörg Mayer 0210800d08 Beginnings of WASSP dissection - that's the protocol run between
HiPath Wireless controllers and the APs.

svn path=/trunk/; revision=27842
2009-03-24 22:02:05 +00:00
Martin Mathieson d1fec1b985 Only report CRC Status when we know it to be valid.
svn path=/trunk/; revision=27841
2009-03-24 17:28:30 +00:00
Bill Meier 43682eea00 From David Castleford: ismacrypt dissector
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3009)

svn path=/trunk/; revision=27840
2009-03-24 17:00:53 +00:00
Balint Reczey 40fd250351 Removed code duplication in ASCII key computation.
svn path=/trunk/; revision=27839
2009-03-24 11:54:56 +00:00
Martin Mathieson f474eaedd8 Add CRC error flag to frames, and show in stats window.
svn path=/trunk/; revision=27837
2009-03-23 22:16:25 +00:00
Anders Broman 84bea61368 From Michael Lum:
ANSI MAP FeatureRequest update
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3349

svn path=/trunk/; revision=27836
2009-03-23 21:24:04 +00:00
Balint Reczey 59fd8b7d32 Fix ASCII key computation.
This fixes bug 2943 thus allows ESP decoding again, which was 
broken since r25264.

svn path=/trunk/; revision=27835
2009-03-23 18:14:28 +00:00
Anders Broman 226805b6b1 Some updates and bug fixes.
svn path=/trunk/; revision=27833
2009-03-23 17:32:39 +00:00
Anders Broman c84056b66d Update to the 200903 release.
svn path=/trunk/; revision=27832
2009-03-23 17:31:50 +00:00
Anders Broman aa4ddb790d Fix: The AuthDir invoke is missing optional tags for a couple of parameters.
and FeatReq invoke fixes.

svn path=/trunk/; revision=27831
2009-03-23 17:30:38 +00:00
Stig Bjørlykke b511818b09 Fixed some data types to remove some warnings.
svn path=/trunk/; revision=27830
2009-03-23 13:31:04 +00:00
Stig Bjørlykke 0c1f7c06f2 Fixed some data types to remove some warnings.
svn path=/trunk/; revision=27829
2009-03-23 13:15:56 +00:00
Stig Bjørlykke 9d70ae5470 Fixed some data types to remove some warnings.
svn path=/trunk/; revision=27828
2009-03-23 13:13:05 +00:00
Stig Bjørlykke 8b156ecfc8 Removed some "statement not reached" warnings.
svn path=/trunk/; revision=27827
2009-03-23 13:03:18 +00:00
Stig Bjørlykke df120bc8d2 Removed some "initializer does not fit or is out of range" warnings.
svn path=/trunk/; revision=27826
2009-03-23 12:44:50 +00:00
Stig Bjørlykke c11055cda9 Fixed some data types to remove some warnings in the solaris build.
svn path=/trunk/; revision=27825
2009-03-23 12:41:56 +00:00
Bill Meier 6d4606e9e8 P64 change
svn path=/trunk/; revision=27824
2009-03-22 22:15:23 +00:00
Anders Broman 00b5a6f1b8 Dissect all the ESM messages.
svn path=/trunk/; revision=27823
2009-03-22 21:20:56 +00:00
Bill Meier d6a5a7c761 P64 changes: Fix some cases for which size_t is not required
svn path=/trunk/; revision=27822
2009-03-22 20:55:31 +00:00
Bill Meier 4993cb95cd (Minor) Change a g_snprint to a g_strlcpy;
Also: Fix an off-by-1  inadvertantly introduced a while back.

svn path=/trunk/; revision=27820
2009-03-22 16:25:01 +00:00
Bill Meier 94f9079b2f g_snprintf() & etc since glib 1.3.12 don't return -1,
and also always NUL terminate the string.


svn path=/trunk/; revision=27819
2009-03-22 15:42:03 +00:00
Guy Harris 724cae360e proto_item_append_string() actually appends to the string value for a
protocol tree item; the item being added to isn't a string, so
proto_item_append_text() should be used - but the second argument to
proto_item_append_text() should always be a format string.

Use #if 0/#endif to leave a data structure in the source code without
compiling it in, rather than a comment (if you use a comment, things can
break if you put a comment into the commented-out code).

svn path=/trunk/; revision=27811
2009-03-20 23:20:45 +00:00
Martin Mathieson 77827a1ac7 Fix broken linux build.
svn path=/trunk/; revision=27809
2009-03-20 22:39:29 +00:00
Anders Broman 470b06a35e Further NAS updates.
svn path=/trunk/; revision=27808
2009-03-20 20:15:46 +00:00
Stig Bjørlykke 43976549ea From Dejan Bucar (bug 3345):
Added official LINX Ethernet type.

svn path=/trunk/; revision=27804
2009-03-20 11:06:20 +00:00
Anders Broman a60cc1d526 More NAS EPS updates and bugfixes.
svn path=/trunk/; revision=27802
2009-03-19 22:03:33 +00:00
Anders Broman a9f6319ec8 Revert the previous changes MCC and MNC are coded differently in different places.
svn path=/trunk/; revision=27801
2009-03-19 22:02:46 +00:00
Gerald Combs 18f24c0675 Add an expert item for the seconds-encoded-as-little-endian bug.
svn path=/trunk/; revision=27797
2009-03-19 17:40:18 +00:00
Anders Broman 40b778e01c From Michael Lum:
MEID digit translation fix.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3341

svn path=/trunk/; revision=27795
2009-03-19 06:41:41 +00:00
Bill Meier 20128275db - Move register_dissector(...) from proto_reg_handoff() to proto_register();
- Use dissector_add_handle("udp",...)  rather than dissector_add(""udp",0,...)

svn path=/trunk/; revision=27794
2009-03-19 01:54:09 +00:00
Guy Harris 987e12f435 Clean up indentation.
Note that -5047 can also mean "disk quota exceeded".

Define the ASP errors as 32-bit (negative) numbers, just like the AFP
errors.

Add a couple of ASP errors to the list of error values.

svn path=/trunk/; revision=27792
2009-03-18 23:30:21 +00:00
Stig Bjørlykke 4932b881f2 Removed C++ style comments.
svn path=/trunk/; revision=27791
2009-03-18 23:06:08 +00:00
Guy Harris cf536e062b Don't g_assert() in a dissector, just drive on.
Use ws_fopen(), not fopen(), to open files.

svn path=/trunk/; revision=27789
2009-03-18 21:40:04 +00:00
Guy Harris bd7aaf750a Don't g_assert() in a dissector; just drive on.
svn path=/trunk/; revision=27788
2009-03-18 21:37:56 +00:00
Guy Harris 3c2b8a7c84 None of those strings will have a length that doesn't fit in a gulong.
svn path=/trunk/; revision=27787
2009-03-18 20:56:21 +00:00
Guy Harris 6ef43f30a8 Get rid of a bunch of uses of size_t where int suffices.
svn path=/trunk/; revision=27786
2009-03-18 20:54:28 +00:00
Guy Harris a1ea9ba618 Squelch a P64 warning.
svn path=/trunk/; revision=27785
2009-03-18 20:48:42 +00:00
Guy Harris 7fe1c7daf5 Get rid of P64 warnings; those strings should never be longer than 2^31-1.
svn path=/trunk/; revision=27784
2009-03-18 20:47:22 +00:00
Guy Harris 59677ebed0 Use g_strreverse() to reverse strings.
svn path=/trunk/; revision=27783
2009-03-18 20:45:57 +00:00
Guy Harris fd7d6fdc03 Get rid of some P64 warnings; those lengths should never be > 2^31-1.
svn path=/trunk/; revision=27782
2009-03-18 20:42:59 +00:00
Guy Harris e98e65977f Get rid of uses of size_t; they're not necessary, and it causes a pile
of 64-bit-to-32-bit conversion warnings in LLP64 environments such as
Win64.

svn path=/trunk/; revision=27781
2009-03-18 20:41:45 +00:00
Richard van der Hoff 0bf1ff9f10 improve dissection of optional parameters. In particular, make the tag and length fields explicit.
svn path=/trunk/; revision=27780
2009-03-18 20:31:15 +00:00
Richard van der Hoff 02dbe1edba fix unused parameter warning
svn path=/trunk/; revision=27779
2009-03-18 20:30:35 +00:00
Anders Broman 0d2fb53b74 - Fix APDU dissection.
- NAS EPS bugfixes and enhancements.

svn path=/trunk/; revision=27778
2009-03-18 19:40:54 +00:00
Bill Meier 1f54573f66 From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
From me:
   - As suggested by Jakub actually use sizeof(...) rather than a numeric constant
      in various places;


svn path=/trunk/; revision=27775
2009-03-18 15:35:55 +00:00
Martin Mathieson f2c6ea1f55 Allow a lot more than 32 subheaders.
svn path=/trunk/; revision=27774
2009-03-18 15:35:45 +00:00
Bill Meier 4f34bb9b15 From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
- As suggested actually use sizeof(...) rather than a numeric constant.
  - g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1.

svn path=/trunk/; revision=27772
2009-03-18 15:03:46 +00:00
Anders Broman bd72a48963 From Munenori Ohuchi:
Enhacement to support 'WiMAX Forum/3GPP2 Proxy Mobile IPv4'.

svn path=/trunk/; revision=27770
2009-03-18 07:36:53 +00:00
Anders Broman 85b8227311 From Bjørn Mork:
Decode ipv6prefix attributes in packet-radius.

svn path=/trunk/; revision=27769
2009-03-18 07:31:35 +00:00
Anders Broman 26e5b929fa From Patrick A Baldwin:
Enhancements for CCSDS Dissectors.

svn path=/trunk/; revision=27768
2009-03-18 07:29:36 +00:00
Anders Broman 9fd55bf111 Fix a typo.
svn path=/trunk/; revision=27761
2009-03-17 20:20:36 +00:00
Bill Meier a993847667 (Minor): Remove some unneccessary code; Fix a typo;
svn path=/trunk/; revision=27759
2009-03-17 19:30:58 +00:00
Bill Meier 4f01ce929b Add a comment about the way g_snprintf is used.
svn path=/trunk/; revision=27758
2009-03-17 19:28:05 +00:00
Bill Meier a213345be2 Add a comment about the way g_snprintf() is used.
svn path=/trunk/; revision=27756
2009-03-17 18:13:44 +00:00