Commit Graph

28 Commits

Author SHA1 Message Date
Bill Meier c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Anders Broman 3947676a84 From Vincent Helfre:
Fix sndcp_xid_offset.

svn path=/trunk/; revision=26990
2008-12-13 22:00:22 +00:00
Jaap Keuter 9a3accd9b1 Fix for bug 2944:
Textual correction: Unnumbered Information format-> Unconfirmed Information format, among others.

svn path=/trunk/; revision=26369
2008-10-07 07:29:32 +00:00
Bill Meier aa30dcd129 Minor proto_reg_handoff cleanup: use find_dissector when appropriate.
svn path=/trunk/; revision=26308
2008-09-30 14:49:44 +00:00
Anders Broman 2c68dca215 From Neil Piercy:
Empty GPRS LLC S frames cause truncated data exception
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2855

svn path=/trunk/; revision=26160
2008-09-07 13:36:56 +00:00
Anders Broman acd81d93f8 Fix packet-gprs-llc.c:413: warning: format '%lu' expects type 'long unsigned int', but argument 7 has type 'guint32' and the modified makfiloe.common missed in previous checkin.
svn path=/trunk/; revision=25891
2008-08-01 11:25:23 +00:00
Anders Broman 21381b2f37 From Vincent Helfre:
Implementation of a dissector for SNDCP XID parameters

svn path=/trunk/; revision=25889
2008-08-01 11:08:21 +00:00
Anders Broman 526725485e packet-gprs-llc.c:431: warning: 'ui_ti' may be used uninitialized in this function
svn path=/trunk/; revision=25856
2008-07-28 23:43:39 +00:00
Anders Broman 583d2e96e3 packet-gprs-llc.c:324: warning: unused parameter 'ui_ti'
svn path=/trunk/; revision=25855
2008-07-28 23:03:52 +00:00
Anders Broman 3ea9adb2ff From Vincent Helfre :
GPRS LLC CRC24 badly calculated for non protected frames
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2290

svn path=/trunk/; revision=25854
2008-07-28 19:32:59 +00:00
Bill Meier 33af75a599 Fix some warnings reported by gcc -Wshadow ...
svn path=/trunk/; revision=25628
2008-06-28 21:09:57 +00:00
Jeff Morriss bb323055b2 match_strval() may return NULL so don't blindly pass its return value into col_add_*() or proto_add_*(); use val_to_str() (returning "Unknown (%d)" if no match is found) instead.
svn path=/trunk/; revision=24557
2008-03-04 21:05:21 +00:00
Anders Broman 0b4529008d Implement some of the minor possible speed improvment patches.
svn path=/trunk/; revision=23150
2007-10-11 21:23:14 +00:00
Anders Broman ee86c4c30e From Cyrille Colin:
gsm_a :
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1754
SMS CP (gsm_a_dtap), RP (gsm_a_rp) and T-PDU (gsm_sms) protocol stacks are
decoded in Wireshark when called by BSSAP or RANAP.
Same protocol stack can be called by GPRS-LLC (sapi 7). Simple modification
needed in packet-gsm_a.c to add dtap dissector to llcgprs.sapi 7.

Me a comment in gprs-llc.

svn path=/trunk/; revision=22559
2007-08-20 20:55:06 +00:00
Anders Broman 996d4db495 Ethereal->Wireshark
svn path=/trunk/; revision=18234
2006-05-28 19:49:07 +00:00
Anders Broman 28509cb311 Dissect rrlp payload.
svn path=/trunk/; revision=18211
2006-05-23 05:35:20 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman 2145d15234 From Rene Pilz:
- LLC XID patch (reaability patch).
- Dissection of the MS Radio Capabilities.


svn path=/trunk/; revision=16199
2005-10-12 05:34:36 +00:00
Ronnie Sahlberg 8ad6c3d2ac add missing value_string termination
svn path=/trunk/; revision=15580
2005-08-28 02:13:35 +00:00
Ulf Lamping 0dc9fb3d4a various code cleanup:
-use g_snprintf instead of sprintf and snprintf
-use g_strdup_printf where appropriate
-remove #include "snprintf.h" (as only g_snprintf should be used)
-replace some more alloc/realloc/calloc/free with their glib pendants

svn path=/trunk/; revision=15264
2005-08-08 18:50:39 +00:00
Anders Broman 6ced262fdf From THORNTON, MATT
Some changes that I made to flesh out GPRS message parsing.  More information is displayed about the various frame formats.  I have also added some code to parse XID parameters in the U frame.  I have also fixed a couple of display bugs in the GSM and GPRS LLC parser.

svn path=/trunk/; revision=15224
2005-08-05 19:16:29 +00:00
Ulf Lamping 2c30357c48 checksum messages: use "[correct]" instead of "(correct)" and other "alike" messages
svn path=/trunk/; revision=14880
2005-07-08 22:11:13 +00:00
Guy Harris e84c3d927c Handle the CRC correctly:
don't do it if we don't have the entire packet, including the
	CRC value;

	fetch the CRC value from the packet with tvb_get_letoh24(),
	and compare that against the computed CRC, rather than comparing
	the computed CRC (presumably in host byte order) with the
	little-endian CRC in the packet (that doesn't work if host byte
	order is big-endian).

svn path=/trunk/; revision=13571
2005-03-02 00:21:33 +00:00
Guy Harris 6421106005 Fix capitalization.
svn path=/trunk/; revision=13549
2005-02-28 09:21:59 +00:00
Anders Broman 37a96cbad0 From Rene Pilz :
BSSGP:
   - Does not dissect the LLC-PDU twice

LLC:
- Add CRC calculation to differ between ciphered and non-ciphered packets without taking care about the encryption bit.
This solves crashes when the option "ignore ciphere bit" was activated


GMM/SM:
   - Dissect detach_type now correctly ( fixed by Miklos Szurdi )
   - Dissect timer correctly ( fixed by Miklos Szurdi )
   - Update SM causes for Release 6 ( Miklos Szurdi )
   - Update service_type for Release 6 ( Miklos Szurdi )
   - Rearange pco code like Guy Harris has suggested ( Guy Harris )
   - reimplement dissection of IPv4 and IPv6 addresses
   - Fix offset in pdp_addr
   - Fix offset in Traffic Flow Template (tft)

svn path=/trunk/; revision=13386
2005-02-12 21:20:38 +00:00
Guy Harris 105c252b03 Don't create a dissector handle that we don't use.
svn path=/trunk/; revision=12543
2004-11-18 03:35:43 +00:00
Guy Harris 8566564c59 From Rene Pilz: add a preference to ignore the cipher bit, in case
captures have unciphered data with the cipher bit set.

svn path=/trunk/; revision=12329
2004-10-17 11:04:28 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00