(Part of suggested patch for WIreshark 1.8 applied to trunk instead)
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8315
From me: Add an XXX xomment about how, on Windows, closing the top_level
Wireshark window while the capture_interfaces dialog window is open
will leave the associated dumpcap process running.
svn path=/trunk/; revision=48122
Also: Add an XXX comment re one effect of the
fact that, on Windows, dlg_window_new() does *not*
set the newly created dialog window as 'transient for'
the Wireshark top_level window.
svn path=/trunk/; revision=48106
- For each choice (marked/ignored fg/bg) always show orig color as "prev color";
- Improve spacing between widgets.
Also;
- Add a few explanatory comments;
- Add editor modelines;
- Cleanup whitespace/long-lines/formatting.
svn path=/trunk/; revision=48012
- Significantly simplify & rework code;
- Use GtkColorChooser instead of GtkColorSelection if GTK 3.4 or newer.
- Minor UI cleanup (default buttons & etc)
- Fix crash which occurred in the (existing) GTK3 related code.
- Fix some other relatively minor bugs (including some minor memory leaks);
- Remove some old, commented-out code;
- Use a more consistent naming scheme for certain variables.
svn path=/trunk/; revision=47958
1. Allow to DecodeBy payload over AVCTP
2. Fix L2CAP CID payload recognize after disc
3. Removed unneeded _U_
4. Fall back to control channel in AVRCP
5. Fix time-tracking for passthrough and capability AVRCP commands
From Michal Labedzki, bug 8367 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8367)
svn path=/trunk/; revision=47810
(at the moment, the edit window remains open even if the file is closed or
changed, this allows effectively to overwrite a file's capture commment with
the capture comment of a previously used file)
svn path=/trunk/; revision=47779
is running" mutex. Have the NSIS installer check for this mutex and ask
the user to close Wireshark if it's found. While not perfect this makes
the WinSparkle update process much less annoying.
svn path=/trunk/; revision=47758
preferences (currently hidden) to disable updates, set the update
frequency, and set the update "channel" (stable vs development). Add a
"Help" menu item to manually check for updates.
svn path=/trunk/; revision=47748
gtk_selection_data_set() takes an int, rather than a size_t, as its last
argument, so cast away that bit of "ZOMG ARENT SIZE_T AND INT THE SAME
SIZE!!!!!!!111ONE!!!!!"
svn path=/trunk/; revision=47628
routine (prefs_register_directory_preference). Add PREF_FILENAME and
PREF_DIRNAME support to the Qt module preferences. Change a couple of
preferences to directory names.
Clean up some names and default settings.
svn path=/trunk/; revision=47573
for a preferences module. Use it to fill in the remaining preferences.
Don't show the printing preferences since they're not used here.
Change the titles and tooltips for some of the name resolution
preferences.
Disable the capture preferences if we can't capture. This is different
from the GTK+ version which hides it completely.
Thus concludes the preferences dialog (for the time being).
svn path=/trunk/; revision=47545
Add comments noting that
- We might want to do something different when the bookmark button is
pressed.
- The display filters (dfilters file) and gui.filter_expressions
preferences should be merged.
- Many buttons on Qt4 + OS X + unifiedTitleAndToolBarOnMac makes the
main window really wide.
Add a qstring_strdup convenience routine. Add "disabled" display filter
edit icons. Fix up whitespace and descriptions in a couple of places.
svn path=/trunk/; revision=47522
converted to QStrings, and, to get them to be treated as UTF-8, you need
to call the setCodecForCStrings method of the QTextCodec class to set
the codec to a UTF-8 codec.
In Qt 5, C strings are treated always as UTF-8 when converted to
QStrings, and there's no setCodecForCStrings method for the QTextCodec
class.
In addition, there's also no setCodecForTr method for the QTextCodec
class - and QObject isn't documented as even *having* a tr method, so I
don't know what to do there.
svn path=/trunk/; revision=47436
This completes the process of replacing
Wireshark gtk_table...() usage !!
(However: the prefs dialogs still have a few Gtk3
related Expand/Fill issues which need to be fixed).
svn path=/trunk/; revision=47262
Also: minor cleanup:
- use gtk_window_set_default_size() iso gtk_window_resize();
- change grid row numbers to start at 0 (not 1);
- fix some formatting/whitespace.
svn path=/trunk/; revision=47260
picker widget so we're back to popping up dialogs. Move the contents of
monospace_font.{cpp,h} to wireshark_application.{cpp,h}.
Pango and Qt use completely different string representations for fonts.
Add a separate gui.qt.font_name preference so that they don't clobber
each other.
svn path=/trunk/; revision=47240
Get rid of user-hostile behavior. In the layout preferences pane 2 & 3
radio buttons overrode the user's selection if a duplicate item was
selected. Now we assume that the user knows what he or she is doing and
steal duplicate selections from the other panes.
Qt:
Match the new GTK+ behavior in the layout preferences. Add padding
around the layout images. Add toolbar style preferences to the
Appearance pane (instead of the layout pane).
All:
Remove the selection mode and scrollbar placement prefs and mark them
obsolete as recently discussed on -dev.
Adjust the layout images yet again after more Awful Monitor Testing.
svn path=/trunk/; revision=47214
in a similar manner as done in Makefile.am)
(On my Windows 7 system gdk-pixbuf-csource gives an error
message about "...Couldn't recognize the image file format...".
Let's see what happens in the Windows buildbots).
svn path=/trunk/; revision=47165
more clearly indicate that it's a copy of a preference value rather than
something we've saved in the preferences file. Update
prefs_pref_to_str() to handle default, stashed, and current prefs.
Create ui/preference_utils.[ch] and move some common routines there. Use
prefs_pref_type_name() in the GTK+ preferences dialog.
Make the "OK" button in the Qt preferences dialog work. We simply write
the prefs and redissect on "OK" and do nothing on "Cancel". This is
intentionally different from the Apply/OK/Cancel behavior in the GTK+
version.
Add a general "emitAppSignal" method to wsApp and use it for packet
dissection and preference changes.
Suggest that we might want to create a WsString class to make conversion
between QStrings, gchar *s, and GStrings easier.
svn path=/trunk/; revision=47139
when packing into a [v|h]box so that Gtk2 & Gtk3 behavior is
the same.
Also: Add an XXX comment:
"progess" rendering doesn't seem to work for Gtk3 ??
svn path=/trunk/; revision=47135
when packing into a [v|h]box so that Gtk2 & Gtk3 behavior is
the same.
Also: Add an XXX comment:
"progess" rendering doesn't seem to work for Gtk3 ??
svn path=/trunk/; revision=47134
If we don't get the airpcap_if_list, don't do anything regarding air_pcap.
update_decryption_mode_list() should probably check if a change is taking place before rescaning all packets.
svn path=/trunk/; revision=47131
Specifically: use gtk_box_pack_start() instead
of gtk_container_add() in a number of places.
Also: do some whitespace cleanup.
svn path=/trunk/; revision=47129
Use gtk_box_pack_start() instead of
gtk_container_add() in a few places so that
window resize behavior is the same for
Gtk2 and Gtk3.
Also: do some whitespace cleanup.
svn path=/trunk/; revision=47117
Specifically: use gtk_box_pack_start()
instead of gtk_container_add() in one case
so that (for Gtk3) a window component properly
expands when the window is resized vertically.
svn path=/trunk/; revision=47115
information to crash dumps and the like. (Currently, we only handle OS
X's CrashReporter, but we should do this on other platforms where this
information can be added and would be helpful.)
svn path=/trunk/; revision=47109
Set a default size for the window so that the
initial size of the window in Gtk3 is similar to
that in Gtk2. That is: so that all the columns
(and a number of rows) show.
svn path=/trunk/; revision=47099
immediately close the dialog if he or she presses the escape or enter
keys. Revert the value if the user presses escape. Properly handle the
base for uint preferences. Fix a NULL pointer dereference.
Add a gchar_free_to_qstring utility routine which creates a QString from
a g_malloced string and frees it.
svn path=/trunk/; revision=47083
Use "4 space" indentation.
Add an XXX comment about better formating needed
for the text in the Help window (so the
text columns line up and so the Help text
looks better).
Comment out a "does-noting" for loop;
svn path=/trunk/; revision=47059
Add an XXX comment about trying (and failing)
to change the behavior of the grid when the
column prefs window is horizontally resized.
Also: do whitespace cleanup: indentation & etc.
svn path=/trunk/; revision=47032
Do some minor changes so that the Gtk2 & Gtk3
window resizing behavior is the same.
Also: Clean up whitespace: indentation & etc.
svn path=/trunk/; revision=47024
1. 'File ! Open' changes applied to the 'File ! Merge' window;
2. Small change made so that the GTk2 & Gtk3 behavior are the same (Finally !)
3. window structure picture and notes updated.
svn path=/trunk/; revision=47008
The Gtk2 vs Gtk3 behavior is not precisely the same
when resizing the window hozizontally; IMO it's
"good enough" (after several days of playing around
trying to make the behaviour identical).
svn path=/trunk/; revision=47004
item's name, status, or type resets it to its default value.
Double-clicking the item's value lets you edit it. Implement the
advanced search field. (Clicking OK and Cancel still doesn't yet do
anything.)
Note that we could probably use a
prefs_register_{uint16|port}_preference routine for 16-bit values. Make
reset_pref public. Update some names and descriptions.
svn path=/trunk/; revision=46986
representations, and default status out of write_prefs and into their
own routines. Split the corresponding custom preference write callbacks.
Fix an apparent memory leak in the hidden column callback.
Add an initial preferences dialog to the Qt port. Use the new preference
routines to implement an "Adavanced" page similar to the "about:config"
page available in many web browsers. Standard pages will hopefully follow
soon.
Remove some QDebug includes and make sure our QTreeWidgets have uniform
row heights set.
svn path=/trunk/; revision=46942
Fix minor differences in window handling between Gtk2 & Gtk3:
Use gtk_box_pack_start() instead of gtk_container_add() in
various places.
Also; Do some whitespace and formatting style cleanup.
svn path=/trunk/; revision=46937
Use gtk_box_pack_start() instead of gtk_container_add() in several places.
Also; Do some whitespace and formatting style cleanup.
svn path=/trunk/; revision=46931
Add an XXX comment as to an apparent limit on the
number of characters in a tooltip (at least in one case).
Do some minor whitespace and long-lines cleanup.
svn path=/trunk/; revision=46921
Fix a minor difference in window handling between Gtk2 & Gtk3:
Use gtk_box_pack_start() instead of gtk_container_add() in one case.
Also; Do some whitespace and formatting style cleanup.
svn path=/trunk/; revision=46920
Set the default window size to show the complete window;
Fix a minor difference in window handling between Gtk2 & Gtk3:
Use gtk_box_pack_start() instead of gtk_container_add() in one case.
Also; misc minor cleanup.
svn path=/trunk/; revision=46918
Also: Fix a minor difference in window handling between Gtk2 & Gtk3:
Use gtk_box_pack_start() instead of gtk_container_add(0 in one case.
svn path=/trunk/; revision=46915
"Font and Colors". Use a GtkFontButton to select the font and update the
sample text accordingly. Instead of attempting to resize the sample
color text (which didn't appear to work) scroll to the text that matches
the current combo box selection.
svn path=/trunk/; revision=46909
Also: Fix a minor difference in window handling between Gtk2 & Gtk3:
Use gtk_box_pack_start() instead of gtk_container_add(0 in one case.
svn path=/trunk/; revision=46908
