Commit Graph

9598 Commits

Author SHA1 Message Date
Guy Harris 0ad957b271 From Alex Rozin: cope with what appears to be an ambiguity in the 802.1s
spec, where different implementations take different interpretations.

svn path=/trunk/; revision=9595
2004-01-07 21:14:51 +00:00
Ulf Lamping bd37ba81eb added some simple_dialogs, if save of raw data fails for some reasons
svn path=/trunk/; revision=9594
2004-01-07 20:14:17 +00:00
Olivier Biot 5dd65e0fe0 Get rid of a now unused variable.
svn path=/trunk/; revision=9593
2004-01-07 19:52:25 +00:00
Guy Harris 4645bfd999 Update the list of OSes and OS versions on which Ethereal is known to
work (or inferred to work - some lists were changed to "XXX and later",
on the assumption that later releases didn't break anything).

svn path=/trunk/; revision=9592
2004-01-07 19:51:39 +00:00
Olivier Biot 09668847cc Add a preference that controls the way the SIP version is enforced. By default,
strict enforcement of SIP/2.0 will be applied.

Add some comments.

From Anders Broman:

	Fix the length of content_type_parameter_str.

	Fix a typo in a comment.

svn path=/trunk/; revision=9591
2004-01-07 19:49:45 +00:00
Olivier Biot 219940011c Remove extraneous parameters of packet count in case the end-user manually
enters a range of packets. Comment this in the code.

svn path=/trunk/; revision=9590
2004-01-07 19:10:49 +00:00
Ulf Lamping fa7d90f2c8 minor changes
svn path=/trunk/; revision=9589
2004-01-07 12:12:09 +00:00
Ulf Lamping d242cc04a4 added current windows versions
svn path=/trunk/; revision=9588
2004-01-07 12:10:36 +00:00
Guy Harris a772545c4b Fix some typoes.
Give the appropriate locations for libiconv, gettext, and WinPcap.

Note that the WinPcap package is *not* available from ethereal.com.

Explain a bit more about how to unpack the zip files for development
packages.

svn path=/trunk/; revision=9587
2004-01-07 07:17:47 +00:00
Guy Harris 90aa5d1e9e The type values from Net-SNMP are u_chars; make the formal argument for
them u_char.

svn path=/trunk/; revision=9586
2004-01-07 05:24:36 +00:00
Gilbert Ramirez 4f1c2830f1 Don't assert that quoted_string be NULL; it can be non-NULL if
the previous dfilter failed to compile because a closing double-quote
was not provided. Handle that case.

svn path=/trunk/; revision=9585
2004-01-07 05:24:04 +00:00
Guy Harris 349feca55d Don't do anything exotic to get signed integral values - Ethereal's
dissectors assume a two's-complement machine (we offer our apologies to
those trying to run it on sign-magnitude IBM 7090/7094's and one's
complement Univac/Unisys 11xx machines :-)).

svn path=/trunk/; revision=9584
2004-01-07 05:13:29 +00:00
Guy Harris f497416d24 The year in a LANalyzer capture's trace summary record is a 2-byte year
number.

svn path=/trunk/; revision=9583
2004-01-07 04:50:21 +00:00
Guy Harris 542c89afd4 Use "tvb_get_guint8()", not "tvb_get_ntohs()", to fetch 1-byte numbers.
Use "proto_tree_add_item()" if you don't need the number's value.

svn path=/trunk/; revision=9582
2004-01-07 04:33:21 +00:00
Jörg Mayer 9422e256ef Not that it really matters as the test still alwas evaluates to false:
An array with 256 elements should not be accessed with an index >= 256,
as we do not count as normal people do.

svn path=/trunk/; revision=9581
2004-01-07 01:44:23 +00:00
Ulf Lamping bba39ed952 save dialog with "Captured" and "Displayed" buttons in packet range
svn path=/trunk/; revision=9580
2004-01-07 00:10:52 +00:00
Jörg Mayer bcccb3185d GPL.txt -> ../../COPYING
svn path=/trunk/; revision=9579
2004-01-06 22:52:59 +00:00
Guy Harris 73d47925eb Widgets get freed when the reference count goes to zero; we don't need
to explicitly destroy menu items when we remove them from the "recent
files" list.

Clean up indentation.

svn path=/trunk/; revision=9578
2004-01-06 22:38:07 +00:00
Guy Harris 5f4ed6f6f8 Clear the interface list and free up interface names whenever a new
capture is read.

"interface_anzahl" is always <= MAX_INTERFACES, so we don't need to
check array indices against MAX_INTERFACES when iterating over all known
interfaces.

svn path=/trunk/; revision=9577
2004-01-06 22:05:37 +00:00
Guy Harris 77e43b09ea Don't add an interface to the interface list if we already have
MAX_INTERFACES interfaces in the list.

Make "found" a gboolean.

svn path=/trunk/; revision=9576
2004-01-06 21:11:04 +00:00
Guy Harris 0b82bd5123 Packet data is an array of "guint8"s, not an array of "char"s; declare
variables appropriately.

Put in a cast to squelch MSVC++ warnings.

svn path=/trunk/; revision=9575
2004-01-06 20:05:39 +00:00
Guy Harris f18a95e44e Make the forward declarations of routines and their definitions match.
svn path=/trunk/; revision=9574
2004-01-06 19:56:56 +00:00
Guy Harris 5887d3d5f9 Add some sanity checking for the "-i" argument.
svn path=/trunk/; revision=9573
2004-01-06 02:58:20 +00:00
Guy Harris c5632f3648 Make a variable to which a 16-bit value is assigned big enough to hold
such a value.

svn path=/trunk/; revision=9572
2004-01-06 02:51:13 +00:00
Guy Harris 2df47a9f99 Make some variables to which 16-bit values are assigned wide enough to
hold those values.

svn path=/trunk/; revision=9571
2004-01-06 02:47:40 +00:00
Guy Harris 7e0664f00a The error code in an NBDS error packet is 1 byte, not 2.
svn path=/trunk/; revision=9570
2004-01-06 02:42:50 +00:00
Guy Harris 5e7f6fbdb9 In "decode_qos_umts()", "length" can get assigned a 2-byte value, so
make it a "guint", not just a "guint8".

svn path=/trunk/; revision=9569
2004-01-06 02:38:03 +00:00
Guy Harris 42d05141a3 "decode_MPLS_stack()" always returns a nonnegative value; make it return
"guint", and make the "labnum" variable to which its return value is
assigned a "guint".

"plen" in "decode_prefix_MP()" can have a 16-bit value assigned to it;
make it a "guint", not just a "guint8".

svn path=/trunk/; revision=9568
2004-01-06 02:29:36 +00:00
Guy Harris ad6d84c254 Note in a comment that "dissect_asp_reply_get_status()" might be
dissecting AFP server status - other servers might have different status
formats.

In "dissect_asp_reply_get_status()", put the UTF-8 server name into a
tree, with the length and name in the tree as separate items, and fetch
the length into a 16-bit variable (as it's a 16-bit length in the
packet), as is done in "dissect_dsi_reply_get_status()".  (XXX - should
that just be done with an FT_UINT_STRING field, as is done for other
strings?)

Use "tvb_get_string()" to fetch the UTF-8 server name, and set the
length and name from the values we fetched, in both of those routines.

For FT_UINT_STRING fields in "dissect_asp_reply_get_status()" and
"dissect_dsi_reply_get_status()", don't fetch the length separately -
just use the value filled in by "proto_tree_add_item()" (now that a
"proto_item" is no longer opaque, we can do that).  That means we don't
have a problem with overflows of the 8-bit "len" variable if the length
is 255.

svn path=/trunk/; revision=9567
2004-01-06 02:20:32 +00:00
Guy Harris 865109748d Get rid of an unused value_string table.
svn path=/trunk/; revision=9566
2004-01-06 00:09:48 +00:00
Guy Harris eb59f176c3 Use "rstat4_proc" rather than "rstat3_proc" for rstat version 4.
svn path=/trunk/; revision=9565
2004-01-06 00:08:55 +00:00
Ulf Lamping 65dd8f05bc an enum represents the radio buttons much better,
than an "array" of gbooleans

svn path=/trunk/; revision=9564
2004-01-05 22:21:53 +00:00
Ulf Lamping a895b5a77b fixed / updated some dependencies
svn path=/trunk/; revision=9563
2004-01-05 21:47:44 +00:00
Ulf Lamping 87fc510cb5 switched to MSVC warning level 3 and
default is winpcap version 3 now

svn path=/trunk/; revision=9562
2004-01-05 21:04:42 +00:00
Ulf Lamping 0d9679de8d removed some MSVC warnings (level 3)
svn path=/trunk/; revision=9561
2004-01-05 19:31:44 +00:00
Ulf Lamping ba3b94790d removed some MSVC warnings (level 3)
svn path=/trunk/; revision=9560
2004-01-05 18:11:28 +00:00
Guy Harris 8b26cb6a67 From Alex Rozin: fix handling of MST messages.
Fix his e-mail address.

svn path=/trunk/; revision=9559
2004-01-05 17:35:31 +00:00
Ulf Lamping f16ac7a482 removed some MSVC warnings (level 3)
svn path=/trunk/; revision=9558
2004-01-05 17:33:28 +00:00
Ulf Lamping 94a7e4427b using the file "COPYING" instead of "GPL.txt"
svn path=/trunk/; revision=9557
2004-01-05 17:29:38 +00:00
Guy Harris 8128e99879 From Alex Rozin: fix handling of MST messages.
Fix his e-mail address.

svn path=/trunk/; revision=9556
2004-01-05 17:26:10 +00:00
Ulf Lamping 108b5cb256 using the file "COPYING" instead of "GPL.txt"
svn path=/trunk/; revision=9555
2004-01-05 15:27:35 +00:00
Ulf Lamping 391cfa861d From Lars Roland: corrected PATH settings
svn path=/trunk/; revision=9554
2004-01-05 15:05:00 +00:00
Ulf Lamping b6a0525091 Bugfix from Lars Roland: included missing xdlc.h
svn path=/trunk/; revision=9553
2004-01-05 15:03:38 +00:00
Guy Harris 67f467ddd9 For RTSP requests, we assume that, if there's no Content-Length header,
the request has no body.

When displaying the body, use the reported length remaining, not the
captured length remaining, as the length.

svn path=/trunk/; revision=9552
2004-01-05 03:51:28 +00:00
Guy Harris db85655fb0 Handle non-Unicode error tokens.
Error tokens (at least in one capture) appear to have a server name in
them; handle that as well.  (They also appear to have 3 more bytes of
stuff in them.)

svn path=/trunk/; revision=9551
2004-01-05 01:18:53 +00:00
Guy Harris 6bd03674ed From Yaniv Kaul:
add parsing of message token (Unicode and regular);

	add parsing of error token (Unicode only - do not have a non Unicode
	sample. Anyone?);

	add parsing of done token (only minimal actually);

	add parsing of Collation Information structure in Environment
	Change token.

svn path=/trunk/; revision=9550
2004-01-05 00:55:42 +00:00
Guy Harris 4fd596caf9 From Yaniv Kaul:
add parsing of message token (Unicode and regular);

	add parsing of error token (Unicode only - do not have a non Unicode
	sample. Anyone?);

	add parsing of done token (only minimal actually);

	add parsing of Collation Information structure in Environment
	Change token.

svn path=/trunk/; revision=9549
2004-01-05 00:44:21 +00:00
Ulf Lamping 3426136e95 From Dick Gooris: updated lots of comments
svn path=/trunk/; revision=9548
2004-01-04 23:32:34 +00:00
Olivier Biot f0f48d4d1f Add more information to the WTP protocol summary (PDU type and PDU specific
important parameters).

Document the computation of the length field in WTP concatenation after having
looked at a capture with the length field encoded as a WSP uintvar-integer.

Use "common code" for WTP reassembly, by calling process_reassembled_data().
Document the behavior of reassembly as the output of Ethereal differs between
the first and the second pass.

Question: shoud the common reassembly code provide a call-back mechanism to
get access to previously-unreassembled packets that appear to be part of a
reassembled whole, and to be able to update the state and information of
those packets at the time of the reassembly?

svn path=/trunk/; revision=9547
2004-01-04 22:02:16 +00:00
Guy Harris b135e5f680 From Shiang-Ming Huang: bug fix.
svn path=/trunk/; revision=9546
2004-01-04 20:44:50 +00:00