Commit Graph

12844 Commits

Author SHA1 Message Date
Anders Broman c7fb9d9fe3 From Pascal Quantin:
Fix dissection of PLMN List IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6513

svn path=/trunk/; revision=39674
2011-10-30 15:57:30 +00:00
Stig Bjørlykke 89880b5b59 Increase the size of a unknown INTEGER to FT_INT64 to be able to show
negative integers and integers up to MAXINT64.  We still don't support
integers between MAXINT64 and MAXUINT64, which would be 9 bytes long.

svn path=/trunk/; revision=39673
2011-10-30 15:55:18 +00:00
Guy Harris 7aa8340533 Clang Cat is watching you fail to check for a null pointer.
svn path=/trunk/; revision=39668
2011-10-30 06:47:27 +00:00
Guy Harris f15386dd93 Don't set mr_mult_req_info->num_services *unless we're sure
mr_mult_req_info is non-null*!  This should fix bug 6514, and possibly a
bunch of other buildbot crashes.

svn path=/trunk/; revision=39667
2011-10-29 20:41:30 +00:00
Stig Bjørlykke be353072dc Added support for big integer64 values.
This fixes bug 6295.

svn path=/trunk/; revision=39666
2011-10-29 18:26:57 +00:00
Martin Mathieson 338cb689a6 Fix the width of a type (and hopefully please the buildbots).
svn path=/trunk/; revision=39657
2011-10-28 18:59:30 +00:00
Martin Mathieson ec748afa3a First go at calling UMTS RLC dissector from IxCatapult logs.
Had to change some #defines in the header file (for UDP-framed/heuristic
dissector) - will need to update example sending program later on tonight.

svn path=/trunk/; revision=39656
2011-10-28 18:36:20 +00:00
Alexis La Goutte 5fb574c69e Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39655
2011-10-28 17:44:01 +00:00
Alexis La Goutte 654f213aae Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39654
2011-10-28 17:39:31 +00:00
Alexis La Goutte 2fb7b4fc4c From Xiao Xiangquan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5767
BitTorrent DHT dissector for wireshark

From me :
* Fix encoding attribut for proto_tree_add_item (with fix-encodings-args script)

svn path=/trunk/; revision=39653
2011-10-28 14:50:13 +00:00
Alexis La Goutte f0f3d8d13c From Xiao Xiangquan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5767
Make bt-utp as heuristic dissectors

svn path=/trunk/; revision=39652
2011-10-28 14:49:31 +00:00
Alexis La Goutte ece3e6d974 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39651
2011-10-28 11:20:19 +00:00
Alexis La Goutte 971e3ff730 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39650
2011-10-28 10:24:57 +00:00
Anders Broman fb1736120f From Adam Mitz:
The RTPS2 dissector doesn't handle octetsToNextHeader properly in INFO_RELY submessages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6506

svn path=/trunk/; revision=39646
2011-10-28 06:06:20 +00:00
Bill Meier c4b63360dc Fix proto_tree_add_item( encoding args;
Do whitespace cleanup (for a few files).

svn path=/trunk/; revision=39640
2011-10-27 20:30:38 +00:00
Anders Broman 1b75d2a3f3 ..Filter is not used any more.
svn path=/trunk/; revision=39639
2011-10-27 19:20:39 +00:00
Anders Broman e595aec776 Fix comparison with UAT keys.
svn path=/trunk/; revision=39637
2011-10-27 16:49:53 +00:00
Bill Meier 20e3e0b5b5 Fix some proto_tree_add_item() encoding args;
In some files:
 Remove a few unneeded #includes;
 Do some whitespace/indentation cleanup

svn path=/trunk/; revision=39635
2011-10-27 15:59:12 +00:00
Anders Broman 2c2fb429f7 Fix indentation.
svn path=/trunk/; revision=39634
2011-10-27 15:38:32 +00:00
Anders Broman 4d0e343dbf The comparison with the UAT keys are broken, this is
a fix for fetching the IP address.

svn path=/trunk/; revision=39633
2011-10-27 15:35:48 +00:00
Bill Meier 75c64294fa Fix a typo.
svn path=/trunk/; revision=39632
2011-10-27 14:50:20 +00:00
Jeff Morriss 7b6f829483 Correct an off-by-one error introduced in r39626.
svn path=/trunk/; revision=39631
2011-10-27 14:39:12 +00:00
Jeff Morriss 01de3aea36 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6498 :
Initialize cip_req_info_t.ciaData, too.

svn path=/trunk/; revision=39630
2011-10-27 14:30:57 +00:00
Jeff Morriss 8d25051a28 Followup to r39626: It is also necessary to initialize the number of services
to 0 (in case we throw an exception decoding the first service).

svn path=/trunk/; revision=39629
2011-10-27 13:30:32 +00:00
Jeff Morriss 3c622f7b80 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6491 :
Don't set mr_mult_req_info->num_services until we're sure we've
initialized the full structure for that service.  Otherwise if we
happen to throw an exception before initializing the whole
structure, we'll core someplace (like dissect_cip_generic_service_rsp())
which expects all num_services entries to be fully initialized.


svn path=/trunk/; revision=39626
2011-10-27 01:48:39 +00:00
Bill Meier 269cc1920f Fix a [-Wunused-but-set-variable] compiler warning;
Also: Remove trailing whitespace from lines.

svn path=/trunk/; revision=39623
2011-10-26 23:16:04 +00:00
Anders Broman 095c62b66e The comparison with the UAT keys are broken, this is
a fix for the SPI the src and dst IP address strings needs fixing too.
I'll look into that tomorrow if no one beats me too it.

svn path=/trunk/; revision=39621
2011-10-26 21:42:45 +00:00
Michael Tüxen 406678d63b Declare unused parameters as such. Don't assign them to themselves.
svn path=/trunk/; revision=39620
2011-10-26 20:58:05 +00:00
Bill Meier 0a1ded8725 Fix proto_tree_add_item() encoding args.
svn path=/trunk/; revision=39618
2011-10-26 20:43:58 +00:00
Bill Meier 1fff1e1b09 Fix a proto_tree_add_item() encoding areg;
Use gboolean instead of int in certain cases.

svn path=/trunk/; revision=39617
2011-10-26 20:25:00 +00:00
Bill Meier e400a0c8cb Fix proto_tree_add_item() encoding args;
Use gboolean instead of int in certain cases.

svn path=/trunk/; revision=39616
2011-10-26 20:06:48 +00:00
Bill Meier f7a3494571 Fix proto_tree_add_item() encoding args.
svn path=/trunk/; revision=39615
2011-10-26 19:24:58 +00:00
Bill Meier d6ac27ad42 Fix proto_tree_add_item() encoding args;
Also: remove unneeded #include.

svn path=/trunk/; revision=39614
2011-10-26 18:57:02 +00:00
Bill Meier 6905e631dc Fix some proto_tree_add_item() encoding args.
svn path=/trunk/; revision=39613
2011-10-26 18:38:09 +00:00
Bill Meier 379f083acd Fix some proto_tree_add_item() encoding args;
Remove some unneeded #includes.

svn path=/trunk/; revision=39612
2011-10-26 18:11:24 +00:00
Alexis La Goutte 542bf6f9b7 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39611
2011-10-26 18:02:17 +00:00
Alexis La Goutte 4c2317f44d Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39610
2011-10-26 18:02:01 +00:00
Alexis La Goutte d7c13d0e2d Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39609
2011-10-26 18:01:42 +00:00
Alexis La Goutte bcefa6c2c3 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39608
2011-10-26 18:01:25 +00:00
Alexis La Goutte 52ba0a20db Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39607
2011-10-26 18:01:12 +00:00
Alexis La Goutte d9623925e8 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39606
2011-10-26 18:00:54 +00:00
Bill Meier 4b79db3e55 Add missing hf[] entries (and fix proto_tree_add_item() encoding args).
svn path=/trunk/; revision=39605
2011-10-26 17:04:26 +00:00
Alexis La Goutte 8a00b9a315 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=39604
2011-10-26 15:53:25 +00:00
Stig Bjørlykke 60bb13e25f Removed duplicate enip.connection_transport_data entry.
This fixes bug 6490.

svn path=/trunk/; revision=39603
2011-10-26 12:15:07 +00:00
Martin Mathieson c3c789da98 Add a newline at the end of this file.
svn path=/trunk/; revision=39602
2011-10-26 10:09:20 +00:00
Anders Broman 32713e84c0 Try to get rid of defined but not used warnings.
svn path=/trunk/; revision=39600
2011-10-26 06:24:05 +00:00
Anders Broman 2d9d7449b2 Try to fix
cc1: warnings being treated as errors
packet-cip.c: In function 'dissect_cip_generic_service_req':
packet-cip.c:3281: warning: format not a string literal and no format arguments
packet-cip.c: In function 'dissect_cip_generic_service_rsp':
packet-cip.c:3631: warning: format not a string literal and no format arguments
packet-cip.c: In function 'dissect_cip_data':
packet-cip.c:4881: warning: comparison between signed and unsigned

svn path=/trunk/; revision=39599
2011-10-26 06:14:53 +00:00
Anders Broman 4cfaa22784 From Michael Mann:
Improved CIP and ENIP dissectors

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6416

svn path=/trunk/; revision=39595
2011-10-26 04:55:21 +00:00
Bill Meier 15b6311c01 Fix proto_tree_add_item() encoding args.
svn path=/trunk/; revision=39580
2011-10-25 20:16:26 +00:00
Anders Broman ae8165fd4c Fix some set but not used [-Wunused-but-set-variable] warnings.
svn path=/trunk/; revision=39579
2011-10-25 20:08:26 +00:00