Commit Graph

17294 Commits

Author SHA1 Message Date
Anders Broman ac21800c67 From Greg Morris:
- Change to display NCP connection for each conversation
- New NCP Endpoints. Please apply
expert_comp_table
- Use local variable space instead of pointer. The previous implementation utilized pointers and the values would change the table data.

svn path=/trunk/; revision=17446
2006-03-02 20:50:33 +00:00
Jaap Keuter 5db299677d Fix for bug 783 from Didier Gautheron
I know nothing about iscsi , but try the attached patch. It fix the
wrong desegmentation and the ethereal bug isn't triggered anymore.

svn path=/trunk/; revision=17445
2006-03-02 20:44:13 +00:00
Jaap Keuter fc662e5261 In order to reduce the height of the Preference dialog moving several items from the User Interface page to the Layout page.
svn path=/trunk/; revision=17444
2006-03-02 14:44:50 +00:00
Ronnie Sahlberg 2808928c90 make the tcp_acked struct a pointer from the tcpd struct since we might need it hanging around.
only call subdissectors for packets that are NOT keepalives nor zerowindowprobes.


keepalives only contain garbage anyway
and zerowindowproes just contain a single byte of incomplete data so whats the point trying to dissect it further.



svn path=/trunk/; revision=17443
2006-03-02 09:33:49 +00:00
Luis Ontanon 31c4bb49d8 - remove some warnings from the windows compile
- some more Tap documentation


svn path=/trunk/; revision=17442
2006-03-02 00:22:39 +00:00
Ulf Lamping b38db335d3 I don't see any reason why we should only have to look for a hosts file in the personal preferences file, but not in the datafile path, as we doing it for a lot of other config files at runtime.
Add a try to use a global hosts file if one is available ...

svn path=/trunk/; revision=17441
2006-03-02 00:06:15 +00:00
Gerald Combs 050525cfb5 Add Lua support by default for Win32. Fix some compilation problems.
Add Lua information to the version paragraph.

svn path=/trunk/; revision=17440
2006-03-01 21:31:07 +00:00
Jaap Keuter 873321aa30 From Camilo Viecco:
I just make some modifications for the current Sebek dissector so It can
understand both sebek V2 and V3 packets.



svn path=/trunk/; revision=17439
2006-03-01 17:25:21 +00:00
Guy Harris a8f261dba7 A "-b" argument must have a : in it, as it has to specify a criterion
type and value, separated by a :.

svn path=/trunk/; revision=17438
2006-03-01 01:54:46 +00:00
Guy Harris 8ac0325b2b Clean up indentation a bit.
In "capture_input_new_file()", don't call the callbacks unless we
succeed in opening the new file.  Have "capture_info_new_file()" return
a success/failure indication.

Improve the message logged when we fail to open the new file if we're
only opening it for the quick packet counts.  We really should put up an
alert box and give up on the capture at that point.

svn path=/trunk/; revision=17437
2006-03-01 01:46:52 +00:00
Guy Harris aed93fa46a Reject attempts to use packet capture options when we're reading a saved
capture file.

We don't support saving live captures in any format other than libpcap
format (and probably don't want to - we really want to avoid using
Wiretap in that case, as it requires us to Wiretapify captured packets,
which adds extra processing to the capture path); reject attempts to do
that.

svn path=/trunk/; revision=17436
2006-03-01 01:21:51 +00:00
Guy Harris 214dc565e0 Use "tvb_format_string()" on strings extracted from the packet.
Use "tvb_get_ephemeral_string()" to extract a counted string into an
ep_allocated null-terminated buffer.

Constify a variable that points to packet data.

svn path=/trunk/; revision=17435
2006-03-01 00:22:34 +00:00
Guy Harris 660349cfbc Replace commenting-out of code with "#if 0"/#endif" - it's a bit safer
(you don't have to worry about comments in #if 0'ed otu code), and it
also fixes an unclosed comment (the commenting-out ended with /* rather
than */).

Fix up some indentation as well.

svn path=/trunk/; revision=17434
2006-03-01 00:15:55 +00:00
Guy Harris 08182946ce Constify some items, and make one item static, so we don't initialize
stack copies at run time.

svn path=/trunk/; revision=17433
2006-03-01 00:14:12 +00:00
Guy Harris c7a5c2bcca The sequence and ack numbers in a TCP are guint32's, which means they
should be printed with "%u", not "%lu" (especially on LP64 platforms).

Fix up indentation.

svn path=/trunk/; revision=17432
2006-03-01 00:13:19 +00:00
Guy Harris 4ed66d9779 "help()" really just prints a usage message; it's not a full-blown help
system.  Just call it "usage()".

Also, it doesn't use the "progname" argument - it doesn't need to, it's
text2pcap-specific, and it prefers to call it "Text2pcap" anyway (and,
besides, argv[0] might well be a pathname).  Get rid of that argument.

Fix some white space.

svn path=/trunk/; revision=17431
2006-03-01 00:11:16 +00:00
Jaap Keuter 4939134507 Fix for bug 762: implementing Off/On duration presentation in 10ms units
svn path=/trunk/; revision=17430
2006-02-28 18:22:46 +00:00
Anders Broman 2d6b49599e From Martin Mathieson:
This patch adds the SIP History-Info header from RFC4244.

svn path=/trunk/; revision=17429
2006-02-28 17:40:01 +00:00
Anders Broman 47b86c517e Bugfix: Dissect BAT ASE Signal IE properly.
svn path=/trunk/; revision=17428
2006-02-28 17:01:29 +00:00
Anders Broman 204212aeff From Peter Johansson:
fixes the following compilation warnings (and 
potential problems that may otherwise follow).

packet-per.c(796) : warning C4047: 'function' : 'struct _proto_node ** ' 
differs in levels of indirection from 'struct _proto_node *'
packet-per.c(796) : warning C4024: 'dissect_per_boolean' : different 
types for formal and actual parameter 7
packet-per.c(796) : warning C4700: local variable 'pi' used without 
having been initialized

svn path=/trunk/; revision=17427
2006-02-28 17:00:31 +00:00
Ronnie Sahlberg b47ccd7bb9 mark a few generated fields as generated using PROTO_ITEM_SET_GENERATED
svn path=/trunk/; revision=17426
2006-02-28 10:10:08 +00:00
Ronnie Sahlberg 590d27a8c0 add new dissect_ber_integer64() that can handle 8,16,24,32 and 64bit integers.
use proto_tree_add_[u]int[8,16,24,32,64]() instread of proto_tree_add_item()
since BER integers may well be encoded in less bytes than the type requires.
(i do not think the old code with proto_tree_add_item() could have handleded negative values very well    or at all.)




svn path=/trunk/; revision=17425
2006-02-28 09:39:53 +00:00
Gerald Combs f85a158981 Add guard pages to emem.c. GP memory is protected using mprotect()
under UNIX and VirtualProtect() under Windows.  This probably breaks 
compatibility with Windows 95/98/ME.

svn path=/trunk/; revision=17424
2006-02-27 20:51:53 +00:00
Gerald Combs b164a4688f Add an entry for the UMA dissector.
svn path=/trunk/; revision=17423
2006-02-27 19:43:53 +00:00
Gerald Combs 38a305bbfb Properly terminate a value string. Fixes a current Buildbot complaint.
svn path=/trunk/; revision=17422
2006-02-27 15:39:08 +00:00
Jaap Keuter 714c64ab97 Solving minor annoyances.
svn path=/trunk/; revision=17421
2006-02-27 14:03:48 +00:00
Anders Broman 21a8f186bb from dieder:
packet-x11
copy and past overlooked? test with 8 but substract to 4.

svn path=/trunk/; revision=17420
2006-02-27 09:02:16 +00:00
Anders Broman 0fc74ff335 From dider
file.c
time reference menu callback doesn't set  cf->filter, it dumps a core if 
you have a file big enough in find next/ find prev.

addr_resolv.c
leak memory, break list chain when snooping address.

svn path=/trunk/; revision=17419
2006-02-27 09:01:10 +00:00
Ulf Lamping 7d208bc4e0 ooops, my latest changes doesn't seem to follow the DTD strictly ...
svn path=/trunk/; revision=17418
2006-02-27 08:59:24 +00:00
Anders Broman d49c777b71 Add extention bit if per internal fields shown.
svn path=/trunk/; revision=17417
2006-02-27 08:35:24 +00:00
Anders Broman 983d800af7 From: Florent Drouin:
Add a test to avoid divide by zero during stat. display. Use new variable j, instead of i, already used in the loop.

svn path=/trunk/; revision=17416
2006-02-27 08:33:29 +00:00
Luis Ontanon 8b84860a23 - Some more comments
svn path=/trunk/; revision=17415
2006-02-27 01:54:22 +00:00
Ulf Lamping a39ec4c80d a complete rewrite of the Win32 installation procedure description with a step-by-step guide.
svn path=/trunk/; revision=17414
2006-02-26 18:24:39 +00:00
Ulf Lamping 4648592a43 add a possible solution (add another package using cygwin) if a tool wasn't found.
svn path=/trunk/; revision=17413
2006-02-26 18:21:50 +00:00
Jaap Keuter 32dfb9b404 Fix bounds error.
svn path=/trunk/; revision=17412
2006-02-25 13:54:00 +00:00
Luis Ontanon 27e2c87833 The semantics of luaL_checkudata() change between 5.0 and 5.1 (the later triggers an error).
make sure isXxx() functions do not trigger an error, we want them to return not to pop the stack back to the lua caller.


svn path=/trunk/; revision=17411
2006-02-25 12:54:25 +00:00
Anders Broman fbf8c0b820 Add asn1 to the clean target
svn path=/trunk/; revision=17410
2006-02-25 09:31:35 +00:00
Anders Broman 614dcef084 From Martin Mathieson
- add SIP response code 412 ("Conditional Request Failed") to stats taps.

svn path=/trunk/; revision=17409
2006-02-25 09:28:52 +00:00
Anders Broman aeb971fa5d From Martin Mathieson:
This patch further tightens up testing for resent packets.
It now always compares the method.  I've seen examples where the called 
party hangs up, and chooses the same CSeq for the BYE as the calling 
party chose for the INVITE.

svn path=/trunk/; revision=17408
2006-02-25 09:23:10 +00:00
Luis Ontanon b67337aacf - elua_proto
- add doComments
  - fix an error in DissectorTable_remove
  - reorganize DissectorTable_try

 - elua.h
   squelch some warnings

- Makefile.nmake
  - replace the $^ macro with the targets (i.e. do what nmake was supposed to do)
  - move the doc target into the conditional part


svn path=/trunk/; revision=17406
2006-02-25 03:21:00 +00:00
Jörg Mayer c7a3dd2938 Remove references to README.tvbuff. The Makefile.am should fix the
buildbot failure.

svn path=/trunk/; revision=17405
2006-02-25 02:02:36 +00:00
Ulf Lamping f5661a9970 an error return was missing a pcap_close() call
svn path=/trunk/; revision=17404
2006-02-25 00:02:26 +00:00
Ulf Lamping e6fb194094 update some comments, as dumpcap no longer uses console window stuff
svn path=/trunk/; revision=17403
2006-02-25 00:00:33 +00:00
Ulf Lamping c1b208bd74 add the dumpcap manpage to the menu
svn path=/trunk/; revision=17402
2006-02-24 23:59:22 +00:00
Jaap Keuter 6a8533fbb0 Remove obsolete document README.tvbuff
svn path=/trunk/; revision=17401
2006-02-24 21:54:54 +00:00
Jaap Keuter b78143e9b1 Fix bug 769. Print seq# and ack# as _unsigned_ int in the comment.
svn path=/trunk/; revision=17400
2006-02-24 20:46:39 +00:00
Luis Ontanon eddf915e40 I changed some vanames and did not compile...
svn path=/trunk/; revision=17399
2006-02-24 08:44:49 +00:00
Jörg Mayer 5de3ac7f9d svn propset ...
svn path=/trunk/; revision=17398
2006-02-24 08:09:23 +00:00
Luis Ontanon 7be2fd30ab finish adding the tethereal's funnel.
svn path=/trunk/; revision=17397
2006-02-24 02:01:29 +00:00
Luis Ontanon 7e0c9f759a Add the (still unfinished) tethereal side of the funnel.
svn path=/trunk/; revision=17396
2006-02-24 01:41:59 +00:00