Commit graph

697 commits

Author SHA1 Message Date
Jörg Mayer
4189858920 Fix 'warning: cast discards qualifiers from pointer target type' by removing cast
svn path=/trunk/; revision=9845
2004-01-25 17:33:20 +00:00
Jörg Mayer
111f977cfa Remove the cast again and do the proper fix (add right type to union)
svn path=/trunk/; revision=9844
2004-01-25 17:22:57 +00:00
Jörg Mayer
21c1c34c02 Add a cast to avoid a signedness warning
svn path=/trunk/; revision=9843
2004-01-25 17:07:57 +00:00
Jörg Mayer
c61e9f6ed0 Change the first arg to hex_str_to_bytes from guchar* -> char*
svn path=/trunk/; revision=9842
2004-01-25 16:58:25 +00:00
Jörg Mayer
a2634a1ed3 The octets in an ip address are unsigned
svn path=/trunk/; revision=9840
2004-01-25 15:35:45 +00:00
Guy Harris
d8d91ff347 As with "cf_open_error_message()"/"file_open_error_message()", so with
"cf_write_error_message()"/"file_write_error_message()".

Use "file_open_error_message()" instead of "cf_open_error_message()" in
some places we missed in the previous checkin.

Catch ENOSPC and EDQUOT in "file_open_error_message()".

Use "file_open_error_message()" rather than "file_write_error_message()"
to report errors when creating the file to which we're saving the
"Follow TCP Stream" data.

svn path=/trunk/; revision=9823
2004-01-24 02:01:44 +00:00
Guy Harris
46848f0a9e Add a new "file_open_error_message()" routine in "epan/filesystem.c", to
translate UNIX errno values to a somewhat friendly message format
string.

Rename "file_open_error_message()" in "file.c" to
"cf_open_error_message()", make "cf_open_error_message()" use the new
"file_open_error_message()" for UNIX errno values, have "do_capture()"
in "capture.c" use "file_open_error_message()" to report errors from
"open()", and make "cf_open_error_message()" static as nothing outside
"file.c" uses it.

Do similar stuff in "tethereal.c".

svn path=/trunk/; revision=9821
2004-01-24 01:44:29 +00:00
Jörg Mayer
11e10e61fd Change return type of tvb_format_text from guint8* to gchar*.
Remove now unnecessary casts in two files.

svn path=/trunk/; revision=9801
2004-01-23 09:40:38 +00:00
Ulf Lamping
cd85423556 epan don't need GTK_CFLAGS as GTK isn't used,
GLIB_CFLAGS are just enough

svn path=/trunk/; revision=9779
2004-01-22 19:27:59 +00:00
Guy Harris
d4ab584f0f Move "ts_type_text" out of "epan/timestamp.h into "gtk/recent.c", as
it's only used in the latter; that avoids lots of warnings about
"ts_type_text" being defined but not used in other source files that
include "epan/timestamp.h".  (If it's going to be used in more than one
file, make it non-static and declare it "extern" in "epan/timestamp.h".)

Define TS_NOT_SET as ((ts_type)-1), and use that when initializing
"timestamp_type" in Ethereal and when checking to see whether
"timestamp_type" was set, to avoid signed vs. unsigned comparison
warnings.

Clean up indentation.

svn path=/trunk/; revision=9740
2004-01-19 23:03:20 +00:00
Ulf Lamping
0353c5823f move timestamp format options from "View->Options" dialog into
menuitems under "View->Time Display Format".
renamed timestamp enum items e.g. from ABSOLUTE to TS_ABSOLUTE,
to prevent conflicting definitions with MSVC

svn path=/trunk/; revision=9729
2004-01-19 03:46:43 +00:00
Jörg Mayer
fac68ec7a8 Warning fix when compiling with -strict-prototypes
../../epan/dfilter/drange.h:62: warning: function declaration isn't a prototype
../../epan/dfilter/drange.h:83: warning: function declaration isn't a prototype

svn path=/trunk/; revision=9719
2004-01-18 15:34:23 +00:00
Olivier Biot
40a74b1ff5 Replace guchar * with gchar * and get rid of many signedness warnings.
svn path=/trunk/; revision=9643
2004-01-10 17:31:40 +00:00
Olivier Biot
2857dfc114 Add -Wbad-function-cast to extra gcc flags.
svn path=/trunk/; revision=9639
2004-01-10 16:51:07 +00:00
Jörg Mayer
93da1d2117 Remove a C++ style comment
svn path=/trunk/; revision=9630
2004-01-10 13:15:41 +00:00
Jörg Mayer
ebc0b265bd to_str.c declares this: gchar* ip6_to_str ..., make to_str.h do the same
(char -> gchar)

svn path=/trunk/; revision=9629
2004-01-10 12:50:19 +00:00
Olivier Biot
f5f60f1ba3 Fix the "unmarking a packet matching a color filter does not apply the color
filter's colors" bug, by storing the pointer to the matching color_filter_t
structure in the frame_data structure.

Replace "frame" and "frames" by "packet" and "packets" in many places.

svn path=/trunk/; revision=9607
2004-01-09 02:57:54 +00:00
Guy Harris
eff17e272d Fix a typo.
svn path=/trunk/; revision=9606
2004-01-09 01:02:10 +00:00
Guy Harris
32a44690cd Fix a comment.
svn path=/trunk/; revision=9605
2004-01-09 00:57:48 +00:00
Gilbert Ramirez
4f1c2830f1 Don't assert that quoted_string be NULL; it can be non-NULL if
the previous dfilter failed to compile because a closing double-quote
was not provided. Handle that case.

svn path=/trunk/; revision=9585
2004-01-07 05:24:04 +00:00
Ulf Lamping
ba3b94790d removed some MSVC warnings (level 3)
svn path=/trunk/; revision=9560
2004-01-05 18:11:28 +00:00
Ulf Lamping
b6a0525091 Bugfix from Lars Roland: included missing xdlc.h
svn path=/trunk/; revision=9553
2004-01-05 15:03:38 +00:00
Richard Sharpe
fa9874ef73 Apply the patches from Tadaaki Nagao for a global version of disabled
protocols ...

svn path=/trunk/; revision=9538
2004-01-03 18:40:08 +00:00
Olivier Biot
8775850e3b Add support of contains operator in slices.
svn path=/trunk/; revision=9512
2004-01-01 17:02:56 +00:00
Olivier Biot
ef48504769 Add support of contains and matches operators on slices.
svn path=/trunk/; revision=9511
2004-01-01 16:59:20 +00:00
Guy Harris
354b911d05 Add a "saved_can_desegment" field to the "packet_info" structure, so
that dissectors for pass-through proxying protocols such as SOCKS can
allow the subdissectors they call to ask that desegmentation be done.

svn path=/trunk/; revision=9488
2003-12-29 22:44:50 +00:00
Guy Harris
52ce0b5f48 "hex_str_to_bytes()" modifies the GByteArray supplied to it, so don't
mark it as "const".

svn path=/trunk/; revision=9474
2003-12-29 19:53:52 +00:00
Gerald Combs
d72750578b Pull most of bytes_from_unparsed() into a new routine,
hex_str_to_bytes().  Use the new routine to initialize any WEP keys we
have defined.  This has the side effect of fixing an overflow if the user
entered a long WEP key.

svn path=/trunk/; revision=9471
2003-12-29 04:07:06 +00:00
Guy Harris
20788302e3 In "alloc_field_info()", handle the case where the offset is past the
byte past the end of the tvbuff.

svn path=/trunk/; revision=9445
2003-12-24 23:37:28 +00:00
Guy Harris
129de02c79 In "tvb_ensure_bytes_remaining()", throw ReportedBoundsError, not
BoundsError, if the offset is just past the end of the reported data
(because we're ensuring that there actually *is* a byte there, and,
even according to the reported length, it isn't).

svn path=/trunk/; revision=9444
2003-12-24 23:28:17 +00:00
Jörg Mayer
982b7a3f2b Add -pedantic to --with-extra-gcc-checks
svn path=/trunk/; revision=9443
2003-12-24 14:45:48 +00:00
Guy Harris
cde3ec1e33 Let FT_PROTOCOL fields, if the length specified is -1, have a length of
0 - now that "tvb_ensure_length_remaining()" ensures that there's at
least one byte of data, we should use "tvb_length_remaining()" for
FT_PROTOCOL fields.

svn path=/trunk/; revision=9440
2003-12-24 11:07:03 +00:00
Guy Harris
e6f433d884 Do the "isprint()" hack for GTK+ 2.x or 1.3[.x], whether on UNIX or
Windows - the problem is that GTK+ 1.3[.x] and later assume strings
handed to them are UTF-8 strings, not, for example, ISO 8859/x strings.

In packet-radius.c, re-define "isprint()" rather than #ifdeffing its use
(the old code was also incorrectly treating 0x7f as a printable).

svn path=/trunk/; revision=9435
2003-12-24 01:12:17 +00:00
Guy Harris
821baa3d48 Have "tvb_ensure_length_remaining()" throw the appropriate exception if
there's no data remaining - its callers largely depend on it doing so.

That means that the BEEP dissector doesn't have to check for it
returning 0.

svn path=/trunk/; revision=9433
2003-12-23 21:22:00 +00:00
Olivier Biot
2a6e130e10 Move the GSM SMS dissection to a dedicated subdissector (currently still within
packet-smpp.c).

Now the higher-level protocols show up without the need of unfolding the SMPP
dissector tree.

Add a new address type AT_STRINGZ, and use it for GSM SMS message reassembly.

Get rid of the different UDH IE subtrees, and replace them with one subtree
for all UDH IEs.

Add debug logging to SMPP and SMPP GSM SMS dissectors.

Move the Short Message reassembly from the SMPP dissector to the SMPP GSM SMS
dissector. Fix duplicated "reassembled in" header fields.

Rename header fields that are now part of SMPP GSM SMS (including the dissector
table name, so it has also been updated in packet-wsp.c and packet-wtp.c).

Add an explicit "if (!tree) return" in the WSP add_headers() method.

NOTE: it would be great if we were able to merge the existing packet-gsm_sms.c
and the SMPP GSM SMS dissector.

svn path=/trunk/; revision=9431
2003-12-23 12:07:14 +00:00
Guy Harris
331b8b5a8b Add, for \xXX, the same sanity check (that 0xXX fits in a single byte)
that we have for \0OOO.

svn path=/trunk/; revision=9396
2003-12-21 21:04:56 +00:00
Ulf Lamping
dea93d2bee removed some MSVC warnings (added type casts)
svn path=/trunk/; revision=9370
2003-12-20 23:50:50 +00:00
Gilbert Ramirez
1cbfbd022b Print values for ANY_MATCHES and ANY_CONTAINS so that the dftest
executable works properly.

svn path=/trunk/; revision=9353
2003-12-19 04:40:24 +00:00
Olivier Biot
7b1c1a9497 Add support of the "matches" operator to FT_BYTES and FT_ETHER. I don't think
it would make sense to add PCRE support for byte arrays containing an integer
or an IP address.

Avoid lengthy pointer constructs in cmp_matches().

svn path=/trunk/; revision=9343
2003-12-18 13:02:19 +00:00
Olivier Biot
d9d5a1e44d Add protocols to the header fields for which the "matches" operator can be
appliedi (PCRE). In fact, all FT_TVBUFF fields.

svn path=/trunk/; revision=9329
2003-12-17 22:42:02 +00:00
Guy Harris
c642c44ad8 Fix more "CPPLAGS" typoes.
svn path=/trunk/; revision=9310
2003-12-17 02:41:04 +00:00
Guy Harris
8b7cf57054 From Albert Chin: fix for the following:
The PCRE test in acinclude.m4 and epan/acinclude.m4 don't work
	if PCRE exists in a non-system directory.  The problem is that
	LDFLAGS and LIBS are set incorrectly.  LIBS shouldn't contain -L
	arguments.

svn path=/trunk/; revision=9309
2003-12-17 02:36:56 +00:00
Gerald Combs
e660fedd31 Add the help directory to the build. Bump the release version to 0.10.0a
svn path=/trunk/; revision=9276
2003-12-13 18:05:49 +00:00
Guy Harris
d4edb00a3a Add "/usr/local/include" in case the PCRE header file is there.
svn path=/trunk/; revision=9242
2003-12-11 18:37:13 +00:00
Olivier Biot
ca6b915862 PCRE support requires $(PCRE_CFLAGS) in CFLAGS.
svn path=/trunk/; revision=9237
2003-12-10 22:38:48 +00:00
Gerald Combs
9fd657a0e1 Bump the version to 0.10.0. It could be (and has been) argued that the
last release should have been 0.10.0.

svn path=/trunk/; revision=9235
2003-12-10 21:50:04 +00:00
Gerald Combs
45c2823020 Make the _pcre_tuple_t struct internal.
svn path=/trunk/; revision=9233
2003-12-10 21:12:02 +00:00
Olivier Biot
ec776da55a Internal PCRE field type for efficient RE parsing in dfilters.
svn path=/trunk/; revision=9225
2003-12-09 23:15:35 +00:00
Olivier Biot
0f18533b75 Internal PCRE field type for efficient RE parsing in dfilters.
svn path=/trunk/; revision=9224
2003-12-09 23:02:40 +00:00
Guy Harris
11d8817da0 Don't automatically size the columns - that's expensive in large
captures, as it has to compute the width of an auto-resizing column in
every row.  Just pick fixed widths for the columns (and tune the width
of the "Protocol" column so that it's not narrower than the column
title).

svn path=/trunk/; revision=9219
2003-12-09 06:48:40 +00:00