Commit graph

1808 commits

Author SHA1 Message Date
Guy Harris
097877f306 Don't redisplay the "Follow TCP Stream" window on every toggle event for
the display style (ASCII/EBCDIC/char[]/hex) radio button set - pushing a
radio button generates *two* events, one for the button that gets turned
off and one for the button that gets turned on.

svn path=/trunk/; revision=12530
2004-11-16 08:21:32 +00:00
Guy Harris
dfdc47e63c Put the file name into the window title, so if you have more than one of
them open, you know which one corresponds to which file.

Clean up white space.

svn path=/trunk/; revision=12509
2004-11-12 05:36:25 +00:00
Guy Harris
3a1aafc415 When clearing the list, use "history_list", just in case
"history_current" happens to be null (that might not be possible, but
this is still perhaps a bit clearer).

Clear "history_current" after clearing the list, as the current entry no
longer exists, so that "packet_history_add()" doesn't use the now-bogus
value.

svn path=/trunk/; revision=12488
2004-11-03 23:44:08 +00:00
Ulf Lamping
a309bf0a8a first implementation of the packet history function
svn path=/trunk/; revision=12460
2004-11-01 11:42:08 +00:00
Ulf Lamping
7445ecfd05 split capture_loop from capture.c, some more code cleanup
svn path=/trunk/; revision=12451
2004-10-30 17:50:51 +00:00
Ulf Lamping
bdfe1d7fc8 move quit_after_cap into capture_opts
svn path=/trunk/; revision=12449
2004-10-30 14:30:52 +00:00
Guy Harris
b48b8847b1 Change some of the merge.c APIs to return more information on failure,
and use that information to provide better error messages.

Have "merge_open_outfile()" do all the work of filling in the
merge_out_file_t structure, with the values to use passed as arguments. 
Get rid of some structure members that used to be used solely to pass
information to "merge_open_outfile()".

Add a "cf_merge_files()" routine to do the merging and reporting of errors.

svn path=/trunk/; revision=12420
2004-10-27 23:28:37 +00:00
Ulf Lamping
e0bbf855d9 fix doxygen tags
svn path=/trunk/; revision=12404
2004-10-27 04:45:00 +00:00
Ulf Lamping
5fed058707 fix doxygen generation
svn path=/trunk/; revision=12403
2004-10-27 04:03:31 +00:00
Guy Harris
c0ad4beb9c Change some code that affects g_resolv_flags to set a flag if the check
box for the flag is active and clear it if it's inactive, rather than
clearing all but RESOLV_CONCURRENT and then setting flags if the check
box is active - or, in one case, not clearing any flags due to a typo
and then setting them, so they never get cleared.  This matches what's
done with theresolution flags in some other places.

svn path=/trunk/; revision=12375
2004-10-22 07:07:08 +00:00
Guy Harris
1cc64fbf11 The top-level window's list of capture filter expressions might not yet
exist if no filters have been remembered; don't set the popdown string
list for the filter combo box if the list is empty.

svn path=/trunk/; revision=12367
2004-10-21 19:12:22 +00:00
Guy Harris
ee26f8b9bb From Alejandro Vaquero: in the RTP analysis code, don't analyze packets
that have an RTP version other than 2.

svn path=/trunk/; revision=12332
2004-10-17 22:14:47 +00:00
Guy Harris
34a94d6b37 When merging, default to the current file format as the output format.
svn path=/trunk/; revision=12327
2004-10-17 03:11:31 +00:00
Guy Harris
4624549a99 From Mark C. Brown: allow the file type for the merge operation to be
specified in the GUI.

svn path=/trunk/; revision=12326
2004-10-17 02:53:26 +00:00
Guy Harris
a053ee960e Have "range_convert_range()" dynamically allocate a string large enough
to hold the representation of the range, rather than imposing a
fixed-size limit on the string.

Check for overflow in "strtoul()" - and use "strtoul()" rather than
"strtol()" for range members.

Clean up indentation.

Get rid of an unnecessary include in <epan/range.h>.

svn path=/trunk/; revision=12323
2004-10-17 01:31:36 +00:00
Guy Harris
727ad67453 Remove the fixed maximum number of subranges in a range_t; dynamically
allocate them to be large enough.

Add checks that the numbers in the range fit in a guint32.

Check the validity of a range before saving or printing, and report
errors in an alert box.

Clean up white space.

svn path=/trunk/; revision=12320
2004-10-16 23:32:24 +00:00
Guy Harris
b2543fed6c Make the nranges member of a range_t be the number of ranges, not the
number of ranges - 1, and update loops that iterate over all the ranges
appropriately.

Make "range_convert_str()" return a success/failure indication, and
check it.  Rewrite it to do more checks, and not to blithely ignore
unknown characters.

svn path=/trunk/; revision=12313
2004-10-16 08:33:40 +00:00
Guy Harris
abd16b297f From Jeff Morriss: PREF_RANGE preference type, for ranges of integers.
svn path=/trunk/; revision=12300
2004-10-14 23:45:09 +00:00
Michael Tüxen
aa4c473ba1 Fix bugs to get it working on gtk1 and gtk2.
Some clean ups.

svn path=/trunk/; revision=12297
2004-10-14 16:23:11 +00:00
Michael Tüxen
d2b8a466a0 Support PPID and port number based selection for SCTP. From Irene Ruengeler.
svn path=/trunk/; revision=12284
2004-10-12 18:18:44 +00:00
Ulf Lamping
d1a769c20b fix a bug reported by venkata sandeep: capture->start->capture files dialog browse function used FILE_SELECTION_OPEN instead of the correct FILE_SELECTION_WRITE_BROWSE. Now you can (again) select and enter the filename to write capture data to.
svn path=/trunk/; revision=12272
2004-10-12 06:11:30 +00:00
Guy Harris
eb088099b0 Check the values of the protocol preferences before fetching them; if
any are not valid, pop up an alert box and don't dismiss the preferences
dialog.

svn path=/trunk/; revision=12269
2004-10-12 03:13:17 +00:00
Anders Broman
e90f317e77 From: "Alejandro Vaquero : Add IP bandwidth calculation in RTP analysis (in Kbps).
svn path=/trunk/; revision=12251
2004-10-11 05:23:31 +00:00
Gerald Combs
a611bf0740 Add cfilter_combo_utils.h to the distribution, so that we pass distcheck.
svn path=/trunk/; revision=12250
2004-10-09 16:30:26 +00:00
Gerald Combs
ce577d4eff Update the Example Files (sample captures) link.
svn path=/trunk/; revision=12233
2004-10-07 20:30:35 +00:00
Guy Harris
ab9b8d36b5 Save the capture filter in the recent list iff the capture succeeds.
Checking the syntax involves opening a device, which

	1) might not succeed

and

	2) might tie up a BPF device or otherwise consume resources

so we leave it up to the capture operation to do the checking.

svn path=/trunk/; revision=12225
2004-10-07 03:50:16 +00:00
Ulf Lamping
25acc5cd72 Fix a bug reported by Keith A French: No "OK" button for Capture Filter dialog.
Probably caused by the changes of the capture filter drop down box in the capture prepare dialog.

svn path=/trunk/; revision=12222
2004-10-06 17:29:53 +00:00
Guy Harris
bd5bfa9893 From Alejandro Vaquero: make the window bigger so we don't have
overlapped buttons.

svn path=/trunk/; revision=12213
2004-10-06 07:21:05 +00:00
Guy Harris
51dd2ac334 Make the default capture filter be the last one used, as it was before -
it's a pain to have to keep typing the same filter over and over again
if you're trying multiple captures of the same type of traffic.  At
least with GTK+ 2.x, the text of the filter is selected, so if you start
typing a new filter it'll replace the default filter.

svn path=/trunk/; revision=12212
2004-10-05 23:34:53 +00:00
Guy Harris
919c62cc39 Don't use a terminating entry in the clock_map table, compute the number
of entries in it and check that many entries - that squelches a compiler
warning.

From Alejandro Vaquero: get rid of an unused argument to
"rtp_packet_add_graph()".

svn path=/trunk/; revision=12201
2004-10-05 08:51:16 +00:00
Ulf Lamping
cd4a4308bb add some button tooltips, renamed some buttons
svn path=/trunk/; revision=12192
2004-10-03 16:29:40 +00:00
Ulf Lamping
89d8596294 add some button tooltips
svn path=/trunk/; revision=12191
2004-10-03 16:28:29 +00:00
Ulf Lamping
bdbe26adb2 added some comments
svn path=/trunk/; revision=12185
2004-10-02 11:05:27 +00:00
Ulf Lamping
1d680a74c4 precise a comment
svn path=/trunk/; revision=12184
2004-10-02 09:34:12 +00:00
Ulf Lamping
ba285f9a4e removed ITU-T prefix from H225, so H.225 and H.323 are closer together.
If someone insists in using the ITU-T prefix, it should be applied to both protocols.

svn path=/trunk/; revision=12183
2004-10-02 08:41:52 +00:00
Ulf Lamping
8878a1521f GUI fine tuning, e.g. removed useless "Unselect" button, some behaviour things, ...
svn path=/trunk/; revision=12182
2004-10-02 08:31:58 +00:00
Guy Harris
c2e5e4868d Don't define "transport_prot_name[]" in "h323_conversations.h", as that
puts a separate copy in every file that includes "h323_conversations.h",
even if it doesn't use that copy.  Instead, define it in
"h323_conversations.c" and declare it in "h323_conversations.h".

svn path=/trunk/; revision=12179
2004-10-01 22:09:38 +00:00
Ulf Lamping
433701e19b indirection in menu entry not needed (maybe later again)
svn path=/trunk/; revision=12175
2004-10-01 15:55:14 +00:00
Ulf Lamping
a1f280a04e clarify column titles
svn path=/trunk/; revision=12174
2004-10-01 15:36:53 +00:00
Guy Harris
ac43a4c8c8 From Francisco Alcoba: handle H.323 conversations over UDP and SCTP.
svn path=/trunk/; revision=12169
2004-10-01 09:13:33 +00:00
Guy Harris
92ee993e82 "prefs-int.h" belongs in epan, too.
svn path=/trunk/; revision=12168
2004-10-01 08:33:53 +00:00
Guy Harris
01f4257058 From Alejandro Vaquero:
RTP graphic analysis;

	assorted bug fixes;

	display delay and jitter in milliseconds, and add the percentage
	of lost packets to the statistics.

svn path=/trunk/; revision=12166
2004-10-01 07:14:50 +00:00
Ulf Lamping
d235806dde use "Analyze" not "Analyse", as in the menu.
add some tooltips

svn path=/trunk/; revision=12163
2004-10-01 05:42:02 +00:00
Ulf Lamping
2cf1e653b7 removed unreferenced "label_stats"
svn path=/trunk/; revision=12162
2004-10-01 05:17:53 +00:00
Guy Harris
d23ca96d16 Add an RCS ID.
svn path=/trunk/; revision=12154
2004-09-30 19:49:48 +00:00
Guy Harris
3c5560871b Set svn:keywords to Id to expand RCS IDs, and set svn:eol-style to
native to canonicalize line endings.

svn path=/trunk/; revision=12153
2004-09-30 19:36:22 +00:00
Anders Broman
2e0b11edbf From Lars Roland:
Having a closer look at the new and very useful H323 Call Analysis 
feature, I have found some bugs and unnecessarily complicated code for 
managing the registration of the tap listeners. So I decided to rewrite 
this part of the source code. This part of the code is much smaller now. 
Unnecessary and wrong calls of register_ethereal_tap() and 
register_tap_listener_xxx() have been removed or replaced.

I also fixed a bug with RAS Messages.

svn path=/trunk/; revision=12149
2004-09-30 18:09:09 +00:00
Guy Harris
2398487dc2 For file browsing dialog boxes, the affirmative button should be "OK",
not "Save".

In UN*X with GTK+ 2.x, put the affirmative button in file dialogs to the
right of the cancel button, as is done with other dialogs.

svn path=/trunk/; revision=12146
2004-09-30 02:02:35 +00:00
Anders Broman
a95464b528 Add
h323_analysis.h	\
	h323_conversations.h	\
	h323_conversations_dlg.h	\

svn path=/trunk/; revision=12144
2004-09-29 22:35:46 +00:00
Anders Broman
76f4b01674 Add
h323_analysis.c	\
	h323_conversations_dlg.c	\

svn path=/trunk/; revision=12143
2004-09-29 22:34:01 +00:00